Re: 1.9.1 release pending, please give it a look

[Igor Klevanets]

Hi Just trying to pay attention to topic "Add libssh2_agent_sign() to allow sign any message" =)https://www.libssh2.org/mail/libssh2-devel-archive-2020-09/0004.shtml https://github.com/libssh2/libssh2/pull/516Оf cause it is not blocker for release 1.9.1. May be it is candidate for 1.10.0 - I'm not sure. Please take a look on this feature anyway. Thanke youIgor Klevanets
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

RE: 1.9.1 release pending, please give it a look

[Kelley, Ryan]

Just checking in here on what if anything is needed to release this version?

Ryan Kelley

-Original Message-
From: Will Cosgrove  
Sent: Friday, May 14, 2021 5:45 PM
To: libssh2 development 
Subject: Re: 1.9.1 release pending, please give it a look

Yup, sure. There are some features added so that makes sense. I’ll update the 
change logs PR to refer to 1.10.

Will

> On May 14, 2021, at 2:37 PM, Daniel Stenberg  wrote:
> 
> On Wed, 12 May 2021, Will Cosgrove wrote:
> 
>> We are pulling together the 1.9.1 release and I’d request, if you haven’t 
>> already, give the main branch a sanity pass with your existing code and get 
>> any last minute issues submitted ASAP.
> 
> There are a few changes and improvementslanded since 1.9.0 though, shouldn't 
> the next release from master than perhaps rather be called 1.10.0 ?
> 
> -- 
> 
> / daniel.haxx.se___
> libssh2-devel 
> https://urldefense.com/v3/__https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel__;!!GjvTz_vk!Eaqd9d8OqrV4ew_RGrP6tjDf9t1y7qigu-gvTyxt6oUl3jLl28fFidvgscObiA$
>  


___
libssh2-devel 
https://urldefense.com/v3/__https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel__;!!GjvTz_vk!Eaqd9d8OqrV4ew_RGrP6tjDf9t1y7qigu-gvTyxt6oUl3jLl28fFidvgscObiA$
 


smime.p7s
Description: S/MIME cryptographic signature
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Marc Hoersken]

On 19.05.21 21:20, Marc Hoersken wrote:
> Good progress can be found here:
> https://ci.appveyor.com/project/mback2k/libssh2/build/job/dtp4y5s7p8fk1cdm
>
> The Docker container is now being run on GitHub Actions instead of
> DigitalOcean, so we don't rely on someone paying that.


Another update with the first completely successful run including tests
since September 2020:
https://ci.appveyor.com/project/mback2k/libssh2/builds/39247798

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Marc Hoersken]

I am currently working on making the tests work again on AppVeyor and 
would like to merge your changes after that to see if they break 
anything there.



Good progress can be found here: 
https://ci.appveyor.com/project/mback2k/libssh2/build/job/dtp4y5s7p8fk1cdm


The Docker container is now being run on GitHub Actions instead of 
DigitalOcean, so we don't rely on someone paying that.


@alamaison did that for us in the past, but that changed some time ago. 
Thanks again to him for doing that for a long time!


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Laurent Stacul]

Hello,

The latest tarball 
(https://www.libssh2.org/snapshots/libssh2-1.9.0-20210519.tar.gz)
is working fine. Thanks for the quick merges.

Regards,
Laurent

On Wed, May 12, 2021 at 09:17:59AM -0700, Will Cosgrove wrote:

Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t 
already, give the main branch a sanity pass with your existing code and get any 
last minute issues submitted ASAP.

Thanks!

Will
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Marc Hoersken]

Hello,

Am 18.05.2021 um 10:57 schrieb Laurent Stacul:

I was also wondering if you would mind integrating the PRs I did to be
able to the the tests inside an OCI container:

- https://github.com/libssh2/libssh2/pull/557
- https://github.com/libssh2/libssh2/pull/560
- https://github.com/libssh2/libssh2/pull/559

As these PRs only touch tests (and more particularly the ones run when
using CMake), I don't think it would hurt.



I am currently working on making the tests work again on AppVeyor and 
would like to merge your changes after that to see if they break 
anything there.


This will hopefully happen during this week or on the weekend, but I am 
not sure if this will be in time for the release.


Best regards,
Marc

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Laurent Stacul]

Hello,

In fact, there was still some missing file in the daily tarball
(https://libssh2.org/snapshots/libssh2-1.9.0-20210518.tar.gz). I
provided a PR to solve this
(https://github.com/libssh2/libssh2/pull/604).

I was also wondering if you would mind integrating the PRs I did to be
able to the the tests inside an OCI container:

- https://github.com/libssh2/libssh2/pull/557
- https://github.com/libssh2/libssh2/pull/560
- https://github.com/libssh2/libssh2/pull/559

As these PRs only touch tests (and more particularly the ones run when
using CMake), I don't think it would hurt.

Thanks in advance for your answers.
Regards,
Laurent

On Wed, May 12, 2021 at 09:17:59AM -0700, Will Cosgrove wrote:

Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t 
already, give the main branch a sanity pass with your existing code and get any 
last minute issues submitted ASAP.

Thanks!

Will
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Laurent Stacul]

Hello,

I am giving a try to libssh2 1.10.0. I tool the snapshot of 20210517
(https://libssh2.org/snapshots/libssh2-1.9.0-20210517.tar.gz).

Build with CMake is ok but running the tests fails:

+ ctest --output-on-failure
Test project 
/home/docker/development/opensource-pack-builder/components/ssh2/BUILD/libssh2-1.9.0-20210517/_build_shared
  Start  1: test_hostkey
 1/14 Test  #1: test_hostkey 
***Failed0.21 sec
Error running command 'docker build -t libssh2/openssh_server openssh_server' 
(exit 256): Sending build context to Docker daemon  10.75kB
Step 1/32 : FROM debian:jessie
 ---> 3aaeab7a4777
Step 2/32 : RUN apt-get update  && apt-get install -y openssh-server  && apt-get clean  
&& rm -rf /var/lib/apt/lists/*
 ---> Using cache
 ---> 396dccb5e4e3
Step 3/32 : RUN mkdir /var/run/sshd
 ---> Using cache
 ---> 08b0b21b084b
Step 4/32 : COPY ssh_host_rsa_key /tmp/etc/ssh/ssh_host_rsa_key
 ---> Using cache
 ---> 5ce3c9d315c9
Step 5/32 : RUN mv /tmp/etc/ssh/ssh_host_rsa_key /etc/ssh/ssh_host_rsa_key
 ---> Using cache
 ---> bae8bc7d29f0
Step 6/32 : RUN chmod 600 /etc/ssh/ssh_host_rsa_key
 ---> Using cache
 ---> 7597e217b7a9
Step 7/32 : COPY ssh_host_ecdsa_key /tmp/etc/ssh/ssh_host_ecdsa_key
COPY failed: file not found in build context or excluded by .dockerignore: stat 
ssh_host_ecdsa_key: file does not exist

Failed to build docker image

I think those distribution extra files are missing in the automake config.

Regards,
Stac

On Wed, May 12, 2021 at 09:17:59AM -0700, Will Cosgrove wrote:

Hi All,
We are pulling together the 1.9.1 release and I’d request, if you haven’t 
already, give the main branch a sanity pass with your existing code and get any 
last minute issues submitted ASAP.

Thanks!

Will
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Will Cosgrove]

Yup, sure. There are some features added so that makes sense. I’ll update the 
change logs PR to refer to 1.10.

Will

> On May 14, 2021, at 2:37 PM, Daniel Stenberg  wrote:
> 
> On Wed, 12 May 2021, Will Cosgrove wrote:
> 
>> We are pulling together the 1.9.1 release and I’d request, if you haven’t 
>> already, give the main branch a sanity pass with your existing code and get 
>> any last minute issues submitted ASAP.
> 
> There are a few changes and improvementslanded since 1.9.0 though, shouldn't 
> the next release from master than perhaps rather be called 1.10.0 ?
> 
> -- 
> 
> / daniel.haxx.se___
> libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Daniel Stenberg]

On Wed, 12 May 2021, Will Cosgrove wrote:

We are pulling together the 1.9.1 release and I’d request, if you haven’t 
already, give the main branch a sanity pass with your existing code and get 
any last minute issues submitted ASAP.


There are a few changes and improvementslanded since 1.9.0 though, shouldn't 
the next release from master than perhaps rather be called 1.10.0 ?


--

 / daniel.haxx.se___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Will Cosgrove]

I do apprecate the efforts!  In fact, I couldn’t run autoreconf with the 
configure.ac file as-is on my Mac (PR #594 if anyone is interested) so copying 
your old config file was fine for a quick test.

Cheers,
Will

>>> Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16
 The command "autoreconf -if" will generate the configure file from the 
 source.
 That's a standard autotools command that works in just about any autotools
 project.
>>> 
>>> I know that autoreconf should do the trick. But autoreconf is not part of
>>> the standard toolset on macOS with Xcode. I never needed it up until now.
>>> See for instance https://superuser.com/a/897316/173319 for the extra steps
>>> needed.
>> 
>> You're using an unreleased version of the source code for developers, so 
>> you'll
>> have to expect to use developer tools. If you use a released version, 
>> configure
>> will be included and you won't need to use these.
> 
> It was just a one time effort, as a reaction to Will's request for a
> sanity pass.
> -- 
> Jan
> 
> ___
> libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel


___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Jan Ehrhardt]

Dan Fandrich in gmane.network.ssh.libssh2.devel (Thu, 13 May 2021 00:18:21
-0700):
>On Thu, May 13, 2021 at 08:09:57AM +0200, Jan Ehrhardt wrote:
>> Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16
>> >The command "autoreconf -if" will generate the configure file from the 
>> >source.
>> >That's a standard autotools command that works in just about any autotools
>> >project.
>> 
>> I know that autoreconf should do the trick. But autoreconf is not part of
>> the standard toolset on macOS with Xcode. I never needed it up until now.
>> See for instance https://superuser.com/a/897316/173319 for the extra steps
>> needed.
>
>You're using an unreleased version of the source code for developers, so you'll
>have to expect to use developer tools. If you use a released version, configure
>will be included and you won't need to use these.

It was just a one time effort, as a reaction to Will's request for a
sanity pass.
-- 
Jan

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Daniel Stenberg]

On Wed, 12 May 2021, Jan Ehrhardt wrote:


Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
the main branch?


Yes they are!

--

 / daniel.haxx.se
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Dan Fandrich]

On Thu, May 13, 2021 at 08:09:57AM +0200, Jan Ehrhardt wrote:
> Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16
> >The command "autoreconf -if" will generate the configure file from the 
> >source.
> >That's a standard autotools command that works in just about any autotools
> >project.
> 
> I know that autoreconf should do the trick. But autoreconf is not part of
> the standard toolset on macOS with Xcode. I never needed it up until now.
> See for instance https://superuser.com/a/897316/173319 for the extra steps
> needed.

You're using an unreleased version of the source code for developers, so you'll
have to expect to use developer tools. If you use a released version, configure
will be included and you won't need to use these.

Dan
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Jan Ehrhardt]

Dan Fandrich in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021 17:41:16
-0700):
>On Thu, May 13, 2021 at 02:00:42AM +0200, Jan Ehrhardt wrote:
>> That was a bit hard, as neither the snapshots nor github contained
>> ./configure. And the script at https://github.com/Frugghi/iSSH2 really
>> needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
>> installed.
>
>The command "autoreconf -if" will generate the configure file from the source.
>That's a standard autotools command that works in just about any autotools
>project.

I know that autoreconf should do the trick. But autoreconf is not part of
the standard toolset on macOS with Xcode. I never needed it up until now.
See for instance https://superuser.com/a/897316/173319 for the extra steps
needed.
-- 
Jan

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Dan Fandrich]

On Thu, May 13, 2021 at 02:00:42AM +0200, Jan Ehrhardt wrote:
> That was a bit hard, as neither the snapshots nor github contained
> ./configure. And the script at https://github.com/Frugghi/iSSH2 really
> needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
> installed.

The command "autoreconf -if" will generate the configure file from the source.
That's a standard autotools command that works in just about any autotools
project.

Dan
___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Jan Ehrhardt]

Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021
11:46:22 -0700):
>Looks like they are! Otherwise, you can clone it from github
>(https://github.com/libssh2/libssh2 )
>and build it. 

That was a bit hard, as neither the snapshots nor github contained
./configure. And the script at https://github.com/Frugghi/iSSH2 really
needs it. I was compiling on a Mac with macOS Big Sur 11.3.1. No autotools
installed.

In the end I took the configure from the LibSSH2 1.9.0 and got it
compiled. No problems encountered: my iPhone app uploaded 320 MB in 1:35m
from my home to a datacenter somewhere in Amsterdam via sftp.
-- 
Jan

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Will Cosgrove]

Looks like they are! Otherwise, you can clone it from github 
(https://github.com/libssh2/libssh2 ) and 
build it. 

Cheers,

Will 


> On May 12, 2021, at 11:34 AM, Jan Ehrhardt  wrote:
> 
> Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021
> 09:17:59 -0700):
>> We are pulling together the 1.9.1 release and I’d request, if you haven’t
>> already, give the main branch a sanity pass with your existing code and
>> get any last minute issues submitted ASAP.
> 
> Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
> the main branch? That would be the easiest way to test
> https://github.com/Frugghi/iSSH2 and
> https://github.com/Jan-E/iSSH2/tree/catalyst 
> -- 
> Jan
> 
> ___
> libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Re: 1.9.1 release pending, please give it a look

[Jan Ehrhardt]

Will Cosgrove in gmane.network.ssh.libssh2.devel (Wed, 12 May 2021
09:17:59 -0700):
>We are pulling together the 1.9.1 release and I’d request, if you haven’t
>already, give the main branch a sanity pass with your existing code and
>get any last minute issues submitted ASAP.

Are the dauly snapshots at https://www.libssh2.org/snapshots/ snapshots of
the main branch? That would be the easiest way to test
https://github.com/Frugghi/iSSH2 and
https://github.com/Jan-E/iSSH2/tree/catalyst 
-- 
Jan

___
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel