Re: lilypond-book on windows

2012-01-12 Thread David Kastrup
Trevor Daniels t.dani...@treda.co.uk writes:

 Trevor Daniels wrote Wednesday, January 11, 2012 6:49 PM

 To carry things to their logical conclusion I'm installing MikTeX to
 see if it is possible to make Reinhold's code work as intended on
 Windows.  Even if it does, I could not recommend downloading
 167Mbytes of MikTeX just to pick up these values automatically.

 Well, MikTex contains texi2dvi.exe, so I renamed this to texi2pdf.exe
 and added its directory to the MinGW path.

You need a TeX distribution anyway to create PDF from lytex files.  And
if you are not creating print copy there is no point in figuring out a
line width as it would deliver a result without any meaning (except if
for some reason you want notes in HTML use the same line breaks as in
print).  So if lilypond-book fails when creating HTML documentation
without a TeX distribution, this is a deficiency not just in Windows.
It does not make sense on GNU/Linux either.

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: lilypond-book -2

2012-01-12 Thread Trevor Daniels


Graham, you wrote Thursday, January 12, 2012 6:22 AM



I expect to have that sleep(0.001) error.  I do not expect any
other errors.

http://lilypond.org/~graham/lilypond-2.15.25-2.mingw.exe

What's the exact error you see when you try this one?  I
know/expect that it barfs in threading.py, but I need to know what
in the lilypond code calls that.


lilypond-book.py (GNU LilyPond) 2.15.25
Reading 
C:/Users/Trevor/LilyPond-git/Documentation/notation/contemporary.itely..

.
Running texi2pdf on file c:\users\trevor\appdata\local\temp\tmpwxztgo.texi 
to de

tect default page settings.

Traceback (most recent call last):
 File c:/program files/lilypond/usr/bin/lilypond-book.py, line 739, in ?
   main ()
 File c:/program files/lilypond/usr/bin/lilypond-book.py, line 722, in 
main

   chunks = do_file (files[0])
 File c:/program files/lilypond/usr/bin/lilypond-book.py, line 595, in 
do_file

   global_options.formatter.init_default_snippet_options (source)
 File c:\program 
files\lilypond\usr\share\lilypond\current\python\book_texinfo

.py, line 289, in init_default_snippet_options
   texinfo_defaults = get_texinfo_width_indent (source, 
self.global_options);
 File c:\program 
files\lilypond\usr\share\lilypond\current\python\book_texinfo

.py, line 224, in get_texinfo_width_indent
   (parameter_string, error_string) = proc.communicate ()
 File /usr/lib/python2.4/subprocess.py, line 773, in communicate
 File /usr/lib/python2.4/threading.py, line 418, in start
IOError: (0, 'Error')
Lilypond-book returned code 1

Trevor 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-12 Thread lemzwerg

LGTM, but not time to test...


http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc
File lily/staff-symbol-referencer.cc (right):

http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc#newcode95
lily/staff-symbol-referencer.cc:95: Real y = (pure
The outermost parentheses have no effect.  I suggest to remove them.

http://codereview.appspot.com/5538049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Glyphs for Kievan Notation (issue 4951062)

2012-01-12 Thread aleksandr . andreev

On 2012/01/11 21:37:36, Neil Puttock wrote:


Add a check for kievan style in Stem::is_normal_stem ().


Unfortunately, that doesn't seem to do anything. Unless I'm not
accessing the property correctly ... see the latest patch.

Aleks

http://codereview.appspot.com/4951062/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Glyphs for Kievan Notation (issue 4951062)

2012-01-12 Thread Neil Puttock
On 12 January 2012 15:43,  aleksandr.andr...@gmail.com wrote:

 Unfortunately, that doesn't seem to do anything. Unless I'm not
 accessing the property correctly ... see the latest patch.

You're trying to access style from the Stem instead of the NoteHead.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: lilypond-book on windows

2012-01-12 Thread Reinhold Kainhofer
On 12/01/2012 09:06, David Kastrup wrote:
 Trevor Daniels t.dani...@treda.co.uk writes:

 Trevor Daniels wrote Wednesday, January 11, 2012 6:49 PM

 To carry things to their logical conclusion I'm installing MikTeX to
 see if it is possible to make Reinhold's code work as intended on
 Windows.  Even if it does, I could not recommend downloading
 167Mbytes of MikTeX just to pick up these values automatically.
 Well, MikTex contains texi2dvi.exe, so I renamed this to texi2pdf.exe
 and added its directory to the MinGW path.
 You need a TeX distribution anyway to create PDF from lytex files.  And
 if you are not creating print copy there is no point in figuring out a
 line width as it would deliver a result without any meaning (except if
 for some reason you want notes in HTML use the same line breaks as in
 print).  So if lilypond-book fails when creating HTML documentation
 without a TeX distribution, this is a deficiency not just in Windows.

Exactly, and as I said, it is supposed to work without texi2pdf (and/or
a working TeX installation) available.

However, even for HTML we need some kind of line width so that we can
line-break all lilypond snippets. The default fallback value (which
roughly corresponds to A4 with some margins) is an acceptable default
value, so things should look okay in any case.

The problem is just that the subprocess module needs msvcrt on Windows,
but that python as provided by lilypond does not ship that module. I
would rather see this as a packaging problem, or am I seeing something
wrong?

Cheers,
REinhold

-- 
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial  Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Production with LilyPond

2012-01-12 Thread James
hello,

On 12 January 2012 05:47, Graham Percival gra...@percival-music.ca wrote:
 On Wed, Jan 11, 2012 at 12:19:27PM +0100, Janek Warchoł wrote:
 2012/1/10 Xavier Scheuer x.sche...@gmail.com:
  I guess this message would be more appropriate on lilypond-u...@gnu.org
  rather than on the bug reports mailing list.  May I suggest you to send
  it (again) to this address, thus reaching the LilyPond Users community?

 Sending such information to bug reports list looks strange to me too,
 however http://lilypond.org/productions.html says exactly to do this -
 maybe it shouldn't say so?

 What on earth are you talking about?  bug-lilypond is the place
 for users to report matters that are of interest to developers.
 Aurélien reported it there.  James will hopefully be acting on his
 report.  This is working exactly as it should.


http://code.google.com/p/lilypond/issues/detail?id=2218

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Glyphs for Kievan Notation (issue 4951062)

2012-01-12 Thread aleksandr . andreev

On 2012/01/12 16:24:13, Neil Puttock wrote:


You're trying to access style from the Stem instead of the NoteHead.


Got it. Thanks, Neil.




http://codereview.appspot.com/4951062/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: lilypond-book on windows

2012-01-12 Thread Graham Percival
On Thu, Jan 12, 2012 at 06:50:56PM +0100, Reinhold Kainhofer wrote:
 The problem is just that the subprocess module needs msvcrt on Windows,
 but that python as provided by lilypond does not ship that module.

This does not appear to have been a problem for the past few
releases.

 I would rather see this as a packaging problem, or am I seeing
 something wrong?

The current problem is that subprocess.communicate() in python
2.4.2 appears to bork on windows.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: lilypond-book on windows

2012-01-12 Thread Graham Percival
On Thu, Jan 12, 2012 at 07:00:27PM +0100, David Kastrup wrote:
 Reinhold Kainhofer reinh...@kainhofer.com writes:
 
  However, even for HTML we need some kind of line width so that we can
  line-break all lilypond snippets.
 
 That line width should be based on a pixel width (1024 is probably
 reasonably).  It is nonsensical to have it based on a paper size.

We want the line widths to look the same in the HTML as in the
pdfs.  Also, we don't want to insist that people use a full-screen
window with at least 1024 pixels -- or rather, given the left-hand
navbar, that would require at least a full-screen window at 1280
pixels or so.

 If lilypond-book calls texi2pdf in the course of generating HTML, that
 is a bug.

No, that is correct and working as desired.  The fallback works
perfectly well other than one remaining OS-specific bug in a
python version from 6 or so years ago.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-12 Thread Carl . D . Sorensen

A few comments.

Thanks,

Carl



http://codereview.appspot.com/5538049/diff/1/input/regression/dot-column-vertical-positioning.ly
File input/regression/dot-column-vertical-positioning.ly (right):

http://codereview.appspot.com/5538049/diff/1/input/regression/dot-column-vertical-positioning.ly#newcode5
input/regression/dot-column-vertical-positioning.ly:5: line breaking.
What should the output look like?  How do I know if the regtest passes?

http://codereview.appspot.com/5538049/diff/1/lily/include/staff-symbol-referencer.hh
File lily/include/staff-symbol-referencer.hh (right):

http://codereview.appspot.com/5538049/diff/1/lily/include/staff-symbol-referencer.hh#newcode37
lily/include/staff-symbol-referencer.hh:37: static void
internal_set_position (Grob *, Real, bool);
shouldn't internal_set_position be private, and be called by
pure_set_position and set_position, which are the public functions?

http://codereview.appspot.com/5538049/diff/1/lily/include/staff-symbol-referencer.hh#newcode52
lily/include/staff-symbol-referencer.hh:52: static Real
internal_get_position (Grob *, bool);
Ditto here -- I think internal_get_postion should be private.

http://codereview.appspot.com/5538049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCH: Countdown to 20120114

2012-01-12 Thread Colin Campbell

For Thursday, January 14, 2012

Build:
 Issue 2210 
http://code.google.com/p/lilypond/issues/detail?id=2210: Patch: Build: 
Top-level GNUmakefile- R 5535047 http://codereview.appspot.com/5535047/


Enhancement:
Issue 2206 
http://code.google.com/p/lilypond/issues/detail?id=2206: Patch: Let 
\footnote do the job of \footnote, \footnoteGrob, \autoFootnote and 
\autoFootnoteGrob - R 5527058 http://codereview.appspot.com/5527058/


Scripts:
Issue 2104 
http://code.google.com/p/lilypond/issues/detail?id=2104: Patch: Fix 
.dep file from lilypond-book when include paths are involved. - R 
5486064 http://codereview.appspot.com/5486064/
Issue 2209 
http://code.google.com/p/lilypond/issues/detail?id=2209: lilypond-book 
creates uncompilable latex files (windows) - R 5530069 
http://codereview.appspot.com/5530069/



Cheers,
Colin


--
I've learned that you shouldn't go through life with a catcher's mitt on both 
hands.
You need to be able to throw something back.
-Maya Angelou, poet (1928- )

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

2012-01-12 Thread julien . rioux

Reviewers: ,

Message:
Open for review.

Description:
Add a node prefix to snippets, preventing duplicate node errors (issue
2221).

Please review this at http://codereview.appspot.com/5541050/

Affected files:
  M Documentation/snippets.tely
  M Documentation/snippets/ancient-notation-intro.itely
  M Documentation/snippets/chords-intro.itely
  M Documentation/snippets/contexts-and-engravers-intro.itely
  M Documentation/snippets/editorial-annotations-intro.itely
  M Documentation/snippets/expressive-marks-intro.itely
  M Documentation/snippets/fretted-strings-intro.itely
  M Documentation/snippets/keyboards-intro.itely
  M Documentation/snippets/midi-intro.itely
  M Documentation/snippets/paper-and-layout-intro.itely
  M Documentation/snippets/percussion-intro.itely
  M Documentation/snippets/pitches-intro.itely
  M Documentation/snippets/repeats-intro.itely
  M Documentation/snippets/rhythms-intro.itely
  M Documentation/snippets/simultaneous-notes-intro.itely
  M Documentation/snippets/spacing-intro.itely
  M Documentation/snippets/staff-notation-intro.itely
  M Documentation/snippets/template-intro.itely
  M Documentation/snippets/text-intro.itely
  M Documentation/snippets/titles-intro.itely
  M Documentation/snippets/tweaks-and-overrides-intro.itely
  M Documentation/snippets/unfretted-strings-intro.itely
  M Documentation/snippets/vocal-music-intro.itely
  M Documentation/snippets/winds-intro.itely
  M Documentation/snippets/world-music-intro.itely
  M scripts/build/extract_texi_filenames.py


Index: Documentation/snippets.tely
diff --git a/Documentation/snippets.tely b/Documentation/snippets.tely
index  
b44f4c5a901963b59f290a0e8f4680305461e5c1..2d30fa92ae0d72617e8ea81286055a5848009853  
100644

--- a/Documentation/snippets.tely
+++ b/Documentation/snippets.tely
@@ -41,15 +41,20 @@ by the authors.
 @include macros.itexi

 @ifnothtml
+@macro nodeprefix{PRE}
+@end macro
 @macro lydoctitle{TEXT}
 @unnumberedsec \TEXT\
 @end macro
 @end ifnothtml

 @ifhtml
+@macro nodeprefix{PRE}
+@unmacro lydoctitle
 @macro lydoctitle{TEXT}
-@node \TEXT\
-@unnumberedsec \TEXT\
+@node \PRE\: \\TEXT\\
+@unnumberedsec \\TEXT\\
+@end macro
 @end macro
 @end ifhtml

Index: Documentation/snippets/ancient-notation-intro.itely
diff --git a/Documentation/snippets/ancient-notation-intro.itely  
b/Documentation/snippets/ancient-notation-intro.itely
index  
a6de3f24c603c6dc1d2ecd43dea37623a322a40d..30b13b9828f16d15fe797cfc9e918ec7c2a36507  
100644

--- a/Documentation/snippets/ancient-notation-intro.itely
+++ b/Documentation/snippets/ancient-notation-intro.itely
@@ -1,5 +1,6 @@
 @node Ancient notation
 @unnumbered Ancient notation
+@nodeprefix Ancient notation

 @ruser{Ancient notation}

Index: Documentation/snippets/chords-intro.itely
diff --git a/Documentation/snippets/chords-intro.itely  
b/Documentation/snippets/chords-intro.itely
index  
83aeaaaf25077a5ce926943fe4f726066363837e..1427e49a5bc69fb4f0fc3bf3512559c1f45e1360  
100644

--- a/Documentation/snippets/chords-intro.itely
+++ b/Documentation/snippets/chords-intro.itely
@@ -1,5 +1,6 @@
 @node Chords
 @unnumbered Chords
+@nodeprefix Chords

 @ruser{Chord notation}

Index: Documentation/snippets/contexts-and-engravers-intro.itely
diff --git a/Documentation/snippets/contexts-and-engravers-intro.itely  
b/Documentation/snippets/contexts-and-engravers-intro.itely
index  
ef796b0592511526d57ad1d251c5892b47ba7d41..e4e11670ccf26d898d56901afbdd819e9802a61c  
100644

--- a/Documentation/snippets/contexts-and-engravers-intro.itely
+++ b/Documentation/snippets/contexts-and-engravers-intro.itely
@@ -1,5 +1,6 @@
 @node Contexts and engravers
 @unnumbered Contexts and engravers
+@nodeprefix Contexts and engravers

 @c FIXME make xref more precise when the chapter has been
 @c revised in GDP
Index: Documentation/snippets/editorial-annotations-intro.itely
diff --git a/Documentation/snippets/editorial-annotations-intro.itely  
b/Documentation/snippets/editorial-annotations-intro.itely
index  
0dd710632ac2de83c62a1d04188909418be2467e..793c8570b1896be3ad9203e4475f03010334481f  
100644

--- a/Documentation/snippets/editorial-annotations-intro.itely
+++ b/Documentation/snippets/editorial-annotations-intro.itely
@@ -1,5 +1,6 @@
 @node Editorial annotations
 @unnumbered Editorial annotations
+@nodeprefix Editorial annotations

 @ruser{Editorial annotations}

Index: Documentation/snippets/expressive-marks-intro.itely
diff --git a/Documentation/snippets/expressive-marks-intro.itely  
b/Documentation/snippets/expressive-marks-intro.itely
index  
c869a5347ce731e3d12449c00dfbba458bffe156..60598e5420cf28a3368db8cba13ccfd7f2cc88c2  
100644

--- a/Documentation/snippets/expressive-marks-intro.itely
+++ b/Documentation/snippets/expressive-marks-intro.itely
@@ -1,5 +1,6 @@
 @node Expressive marks
 @unnumbered Expressive marks
+@nodeprefix Expressive marks

 @ruser{Expressive marks}

Index: Documentation/snippets/fretted-strings-intro.itely
diff --git a/Documentation/snippets/fretted-strings-intro.itely  

Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread julien . rioux

Reviewers: ,

Message:
Open for review.

Description:
Undefined references in translated manuals (issue 2220).

Please review this at http://codereview.appspot.com/5539052/

Affected files:
  M Documentation/cs/learning/common-notation.itely
  M Documentation/cs/learning/fundamental.itely
  M Documentation/de/learning/common-notation.itely
  M Documentation/de/learning/tutorial.itely
  M Documentation/de/learning/tweaks.itely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/de/notation/chords.itely
  M Documentation/de/notation/expressive.itely
  M Documentation/de/notation/fretted-strings.itely
  M Documentation/de/notation/input.itely
  M Documentation/de/notation/notation-appendices.itely
  M Documentation/de/notation/pitches.itely
  M Documentation/de/notation/spacing.itely
  M Documentation/de/notation/text.itely
  M Documentation/de/notation/vocal.itely
  M Documentation/de/notation/world.itely
  M Documentation/de/usage/running.itely
  M Documentation/es/extending/scheme-tutorial.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/fr/notation/pitches.itely
  M Documentation/fr/notation/specialist.itely
  M Documentation/fr/notation/staff.itely
  M Documentation/fr/notation/vocal.itely
  M Documentation/hu/usage.tely
  M Documentation/hu/usage/lilypond-book.itely
  M Documentation/it/learning/fundamental.itely
  M Documentation/it/learning/templates.itely
  M Documentation/ja/notation/input.itely



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread lemzwerg

Julien,

please apply such obvious (and trivial) fixes directly to lilypond
without creating a Rietveld issue.


http://codereview.appspot.com/5539052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread graham

LGTM, I could kiss you for doing this work.

Please push directly to staging once Patchy is finished checking the
compile (about 30 minutes from now).

http://codereview.appspot.com/5539052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

2012-01-12 Thread graham

Looks Absolutely Fantastic To Me.

Please push directly to staging once Patchy has finished testing the
compile (about 30 minutes?)

http://codereview.appspot.com/5541050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel