Change all occurences of echo -n to printf for portability (issue 5903046)
http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh File scripts/build/install-info-html.sh (right): http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh#newcode129 scripts/build/install-info-html.sh:129: printf $name: Writing index: $index_file... This is dangerous since $name could contain print control characters. So one should rather write printf %s: Writing index: %s... $name $index_file... http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM $CHECKSUM_FILE I'd prefer %s $AUTOGEN_INPUT_CHECKSUM here too in order to avoid teaching sloppy use of printf, but it can't actually do harm here since md5sum does not produce backslashes or percent characters. http://codereview.appspot.com/5903046/diff/1/smart-configure.sh File smart-configure.sh (right): http://codereview.appspot.com/5903046/diff/1/smart-configure.sh#newcode19 smart-configure.sh:19: printf $CONFIGURE_CHECKSUM $CONFIGURE_CHECKSUM_FILE See last comment. http://codereview.appspot.com/5903046/diff/1/stepmake/bin/stepmakeise.sh File stepmake/bin/stepmakeise.sh (right): http://codereview.appspot.com/5903046/diff/1/stepmake/bin/stepmakeise.sh#newcode37 stepmake/bin/stepmakeise.sh:37: printf Checking version... Good enough: literal string without control or format characters is harmless. http://codereview.appspot.com/5903046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Change all occurences of echo -n to printf for portability (issue 5903046)
http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM $CHECKSUM_FILE On 2012/03/24 06:00:52, dak wrote: I'd prefer %s $AUTOGEN_INPUT_CHECKSUM here too in order to avoid teaching sloppy use of printf, but it can't actually do harm here since md5sum does not produce backslashes or percent characters. And while we are at it: the trailing whitespace could be removed as well. http://codereview.appspot.com/5903046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add an example implementation of cross-staff stems (issue 5882053)
On 2012/03/23 21:46:41, Pavel Roskin wrote: OK, I'll use make-engraver in the next revision. I guess I'll need to strip all Lilypond 2.14 compatibility stuff if this snippet is to be a part of the Lilypond documentation. In LilyPond itself, it makes sense to document the latest version. If people read 2.16 documentation, they can't expect to see stuff that is guaranteed to work under 2.14. It is not uncommon for some new features to be only discernible from regtests. That is not really good. This is the current state for Scheme engravers. It would be good to have some nice examples for Scheme engravers in the documentation. This particular case is, in my opinion, too complex for either documentation or a targeted regtest. It is LSR material, or should become part of LilyPond proper if one can think of a good way. Note that we have snippets in the LilyPond documentation/repository as well: those can use the newest features. That would be the proper place, I think. We still need to get Scheme engravers into the main documentation. http://codereview.appspot.com/5882053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add an example implementation of cross-staff stems (issue 5882053)
Hello, On 24 March 2012 08:19, d...@gnu.org wrote: On 2012/03/23 21:46:41, Pavel Roskin wrote: OK, I'll use make-engraver in the next revision. I guess I'll need to strip all Lilypond 2.14 compatibility stuff if this snippet is to be a part of the Lilypond documentation. In LilyPond itself, it makes sense to document the latest version. If people read 2.16 documentation, they can't expect to see stuff that is guaranteed to work under 2.14. It is not uncommon for some new features to be only discernible from regtests. That is not really good. This is the current state for Scheme engravers. It would be good to have some nice examples for Scheme engravers in the documentation. This particular case is, in my opinion, too complex for either documentation or a targeted regtest. It is LSR material, or should become part of LilyPond proper if one can think of a good way. Note that we have snippets in the LilyPond documentation/repository as well: those can use the newest features. That would be the proper place, I think. We still need to get Scheme engravers into the main documentation. We have this http://code.google.com/p/lilypond/issues/detail?id=1995 We could incorporate 'Scheme stuff' via this. As I;ve always said, although I don't understand this from a technical point of view if someone can articulate what they want in text form I can do the texinfo 'stuff' to get it in the doc. I'm not sure if the NR is the correct place as opposed to a new @node (or similar) in Extending or whatever. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
New Japanese PO file for 'lilypond' (version 2.15.29)
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Japanese team of translators. The file is available at: http://translationproject.org/latest/lilypond/ja.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/lilypond/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/lilypond.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. coordina...@translationproject.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Change all occurences of echo -n to printf for portability (issue 5903046)
http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh File smart-autogen.sh (right): http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh#newcode16 smart-autogen.sh:16: printf %s $AUTOGEN_INPUT_CHECKSUM $CHECKSUM_FILE Remove trailing space in this line before pushing. http://codereview.appspot.com/5903046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
