Re: Fixes heights and pure heights of stems. (issue 4898044)
Mike, The code in lily/note-collision.cc:219 needs an update to adjust the stem beginning (issue 2441). I tried but I can't find the pure callback for stem beginnings. ly:stem::pure-calc-stem-begin-position Lemme know if I can be of help w/ fixing this! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixes heights and pure heights of stems. (issue 4898044)
On Mon, 26 Mar 2012 23:14:15 -0700, Mike Solomon mike...@ufl.edu wrote:
The code in lily/note-collision.cc:219 needs an update to adjust the
stem beginning (issue 2441). I tried but I can't find the pure
callback for stem beginnings.
ly:stem::pure-calc-stem-begin-position
Okay, it is actually the not-pure version that causes trouble.
When internal_calc_stem_begin_position (Grob *me, bool calc_beam)
is called to actually print the stems, calc_beam is true, and
+ if (beam calc_beam)
+{
+ (void) beam-get_property (quantized-positions);
+ return me-extent (me, Y_AXIS)[-get_grob_direction (me)] * ss * 2;
+}
returns an answer that does not include the results of
Real y_attach = Note_head::stem_attachment_coordinate (head, Y_AXIS);
It seems that the /begin/ positions, the positions of the stem-ends attached to
the note heads, should be calculated the old way whether the beam placement has
been determined or not, so I'm inclined to remove if() above, removing the need
for a pure_* version of calc-stem-begin-position.
Lemme know if I can be of help w/ fixing this!
I'd rather you did.
-Keith
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixes heights and pure heights of stems. (issue 4898044)
On Mar 27, 2012, at 9:21 AM, Keith OHara wrote: It seems that the /begin/ positions, the positions of the stem-ends attached to the note heads, should be calculated the old way whether the beam placement has been determined or not, so I'm inclined to remove if() above, removing the need for a pure_* version of calc-stem-begin-position. This code is only triggered if there is a beam (beam calc_beam), so it should be done the old way in this case. I'll work on the bug later today - thanks for finding it! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Parsed object should be dead
I'm getting a lot of: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers from current master. Is anyone else having this problem? Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Parsed object should be dead
m...@apollinemike.com m...@apollinemike.com writes: I'm getting a lot of: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers from current master. Is anyone else having this problem? I have not gotten lots of it, but I _did_ get one on the graphviz stuff. What you are seeing (as well as the graphviz report) is likely connected with commit e9f23376b8bac1ae6b776d944469712c983e844c Author: David Kastrup d...@gnu.org Date: Wed Mar 21 19:57:46 2012 +0100 Issue 2425: Don't reload initialization files when processing multiple files This significantly speeds up processing of multiple files per session, but has some more potential for bleedover between files. Bleedover can occur when data structures set up by init.ly (and the loaded files) in the parser module before calling the main file are modified in-place. init.ly caters for the known cases: some hash tables modified by user commands are cleared at the start of a new pass, and output definitions are cloned rather than reused from the first load of init.ly. One problem might be be that parsed objects should be dead messages might more easily persist beyond the file actually causing the problem. Can you check whether this is what you are seeing (namely the messages starting with one particular file, and then triggering for every remaining file in the session)? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Parsed object should be dead
David Kastrup d...@gnu.org writes: m...@apollinemike.com m...@apollinemike.com writes: I'm getting a lot of: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers from current master. Is anyone else having this problem? I have not gotten lots of it, but I _did_ get one on the graphviz stuff. What you are seeing (as well as the graphviz report) is likely connected with commit e9f23376b8bac1ae6b776d944469712c983e844c Well, I just investigated some more, and I _should_ have been seeing a lot more, actually. Those messages are generated for object types that have an ASSERT_LIVE_IS_ALLOWED() in their mark procedure since they are not supposed to survive the existence of their parser. The whole point of my commit, however, is to let some objects (like context definitions and context mods) travel from the first initialization run into the next session. I'll have to see whether I can come up with something that makes an exception for the saved init data. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: German translation request
Am 26.03.2012 12:15, schrieb James:
Hello
On 25 March 2012 14:10, Phil Holmesem...@philholmes.net wrote:
In Notation/wind.itely, please could the following be changed:
Die Liste aller möglichen Löcher und Einstellungen eines bestimmten
Instruments kann auf der Kommandozeile oder in einer Log-Datei
angezeigt werden, auch wenn man sie nicht in der Notenausgabe anzeigen
lassen kann:
@lilypond[verbatim,quote]
#(print-keys-verbose 'flute)
@end lilypond
So that we lose the lilypond fragment, but instead use an @code{} block for
the print-keys instruction. This has been done for the English and other
languages, and the remaining use in the German manuals produces about 7% of
the un-needed output from make doc.
Thanks.
http://code.google.com/p/lilypond/issues/detail?id=2437
I think Till Paala has done this already:
commit a074a6092c2a556a584960e63770a2c6201bc05c
Author: Till Paala till.ret...@gmx.de
Date: Tue Mar 20 20:59:56 2012 +0200
Doc-de: update wood.itely to omit woodwind key listing
wood.itely is wrong, he changed wind.itely, but the code is corrected
anyway.
Regards,
Marc
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
In-tree make check fails with lilypond-book include file regtest.
commit ee70161485a2d2f347db3e29724a943c741ef524
Author: Julien Rioux jri...@physics.utoronto.ca
Date: Wed Mar 21 09:13:55 2012 -0400
Regtests for lilypond-book include files located in subdir.
causes the regtests to fail. Rerunning configure, make clean and make
test does not help.
Parsing...
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:18:11: error: cannot
find file: `include/myvar.ily'
(search path:
`/usr/local/tmp/lilypond/out/lybook-db/91:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/svg/:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/type1/:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/otf/:/usr/local/tmp/lilypond/out/share/lilypond/current/scm:/usr/local/tmp/lilypond/out/share/lilypond/current/ps:/usr/local/tmp/lilypond/out/share/lilypond/current/ly:/usr/local/tmp/lilypond/out/lybook-db:../:./:./out-test:../../../input:/usr/local/tmp/lilypond/Documentation:/usr/local/tmp/lilypond/Documentation/snippets:../../../input/regression/:/usr/local/tmp/lilypond/Documentation/included/:/usr/local/tmp/lilypond/mf/out/:/usr/local/tmp/lilypond/mf/out/:/usr/local/tmp/lilypond/Documentation/pictures:/usr/local/tmp/lilypond/Documentation/pictures/./out-test:')
\include
include/myvar.ily
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:18: error: unknown
escaped string: `\myVar'
\relative c'' {
\myVar }
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:18: error: syntax
error, unexpected STRING
\relative c'' {
\myVar }
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:2: error: errors
found, ignoring music expression
\relative c'' { \myVar }
fatal error: failed files: 91/lily-c3d833f7.ly
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
And another include file error.
A nuisance.
This is pdfTeX, Version 3.1415926-1.40.10 (TeX Live 2009/Debian)
entering extended mode
(./texinfo-include-language-detection.texi
(/usr/local/tmp/lilypond/tex/texinfo.tex
Loading texinfo [version 2009-08-14.15]: pdf, fonts, markup, glyphs,
page headings, tables, conditionals, indexing, sectioning, toc, environments,
defuns, macros, cross references, insertions,
(/usr/share/texmf-texlive/tex/generic/epsf/epsf.tex
This is `epsf.tex' v2.7.3 23 July 2005
) localization, formatting, and turning on texinfo input format.)
(/usr/local/tmp/lilypond/tex/txi-es.tex no patterns for spanish)
(Texinfo language detection)
(./texinfo-include-language-detection-included.texi (./include3.texidoces)
(./include3-systems.texi
./include3-systems.texi:1: Could not find image file /usr/local/tmp/lilypond/ou
t/lybook-db/b0/lily-1ef6eeb0-1 for pdf.
@dopdfimage ...uld not find image file #1 for pdf}
@else @gdef @pdfimgext {PD...
@imagexxx ...ndent @ifpdf @dopdfimage {#1}{#2}{#3}
@else @setbox 0 = @hbox {@...
@image ...true @fi @else @imagexxx #1,@finish
@fi
l.1 .../lilypond/out/lybook-db/b0/lily-1ef6eeb0-1}
?
./include3-systems.texi:1: Emergency stop.
@dopdfimage ...uld not find image file #1 for pdf}
@else @gdef @pdfimgext {PD...
@imagexxx ...ndent @ifpdf @dopdfimage {#1}{#2}{#3}
@else @setbox 0 = @hbox {@...
@image ...true @fi @else @imagexxx #1,@finish
@fi
l.1 .../lilypond/out/lybook-db/b0/lily-1ef6eeb0-1}
./include3-systems.texi:1: == Fatal error occurred, no output PDF file produc
ed!
Transcript written on texinfo-include-language-detection.log.
/usr/bin/texi2dvi: pdfetex exited with bad status, quitting.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Parsed object should be dead
m...@apollinemike.com m...@apollinemike.com writes: I'm getting a lot of: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers from current master. Is anyone else having this problem? URL:http://code.google.com/p/lilypond/issues/detail?id=2443 I would tend to push this to staging reasonably fast once it passes the tests. No idea why this would not have been more conspicuous. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: And another include file error.
David Kastrup d...@gnu.org writes: A nuisance. Not repeatable so far, probably rerunning configure and make clean might have fixed the problem. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
David Kastrup d...@gnu.org writes: commit ee70161485a2d2f347db3e29724a943c741ef524 Author: Julien Rioux jri...@physics.utoronto.ca Date: Wed Mar 21 09:13:55 2012 -0400 Regtests for lilypond-book include files located in subdir. causes the regtests to fail. Rerunning configure, make clean and make test does not help. Reverted for now. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: dist-check failure
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: lilypond-devel@gnu.org
Sent: Tuesday, March 27, 2012 1:42 AM
Subject: dist-check failure
ge.ja.html
file from VC not distributed:
lilypond-2.15.35/Documentation/misc/browser-language.nl.html
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/example.ly
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/myvar.ily
rm -rf /tmp/tmpGQR4Q7
Traceback (most recent call last):
File test-lily/dist-check.py, line 137, in module
main ()
File test-lily/dist-check.py, line 132, in main
check_files (tarball, repo)
File test-lily/dist-check.py, line 117, in check_files
raise Exception ('dist error found')
Exception: dist error found
Is this happening with a GUB build or something else?
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: German translation request
- Original Message - From: Marc Hohl m...@hohlart.de To: lilypond-devel@gnu.org Sent: Tuesday, March 27, 2012 10:21 AM Subject: Re: German translation request Am 26.03.2012 12:15, schrieb James: Hello On 25 March 2012 14:10, Phil Holmesem...@philholmes.net wrote: In Notation/wind.itely, please could the following be changed: http://code.google.com/p/lilypond/issues/detail?id=2437 I think Till Paala has done this already: commit a074a6092c2a556a584960e63770a2c6201bc05c Author: Till Paala till.ret...@gmx.de Date: Tue Mar 20 20:59:56 2012 +0200 Doc-de: update wood.itely to omit woodwind key listing OK - thanks. I guess it hadn't hit master last Sunday, when I was looking. I'll check we're fixed at the weekend and kill the bug report if we're done. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: dist-check failure
Phil Holmes m...@philholmes.net writes:
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: lilypond-devel@gnu.org
Sent: Tuesday, March 27, 2012 1:42 AM
Subject: dist-check failure
ge.ja.html
file from VC not distributed:
lilypond-2.15.35/Documentation/misc/browser-language.nl.html
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/example.ly
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/myvar.ily
rm -rf /tmp/tmpGQR4Q7
Traceback (most recent call last):
File test-lily/dist-check.py, line 137, in module
main ()
File test-lily/dist-check.py, line 132, in main
check_files (tarball, repo)
File test-lily/dist-check.py, line 117, in check_files
raise Exception ('dist error found')
Exception: dist error found
Is this happening with a GUB build or something else?
Pretty certainly GUB build. I already reverted the regression test for
another (likely related) reason, namely an in-tree make test failing.
And I _might_ have been hit by the browser-language thing but without
being able to reproduce it.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
Hi, 2012/3/23 Graham Percival gra...@percival-music.ca Well, you need to figure out why git fetch in your $LILYPOND_GIT repository fails. git fetch works now... I need som new patch for play with... Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
Marek, On 27 March 2012 18:48, Marek Klein ma...@gregoriana.sk wrote: Hi, 2012/3/23 Graham Percival gra...@percival-music.ca Well, you need to figure out why git fetch in your $LILYPOND_GIT repository fails. git fetch works now... I need som new patch for play with... Marek I reset one of mine on the countdown http://code.google.com/p/lilypond/issues/detail?id=2216 Try that. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
On 27/03/2012 1:48 PM, Marek Klein wrote: Hi, 2012/3/23 Graham Percivalgra...@percival-music.ca Well, you need to figure out why git fetch in your $LILYPOND_GIT repository fails. git fetch works now... I need som new patch for play with... Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel When there are no issues with a label of Patch=new, you can still test patches by specifying issue numbers on the command line like this: python test-patches.py 2216 without having to reset the said issue. -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On 27/03/2012 9:37 AM, David Kastrup wrote: David Kastrupd...@gnu.org writes: commit ee70161485a2d2f347db3e29724a943c741ef524 Author: Julien Riouxjri...@physics.utoronto.ca Date: Wed Mar 21 09:13:55 2012 -0400 Regtests for lilypond-book include files located in subdir. causes the regtests to fail. Rerunning configure, make clean and make test does not help. Reverted for now. I locally reverted your revert and could make, make test and make doc from scratch in the src dir after the fixes that I committed today. Unless there is any objections I will push the revert of the revert to staging. -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: dist-check failure
On 26/03/2012 8:42 PM, Graham Percival wrote:
ge.ja.html
file from VC not distributed:
lilypond-2.15.35/Documentation/misc/browser-language.nl.html
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/example.ly
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/myvar.ily
rm -rf /tmp/tmpGQR4Q7
Traceback (most recent call last):
File test-lily/dist-check.py, line 137, inmodule
main ()
File test-lily/dist-check.py, line 132, in main
check_files (tarball, repo)
File test-lily/dist-check.py, line 117, in check_files
raise Exception ('dist error found')
Exception: dist error found
- Graham
Is it fixed now with master?
--
Julien
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
2012/3/27 James pkx1...@gmail.com I reset one of mine on the countdown http://code.google.com/p/lilypond/issues/detail?id=2216 Try that. This is the output: Trying issue 2216 Found patch: (2216, '/home/marek/lilypond-patchy/issue5843060_6001.diff', 'AU: Document all options for lilypond -dhelp') Problem compiling master. Patchy cannot reliably continue. Traceback (most recent call last): File test-patches.py, line 16, in module main(issues_id) File test-patches.py, line 12, in main patchy.do_check(issues) File /home/marek/lilypond-patchy/projecthosting_patches.py, line 213, in do_check compile_lilypond_test.main(patches) File /home/marek/lilypond-patchy/compile_lilypond_test.py, line 289, in main raise err Exception: Failed runner: nice make test-baseline -j3 CPU_COUNT=3 See the log file log-None-nice-make-test-baseline--j3-CPU_COUNT=3.txt However, I cannot find the log file :( Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
On 27/03/2012 2:58 PM, Marek Klein wrote: 2012/3/27 Jamespkx1...@gmail.com I reset one of mine on the countdown http://code.google.com/p/lilypond/issues/detail?id=2216 Try that. This is the output: Trying issue 2216 Found patch: (2216, '/home/marek/lilypond-patchy/issue5843060_6001.diff', 'AU: Document all options for lilypond -dhelp') Problem compiling master. Patchy cannot reliably continue. Traceback (most recent call last): File test-patches.py, line 16, inmodule main(issues_id) File test-patches.py, line 12, in main patchy.do_check(issues) File /home/marek/lilypond-patchy/projecthosting_patches.py, line 213, in do_check compile_lilypond_test.main(patches) File /home/marek/lilypond-patchy/compile_lilypond_test.py, line 289, in main raise err Exception: Failed runner: nice make test-baseline -j3 CPU_COUNT=3 See the log file log-None-nice-make-test-baseline--j3-CPU_COUNT=3.txt However, I cannot find the log file :( Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel On a default configuration this logfile would be in /tmp/lilypond-autobuild Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
2012/3/27 Julien Rioux jri...@physics.utoronto.ca On 27/03/2012 2:58 PM, Marek Klein wrote: However, I cannot find the log file :( On a default configuration this logfile would be in /tmp/lilypond-autobuild Cheers, Julien Here it is: http://gregoriana.sk/data/log-None-nice-make-test-baseline--j3-CPU_COUNT=3.txt (The word Chyba means Error) Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
On 27/03/2012 3:20 PM, Marek Klein wrote: 2012/3/27 Julien Riouxjri...@physics.utoronto.ca On 27/03/2012 2:58 PM, Marek Klein wrote: However, I cannot find the log file :( On a default configuration this logfile would be in /tmp/lilypond-autobuild Cheers, Julien Here it is: http://gregoriana.sk/data/log-None-nice-make-test-baseline--j3-CPU_COUNT=3.txt (The word Chyba means Error) Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel So it points to /tmp/lilypond-autobuild/build/out/lybook-testdb/snippet-names--7220266384705246370.log Is that file still around? -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: volunteer for patchy new-patches
2012/3/27 Julien Rioux jri...@physics.utoronto.ca So it points to /tmp/lilypond-autobuild/build/**out/lybook-testdb/snippet- **names--7220266384705246370.log Is that file still around? http://gregoriana.sk/data/snippet-names--7220266384705246370.log Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
how to handle big attachments to bugreports?
Hi, i have a multi-issue bug report almost done, and it contains about 5 MB of examples (i've already cut it down). I remember that we have little space on google tracker, how shall i handle these files? I don't have my webserver and i don't like the idea of putting them on some hosting website, because they'll disappear after some time. Can they be hosted on LilyNet or something? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: how to handle big attachments to bugreports?
Janek, 2012/3/27 Janek Warchoł janek.lilyp...@gmail.com: Hi, i have a multi-issue bug report almost done, and it contains about 5 MB of examples (i've already cut it down). I remember that we have little space on google tracker, how shall i handle these files? I don't have my webserver and i don't like the idea of putting them on some hosting website, because they'll disappear after some time. Can they be hosted on LilyNet or something? Use nabble. I did for all my reg tests I did before we went 'patchy'. I'd link to that from Rietveld for users to look at. Reg tests can get large, For example http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2051-24-November-td4986583.html Might be easier. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On Tue, Mar 27, 2012 at 02:18:18PM -0400, Julien Rioux wrote: I locally reverted your revert and could make, make test and make doc from scratch in the src dir after the fixes that I committed today. Unless there is any objections I will push the revert of the revert to staging. Please wait a day. I don't agree with David's revert of your commit without understanding why it was happening, but reverting that revert without understand why it was happening will just put us back in the initial problematic state. Let's see if current master can be built ok, and fix the dist failures. *Then* we can add back the lilypond-book thing. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On Tue, Mar 27, 2012 at 10:34:37PM +0100, Graham Percival wrote: Let's see if current master can be built ok, and fix the dist failures. *Then* we can add back the lilypond-book thing. oh wait, I just checked git and now see that you have a fix for dist, and have a solution for this as well. What you have done sounds like the right way to move forward. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: Countdown to 20120329
For 20:00 MDT Thursday March 29 Scripts: Issue 2440 http://code.google.com/p/lilypond/issues/detail?id=2440: Patch: rall. and accel stopped working in articulate - R5927044 http://codereview.appspot.com/5927044/ Cheers, Colin -- To live content with small means;to seek elegance rather than luxury, and refinement rather than fashion; to be worthy, not respectable, and wealthy, not rich; to listen to stars and birds, babes and sages, with open heart; to study hard; to think quietly, act frankly, talk gently, await occasions, hurry never; in a word, to let the spiritual, unbidden and unconscious, grow up through the common--this is my symphony. - William Henry Channing,clergyman, reformer (1810-1884) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
Graham Percival gra...@percival-music.ca writes: On Tue, Mar 27, 2012 at 02:18:18PM -0400, Julien Rioux wrote: I locally reverted your revert and could make, make test and make doc from scratch in the src dir after the fixes that I committed today. Unless there is any objections I will push the revert of the revert to staging. Please wait a day. I don't agree with David's revert of your commit without understanding why it was happening, If one understands why something is happening, one can fix the commit instead of reverting it. A revert of non-merge commits is cheap to do and easy to revert again. In this case, the commit in question stopped make test in a standard setup from completing and broke the build of the release as well. It did not contain a bugfix, but rather a regtest for a fix: the fix itself stayed in LilyPond. The problem was most likely not with the regtest itself (after all, it passed the out-of-tree tests of both Patchies), but rather with the infrastructure supporting that kind of multi-file regtest. That means that a fix will meddle with infrastructure, making it a good idea to give it the normal review process, not an expedited emergency one. Reverting the problematic regtest removed the urgency for getting a fix in. When I acted without further communication, it was not done out of a whim but because the advantages of doing so very much outweighed the disadvantages in my assessment of the situation, an assessment based on more than an hour of tests of different constellations involving and not involving the commit and analyzing its impact. Julien's timely response certainly is welcome and alleviates the problem, but it still is not amiss to give the proposed fix a chance at review without having to hammer it home. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
