Re: Fix extra spacing in Kievan notation (issue 6684051)
The presence of a long syllable in the lyrics makes the left_col-extent larger than spring.min_distance(). Manipulating the SpacingSpanner properties has no effect -- the extraneous space is still there. long syllables are a general problem, see Janek's GSoC list, it shouldn't be solved this way. p ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Update contributors. (issue 6689045)
On Mon, Oct 15, 2012 at 5:18 PM, gra...@percival-music.ca wrote: Sorry, there's a bit of confusion here. The past policy was: Thanks, I've updated the file to clarify the policy and made sure that I do not move contributors from past to current but simply add them to current. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Update contributors. (issue 6689045)
The policy clarification LGTM, some minor nitpicks below: http://codereview.appspot.com/6689045/diff/4001/Documentation/included/authors.itexi File Documentation/included/authors.itexi (right): http://codereview.appspot.com/6689045/diff/4001/Documentation/included/authors.itexi#newcode315 Documentation/included/authors.itexi:315: Julien Rioux, 'Rioux' should be placed before 'Sanderson' http://codereview.appspot.com/6689045/diff/4001/Documentation/included/authors.itexi#newcode414 Documentation/included/authors.itexi:414: Ralpha Palmer, typo? http://codereview.appspot.com/6689045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Naming _another_ lacking puzzle piece
Joe Neeman joenee...@gmail.com writes: On Sun, Oct 14, 2012 at 5:19 AM, David Kastrup d...@gnu.org wrote: You are viewing this from the stack angle. But that is a complex view already. The actual user view is A. \override sets a context-specific property value \revert removes a context-specific property value This works reliably. If I ever need more complex stuff than that, I can look it up. And to make the this works reliably part work, we won't expose any isolated \temporary \override without matching \revert in LilyPond. How do you plan to achieve this? If there are any commands using a \temporary...\revert that spans for more than one timestep, I can always nest them and I can always sneak in \overrides between the \temporary and the \revert, just by putting music in parallel. Sneaking is expected to cause problems, and sneaking in _overrides_ is not problematic as they just change the _top_ of the stack, and that gets reverted anyway. Only sneaking in _reverts_ destroys the stack balance, and that means that some states get reverted _more_ than appropriate. However, if the expectation of the user is that they get reverted _totally_ when he writes reverts, things end up better than expected. People have complained about \push/\pop being intolerably programmer-centric _terminology_, but terminology is cheap. The underlying fear was people won't understand what push/pop does, and that can't be cured by using prettier names but only by not doing anything hard to understand unless asked for it. I think stacks are easy to understand, even for non-technical users. The reason for avoiding push/pop is just to stop people from thinking oh, that's programming, it must be hard. Having to keep a stack properly nested _is_ a nuisance. The fundamental complaint about Scheme as the core programming language of LilyPond is that you need to keep so many parentheses nested. LilyPond is _complex_, and sometimes one needs that complexity. But we should try to keep simple things simple, and leave the need to understand complex behavior for when complex things are required. While that's true, I think that a coherent and consistent whole is more important than a slightly simpler beginner interface. I don't find the user interface, as it is, inconsistent. One rarely needs to bother with the full power of a stack (heck, we got along 7 years without a hook into push), and the non-pushing default of \override reflects that. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How to proceed
On Tue, Oct 16, 2012 at 2:44 AM, David Kastrup d...@gnu.org wrote: [...] A coherent set of choices governed by a particular patterning may be called design. Letting choices be made individually by a democratic process will favor varying concepts of simplicity on a detail level while breaking the ability for creating a design according to a pervasive patterning of the problem space. What I am getting at is that if we want to have the basic functionality usable for beginners and musicians who don't know programming, it won't do to let beginners and musicians who don't know programming make the design choices, even though their input and feedback will be helpful for making checking that the design actually meets its objectives. [...] It seems that you're tired by our our style of discussing which results in endless email threads :( I'm sorry, and i'll try to be more brief. I also think that we don't (and shouldn't) aim for random democracy - rather meritocracy and informed democracy. Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Naming _another_ lacking puzzle piece
On Sun, Oct 14, 2012 at 1:26 PM, David Kastrup d...@gnu.org wrote:
Joe Neeman joenee...@gmail.com writes:
On Sun, Oct 14, 2012 at 5:19 AM, David Kastrup d...@gnu.org wrote:
You are viewing this from the stack angle. But that is a complex
view already. The actual user view is
A.
\override sets a context-specific property value
\revert removes a context-specific property value
This works reliably. If I ever need more complex stuff than that,
I can
look it up.
And to make the this works reliably part work, we won't expose
any
isolated \temporary \override without matching \revert in
LilyPond.
How do you plan to achieve this? If there are any commands using a
\temporary...\revert that spans for more than one timestep, I can
always nest them and I can always sneak in \overrides between the
\temporary and the \revert, just by putting music in parallel.
Sneaking is expected to cause problems, and sneaking in _overrides_ is
not problematic as they just change the _top_ of the stack, and that
gets reverted anyway. Only sneaking in _reverts_ destroys the stack
balance, and that means that some states get reverted _more_ than
appropriate. However, if the expectation of the user is that they get
reverted _totally_ when he writes reverts, things end up better than
expected.
[talk] If you want this to be the user's expectation, then perhaps it would
be more appropriate to have \revert clear the stack entirely. Consider
something like this:
\redNotes { ...
\greenNotes { ...
\override NoteHead.color = #purple
...
\revert NoteHead.color
}
...
}
where the functions redNotes and greenNotes use a push. With the current
behaviour, the note colors will go red, green, purple, red, black, so the
\revert neither undoes a single change nor does it return to the default.
If \revert clears the stack, then you'll get red, green, purple, black,
which is not ideal in my opinion, but at least better than the earlier
option. (My preferred behaviour would be red, green, purple, green, red.)
People have complained about \push/\pop being intolerably
programmer-centric _terminology_, but terminology is cheap. The
underlying fear was people won't understand what push/pop does,
and
that can't be cured by using prettier names but only by not doing
anything hard to understand unless asked for it.
I think stacks are easy to understand, even for non-technical users.
The reason for avoiding push/pop is just to stop people from thinking
oh, that's programming, it must be hard.
Having to keep a stack properly nested _is_ a nuisance. The fundamental
complaint about Scheme as the core programming language of LilyPond is
that you need to keep so many parentheses nested.
An override stack is more forgiving than nested parentheses for two
reasons: first, it isn't an error if you have a non-empty stack at the end
of the piece, and second, there would be a command to clear the stack and
reset the default. It is admittedly hard to know for sure without trying
it, but I find it hard to imagine that keeping track of the stack will
cause difficulties.
LilyPond is _complex_, and sometimes one needs that complexity.
But we
should try to keep simple things simple, and leave the need to
understand complex behavior for when complex things are required.
While that's true, I think that a coherent and consistent whole is
more important than a slightly simpler beginner interface.
I don't find the user interface, as it is, inconsistent. One rarely
needs to bother with the full power of a stack (heck, we got along
7 years without a hook into push), and the non-pushing default of
\override reflects that.
But now that we are giving a hook into push, I think that the non-pushing
default of override will cause problems.
Cheers,
Joe
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Naming _another_ lacking puzzle piece
Joe Neeman joenee...@gmail.com writes: But now that we are giving a hook into push, I think that the non-pushing default of override will cause problems. I consider it utterly ludicrous that the mere availability of \temporary will magically cause problems with the existing usage of \override, but there is no point in continuing this farce as I have already given up. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Naming _another_ lacking puzzle piece
On Tue, Oct 16, 2012 at 10:21 AM, David Kastrup d...@gnu.org wrote: Joe Neeman joenee...@gmail.com writes: But now that we are giving a hook into push, I think that the non-pushing default of override will cause problems. I consider it utterly ludicrous that the mere availability of \temporary will magically cause problems with the existing usage of \override, Is the example I posted (and which you snipped) utterly ludicrous? but there is no point in continuing this farce as I have already given up. Do you really consider this discussion a farce? I thought I was making reasonable points, but if they are indeed farcical then perhaps I should give up too. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
problem uploading a patch
Hi, I'm trying to upload a patch created in a branch to Rietveld, but I seem to be creating an unholy mess. I attempted to run git-cl upload master within my branch, but I end up with a huge list of recent commits not my own. The same thing happened when I ran git format-patch master and earlier, when I tried to merge several commits with git rebase -i master I'm not sure what's going on here. I did manage to get a .patch file with my commits (in the midst of dozens of others). Is there a simple command to upload this to Rietveld? Thanks, David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix extra spacing in Kievan notation (issue 6684051)
On 2012/10/16 08:14:17, benko.pal wrote: The presence of a long syllable in the lyrics makes the left_col-extent larger than spring.min_distance(). Manipulating the SpacingSpanner properties has no effect -- the extraneous space is still there. long syllables are a general problem, see Janek's GSoC list, it shouldn't be solved this way. p The GSoC issues do not deal with packed spacing, so this is somewhat different, though related. Do you have any ideas for how this issue could be addressed differently? Has there been any work on the various GSoC issues? http://codereview.appspot.com/6684051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: problem uploading a patch
- Original Message - From: David Nalesnik david.nales...@gmail.com To: Lilypond Dev lilypond-devel@gnu.org Sent: Tuesday, October 16, 2012 8:56 PM Subject: problem uploading a patch Hi, I'm trying to upload a patch created in a branch to Rietveld, but I seem to be creating an unholy mess. I attempted to run git-cl upload master within my branch, but I end up with a huge list of recent commits not my own. The same thing happened when I ran git format-patch master and earlier, when I tried to merge several commits with git rebase -i master I'm not sure what's going on here. I did manage to get a .patch file with my commits (in the midst of dozens of others). Is there a simple command to upload this to Rietveld? Thanks, David If you have a record of changes you've made, then I tend to use git reset --hard origin/master which takes you back to the current state of master, and then git am your.patch which applies the patch you have. Follow this with git cl issue your_issue_number in case git cl is confused, and finally git cl upload -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: problem uploading a patch
Hi Phil, On Tue, Oct 16, 2012 at 3:11 PM, Phil Holmes [...] If you have a record of changes you've made, then I tend to use git reset --hard origin/master which takes you back to the current state of master, and then git am your.patch which applies the patch you have. Follow this with git cl issue your_issue_number in case git cl is confused, and finally git cl upload Everything went fine until this point, but then I get a number of errors: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445) david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload Unable to determine default branch to diff against. Either pass complete git diff-style arguments, like git cl upload origin/master or verify this branch is set up to track another (via the --track argument to git checkout -b ...). david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload origin/master input/regression/measure-counter.ly | 41 ly/spanners-init.ly |4 + scm/define-event-classes.scm|6 +- scm/define-grob-interfaces.scm |5 ++ scm/define-grob-properties.scm |1 + scm/define-grobs.scm| 18 + scm/define-music-types.scm |5 ++ scm/music-functions.scm | 117 +++ 8 files changed, 194 insertions(+), 3 deletions(-) This branch is associated with issue 2445. Adding patch to that issue. Traceback (most recent call last): File /home/david/bin/git-cl, line 888, in module sys.exit(main(sys.argv)) File /home/david/bin/git-cl, line 882, in main return func(argv[2:]) File /home/david/bin/git-cl, line 584, in CmdUpload desc = cl.GetDescription() File /home/david/bin/git-cl, line 278, in GetDescription self.description = urllib2.urlopen(url).read().strip() File /usr/lib/python2.6/urllib2.py, line 126, in urlopen return _opener.open(url, data, timeout) File /usr/lib/python2.6/urllib2.py, line 397, in open response = meth(req, response) File /usr/lib/python2.6/urllib2.py, line 510, in http_response 'http', request, response, code, msg, hdrs) File /usr/lib/python2.6/urllib2.py, line 435, in error return self._call_chain(*args) File /usr/lib/python2.6/urllib2.py, line 369, in _call_chain result = func(*args) File /usr/lib/python2.6/urllib2.py, line 518, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) urllib2.HTTPError: HTTP Error 404: Not Found I have no idea what's going on here :( I don't want to nuke the build directory and start again, branch-free. Hopefully there's another option! -David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: problem uploading a patch
Hi Phil. david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445) david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload Unable to determine default branch to diff against. Either pass complete git diff-style arguments, like git cl upload origin/master or verify this branch is set up to track another (via the --track argument to git checkout -b ...). david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload origin/master input/regression/measure-counter.ly | 41 ly/spanners-init.ly |4 + scm/define-event-classes.scm|6 +- scm/define-grob-interfaces.scm |5 ++ scm/define-grob-properties.scm |1 + scm/define-grobs.scm| 18 + scm/define-music-types.scm |5 ++ scm/music-functions.scm | 117 +++ 8 files changed, 194 insertions(+), 3 deletions(-) This branch is associated with issue 2445. Adding patch to that issue. Traceback (most recent call last): File /home/david/bin/git-cl, line 888, in module sys.exit(main(sys.argv)) File /home/david/bin/git-cl, line 882, in main return func(argv[2:]) File /home/david/bin/git-cl, line 584, in CmdUpload desc = cl.GetDescription() File /home/david/bin/git-cl, line 278, in GetDescription self.description = urllib2.urlopen(url).read().strip() File /usr/lib/python2.6/urllib2.py, line 126, in urlopen return _opener.open(url, data, timeout) File /usr/lib/python2.6/urllib2.py, line 397, in open response = meth(req, response) File /usr/lib/python2.6/urllib2.py, line 510, in http_response 'http', request, response, code, msg, hdrs) File /usr/lib/python2.6/urllib2.py, line 435, in error return self._call_chain(*args) File /usr/lib/python2.6/urllib2.py, line 369, in _call_chain result = func(*args) File /usr/lib/python2.6/urllib2.py, line 518, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) urllib2.HTTPError: HTTP Error 404: Not Found Looking into this further, I discovered a thread where Harm ran into a similar situation: http://www.mail-archive.com/lilypond-devel@gnu.org/msg47866.html It's clearly not the same error, but it prompted me to look at the way git cl is configured. I get: [core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote origin] url = git://git.sv.gnu.org/lilypond.git fetch = +refs/heads/master:refs/remotes/origin/master [branch master] remote = origin merge = refs/heads/master rebase = true [rietveld] server = codereview.appspot.com cc = lilypond-devel@gnu.org [branch dev/measure_counter] rietveldissue = 2445 [gui] wmstate = normal Is everything here OK? I even tried adding http:// before the server address, but this led to [...] File /usr/lib/python2.6/httplib.py, line 682, in _set_hostport raise InvalidURL(nonnumeric port: '%s' % host[i+1:]) httplib.InvalidURL: nonnumeric port: '' No idea what to do :( -David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: problem uploading a patch
David Nalesnik david.nales...@gmail.com writes: Hi, I'm trying to upload a patch created in a branch to Rietveld, but I seem to be creating an unholy mess. I attempted to run git-cl upload master within my branch, but I end up with a huge list of recent commits not my own. The same thing happened when I ran git format-patch master and earlier, when I tried to merge several commits with git rebase -i master I'm not sure what's going on here. Try git rebase origin first, and also use git-cl upload origin rather than master. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
