PATCHES: Countdown for June 26th 2014
Hello, Here is the current patch countdown list. The next countdown will be on June 26th 2014. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaitingcolspec=Patch%20Owner%20ID%20Summarysort=patch PUSH: Mark Polesky: Add `make-countdown-announcement.sh'. http://code.google.com/p/lilypond/issues/detail?id=3957 COUNTDOWN: James Lowe: Patch: Doc - NR 1.1.3 and Changes update w/ new Clef Appendix http://code.google.com/p/lilypond/issues/detail?id=3959 Mark Polesky: Give examples of \applyContext usage. http://code.google.com/p/lilypond/issues/detail?id=3958 REVIEW: James Lowe: Patch: Authors.itexi - Updated Developers list http://code.google.com/p/lilypond/issues/detail?id=3964 James Lowe: Patch: Doc: Updated Roadmap text file http://code.google.com/p/lilypond/issues/detail?id=3963 Janek WarchoÅ: Patch: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters http://code.google.com/p/lilypond/issues/detail?id=3962 James Lowe: NR 4.3.7 - explict breaks needs better example for iine/page-break-permission http://code.google.com/p/lilypond/issues/detail?id=3960 James Lowe: Extending 2.3.2: Add sentence to definition to clarify point further http://code.google.com/p/lilypond/issues/detail?id=3955 Mark Polesky: Scale slurs and ties when using \magnifyMusic. http://code.google.com/p/lilypond/issues/detail?id=3942 James Lowe: Usage: add warning about duplicate messages in the log http://code.google.com/p/lilypond/issues/detail?id=3873 Janek WarchoÅ: Patch: don't abort aligning when grob's parent is a PaperColumn http://code.google.com/p/lilypond/issues/detail?id=3254 WAITING: Urs Liska: Patch: Issue 3916: Add \alternatingTimeSignatures http://code.google.com/p/lilypond/issues/detail?id=3918 Janek WarchoÅ: Patch: rewrite Self_alignment_interface http://code.google.com/p/lilypond/issues/detail?id=3239 Janek WarchoÅ: Positioning of 8 under clef symbol in G_8 clef http://code.google.com/p/lilypond/issues/detail?id=3186 Mike Solomon: Patch: Prevents vertical axis groups with empty skylines http://code.google.com/p/lilypond/issues/detail?id=3156 Mike Solomon: Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning. http://code.google.com/p/lilypond/issues/detail?id=3134 David Kastrup: Patch: Implement music functions in Scheme rather than C++ http://code.google.com/p/lilypond/issues/detail?id=2716 Thank you, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES: Countdown for June 26th 2014
Hello, can we put 2014-06-23 8:27 GMT+02:00 james pkx1...@gmail.com: Janek Warchoł: Patch: don't abort aligning when grob's parent is a PaperColumn http://code.google.com/p/lilypond/issues/detail?id=3254 on this countdown? I have lots of further work that depends on this patch, so i'd like to get it accepted asap (the other one can wait). Also, it's not very big, so it shouldn't be hard to review. best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES: Countdown for June 26th 2014
On 23/06/14 07:45, Janek Warchoł wrote: Hello, can we put 2014-06-23 8:27 GMT+02:00 james pkx1...@gmail.com: Janek Warchoł: Patch: don't abort aligning when grob's parent is a PaperColumn http://code.google.com/p/lilypond/issues/detail?id=3254 on this countdown? I have lots of further work that depends on this patch, so i'd like to get it accepted asap (the other one can wait). Also, it's not very big, so it shouldn't be hard to review. best, Janek Feel free to change it. I make a minimum cut off point of 20 - 24 hours since a patch was 'tested' before I move them on - I have to cut-off somewhere - this was I think 19 hours. So for me it's no big deal. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)
LGTM - this is helpful, thanks! https://codereview.appspot.com/110060045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Question about defined music functions
Hello, Can I assume (dangerous ground I know) that if I look in ly/music-functions-init.ly and see an entry that has the form someString = #(define-music-function ... That this is always a command in the form \someString That a user can directly in a .ly file (if you see what I mean/). I ask because if I look (for example) at this checkin http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=3b65aea88185c2ce92b1a905e0535d7d4c60d71a I can see that the ly/music-functions-init.ly file shows +magnifyMusic = +#(define-music-function but if I look at this check-in http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=d3e856b31301bc6e67a13118ad432d22897d9f8b The new function \justify-line seems to only touch the scm/define-markup-commands.scm file and nothing is added to ly/music-functions-init.ly Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Question about defined music functions
James pkx1...@gmail.com writes: Can I assume (dangerous ground I know) that if I look in ly/music-functions-init.ly and see an entry that has the form someString = #(define-music-function ... That this is always a command in the form \someString That a user can directly in a .ly file (if you see what I mean/). Basically, assuming that I see what you mean. +magnifyMusic = +#(define-music-function but if I look at this check-in http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=d3e856b31301bc6e67a13118ad432d22897d9f8b The new function \justify-line seems to only touch the scm/define-markup-commands.scm file and nothing is added to ly/music-functions-init.ly It is not a music function but rather a markup command. You can only use it inside of markup. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
astyle 2.02
Hi, our fixcc scripts says that it requires astyle in version exactly 2.02. However, the latest version is 2.04 and i didn't manage to find packaged 2.02 version - does anyone know where i could get it? Or maye we could use 2.04 after all? I believe that having a tool like fixcc is absolutely awesome, but only if it works without hassles, so i'd like to do something about it. best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: astyle 2.02
I can see 2.01 in debian wheezy: https://packages.debian.org/search?keywords=astyle Il 23/giu/2014 22:52 Janek Warchoł janek.lilyp...@gmail.com ha scritto: Hi, our fixcc scripts says that it requires astyle in version exactly 2.02. However, the latest version is 2.04 and i didn't manage to find packaged 2.02 version - does anyone know where i could get it? Or maye we could use 2.04 after all? I believe that having a tool like fixcc is absolutely awesome, but only if it works without hassles, so i'd like to do something about it. best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: astyle 2.02
Janek Warchoł wrote: our fixcc scripts says that it requires astyle in version exactly 2.02. However, the latest version is 2.04 and i didn't manage to find packaged 2.02 version - does anyone know where i could get it? Or maye we could use 2.04 after all? Sourceforge has all the old versions, and they build out of the box: https://sourceforge.net/projects/astyle/files/astyle/ I just tried both 2.02 and 2.04. Either version makes about 400 lines of changes, which are mostly identical. The differences are: * 2.02 unnecessarily indents inside the toplevel extern block in file-cookie.hh. * 2.04 recognizes type specifiers like 'char*' more reliably, so it adjusts their whitespace in some places where 2.02 doesn't. * 2.04 misspaces an operator (maybe misinterpreting it as a C++11 rvalue reference?): @@ -193,7 +193,7 @@ Midi_time_signature::to_string () const Midi_note::Midi_note (Audio_note *a) : Midi_channel_item (a), audio_ (a), -dynamic_byte_ (min (max (Byte ((a-dynamic_ a-dynamic_-volume_ = 0 +dynamic_byte_ (min (max (Byte ((a-dynamic_ a-dynamic_-volume_ = 0 ? a-dynamic_-volume_ * 0x7f : 0x5a) + a-extra_velocity_), Byte (0)), Byte (0x7f))) * 2.02 and 2.04 make slightly different mistakes here: @@ -106,7 +106,7 @@ LY_DEFINE (ly_moment_mul, ly:moment-mul, Moment *ma = unsmob_moment (a); Moment *mb = unsmob_moment (b); - return (*ma * * mb).smobbed_copy (); + return (*ma **mb).smobbed_copy (); } * 2.04 aligns ? and : when they're on separate lines: @@ -1819,7 +1913,7 @@ ? (pure ? scm_car (inside) : unpure_pure_container_unpure_part (scm_car (inside))) - : scm_car (inside); + : scm_car (inside); SCM args = scm_cons (delayed_argument, evaluate_args (delayed_argument, scm_cdr (inside), pure, start, end)); The cases where 2.04 does worse than 2.02 are minor; I don't think they're enough that fixcc.py should refuse to use it. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: BreathingSigns and automatic beams
On Wed, Mar 6, 2013 at 6:00 PM, Thomas Morley
thomasmorle...@googlemail.com wrote:
Well, nowadays we have the 'collision-interfaces-property but adding
breathing-sign-interface to it seems to have no effect.
\version 2.17.12
respectBS = {
\override Beam #'collision-interfaces =
#'(beam-interface
clef-interface
breathing-sign-interface
flag-interface
inline-accidental-interface
key-signature-interface
note-head-interface
octavate-eight-interface
stem-interface
time-signature-interface)
}
\relative c' {
\respectBS
c8 d e f b[ a \breathe g f]
}
Reviving this old thread. I was trying to do this today and found the
same frustration. It looks like it requires a simple change to the
code:
=
diff --git a/lily/auto-beam-engraver.cc b/lily/auto-beam-engraver.cc
index 8b55b44..92bc796 100644
--- a/lily/auto-beam-engraver.cc
+++ b/lily/auto-beam-engraver.cc
@@ -353,7 +353,8 @@ void
Auto_beam_engraver::acknowledge_breathing_sign (Grob_info /* info */)
{
check_bar_property ();
- if (stems_)
+ bool breathBreaksBeam = to_boolean (get_property
(breathingSignBreaksBeam));
+ if (stems_ breathBreaksBeam)
end_beam ();
}
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index ebfff6a..322db5f 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -638,6 +638,7 @@ automatically when an output definition (a @code{\\score} or
beamHalfMeasure = ##t
autoBeaming = ##t
+ breathingSignBreaksBeam = ##t
autoBeamCheck = #default-auto-beam-check
completionFactor = #unity-if-multimeasure
diff --git a/scm/define-context-properties.scm
b/scm/define-context-properties.scm
index 2d38188..3e5510d 100644
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -115,6 +115,7 @@ arguments, @var{context}, @var{dir} [start/@/stop
(-1 or 1)], and
starts or stops the auto beam.)
(autoBeaming ,boolean? If set to true then beams are generated
automatically.)
+ (breathingSignBreaksBeam ,boolean? Indicates that a breathing
sign causes beams to break.)
(autoCautionaries ,list? List similar to @code{autoAccidentals},
but it controls cautionary accidentals rather than normal ones. Both
lists are tried, and the one giving the most accidentals wins. In
=
Is this an appropriate approach? Ideally it'd be nice to give it a
list of things that cause beams to end (e.g. breathing sign, manual
beam, bar line, etc.).
-Jay
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: BreathingSigns and automatic beams
Jay Anderson horndud...@gmail.com writes:
On Wed, Mar 6, 2013 at 6:00 PM, Thomas Morley
thomasmorle...@googlemail.com wrote:
Well, nowadays we have the 'collision-interfaces-property but adding
breathing-sign-interface to it seems to have no effect.
\version 2.17.12
respectBS = {
\override Beam #'collision-interfaces =
#'(beam-interface
clef-interface
breathing-sign-interface
flag-interface
inline-accidental-interface
key-signature-interface
note-head-interface
octavate-eight-interface
stem-interface
time-signature-interface)
}
\relative c' {
\respectBS
c8 d e f b[ a \breathe g f]
}
Reviving this old thread. I was trying to do this today and found the
same frustration.
You don't say which frustration. You apparently want to have automatic
beams across breath marks. To me, that does not make a lot of sense.
But since the beam engraver sits at Voice level, that's sort of easy to
cheat around:
\version 2.17.12
breathe = \new Voice \breathe
\relative c' {
c8 d e f b a \breathe g f
}
Of course, this does not follow \voiceOne/\voiceTwo settings.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: astyle 2.02
On Mon, Jun 23, 2014 at 09:28:24PM -0400, Devon Schudy wrote: The cases where 2.04 does worse than 2.02 are minor; I don't think they're enough that fixcc.py should refuse to use it. Thanks for the analysis of astyle 2.02 vs. 2.04. I support switching to 2.04. However, fixcc.py should reject any version other than the specific version we want. Otherwise, you could run it on your computer (and push it), then I could run it on my computer (and push it), then you could do the same thing, and basically we'd end up with an infinite sequence of formatting changes. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by janek.lilyp...@gmail.com)
Looks very good. I looked for unwanted side-effects, and found no problems. The old code did a very bad thing, ignoring the self-alignment-X/Y request if the parent was a paper-column. https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc File lily/paper-column.cc (right): https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc#newcode226 lily/paper-column.cc:226: Paper_column::get_generic_interface_extent (Grob *column, SCM interface, Axis a) I don't understand what 'generic' means over just get_interface_extent(c, i, a) but I leave it to you to name your function. https://codereview.appspot.com/108110044/diff/80001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/108110044/diff/80001/lily/self-alignment-interface.cc#newcode82 lily/self-alignment-interface.cc:82: MAKE_SCHEME_CALLBACK (Self_alignment_interface, centered_on_note_columns, 1); Looks like somebody had a similar idea. This function seems to be used only for dynamics in a Dynamics context. https://codereview.appspot.com/108110044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters (issue 108110045 by janek.lilyp...@gmail.com)
looks good, and logical. https://codereview.appspot.com/108110045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
