Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)
https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist factor) There is no doc string here or other documentation. You call the argument fonts-alist, but the code later makes obvious that this is, indeed, not at all an alist. Instead an alist is later constructed from it. https://codereview.appspot.com/108700043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 4015: Add \magnifyStaff. (issue 117830043 by markpole...@gmail.com)
Reviewers: , Message: Here's a new music function called \magnifyStaff (along the lines of \magnifyMusic) that scales staff sizes, staff lines, bar lines, beamlets, and horizontal spacing at the Staff context level. Staff lines are prevented from being scaled smaller than the default (and consequently, so are stems, slurs, etc., since the thickness of each is based on staff lines). This should improve the user experience for this task, which is somewhat cumbersome as it stands. I rewrote the backend to \magnifyMusic so that the two functions could share some code. The bulk of the code is in: ly/music-functions-init.ly scm/music-functions.scm scm/define-context-properties.scm You can see example usages in the modified Documentation files and regtests. This is issue 4015 on the tracker: http://code.google.com/p/lilypond/issues/detail?id=4015 Cheers, Mark Description: * Add \magnifyStaff. * Rewrite parts of the \magnifyMusic function so that it can share some scheme code with the new \magnifyStaff function. * Add regtests. * Update documentation. Please review this at https://codereview.appspot.com/117830043/ Affected files (+329, -95 lines): M Documentation/essay/engraving.itely M Documentation/music-glossary.tely M Documentation/notation/spacing.itely M Documentation/notation/staff.itely A input/regression/magnifyStaff-bar-lines.ly A input/regression/magnifyStaff-dots-beamlets.ly A input/regression/magnifyStaff-space-alist.ly A input/regression/magnifyStaff-staff-line-thickness.ly M ly/music-functions-init.ly M scm/define-context-properties.scm M scm/music-functions.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)
https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist factor) On 2014/07/16 09:20:45, dak wrote: There is no doc string here or other documentation. I wrote one now; didn't do it because I started with a copy of make-pango-font-tree, and it does not have one as well (I know, not the best reason). Is there some place but the font.scm itself where it can be seen live? It is not built into the docs, right? You call the argument fonts-alist, but the code later makes obvious that this is, indeed, not at all an alist. Instead an alist is later constructed from it. Good catch. I first planned for an alist, but the less verbose input format of the lists looks more appealing to me. https://codereview.appspot.com/108700043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: Appendix - Articulations and Ornamentation - part 2 (issue 114840043 by pkx1...@gmail.com)
https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1547 Documentation/notation/notation-appendices.itely:1547: @multitable @columnfractions .20 .20 .20 .20 .20 No @headitem? https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1606 Documentation/notation/notation-appendices.itely:1606: @multitable @columnfractions .20 .20 .20 .20 Missing the fifth .20 here, no? https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1691 Documentation/notation/notation-appendices.itely:1691: @multitable @columnfractions .20 .20 .20 .20 Same here? https://codereview.appspot.com/114840043/diff/1/Documentation/notation/notation-appendices.itely#newcode1800 Documentation/notation/notation-appendices.itely:1800: @multitable @columnfractions .20 .20 .20 .20 I count only 3 columns now, but that should not be a problem But wants to be five eventually? https://codereview.appspot.com/114840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Rietveld with Google two-factor authentification
Hi all, does one of you use Google's two-factor authentification thingie? I used it without any trouble on usual apps, but now I'm kind of stuck with git cl to commit patches to Rietveld. AFAICS, the only way to login is via an application-specific password, which is an ugly beast not meant for manual input more than once. My usual password is not accepted (which is good), since git-cl does not ask for the second-factor token (which is bad). And obviously git-cl is not able to cache the credentials - I get Could not find stored credentials $HOME/.lilypond-project-hosting-login each time. What am I missing here? Best, Alexander ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Rietveld with Google two-factor authentification
On Wed, Jul 16, 2014 at 03:11:31PM +0200, Alexander Kobel wrote: My usual password is not accepted (which is good), since git-cl does not ask for the second-factor token (which is bad). And obviously git-cl is not able to cache the credentials - I get Could not find stored credentials $HOME/.lilypond-project-hosting-login each time. That is correct, git-cl does no caching, no fancy authentication, etc. It attempts to read the above file, and it takes the first line in that file as the username and the second line in that file as the password. That's all it does. Patches to git-cl most welcome. :) I've heard of this two-factor authentication, but I've never used it (even in my personal life), and git-cl was my first foray into authentication on foreign servers. I was kind-of expecting that somebody familiar with python+google+authentication to take 30 minutes (rough estimate for somebody familiar with the above) to fix it after a few months, but obviously there's been no takers yet. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Rietveld with Google two-factor authentification
On 07/16/2014 03:58 PM, Graham Percival wrote: On Wed, Jul 16, 2014 at 03:11:31PM +0200, Alexander Kobel wrote: My usual password is not accepted (which is good), since git-cl does not ask for the second-factor token (which is bad). And obviously git-cl is not able to cache the credentials - I get Could not find stored credentials $HOME/.lilypond-project-hosting-login each time. That is correct, git-cl does no caching, no fancy authentication, etc. It attempts to read the above file, and it takes the first line in that file as the username and the second line in that file as the password. That's all it does. Ah, okay. That means if I put this application-specific password there, I'm done? Cool. Now I just need to write some new patch to test... Patches to git-cl most welcome. :) I see... ;-) I've heard of this two-factor authentication, but I've never used it (even in my personal life), I do like the concept a lot, but it's certainly not for everyday tasks - if you push 30 patches a day, you don't want to read a token each time. That's what those app-specific passwords are there for; they can be revoked independently of each other, and they only apply for specific tasks. E.g., with the Rietveld-only password it is impossible to access my calendar. So while it's still a risk to store it in some potentially publicly available place, I don't expose my entire Google profile with it. YMMV. and git-cl was my first foray into authentication on foreign servers. I was kind-of expecting that somebody familiar with python+google+authentication to take 30 minutes (rough estimate for somebody familiar with the above) to fix it after a few months, but obviously there's been no takers yet. I just stumbled across the issue; I'll never did anything authentication-related, too, but I'll have a look. Thanks, Alexander ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Question about @vindex entries in macros.itexi
Hello,
This is way above my 'pay grade' but I wondered - from my limited
understanding of TexInfo - why we include a @vindex in the following macros.
So for instance if I look in macros.itexi I can see (cut for brevity):
--snip--
@macro rprogram{TEXT}
@vindex \TEXT\
@ref{\TEXT\,,,usage-big-page,Application Usage}
@end macro
@macro rprogramnamed{TEXT,DISPLAY}
@vindex \TEXT\
@ref{\TEXT\,,\DISPLAY\,usage-big-page,Application Usage}
@end macro
@macro rlsr{TEXT}
@ref{\TEXT\,,,snippets-big-page,Snippets}
@end macro
@macro rlsrnamed{TEXT,DISPLAY}
@ref{\TEXT\,,\DISPLAY\,snippets-big-page,Snippets}
@end macro
@macro rinternals{TEXT}
@vindex \TEXT\
@ref{\TEXT\,,,internals-big-page,Internals Reference}
@end macro
--snip--
and so on.
Although, as you can see, two of these @macros don't have an @vindex in
them.
You see, it seems that when we include an @ref{} (or a more specific
@rcontrib{} @rlearning{} etc.) in a sentence and not on a line on its
own, it generates a warning in the *.makeinfo.log files.
--snip--
...
/tmp/lilypond-autobuild/Documentation/contributor/introduction.itexi:26:
warning: @vindex should only appear at a line beginning (possibly
involving @rcontrib)
/tmp/lilypond-autobuild/Documentation/contributor/introduction.itexi:26:
warning: @vindex should only appear at a line beginning (possibly
involving @rcontrib)
/tmp/lilypond-autobuild/Documentation/contributor/introduction.itexi:117: warning:
@vindex should only appear at a line beginning (possibly involving @rweb)
...
--snip--
When I reference those lines in the *.itexi file I can see these @ref{}
constructions in the source at the end or in the middle of a sentence.
It doesn't break the build obviously but I wondered what their purpose
was of having the @vindex in some of the macros, at least in this context?
Thanks
James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add an expert font tree interface (issue 108700043 by perpeduumimmob...@gmail.com)
On 16/07/14 14:04, perpeduumimmob...@gmail.com wrote: https://codereview.appspot.com/108700043/diff/20001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/20001/scm/font.scm#newcode240 scm/font.scm:240: (define-public (make-expert-font-tree fonts-alist factor) On 2014/07/16 09:20:45, dak wrote: There is no doc string here or other documentation. I wrote one now; didn't do it because I started with a copy of make-pango-font-tree, and it does not have one as well (I know, not the best reason). Is there some place but the font.scm itself where it can be seen live? It is not built into the docs, right? http://lilypond.org/doc/v2.18/Documentation/internals/ James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4015: Add \magnifyStaff. (issue 117830043 by markpole...@gmail.com)
markpolesky wrote Here's a new music function called \magnifyStaff (along the lines of \magnifyMusic) that scales staff sizes, staff lines, bar lines, beamlets, and horizontal spacing at the Staff context level. Staff lines are prevented from being scaled smaller than the default (and consequently, so are stems, slurs, etc., since the thickness of each is based on staff lines). This should improve the user experience for this task, which is somewhat cumbersome as it stands. Thanks for working on this! It will definitely be a welcome improvement, at least for this user. Since magnify technically only refers to increasing size and not reducing it, would it make sense to come up with a name for these two functions that would make it clearer that they do both? The best ideas I've come up with would be either resize or scale. Since scale could be confused with the musical meaning of scale, I think resize is the better option of these two. \resizeStaff \resizeMusic Thoughts on this? -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/Issue-4015-Add-magnifyStaff-issue-117830043-by-markpolesky-gmail-com-tp164515p164526.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4015: Add \magnifyStaff. (issue 117830043 by markpole...@gmail.com)
On Wed, Jul 16, 2014 at 12:01 PM, Paul Morris p...@paulwmorris.com wrote: The best ideas I've come up with would be either resize or scale. Since scale could be confused with the musical meaning of scale, I think resize is the better option of these two. \resizeStaff \resizeMusic I'm not opposed to those names; let's see what the others say. By the way scale is also bad because of its connection with \scaleDurations. Mark ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LilyPond meeting 2014?
Oh, I wish I could go! Unfortunately it's kind of a huge expense to fly from the USA :(. Enjoy, whoever goes! Regards, Abraham On Sun, Jul 13, 2014 at 7:50 AM, David Kastrup d...@gnu.org wrote: Janek Warchoł janek.lilyp...@gmail.com writes: 2014-07-13 10:53 GMT+02:00 Marc Hohl m...@hohlart.de: Am 12.07.2014 19:58, schrieb Mike Solomon: I’d love to meet up but I am in gig mode as well towards the end of the summer and we have a newborn in the house. Hey, congratulations! The nights are quiet, yes? ;-) All the best for all of you! I suppose at nights they're rehearsing the Queen of the Night coloraturas ;-) Oh, lots of time. One would already call URL:https://www.youtube.com/watch?v=F9ijwfRTv0o a young performer. There is also URL:https://www.youtube.com/watch?v=sF0zePMxxys but frankly, I cannot understand a word. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
