Re: request to add the agostini drum style to lilypond
Frédéric Gohier fgohie...@hotmail.com writes: Hello, please find attach my proposal to add the agostini drum style That's without any documentation or rationale. Nobody will be able to make use of it in this form or even discover it except by accident, making it a dead piece of code. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: request to add the agostini drum style to lilypond
Am 18.09.2014 08:38, schrieb David Kastrup: Frédéric Gohier fgohie...@hotmail.com writes: Hello, please find attach my proposal to add the agostini drum style That's without any documentation or rationale. Nobody will be able to make use of it in this form or even discover it except by accident, making it a dead piece of code. David, you're right with what you say. But nevertheless it might be a good idea to provide the OP with a more helpful answer that will enable him to get his suggestion reviewed properly. Even if it should turn out that the proposal will *not* be included in LilyPond it may well be that Frédéric will come up with suggestions in the future. But being left with *that* comment chances are good he won't bother trying to improve LilyPond anymore. And that's something we shouldn't afford. @ Frédéric: There is a formalized way to contribute to LilyPond, which is described in the Contributor's Guide (LINKs). From your patch one can see that you have the LilyPond Git repository and know your way around that, so it would be possible to set this up. For a single proposal you can try sending a patch to the bug-lilypond list, but this is actually not guaranteed to be processed. This will only happen if someone explicitly picks it up and handles it for you. Therefore you should write your email in a way to convince one of the developers that it is worthwile to process the suggestion. That means it should include a description of the patch, what it does and why you think it should be included in LilyPond directly (e.g. make plausible that it's a sufficiently common use case and not a private interest only). Of course such an addition needs documentation, as David says. But it is perfectly OK to say that you'll write proper documentation when there's a kind of agreement that your addition may be included in LilyPond (but before actually submitting your patch for review). And a final comment: if it should become clear that you won't get your addition into LilyPond you can still submit it for openlilylib (https://github.com/openlilylib/openlilylib). This is a good place to make additions easily available that for some reason or another won't go into core LilyPond. Best Urs -- Urs Liska www.openlilylib.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
How can I change my email address for code reviews?
Every time I try submit a code review, it makes the owner e...@ticalc.org, which is the address I first used, but I want it to use nine.fierce.ball...@gmail.com. I’m using LilyDev. ~/.gitconfig says nine.fierce.ball...@gmail.com. I’ve tried removing ~/.last_code_review_email_address. I’ve even gone as far as running rm -f ~/lilypond-git and getting it again with lily-git.tcl. No go. git cl upload still uses the old address. What am I missing? Thanks in advance. — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How can I change my email address for code reviews?
On Thu, Sep 18, 2014 at 07:01:02PM -0400, Dan Eble wrote: I’m using LilyDev. ~/.gitconfig says nine.fierce.ball...@gmail.com. I’ve tried removing ~/.last_code_review_email_address. I’ve even gone as far as running rm -f ~/lilypond-git and getting it again with lily-git.tcl. No go. git cl upload still uses the old address. What am I missing? Thanks in advance. Take a look at your ~/.gitconfig . If lily-git.tcl inherits your old address from somewhere, it must be a user setting such as $HOME/.gitconfig or an export GIT_EMAIL or something like that. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How can I change my email address for code reviews?
On Sep 18, 2014, at 20:50 , Graham Percival gra...@percival-music.ca wrote: On Thu, Sep 18, 2014 at 07:01:02PM -0400, Dan Eble wrote: I’m using LilyDev. ~/.gitconfig says nine.fierce.ball...@gmail.com. I’ve tried removing ~/.last_code_review_email_address. I’ve even gone as far as running rm -f ~/lilypond-git and getting it again with lily-git.tcl. No go. git cl upload still uses the old address. What am I missing? Thanks in advance. Take a look at your ~/.gitconfig . If lily-git.tcl inherits your old address from somewhere, it must be a user setting such as $HOME/.gitconfig or an export GIT_EMAIL or something like that. Thanks for the response. My ~/.gitconfig was correct, but I finally resolved the problem by following these steps: * remove ~/.codereview_upload_cookies * create a patch of my work in progress * delete my branch * recreate my branch * apply the patch * commit * git cl upload (it prompts for an email address) — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Add chord range to make-part-combine-music (issue 144170043 by nine.fierce.ball...@gmail.com)
Reviewers: ,
Message:
I hope this is acceptable for now without a music function. I have
other partcombiner contributions planned and I think it makes sense to
work from the inside out.
https://code.google.com/p/lilypond/issues/detail?id=4112
Description:
Add chord range to make-part-combine-music
Please review this at https://codereview.appspot.com/144170043/
Affected files (+38, -10 lines):
A input/regression/part-combine-chord-range.ly
M ly/music-functions-init.ly
M scm/part-combiner.scm
Index: input/regression/part-combine-chord-range.ly
diff --git a/input/regression/part-combine-chord-range.ly
b/input/regression/part-combine-chord-range.ly
new file mode 100644
index
..3536ac3a22384e30d72015a382b6abe3a452c750
--- /dev/null
+++ b/input/regression/part-combine-chord-range.ly
@@ -0,0 +1,26 @@
+\header {
+ texidoc =The part combiner chord range can be adjusted.
+}
+
+\version 2.19.15
+
+\layout { ragged-right = ##t }
+
+vone = \relative e' {
+ d4 e f fisis | g geses b' bisis | b2 beses
+}
+
+vtwo = \relative e' {
+ e4 e e e | e eisis d deses | c2 cisis
+}
+
+comm = { s1_apart s1_chords s1_apart }
+
+customcombine =
+#(define-music-function (parser location part1 part2) (ly:music? ly:music?)
+ (make-part-combine-music parser (list part1 part2) #f '(2 . 12)))
+
+\new Staff
+ \customcombine \vone \vtwo
+ \comm
+
Index: ly/music-functions-init.ly
diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index
6bb98c6c801f3c024eb3fce3c43755fd7376e5ab..daf2b93a6ff804443365b0a2b4e6c57cfe60da7f
100644
--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -1131,26 +1131,28 @@ parenthesize =
(set! (ly:music-property arg 'parenthesize) #t))
arg)
+#(define partcombine-chord-range '(0 . 8))
+
partcombine =
#(define-music-function (parser location part1 part2) (ly:music? ly:music?)
(_i Take the music in @var{part1} and @var{part2} and typeset so
that they share a staff.)
(make-part-combine-music parser
-(list part1 part2) #f))
+(list part1 part2) #f partcombine-chord-range))
partcombineUp =
#(define-music-function (parser location part1 part2) (ly:music? ly:music?)
(_i Take the music in @var{part1} and @var{part2} and typeset so
that they share a staff with stems directed upward.)
(make-part-combine-music parser
-(list part1 part2) UP))
+(list part1 part2) UP partcombine-chord-range))
partcombineDown =
#(define-music-function (parser location part1 part2) (ly:music? ly:music?)
(_i Take the music in @var{part1} and @var{part2} and typeset so
that they share a staff with stems directed downward.)
(make-part-combine-music parser
-(list part1 part2) DOWN))
+(list part1 part2) DOWN
partcombine-chord-range))
partcombineForce =
#(define-music-function (location parser type once) (symbol-or-boolean?
boolean?)
Index: scm/part-combiner.scm
diff --git a/scm/part-combiner.scm b/scm/part-combiner.scm
index
dd3152cbb7125bfd025e2a85cefdd95f4fa73b5f..6b1b5e1fbc48761b833b10e8cb46f5515f641f6b
100644
--- a/scm/part-combiner.scm
+++ b/scm/part-combiner.scm
@@ -253,7 +253,7 @@ LilyPond version 2.8 and earlier.
global)
context-list))
-(define-public (make-part-combine-music parser music-list direction)
+(define-public (make-part-combine-music parser music-list direction
chord-range)
(let* ((m (make-music 'PartCombineMusic))
(m1 (make-non-relative-music (context-spec-music (first
music-list) 'Voice one)))
(m2 (make-non-relative-music (context-spec-music (second
music-list) 'Voice two)))
@@ -266,14 +266,14 @@ LilyPond version 2.8 and earlier.
(set! (ly:music-property m 'split-list)
(if (and (assoc one evs1) (assoc two evs2))
(determine-split-list (reverse! (assoc-get one evs1) '())
-(reverse! (assoc-get two evs2) '()))
+(reverse! (assoc-get two evs2) '())
+chord-range)
'()))
m))
-(define-public (determine-split-list evl1 evl2)
- @var{evl1} and @var{evl2} should be ascending.
+(define-public (determine-split-list evl1 evl2 chord-range)
+ @var{evl1} and @var{evl2} should be ascending. @var{chord-range} is a
pair (min . max) defining the distance (in steps) between notes that may
share a stem.
(let* ((pc-debug #f)
- (chord-threshold 8)
(voice-state-vec1 (make-voice-states evl1))
(voice-state-vec2 (make-voice-states evl2))
(result (make-split-state voice-state-vec1 voice-state-vec2)))
@@ -379,12 +379,12 @@ Only set if not set previously.
(if (and (pair? pitches1)
(pair? pitches2)
(or
-
