Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)
Patch counted down - Frederic, can you give me a new git formatted patch (just to make sure it is rebased against current master), and I'll push it for you. James https://codereview.appspot.com/150860044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for October 9th 2014
Hello, Here is the current patch countdown list. The next countdown will be on October 9th. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaitingcolspec=Patch%20Owner%20ID%20Summarysort=patch PUSH: Trevor Daniels: \keepWithTag does not play well with satb.ly template http://code.google.com/p/lilypond/issues/detail?id=4146 David Kastrup: Patch: Use Xxx:is_smob instead of Xxx:unsmob when used in boolean contexts http://code.google.com/p/lilypond/issues/detail?id=4141 David Kastrup: Patch: Let ly:output-def? be implemented via Smob_base http://code.google.com/p/lilypond/issues/detail?id=4140 Valentin Villenave: Add functionality to string numbers http://code.google.com/p/lilypond/issues/detail?id=4139 David Kastrup: Patch: Make \time work with \tweak and \footnote http://code.google.com/p/lilypond/issues/detail?id=4138 David Kastrup: Patch: Reimplement forced partcombine decisions via context properties http://code.google.com/p/lilypond/issues/detail?id=4131 James Lowe: Patch: Add an alternative Drum Style - agostini-drums-style http://code.google.com/p/lilypond/issues/detail?id=4128 Phil Holmes: Patch: Adds incipit section to NR http://code.google.com/p/lilypond/issues/detail?id=3980 COUNTDOWN: David Kastrup: Patch: Eliminate will never be null warnings in smobs.tcc. http://code.google.com/p/lilypond/issues/detail?id=4152 James Lowe: Patch: Doc: Usage 1.2 - Added note about using wildcards http://code.google.com/p/lilypond/issues/detail?id=4147 David Kastrup: tie in TabStaff (using q) displays one of the unisone notes in a chord http://code.google.com/p/lilypond/issues/detail?id=3066 David Kastrup: \lyricsto may turn into a voice-mangling zombie when both parents die at the same time http://code.google.com/p/lilypond/issues/detail?id=2010 David Kastrup: ossia staff doesn't stop at correct horizontal position http://code.google.com/p/lilypond/issues/detail?id=660 David Kastrup: non-synchronized grace note makes voiceOne go stems down http://code.google.com/p/lilypond/issues/detail?id=630 WAITING: Keith OHara: allow bn for B-natural in English http://code.google.com/p/lilypond/issues/detail?id=4076 David Kastrup: Patch: Revert Issue 3978: Merge alignment cleanup http://code.google.com/p/lilypond/issues/detail?id=4036 Urs Liska: Patch: Issue 3916: Add \alternatingTimeSignatures http://code.google.com/p/lilypond/issues/detail?id=3918 Mike Solomon: Patch: Prevents vertical axis groups with empty skylines http://code.google.com/p/lilypond/issues/detail?id=3156 Mike Solomon: Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning. http://code.google.com/p/lilypond/issues/detail?id=3134 David Kastrup: Patch: Implement music functions in Scheme rather than C++ http://code.google.com/p/lilypond/issues/detail?id=2716 Thank you, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
es means ees???
In the lilypond 2.19 installed file
usr/share/lilypond/current/ly/chord-modifiers-init.ly
I see the following at line 27
c es ges-\markup { \super o } % should be $\circ$ ?
Here, instead of ees, is written es.
I've tried this out, and it appears to be a synonym, but I don't see
this documented. Anyone know what's going on?
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: es means ees???
Richard Shann rich...@rshann.plus.com writes:
In the lilypond 2.19 installed file
usr/share/lilypond/current/ly/chord-modifiers-init.ly
I see the following at line 27
c es ges-\markup { \super o } % should be $\circ$ ?
Here, instead of ees, is written es.
I've tried this out, and it appears to be a synonym, but I don't see
this documented. Anyone know what's going on?
That's the natural name for it, cf
URL:http://www.lilypond.org/doc/v2.18/Documentation/music-glossary/pitch-names.
I don't know where you have looked for the information, but in the
canonical point of documentation (or, depending on how you view it,
immediately adjacent and cross-referenced from it), namely
URL:http://lilypond.org/doc/v2.18/Documentation/notation/writing-pitches#note-names-in-other-languages,
I read
In Dutch, aes is contracted to as, but both forms are accepted in
LilyPond. Similarly, both es and ees are accepted. This also applies
to aeses / ases and eeses / eses. Sometimes only these contracted
names are defined in the corresponding language files.
The sometimes sentence is somewhat hand-waving and it is not clear to
what it applies. Dutch as the default note entry mode also intended for
foreigners and automatic notename generation, is more lenient in its
forms. German, IIRC, only accepts the correct contracted forms.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: es means ees???
- Original Message -
From: Richard Shann rich...@rshann.plus.com
To: lilypond-devel@gnu.org
Sent: Monday, October 6, 2014 11:12:55 AM
Subject: es means ees???
In the lilypond 2.19 installed file
usr/share/lilypond/current/ly/chord-modifiers-init.ly
I see the following at line 27
c es ges-\markup { \super o } % should be $\circ$ ?
Here, instead of ees, is written es.
I've tried this out, and it appears to be a synonym, but I don't see
this documented. Anyone know what's going on?
Richard
*
I'm not sure about actually being documented but I do recall seeing this
written somewhere. Your surmise is correct; 'ees' and 'es' *are* synonyms. I
think the logic runs like this; d = d and d + es = des (d-flat) so e + es = ees
= e-flat as 'es' by itself actually indicates a flat sign. I think that 'es'
is the normal usage, however, and it is a bit shorter. I've always just used
'es' and later learned that 'ees' was a synonym. I think that 'as' and 'aes'
may also be synonyms as well.
-David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: es means ees???
Richard,
AFAIK, it's not documented, but you can find all available note names in the
file scm/define-note-names.scm, in which you'll find that both es and ees work
for writing e-flat.
Regards,
Abraham
Sent from my iPhone
On Oct 6, 2014, at 5:12 AM, Richard Shann rich...@rshann.plus.com wrote:
In the lilypond 2.19 installed file
usr/share/lilypond/current/ly/chord-modifiers-init.ly
I see the following at line 27
c es ges-\markup { \super o } % should be $\circ$ ?
Here, instead of ees, is written es.
I've tried this out, and it appears to be a synonym, but I don't see
this documented. Anyone know what's going on?
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: es means ees???
Thank you to all who replied - I didn't think to look in the note names
in other languages section.
Richard
On Mon, 2014-10-06 at 13:41 +0200, David Kastrup wrote:
Richard Shann rich...@rshann.plus.com writes:
In the lilypond 2.19 installed file
usr/share/lilypond/current/ly/chord-modifiers-init.ly
I see the following at line 27
c es ges-\markup { \super o } % should be $\circ$ ?
Here, instead of ees, is written es.
I've tried this out, and it appears to be a synonym, but I don't see
this documented. Anyone know what's going on?
That's the natural name for it, cf
URL:http://www.lilypond.org/doc/v2.18/Documentation/music-glossary/pitch-names.
I don't know where you have looked for the information, but in the
canonical point of documentation (or, depending on how you view it,
immediately adjacent and cross-referenced from it), namely
URL:http://lilypond.org/doc/v2.18/Documentation/notation/writing-pitches#note-names-in-other-languages,
I read
In Dutch, aes is contracted to as, but both forms are accepted in
LilyPond. Similarly, both es and ees are accepted. This also applies
to aeses / ases and eeses / eses. Sometimes only these contracted
names are defined in the corresponding language files.
The sometimes sentence is somewhat hand-waving and it is not clear to
what it applies. Dutch as the default note entry mode also intended for
foreigners and automatic notename generation, is more lenient in its
forms. German, IIRC, only accepts the correct contracted forms.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Is there a test for a pair of numbers?
I am developing compact chord symbols for LilyPond and have added this property to define-context-properties.scm (chordCompactScale ,pair? Draw chord symbols scaled by this amount) This works, but I was wondering if there is a more exacting type test than pair? ? Richard ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Is there a test for a pair of numbers?
Richard Shann rich...@rshann.plus.com writes: I am developing compact chord symbols for LilyPond and have added this property to define-context-properties.scm (chordCompactScale ,pair? Draw chord symbols scaled by this amount) This works, but I was wondering if there is a more exacting type test than pair? ? number-pair? ? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Is there a test for a pair of numbers?
On Mon, 2014-10-06 at 17:52 +0200, David Kastrup wrote: number-pair? great, thanks! Richard ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Compact Chord Symbols Patch
I have created a patch for LilyPond (following the guidelines in the documentation). I enclose a file that creates a chord chart from this version, though I realize that it is too verbose for use in documenting the new functionality. I'll be happy to create something smaller if it looks like the patch will be welcomed. (This one gives an idea of the output). Richard From 8a3569e75d1fdff5318497051bb840e330162e47 Mon Sep 17 00:00:00 2001 From: Richard Shann rich...@rshann.plus.com Date: Mon, 6 Oct 2014 18:09:51 +0100 Subject: [PATCH] Allow creation of compact chord symbols Compact chord symbols have the elements of the chord (the root name, quality and bass-inversion) packed tightly together so as to allow the creation of fakebooks. Nowadays these will often be stored on hand held devices. This patch allows the default chord symbols to be drawn in such a manner, by defining the context property chordCompactScale. Where this is not defined, the default behavior is maintained. --- scm/chord-ignatzek-names.scm | 125 ++ scm/define-context-properties.scm | 1 + 2 files changed, 100 insertions(+), 26 deletions(-) diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm index 22f54fe..c7671cb 100644 --- a/scm/chord-ignatzek-names.scm +++ b/scm/chord-ignatzek-names.scm @@ -88,6 +88,46 @@ (ly:context-property context 'chordRootNamer) ;; name-root nn))) + (define (compact-name-root pitch scale) + (let* ((alt (ly:pitch-alteration pitch))) + (make-line-markup +(list + (make-bold-markup +(make-scale-markup '(0.5 . 1) +(make-simple-markup +(vector-ref #(C D E F G A B) (ly:pitch-notename +pitch) + (if (= alt 0) +(make-hspace-markup 0.1) +(make-line-markup +(list + (make-hspace-markup 0.1) + (make-fontsize-markup -7 (make-raise-markup 1.2 ;(* 1 scale) + (alteration-text-accidental-markup alt))) + (make-hspace-markup -0.5 + (define (name-inversion pitch scale) +(let* ((alt (ly:pitch-alteration pitch))) + (make-line-markup +(list + (make-raise-markup 1 +(make-scale-markup '(0.75 . 0.5) +(make-bold-markup (make-simple-markup / + (make-bold-markup +(make-scale-markup '(0.5 . 0.75) +(make-simple-markup +(vector-ref #(C D E F G A B) (ly:pitch-notename +pitch) + (if (= alt NATURAL) +(make-hspace-markup 2) +(make-line-markup +(list + (make-hspace-markup 0.1) + (make-fontsize-markup -7 + (if (= alt SHARP) +(make-raise-markup 0.1 +(alteration-text-accidental-markup alt)) +(make-raise-markup 0.2 +(alteration-text-accidental-markup alt))) (define (is-natural-alteration? p) (= (natural-chord-alteration p) (ly:pitch-alteration p))) @@ -169,9 +209,42 @@ work than classifying the pitches. (make-line-markup total))) +(define (markup-formatting sep root-markup prefixes to-be-raised-stuff bass-pitch) +(define bass-inv #f) +(define slashsep (ly:context-property context 'slashChordSeparator)) +(define scale (ly:context-property context 'chordCompactScale)) +(if (pair? scale) +(begin +(set! bass-inv (if (ly:pitch? bass-pitch) + (name-inversion bass-pitch scale) +empty-markup)) + (make-scale-markup scale (make-combine-markup +(make-line-markup (list root-markup +(make-scale-markup '(0.4 . 0.6) +(make-bold-markup (conditional-kern-before (markup-join prefixes sep) +(and (not (null? prefixes)) + (= (ly:pitch-alteration root) NATURAL)) +(ly:context-property context 'chordPrefixSpacer +(make-scale-markup '(0.4 . 0.6) (make-bold-markup to-be-raised-stuff +(make-raise-markup -2 bass-inv +(begin +(set! bass-inv +(if (ly:pitch? bass-pitch) + (list slashsep (name-note bass-pitch #f)) + '())) +(make-line-markup +
Re: Compact Chord Symbols Patch
Richard, On 06/10/14 18:30, Richard Shann wrote: I have created a patch for LilyPond (following the guidelines in the documentation). I enclose a file that creates a chord chart from this version, though I realize that it is too verbose for use in documenting the new functionality. I'll be happy to create something smaller if it looks like the patch will be welcomed. (This one gives an idea of the output). Richard I have created http://code.google.com/p/lilypond/issues/detail?id=4154 I'll help shepherd this patch through via the standard review process for this. Also See: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commits-and-patches if you intend (or think you might want) to make further patches for other parts of LilyPond in the future, as this documents the group's method of uploading a patch for proper review and test; and saves having to involve a third party (like me) and/or guaranteeing some kind of proper review and so that your work is not ignored. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Compact Chord Symbols Patch
Developers, On 06/10/14 18:30, Richard Shann wrote: I have created a patch for LilyPond (following the guidelines in the documentation). I enclose a file that creates a chord chart from this version, though I realize that it is too verbose for use in documenting the new functionality. I'll be happy to create something smaller if it looks like the patch will be welcomed. (This one gives an idea of the output). Richard Although I have already created a tracker for this; http://code.google.com/p/lilypond/issues/detail?id=4154 is this actually one of those 'Scheme engraver' type-things that Urs was talking about a week or so back or is this simply best put in the LilyPond Snippet Repository (LSR)? Otherwise I'll feed it in via the normal patch review process. I just wanted clarification before I (or Richard) spend any time on this. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: varC clefs in 2.19
Hi Marc and list, On 01/06/14 09:48, Marc Hohl wrote: Am 01.06.2014 08:54, schrieb James: On 31/05/14 22:44, bobr...@centrum.is wrote: - Original Message - From: James pkx1...@gmail.com To: bobr...@centrum.is Cc: lilypond-devel lilypond-devel@gnu.org Sent: Friday, May 30, 2014 3:16:53 PM Subject: Re: varC clefs in 2.19 snip I downloaded/installed 2.19.7-1 on a machine and can confirm that: \clef tenorvarC ...and... \clef altovarC ...work per your description above. I also tried... \clef mezzosopranovarC ...and... \clef sopranovarC ...which did not produce output but rather gave me a verbose error message listing all the recognized clef names. Is this an oversight or was a decision made not to make the 'varC' glyph available for all the same positions as the default 'C' clef? -David Well that is a question for those more experienced than I that know about things such as if this clef is appropriate for mezzo and sop ranges. I would have assumed that the person that checked in the change would have known, so can only assume that this is an oversight or there is some convention (musically) that means that these voice types would not be in this clef for some reason or other. I am responsible for the added glyph, but I do not use this clef variant at all, so I don't know which combinations are useful/needed. Cf. https://code.google.com/p/lilypond/issues/detail?id=3772 Ian proposed the additional variant, which I implemented 1:1 according to his ideas. I'll cc him, I think he knows more about this type of clefs than me. Adding additional var-clef names would be straightforward. Marc Hi all, I wanted these clefs as they were required in a Handel score I was working with; I only needed the alto- and tenor- flavour versions of these. If you feel a full set of sopranovarC, mezzosopranovarC, baritonevarC clefs need defining, please do so. Cheers, Ian ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: es means ees???
On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here, instead of ees, is written es. I read In Dutch, aes is contracted to as, but both forms are accepted in LilyPond. Similarly, both es and ees are accepted. This also applies to aeses / ases and eeses / eses. Sometimes only these contracted names are defined in the corresponding language files. Yes. In case anybody was wondering, I deliberately moved the as and es contractions from the tutorial into the NR ages ago. For people unfamiliar with that notation, it's easier to remember letter name plus -es or -is rather than introducing all the contractions. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
smob design
The Smob code is sending me mixed messages. On one hand, it looks like multiple levels of derivation will not work, e.g. creating a subclass of Book, because Book::Book() would call smobify_self() before the subclass constructor runs scm_gc_register_collectable_memory() would sizeof(Book) rather than sizeof(derived class) etc.? On the other hand, Book uses the macro VIRTUAL_COPY_CONSTRUCTOR to define a virtual clone() method, as if derivation were intended. Am I confused because the code is confusing, or for no particular reason? If the code could be cleaned up, which direction should it move in? Thanks, — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
