Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[thomasmorley65]

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm
File scm/merge-rests-engraver.scm (right):

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode10
scm/merge-rests-engraver.scm:10: (define (rest-length rest)
This definition is unused later and wouldn't work because of here
undefined 'rest-a'.
Maybe change it to something iterating over a list, comparing their
elements looking at their 'duration-log for Rests and 'measure-count for
MultiMeasureRests.
And use it for checking equal Rests/MMRs.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode23
scm/merge-rests-engraver.scm:23: (define-public merge-rests-engraver
Two general questions:
(1)
Is it possible to merge both engravers or is there a use case to have
them separated?
(2)
What do you think about introducing a property to switch rest-merging
on/off.
Could be a grob-property, both support rest-interface. Or probably a
context-property because the engraver(s) are in Staff.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode72
scm/merge-rests-engraver.scm:72: `((start-translation-timestep .
,(lambda (trans)
The order:
start-translation-timestep
stop-translation-timestep
finalize
acknowledgers
feels irritating and does not correspondend to the time they are called.
Any reason I for it, I'm not aware?

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

[tisimst]

On Thu, May 18, 2017 at 2:34 PM, Xavier Scheuer [via Lilypond] <
ml+s1069038n203182...@n5.nabble.com> wrote:

> On 18 May 2017 at 07:35, Auto mailings of changes to Lily Issues <
> [hidden email] >
> wrote:
> >
> > Initial work to support opentype font features
> >
> > Following up on an old patch I send to the list. One comment was to use
> a
> list
> > for combining multiple font features. This is now implemented. A
> possible
> issue
> > is the pango API needed is somewhat newer. I'll investigate where I need
> to set
> > that in an update (pointers and hints welcome).
> >
> > http://codereview.appspot.com/323850043
>
> Wow!
>

Wow, indeed! This is great news!


> True small caps and old-style numbers coming into Lilypond, this is
> (again) one of my most-wanted features!
>
> How/where do we find the list of font-features? I guess these "terms"
> ("smcp", "onum") are related to Pango and/or OpenType. Or are these
> specific for each font?
>

They are general OpenType glyph categories (i.e., subtables), but the font
designers are the ones who determine whether a font has them or not. So,
trying to use the small-caps glyphs via "smcp" will only work if there are
real small-caps glyphs identified in that subtable. The same is true for
all other subtables.


> For example which term should we use respectively for tabular numbers,
> superior numbers, stylistic alternates, etc.?
>

Here's hoping! This would be brilliant!


> Thank you Jay, you are adding nice and useful features to lily!
>

I'll add my thanks to that. Looking forward to it, Jay!

Best,
Abraham




--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Re-Lilypond-auto-LilyIssues-auto-testlilyissues-issues-1388-Support-OpenType-font-features-tp203182p203185.html
Sent from the Dev mailing list archive at Nabble.com.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Calling in for sickness

[Paul]

Hi David,

I'm really sorry to hear your news and I hope your health improves.

All my best,
-Paul


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #1388 Support OpenType font features

[Xavier Scheuer]

On 18 May 2017 at 07:35, Auto mailings of changes to Lily Issues <
testlilyissues-a...@lists.sourceforge.net> wrote:
>
> Initial work to support opentype font features
>
> Following up on an old patch I send to the list. One comment was to use a
list
> for combining multiple font features. This is now implemented. A possible
issue
> is the pango API needed is somewhat newer. I'll investigate where I need
to set
> that in an update (pointers and hints welcome).
>
> http://codereview.appspot.com/323850043

Wow!

True small caps and old-style numbers coming into Lilypond, this is
(again) one of my most-wanted features!

How/where do we find the list of font-features? I guess these "terms"
("smcp", "onum") are related to Pango and/or OpenType. Or are these
specific for each font?

For example which term should we use respectively for tabular numbers,
superior numbers, stylistic alternates, etc.?

Thank you Jay, you are adding nice and useful features to lily!

Cheers,
Xavier

-- 
Xavier Scheuer 
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Merge Rests Engraver

[Xavier Scheuer]

On 14 May 2017 at 06:15, Jay Anderson  wrote:
>
> https://codereview.appspot.com/321930043/
>
> It was requested sometime last year that I attempt to get this into
> lilypond proper this is my attempt. It creates a scheme module for putting
> all of the merge rest functionality. I didn't see any precedent for this,
> so let me know concerns. If this approach doesn't seem right (e.g. feel it
> should be part of the rest engraver) I can either add a TODO to that
effect
> or I can drop this patch.
>
> When running git-cl it failed to create a new ticket number to track the
> issue (the instructions say I need to request access:
>
http://lilypond.org/doc/v2.19/Documentation/contributor/git_002dcl#configuring-git_002dcl
).
> There is an existing issue (
> https://sourceforge.net/p/testlilyissues/issues/1228/). Let me know what
> more I need to do there. Thanks.

Thank you very much Jay for working on this.
I have used your code for many years and it works really great.
It is really nice to see it coming into lilypond.

Thanks again.

Cheers,
Xavier

-- 
Xavier Scheuer 
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[david . nalesnik]

https://codereview.appspot.com/321930043/diff/60001/ly/init.ly
File ly/init.ly (right):

https://codereview.appspot.com/321930043/diff/60001/ly/init.ly#newcode36
ly/init.ly:36: #(use-modules (scm merge-rests-engraver))
I'm not sure why you are defining a separate module.  The usual
procedure would be to add your functionality to an existing file in the
load list or add your new file to the load list (in scm/lily.scm -- see
init-scheme-files-body).

The Span_stem_engraver, for example, puts the bulk of its code in
scm/music-functions-init.scm.  (There is also some code in
scm.scheme-engravers.scm -- I'm not sure if you ought to add something
there.)

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm
File scm/merge-rests-engraver.scm (right):

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode14
scm/merge-rests-engraver.scm:14: (eq?
Here (and elsewhere) use eqv? to compare numbers.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode23
scm/merge-rests-engraver.scm:23: (define-public merge-rests-engraver
Here (and below) use the scheme-engraver macro for consistency.  As far
as I'm aware, all Scheme engravers in the code base use this now.  See
scm/scheme-engravers.scm or input/regression/scheme-text-spanner.ly for
examples.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode35
scm/merge-rests-engraver.scm:35: (if (eq? 'Rest (assoc-ref
(ly:grob-property grob 'meta) 'name))
(See comment about recognizing grobs below.)

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode39
scm/merge-rests-engraver.scm:39: (eq?
eqv?

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode44
scm/merge-rests-engraver.scm:44: (eq? (ly:grob-property mmrest
'measure-count) 1))
eqv?

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode70
scm/merge-rests-engraver.scm:70: (let* ((curr-rests '())
let* not needed -- use let

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode81
scm/merge-rests-engraver.scm:81: (if (eq? 'MultiMeasureRest (assoc-ref
(ly:grob-property grob 'meta) 'name))
You could use grob::name here.  Ordinarily, though, objects are
recognized by their interfaces.  So, here you should try

(if (grob::has-interface grob 'multi-measure-rest-interface)
  [...]

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[pkx166h]

Passes make, make check and a full make doc.

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel