Re: Refactor \markup \pattern (issue 549780045 by d...@gnu.org)
Reviewers: hanwenn,
https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm#newcode4636
scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0
space
On 2020/03/31 20:22:35, hanwenn wrote:
> why 3.0 ? add a comment.
vspace has a factor of 3 for its spacing. Will do.
https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm#newcode4675
scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/
(- middle-width pattern-width) period
On 2020/03/31 20:22:35, hanwenn wrote:
> unrelated change?
Prerequisite. The previous version of \pattern was coded in a manner
where it accepted unexact integers which does not make sense. But our
predicates don't catch that even where warranted and a lot of code will
bomb out on inexact integers late. Fixing the specific problem here for
now made most sense and would have been required anyway if the
predicates had been made more stringent. And since it should have been
like this in the first place for obvious reasons, adding a comment here
did not make a lot of sense, either.
Description:
Refactor \markup \pattern
Please review this at https://codereview.appspot.com/549780045/
Affected files (+4, -20 lines):
M scm/define-markup-commands.scm
Index: scm/define-markup-commands.scm
diff --git a/scm/define-markup-commands.scm b/scm/define-markup-commands.scm
index
8a9cf25cedeb8470092c6a43d4c62cd6045797e7..9dedd024b4a115c79ecae95a044d5d2f7d40cacb
100644
--- a/scm/define-markup-commands.scm
+++ b/scm/define-markup-commands.scm
@@ -4615,11 +4615,8 @@ Negative values may be used to produce mirror images.
;; Repeating
-;; TODO: this should really be pieced together at stencil level rather
-;; than markup level
-
(define-markup-command (pattern layout props count axis space pattern)
- (integer? integer? number? markup?)
+ (index? index? number? markup?)
#:category other
"
Prints @var{count} times a @var{pattern} markup.
@@ -4636,21 +4633,8 @@ Patterns are distributed on @var{axis}.
}
@end lilypond"
(let* ((pattern-stencil (interpret-markup layout props pattern))
- (pattern-width (interval-length
- (ly:stencil-extent pattern-stencil X)))
- (new-props (prepend-alist-chain 'word-space 0 (prepend-alist-chain
'baseline-skip 0 props
-(let loop ((i (1- count)) (patterns (markup)))
- (if (zero? i)
- (interpret-markup
- layout
- new-props
- (if (= axis X)
- (markup patterns #:stencil pattern-stencil)
- (markup #:column (patterns #:stencil pattern-stencil
- (loop (1- i)
-(if (= axis X)
-(markup patterns #:stencil pattern-stencil #:hspace space)
-(markup #:column (patterns #:stencil pattern-stencil
#:vspace space
+ (space (if (= axis X) space (* 3.0 space
+(stack-stencils axis 1 space (make-list count pattern-stencil
(define-markup-command (fill-with-pattern layout props space dir pattern left
right)
(number? ly:dir? markup? markup? markup?)
@@ -4688,7 +4672,7 @@ Patterns are aligned to the @var{dir} markup.
(right-width (interval-length (ly:stencil-extent right-stencil X)))
(middle-width (max 0 (- line-width (+ (+ left-width right-width) (*
word-space 2)
(period (+ space pattern-width))
- (count (truncate (/ (- middle-width pattern-width) period)))
+ (count (inexact->exact (truncate (/ (- middle-width pattern-width)
period
(x-offset (+ (* (- (- middle-width (* count period)) pattern-width)
(/ (1+ dir) 2)) (abs (car pattern-x-extent)
(interpret-markup layout props
(markup #:stencil left-stencil
Re: Add dynamic-interface to keepAliveInterfaces (issue 553760043 by j...@abou-samra.fr)
On 3/31/20, j...@abou-samra.fr wrote: > I'll take a look at it, and try to write appropriate documentation (or > find the authors and ask them to document it!). Setting the issue to > needs_work. I believe it was added by Joe Neeman in order to fix issue #442: https://sourceforge.net/p/testlilyissues/issues/442/ You can’t say it’s undocumented, its documentation is just not meant for regular users: http://lilypond.org/doc/latest/Documentation/internals/keep_005falive_005ftogether_005fengraver There are also several comments in the source code: http://git.savannah.gnu.org/cgit/lilypond.git/tree/lily/keep-alive-together-engraver.cc#n72 Cheers, - V.
Re: Add dynamic-interface to keepAliveInterfaces (issue 553760043 by j...@abou-samra.fr)
On 3/31/20, j...@abou-samra.fr wrote: > By the way, why do we say \RemoveEmptyStaves instead of > \removeEmptyStaves? Because it’s a context property that you need to set for your whole context (it’s actually a \with block), not on-the-fly like \cadenzaOn; see also \RemoveEmptyStaffContext, which is capitalized like all context names (Staff, RhythmicStaff etc.). It may (may!) become clearer to you if you have a look at ly/context-mods-init.ly and ly/engraver-init.ly (unlike non-capitalized properties and commands defined in ly/property-init.ly and ly/music-functions-init.ly). … And, yes, I do realize that’s way too convoluted of an explanation. If someone else can do it more straightforwardly, have at it! :-) Cheers, - V.
Re: Add dynamic-interface to keepAliveInterfaces (issue 553760043 by j...@abou-samra.fr)
On 2020/03/31 20:14:44, jean wrote: > I'll update the documentation with this. Hum, while exploring the regression tests, I just discovered that we have a Keep_alive_together_engraver out there, undocumented, except in the internals. I'll take a look at it, and try to write appropriate documentation (or find the authors and ask them to document it!). Setting the issue to needs_work. https://codereview.appspot.com/553760043/
Re: Issue 5864: improve Rational infinity initialization (issue 577710043 by nine.fierce.ball...@gmail.com)
LGTM https://codereview.appspot.com/577710043/
Re: Issue 5864: improve Rational infinity initialization (issue 577710043 by nine.fierce.ball...@gmail.com)
LGTM https://codereview.appspot.com/577710043/
Refactor \markup \pattern (issue 549780045 by d...@gnu.org)
https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm#newcode4636 scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0 space why 3.0 ? add a comment. https://codereview.appspot.com/549780045/diff/30045/scm/define-markup-commands.scm#newcode4675 scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/ (- middle-width pattern-width) period unrelated change? https://codereview.appspot.com/549780045/
Re: Add dynamic-interface to keepAliveInterfaces (issue 553760043 by j...@abou-samra.fr)
On 2020/03/27 23:16:40, Dan Eble wrote:
> Is the impact (if any) on existing scores important? (cases that we
might not
> have in regression tests but that might irk users?)
It should be close to zero.
In fact, I'm stupid. I just realised a thing: up to now, users have been
told to put \RemoveEmptyStaves in a \context { \Staff ... }. So it won't
change anything in the overwhelming majority of scores. But, it will
allow you to do this in a \context { \Score ... } (also applying to
TabStaff etc.) or, by the by, in a \context { \PianoStaff ... } (it will
apply to the whole piano part, but no longer remove the Dynamics context
between the staves).
I'll update the documentation with this.
By the way, why do we say \RemoveEmptyStaves instead of
\removeEmptyStaves?
https://codereview.appspot.com/553760043/
GSoC applications
Hi all, an hour ago this year's GSoC student application deadline has been completed, and it seems I'm currently the only registered mentor having access to that. Of course we can't discuss application(s) on public lists. So please reply to me privately so I can share the application(s) with you and discuss further process. This involves evaluation of proposal(s) and considering mentorship. Best Urs
Re: 2.21.0 and announcements
Il giorno mar 31 mar 2020 alle ore 14:28 Phil Holmes ha scritto: > I believe that the scripts are not automatically updated for security > reasons. Ok, seems sensible. > I should be able to do this manually when I next upload a build - > I'm assuming that will not be too far into the future. Is that OK? Fine, no need to rush. Best wishes. Davide
Re: 2.21.0 and announcements
- Original Message - From: "Davide Liessi" To: "lilypond-devel" Cc: "Phil Holmes" Sent: Tuesday, March 31, 2020 1:16 PM Subject: Re: 2.21.0 and announcements Il giorno mar 31 mar 2020 alle ore 12:15 Phil Holmes ha scritto: Probably expected. The website text updates automatically - it pulls git and does a "make website" every hour. However, documents and functionality only get updated with a new build via GUB. The links that remained unchanged are part of the website: the script I mentioned is run by `make website` to generate those links. The download links are present in the current website, which means, I think, that the script was run. However they are the old version of the links without my changes, which makes me think that an old version of the script was run to make the website, instead of the current one. Any ideas? I believe that the scripts are not automatically updated for security reasons. I should be able to do this manually when I next upload a build - I'm assuming that will not be too far into the future. Is that OK? -- Phil Holmes
Re: 2.21.0 and announcements
Il giorno mar 31 mar 2020 alle ore 12:15 Phil Holmes ha scritto: > Probably expected. The website text updates automatically - it pulls git > and does a "make website" every hour. However, documents and functionality > only get updated with a new build via GUB. The links that remained unchanged are part of the website: the script I mentioned is run by `make website` to generate those links. The download links are present in the current website, which means, I think, that the script was run. However they are the old version of the links without my changes, which makes me think that an old version of the script was run to make the website, instead of the current one. Any ideas?
Re: 2.21.0 and announcements
- Original Message - From: "Davide Liessi" To: "lilypond-devel" Sent: Tuesday, March 31, 2020 10:57 AM Subject: Re: 2.21.0 and announcements Il giorno mar 31 mar 2020 alle ore 10:16 ha scritto: It will eventually become part of the Website. I see that the new links are already online, while the existing links haven't changed yet. My patch changed the make_download calls in scripts/build/create-weblinks-itexi.py, but it seems like the old version of that script was run. Is this expected or did I miss anything in my patch? Best wishes. Davide Probably expected. The website text updates automatically - it pulls git and does a "make website" every hour. However, documents and functionality only get updated with a new build via GUB. -- Phil Holmes
Re: 2.21.0 and announcements
On 31/03/2020 10:57, Davide Liessi wrote: Il giorno mar 31 mar 2020 alle ore 10:16 ha scritto: It will eventually become part of the Website. I see that the new links are already online, while the existing links haven't changed yet. My patch changed the make_download calls in scripts/build/create-weblinks-itexi.py, but it seems like the old version of that script was run. Is this expected or did I miss anything in my patch? Best wishes. Davide For those that know more than I do. 5867 Web: add 64-bit Mac download links - James Lowe https://sourceforge.net/p/testlilyissues/issues/5867 http://codereview.appspot.com/579520043
Re: 2.21.0 and announcements
Il giorno mar 31 mar 2020 alle ore 10:16 ha scritto: > It will eventually become part of the Website. I see that the new links are already online, while the existing links haven't changed yet. My patch changed the make_download calls in scripts/build/create-weblinks-itexi.py, but it seems like the old version of that script was run. Is this expected or did I miss anything in my patch? Best wishes. Davide
Re: 2.21.0 and announcements
Dear James, Il giorno mar 31 mar 2020 alle ore 10:16 ha scritto: > Thispatch has now been pushed to current master. thanks for taking care of it! Best wishes. Davide
Re: 2.21.0 and announcements
Hello Davide, Thispatch has now been pushed to current master. It will eventually become part of the Website. Thanks. James On 27/03/2020 07:07, pkx1...@posteo.net wrote: Hello On 26/03/2020 18:54, Davide Liessi wrote: Dear David, Il giorno gio 26 mar 2020 alle ore 17:11 David Kastrup ha scritto: I think we should point out on our download page that the GUB-provided installers are _only_ for 32bit MacOSX, and that separate downloads may be provided elsewhere (possibly linking to Marnen's page I agree. Patch attached (based on master), but I haven't tested it. in the hope that it does not get overloaded?). Marnen's builds are hosted on Bintray, whose free plan allows downloads for up to 1TB/month: how much traffic do we expect? Best wishes. Davide I'll test the patch and create a tracker etc. So we don't lose it. James
PATCHES - Countdown for March 31st
Hello, Here is the current patch countdown list. The next countdown will be on April 2nd A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5867 Web: add 64-bit Mac download links - James Lowe https://sourceforge.net/p/testlilyissues/issues/5867 http://codereview.appspot.com/579520043 5863 Use python3 in website.make - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5863 http://codereview.appspot.com/581880043 5861 Trim unused toplevel targets. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5861 http://codereview.appspot.com/547810069 5852 Inline executable-* stepmake templates in lily/GNUmakefile - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5852 http://codereview.appspot.com/577690043 Countdown: 5871 Remove references to test-output-distance.ly. - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5871 http://codereview.appspot.com/549780044 5869 Web: update CG instructions, `attic’ page and THANKS for 2.18 - Valentin Villenave https://sourceforge.net/p/testlilyissues/issues/5869 http://codereview.appspot.com/559730043 5811 mf: use python scripting for generating Emmentaler fonts - Han-Wen Nienhuys https://sourceforge.net/p/testlilyissues/issues/5811 http://codereview.appspot.com/553580043 5611 add property label-alignments to OttavaBracket - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5611 http://codereview.appspot.com/575330043 Review: 5874 Remove all uses of markup macro from scm/*.scm - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5874 http://codereview.appspot.com/575930043 5873 Refactor \markup \pattern - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5873 http://codereview.appspot.com/549780045 5872 convert-ly rule for 2.19.39 as cleanup for issue 4800 - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5872 http://codereview.appspot.com/565850043 1204 Documentation and regtests needed for external font files - Valentin Villenave https://sourceforge.net/p/testlilyissues/issues/1204 http://codereview.appspot.com/557640051 New: No new patches at this time. Waiting: 5864 improve Rational infinity initialization - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5864 http://codereview.appspot.com/577710043 5771 remove unnecessary (descend-to-context ... 'Score) - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5771 http://codereview.appspot.com/557440043 5740 Add \post to defer context actions to end of time step - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5740 http://codereview.appspot.com/581600043 *** Regards, James
