Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG

> \include "hel-arabic.ly"
> \version "2.23.3"
> \relative {
>   \key c \rast
>   c' d edb f | g a bdb c | eb a g f | edb  d c
>   }

You must have done something wrong; I've just downloaded the 2.24.3
binary bundle for GNU/Linux, and this code compiles fine – this means
that it works for previous versions, too.

The changes to `hel-arabic.ly` happened in version 2.25.2; earlier
versions are *not* affected.


Werner


Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi

I installed lilypond-2.23.6-1  ,lilypond-2.24.3 and lilypond-2.25.13: 
for each version I do  : LilyPond rast.ly 
for the unstable version it's normal hel-arabic has been truncated.
I would like to point out that my initial version of hel-arabic.ly that I am 
using is functional.

I tested them with file : rast.ly =>

\include "hel-arabic.ly"
\version "2.23.3"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }
  
\version "2.24.3"  and \version "2.25.13"

It doesn't work, for any version of the 3 versions tested


You can do the test yourself: create a file, name it rast.ly, put this in
\include "hel-arabic.ly"
\version "2.23.3"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }
  
 Then lilypond rast.ly 
 you must obtain the following file: rast.pdf


Once again it's not for me. my version of hel-arabic.ly that I use, works well 
even with version 2.18.1

thanks very match

Hassan



rast.pdf
Description: Adobe PDF document


Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


> I did some tests on version 2.24.3,   2.21.0-1 ,  2.23.6-1
>
> it doesn't work either.

What *exactly* did you do?


Werner



Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
hello again

I did some tests on version 2.24.3,   2.21.0-1 ,  2.23.6-1
 
it doesn't work either.

hassan



Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


> for rast.ly
> 
> \include "hel-arabic.ly"
> \version "2.25.13"
> \relative {
>   \key c \rast
>   c' d edb f | g a bdb c | eb a g f | edb  d c
>   }
> 
> Tmust give  rast.pdf , But that's not the case

Of course not.  You are using the current development version without
my fix.  Again: please have a look at

  https://gitlab.com/lilypond/lilypond/-/merge_requests/2268

and try the code from this MR.


Werner



Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


> > This should ensure full backward compatibility if you process your
> > old files with `convert-ly`.
>
> Which file?

Any input file that uses `hel-arabic.ly`.

Example:

```
\version "2.24.0"

\include "hel-arabic.ly"

\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb d c
}
```

If you process this with `convert-ly`, you get

```
\version "2.25.13"

\include "hel-arabic.ly"
\language "arabic"

\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb d c
}
```

and this output compiles fine with the patch from

  https://gitlab.com/lilypond/lilypond/-/merge_requests/2268

applied.  Please look at this MR and comment.


Werner



Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


> \include "hel_arabic.ly"

It's `hel-arabic.ly`, not `hel_arabic.ly`.


Werner



Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
for rast.ly

\include "hel-arabic.ly"
\version "2.25.13"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }

Tmust give  rast.pdf , But that's not the case


rast.pdf
Description: Adobe PDF document


Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
lilypond rast.ly => 
GNU LilyPond 2.25.13 (running Guile 3.0)
Traitement de « rast.ly »
Analyse...
rast.ly:5:8: Erreur : « edb » n'est pas un nom de note
  c' d 
   edb f | g a bdb c | eb a g f | edb  d c
rast.ly:5:20: Erreur : « bdb » n'est pas un nom de note
  c' d edb f | g a 
   bdb c | eb a g f | edb  d c
rast.ly:5:28: Erreur : « eb » n'est pas un nom de note
  c' d edb f | g a bdb c | 
   eb a g f | edb  d c
rast.ly:5:39: Erreur : « edb » n'est pas un nom de note
  c' d edb f | g a bdb c | eb a g f | 
  edb  d c
Interprétation en cours de la musique...
Pré-traitement des éléments graphiques...
Détermination du nombre optimal de pages...
Répartition de la musique sur une page...
Dessin des systèmes...
Conversion à « rast.pdf »...
erreur fatale : erreur sur les fichiers "rast.ly"

file : rast.ly
\include "hel-arabic.ly"
\version "2.25.13"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }



Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
 I have this  :

lilypond rast.ly
=>
GNU LilyPond 2.25.13 (running Guile 3.0)
Traitement de « rast.ly »
Analyse...
rast.ly:1:10: Erreur : fichier non trouvé : « hel_arabic.ly »
(chemin de recherche : « 
/home/helfa/lilypond/share/lilypond/2.25.13/ly:/home/helfa/lilypond/share/lilypond/2.25.13/ps:/home/helfa/lilypond/share/lilypond/2.25.13/scm:/home/helfa/lilypond/share/lilypond/2.25.13/fonts/otf/:/home/helfa/lilypond/share/lilypond/2.25.13/fonts/svg/:
 »)
\include 
 "hel_arabic.ly"
rast.ly:4:10: Erreur : unknown command: `\rast'
  \key c 
 \rast
rast.ly:4:10: Erreur : type d'argument erroné pour 2.
  Attendait list of number pairs, "rast" trouvé.
  \key c 
 \rast
rast.ly:5:8: Erreur : « edb » n'est pas un nom de note
  c' d 
   edb f | g a bdb c | eb a g f | edb  d c
rast.ly:5:20: Erreur : « bdb » n'est pas un nom de note
  c' d edb f | g a 
   bdb c | eb a g f | edb  d c
rast.ly:5:28: Erreur : « eb » n'est pas un nom de note
  c' d edb f | g a bdb c | 
   eb a g f | edb  d c
rast.ly:5:39: Erreur : « edb » n'est pas un nom de note
  c' d edb f | g a bdb c | eb a g f | 
  edb  d c

Attention : la compilation a échoué et \version est plus que datée ;
  la syntaxe de la source a-t-elle été mise à jour par convert-ly ?

  
https://lilypond.org/doc/v2.25/Documentation/usage/updating-files-with-convert_002dly

Interprétation en cours de la musique...
Pré-traitement des éléments graphiques...
Détermination du nombre optimal de pages...
Répartition de la musique sur une page...
Dessin des systèmes...
Conversion à « rast.pdf »...
erreur fatale : erreur sur les fichiers "rast.ly"

rast.y :

\include "hel_arabic.ly"
\version "2.25.3"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }




Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
hello again

\include "hel_arabic_initial.ly"
\relative {
  \key c \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }
  
This should ensure full backward compatibility if you process your old
files with `convert-ly`.

Which file? 

This file: \include "hel_arabic.ly" \relative { \key c \rast c' d edb f | g a 
bdb c | eb a g f | edb d c } 

Doesn't need compatibility

Hassan



Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


>> [...] Indeed edb and sdb are no longer recognized
> 
> It's not screwed up at all, however, current LilyPond is not
> backward compatible.  I'm already working on a patch.

Please check

  https://gitlab.com/lilypond/lilypond/-/merge_requests/2268

This should ensure full backward compatibility if you process your old
files with `convert-ly`.


Werner



Re: hel-arabic.ly

2024-03-07 Thread Dan Eble

On 2024-03-07 09:24, hassan.elfat...@free.fr wrote:

by trying to make hel-arabic.ly dependent on arabic.ly without consulting me,
you screwed up the hel-arabic.ly file.


Neighbor,

1. You contributed to an open-source project.  Proposed
changes are posted for public review.  GitLab sends
notifications to those who are subscribed.  This mailing
list receives a "PATCHES" message with merge-request
headlines three times a week.  You have had the same
opportunity as any other contributor to follow and
respond to proposed changes.

2. The command

git grep hel-arabic input/regression/

returns no results.  If you are interested in reducing
the dependence on the vigilance of one or two expert
reviewers, consider contributing a test or two to
exercise the unique features of hel-arabic.ly such
that breaking changes would cause visual differences
even non-experts can appreciate.

--
Dan



Re: hel-arabic.ly

2024-03-07 Thread Werner LEMBERG


> In fact it no longer works, I gave the operational version of
> hel-arabic.ly and by trying to make hel-arabic.ly dependent on
> arabic.ly without consulting me, you screwed up the hel-arabic.ly
> file. I can still repair the damage if you give me the opportunity
> to do that.  Indeed edb and sdb are no longer recognized

It's not screwed up at all, however, current LilyPond is not backward
compatible.  I'm already working on a patch.


 Werner



Re: hel-arabic.ly

2024-03-07 Thread Neil Puttock
On Thu, 7 Mar 2024, 14:24 ,  wrote:

>
> \include "hel-arabic.ly"
> \relative {
>   \key do \rast
>

Shouldn't this be

\key c \rast

?

  c' d edb f | g a bdb c | eb a g f | edb  d c
>   }
>
> => rast1.png
>
>
> Hassan
>

Neil

>


Re: hel-arabic.ly

2024-03-07 Thread hassan . elfatihi
Hello again
In fact it no longer works, I gave the operational version of hel-arabic.ly and 
by trying 
to make hel-arabic.ly dependent on arabic.ly without consulting me, 
you screwed up the hel-arabic.ly file. I can still repair the damage 
if you give me the opportunity to do that.Indeed edb and sdb are no longer 
recognized

\include "hel-arabic.ly"
\relative {
  \key do \rast
  c' d edb f | g a bdb c | eb a g f | edb  d c
  }

=> rast1.png


Hassan