Re: Does scripts/auxilar/make-regtest-pngs.sh function properly?
On Sat, Jul 9, 2022 at 6:34 AM John Wheeler wrote: > I am trying to get the process documented in CG: 9.5 "Pixel-base regtest > comparison" to run. But, I am not able to get the command > > ./make-regtest-pngs.sh -j4 -o Why are you trying to run this script? David is adamant this script can't be removed (I disagree with him) because it caters for a very specific type of validation. What are you trying to validate? -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen
Re: Does scripts/auxilar/make-regtest-pngs.sh function properly?
John Wheeler writes: > I am trying to get the process documented in CG: 9.5 "Pixel-base > regtest comparison" to run. But, I am not able to get the command > > ./make-regtest-pngs.sh -j4 -o > > to run without error. Using git bisect points to commit > c85e9950a70d1765e4b9a637a737d873975dfb59, "Framework-ps: rewrite > system clipping to be output format-agnostic" as the point at which it > started failing. > > On the other hand, If I have a successfully generated > 'old-regtest-results', > > ./make-regtest-pngs.sh -j4 -n > > will happily run well past that commit. > > I see a lot of discussion on !1272 saying the script should be kept, > which seems to imply that the script should works. > > Is this a known issue? Rereading the script, it would seem like it has a problem if you run it with -o and have the shell variable do_compare set and to a value other than "" before doing so. Does it help to put do_compare="" at the top of the script? -- David Kastrup
Re: Does scripts/auxilar/make-regtest-pngs.sh function properly?
John Wheeler writes: > I am trying to get the process documented in CG: 9.5 "Pixel-base > regtest comparison" to run. But, I am not able to get the command > > ./make-regtest-pngs.sh -j4 -o > > to run without error. Using git bisect points to commit > c85e9950a70d1765e4b9a637a737d873975dfb59, "Framework-ps: rewrite > system clipping to be output format-agnostic" as the point at which it > started failing. > > On the other hand, If I have a successfully generated > 'old-regtest-results', > > ./make-regtest-pngs.sh -j4 -n > > will happily run well past that commit. > > I see a lot of discussion on !1272 saying the script should be kept, > which seems to imply that the script should works. > > Is this a known issue? Likely not. Kind of unusual error conditions. Looking at that commit, it would seem more likely that this commit needs fixing rather than the scripts since they don't seem related at all and the script does not seem to rely on any strange semantics. However, it seems decidedly weird to be running ./make-regtest-pngs.sh instead of, say, scripts/auxiliar/make-regtests-pngs.sh here: it may just be that you are running the script in a directory completely unsuitable for it. I'll take a look at the instructions. -- David Kastrup
Does scripts/auxilar/make-regtest-pngs.sh function properly?
I am trying to get the process documented in CG: 9.5 "Pixel-base regtest comparison" to run. But, I am not able to get the command ./make-regtest-pngs.sh -j4 -o to run without error. Using git bisect points to commit c85e9950a70d1765e4b9a637a737d873975dfb59, "Framework-ps: rewrite system clipping to be output format-agnostic" as the point at which it started failing. On the other hand, If I have a successfully generated 'old-regtest-results', ./make-regtest-pngs.sh -j4 -n will happily run well past that commit. I see a lot of discussion on !1272 saying the script should be kept, which seems to imply that the script should works. Is this a known issue? Thank you, John Wheeler
