Reviewers: carl.d.sorensen_gmail.com, lemzwerg,
Message:
On 2011/12/06 05:39:42, lemzwerg wrote:
David, I suggest to apply patches of that kind directly to the
repository
without setting up a Rietveld issue.
Done. It is actually part of my EventChord work. I got oodles of
display difference due to all those spurious spaces differing in
different contexts. I first aimed for bug compatibility, but then this
got too crazy.
Anyway, pushed to staging.
Description:
Remove spurious spaces from music expression display, adapt tests.
Please review this at http://codereview.appspot.com/5437140/
Affected files:
M input/regression/display-lily-tests.ly
M scm/define-music-display-methods.scm
Index: input/regression/display-lily-tests.ly
diff --git a/input/regression/display-lily-tests.ly
b/input/regression/display-lily-tests.ly
index
226d08d5e69a52cbfb81767325670f0941ff6fdc..998627b716b3664c835a6e6147326418d1e60084
100644
--- a/input/regression/display-lily-tests.ly
+++ b/input/regression/display-lily-tests.ly
@@ -92,8 +92,8 @@ stderr of this run.
%% Lyrics
\test ##[ \lyrics { a b } #]
-\test ##[ \lyricmode { a -- b } #]% HyphenEvent
-\test ##[ \lyricmode { a __ b } #]% ExtenderEvent
+\test ##[ \lyricmode { a -- b } #] % HyphenEvent
+\test ##[ \lyricmode { a __ b } #] % ExtenderEvent
\test ##[ \lyricmode { a } #] % LyricEvent
\test ##[ \lyricsto foo { bla bla } #]% LyricCombineMusic
\test ##[ { { c d }
@@ -107,41 +107,41 @@ stderr of this run.
\test ##[ c4 ~ #] % TieEvent
\test ##[ c\noBeam #] % BeamForbidEvent
\test ##[ c\1 #] % StringNumberEvent
-\test ##[ { c: c:1 } #] % TremoloEvent
-\test ##[ { c-^ c^^ c_^ } #]%
ArticulationEvent
-\test ##[ { c-+ c^+ c_+ } #]
-\test ##[ { c-- c^- c_- } #]
-\test ##[ { c-| c^| c_| } #]
-\test ##[ { c- c^ c_ } #]
-\test ##[ { c-. c^. c_. } #]
-\test ##[ { c-_ c^_ c__ } #]
-\test ##[ { c-\trill c^\trill c_\trill } #]
-\test ##[ { c-1 c^2 c_3 } #]% FingerEvent
-\test ##[ { c-foo c^foo c_foo } #] % TextScriptEvent
-\test ##[ { R1*4-foo R^foo R_foo } #] %
MultiMeasureTextEvent
+\test ##[ { c: c:1 } #]% TremoloEvent
+\test ##[ { c-^ c^^ c_^ } #] % ArticulationEvent
+\test ##[ { c-+ c^+ c_+ } #]
+\test ##[ { c-- c^- c_- } #]
+\test ##[ { c-| c^| c_| } #]
+\test ##[ { c- c^ c_ } #]
+\test ##[ { c-. c^. c_. } #]
+\test ##[ { c-_ c^_ c__ } #]
+\test ##[ { c-\trill c^\trill c_\trill } #]
+\test ##[ { c-1 c^2 c_3 } #] % FingerEvent
+\test ##[ { c-foo c^foo c_foo } #] % TextScriptEvent
+\test ##[ { R1*4-foo R^foo R_foo } #] %
MultiMeasureTextEvent
\test ##[ { c\harmonic 4 c e\harmonic } #] % HarmonicEvent
-\test ##[ { c-\glissando c^\glissando c_\glissando } #]%
GlissandoEvent
-\test ##[ { c-\arpeggio c^\arpeggio c_\arpeggio } #]% ArpeggioEvent
-\test ##[ { c\p c^\ff c_\sfz } #] % AbsoluteDynamicEvent
-\test ##[ { c[ c] c^[ c^] c_[ c_] } #] % BeamEvent
-\test ##[ { c( c) c^( c^) c_( c_) } #] % SlurEvent
-\test ##[ { c\ c\! c^\ c^\! c_\ c_\! } #]% CrescendoEvent
-\test ##[ { c\ c\! c^\ c^\! c_\ c_\! } #]% DecrescendoEvent
-\test ##[ { c\episemInitium c\episemFinis } #]% EpisemaEvent
-\test ##[ { c\( c\) c^\( c^\) c_\( c_\) } #] % PhrasingSlurEvent
-\test ##[ { c\sustainOn c\sustainOff } #]% SustainEvent
-\test ##[ { c\sostenutoOn c\sostenutoOff } #]% SostenutoEvent
+\test ##[ { c-\glissando c^\glissando c_\glissando } #]% GlissandoEvent
+\test ##[ { c-\arpeggio c^\arpeggio c_\arpeggio } #] % ArpeggioEvent
+\test ##[ { c\p c^\ff c_\sfz } #] % AbsoluteDynamicEvent
+\test ##[ { c[ c] c^[ c^] c_[ c_] } #] % BeamEvent
+\test ##[ { c( c) c^( c^) c_( c_) } #] % SlurEvent
+\test ##[ { c\ c\! c^\ c^\! c_\ c_\! } #] % CrescendoEvent
+\test ##[ { c\ c\! c^\ c^\! c_\ c_\! } #] % DecrescendoEvent
+\test ##[ { c\episemInitium c\episemFinis } #] % EpisemaEvent
+\test ##[ { c\( c\) c^\( c^\) c_\( c_\) } #] % PhrasingSlurEvent
+\test ##[ { c\sustainOn c\sustainOff } #] % SustainEvent
+\test ##[ { c\sostenutoOn c\sostenutoOff } #] % SostenutoEvent
\test ##[ \melisma #]
\test ##[ \melismaEnd #]
-\test ##[ { c\startTextSpan c\stopTextSpan } #]% TextSpanEvent
-\test ##[ { c\startTrillSpan c\stopTrillSpan } #]% TrillSpanEvent
-\test ##[ { c \startStaff c \stopStaff } #]% StaffSpanEvent
-\test ##[ { c\startGroup c\stopGroup c^\startGroup c^\stopGroup
