Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-13 Thread paconet . org

Some of these changes are already pushed. I could kiss myself.


http://codereview.appspot.com/5539052/diff/1/Documentation/es/extending/scheme-tutorial.itely
File Documentation/es/extending/scheme-tutorial.itely (right):

http://codereview.appspot.com/5539052/diff/1/Documentation/es/extending/scheme-tutorial.itely#newcode888
Documentation/es/extending/scheme-tutorial.itely:888: usaríamos
@ref{Funciones de Scheme vacías}, o lo almacenaríamos en un
This change is already pushed in the lilypond/translation branch, commit
30d5b6092

http://codereview.appspot.com/5539052/diff/1/Documentation/es/notation/rhythms.itely
File Documentation/es/notation/rhythms.itely (right):

http://codereview.appspot.com/5539052/diff/1/Documentation/es/notation/rhythms.itely#newcode3120
Documentation/es/notation/rhythms.itely:3120: ensayo, consulte
@ref{Indicaciones de texto}.  Para un control más
My commit 30d5b60 includes a change here as well to fix a wrong xref
(not sure if it was a broken xref).

http://codereview.appspot.com/5539052/diff/1/Documentation/es/notation/rhythms.itely#newcode3122
Documentation/es/notation/rhythms.itely:3122: @ref{Alineación de
objetos}.
This is new, I missed it.

http://codereview.appspot.com/5539052/diff/1/Documentation/es/notation/rhythms.itely#newcode3129
Documentation/es/notation/rhythms.itely:3129: @ref{Alineación de
objetos}.
Already pushed. See 30d5b609 in lilypond/translation branch.  I guess
Git will smartly merge both change sets.

http://codereview.appspot.com/5539052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-13 Thread James
On 13 January 2012 08:42,  paconet@gmail.com wrote:
 Some of these changes are already pushed. I could kiss myself.

can I kiss someone?

Hey perhaps we need a Kissmeister... any takers? Janek?

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-13 Thread Janek Warchoł
2012/1/13 James pkx1...@gmail.com:
 On 13 January 2012 08:42,  paconet@gmail.com wrote:
 Some of these changes are already pushed. I could kiss myself.

 can I kiss someone?

 Hey perhaps we need a Kissmeister... any takers? Janek?

I'm not pretty, so i guess no :P

Thanks for your work, Julien!  I'm inspired.

cheers,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread julien . rioux

Reviewers: ,

Message:
Open for review.

Description:
Undefined references in translated manuals (issue 2220).

Please review this at http://codereview.appspot.com/5539052/

Affected files:
  M Documentation/cs/learning/common-notation.itely
  M Documentation/cs/learning/fundamental.itely
  M Documentation/de/learning/common-notation.itely
  M Documentation/de/learning/tutorial.itely
  M Documentation/de/learning/tweaks.itely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/de/notation/chords.itely
  M Documentation/de/notation/expressive.itely
  M Documentation/de/notation/fretted-strings.itely
  M Documentation/de/notation/input.itely
  M Documentation/de/notation/notation-appendices.itely
  M Documentation/de/notation/pitches.itely
  M Documentation/de/notation/spacing.itely
  M Documentation/de/notation/text.itely
  M Documentation/de/notation/vocal.itely
  M Documentation/de/notation/world.itely
  M Documentation/de/usage/running.itely
  M Documentation/es/extending/scheme-tutorial.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/fr/notation/pitches.itely
  M Documentation/fr/notation/specialist.itely
  M Documentation/fr/notation/staff.itely
  M Documentation/fr/notation/vocal.itely
  M Documentation/hu/usage.tely
  M Documentation/hu/usage/lilypond-book.itely
  M Documentation/it/learning/fundamental.itely
  M Documentation/it/learning/templates.itely
  M Documentation/ja/notation/input.itely



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread lemzwerg

Julien,

please apply such obvious (and trivial) fixes directly to lilypond
without creating a Rietveld issue.


http://codereview.appspot.com/5539052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Undefined references in translated manuals (issue 2220). (issue 5539052)

2012-01-12 Thread graham

LGTM, I could kiss you for doing this work.

Please push directly to staging once Patchy is finished checking the
compile (about 30 minutes from now).

http://codereview.appspot.com/5539052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel