Re: patch for git-cl
2017-01-09 0:09 GMT+01:00 Graham Percival <gra...@percival-music.ca>: > On Sun, Jan 08, 2017 at 09:02:51PM +, Thomas Morley wrote: >> attached a little patch for git-cl to replace googlecodeissue by >> trackerissue in cl_settings.py, which will result in correct info in >> .git/config >> >> How do we handle patches to git-cl? > > In general, I'd recommend a PR, Ok, will do next time. > but I've applied this directly and > pushed. Thanks, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: patch for git-cl
On Sun, Jan 08, 2017 at 09:02:51PM +, Thomas Morley wrote: > attached a little patch for git-cl to replace googlecodeissue by > trackerissue in cl_settings.py, which will result in correct info in > .git/config > > How do we handle patches to git-cl? In general, I'd recommend a PR, but I've applied this directly and pushed. Thanks! Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: patch for git-cl
On Sun, Jan 08, 2017 at 10:15:24PM +, James wrote: > On Sun, 8 Jan 2017 21:02:51 + > Thomas Morley <thomasmorle...@gmail.com> wrote: > > > attached a little patch for git-cl to replace googlecodeissue by > > trackerissue in cl_settings.py, which will result in correct info in > > .git/config > > > > How do we handle patches to git-cl? > > > I imagine pull requests to > > https://github.com/gperciva/git-cl.git That certainly works, but in this case I can handle it manually in a few hours. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: patch for git-cl
On Sun, 8 Jan 2017 21:02:51 + Thomas Morley <thomasmorle...@gmail.com> wrote: > Hi, > > attached a little patch for git-cl to replace googlecodeissue by > trackerissue in cl_settings.py, which will result in correct info in > .git/config > > How do we handle patches to git-cl? I imagine pull requests to https://github.com/gperciva/git-cl.git See http://lilypond.org/doc/v2.19/Documentation/contributor-big-page.html#git_002dcl James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
patch for git-cl
Hi, attached a little patch for git-cl to replace googlecodeissue by trackerissue in cl_settings.py, which will result in correct info in .git/config How do we handle patches to git-cl? Cheers, Harm From b8364652a91f3e07bef7719da71f56994c69e7b3 Mon Sep 17 00:00:00 2001 From: Thomas Morley <thomasmorle...@gmail.com> Date: Sun, 8 Jan 2017 20:39:48 + Subject: [PATCH] Replace googlecodeissue by trackerissue in cl_settings.py The file .git/config will not longer point incorrectly to googlecode --- cl_settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cl_settings.py b/cl_settings.py index 0822b93..4e6bd95 100644 --- a/cl_settings.py +++ b/cl_settings.py @@ -286,7 +286,7 @@ or verify this branch is set up to track another (via the --track argument to def _TrackerIssueSetting(self): """Returns the git setting that stores the Tracker issue.""" -return 'branch.%s.googlecodeissue' % self.GetBranch() +return 'branch.%s.trackerissue' % self.GetBranch() def _RietveldIssueSetting(self): """Returns the git setting that stores the Rietveld issue.""" -- 2.1.4 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
