Re: trouble uploading a patch

[Thomas Morley]

2017-02-21 0:28 GMT+01:00 David Nalesnik :

> Hi David,
>
> your patch has push-status.
> https://sourceforge.net/p/testlilyissues/issues/5064/
> Any changings/additions you want to have included?
>
>
> No, it should be good to go.

Done

> Thanks again!

You're welcome.


Best,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Feb 20, 2017 3:19 PM, "Thomas Morley"  wrote:

2017-02-15 22:39 GMT+01:00 Thomas Morley :
> 2017-02-15 0:53 GMT+01:00 Thomas Morley :
>
>>> OK--I've made a patch update based on the review comments so far.
>>> (See attachment.)
>>
>> I'll upload it asap, which will likely be tomorrow evening.
>
> Done.
> I extended the commit message with the issue number.
>
> Cheers,
>   Harm

Hi David,

your patch has push-status.
https://sourceforge.net/p/testlilyissues/issues/5064/
Any changings/additions you want to have included?


No, it should be good to go.  Thanks again!

Best,
David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Thomas Morley]

2017-02-15 22:39 GMT+01:00 Thomas Morley :
> 2017-02-15 0:53 GMT+01:00 Thomas Morley :
>
>>> OK--I've made a patch update based on the review comments so far.
>>> (See attachment.)
>>
>> I'll upload it asap, which will likely be tomorrow evening.
>
> Done.
> I extended the commit message with the issue number.
>
> Cheers,
>   Harm

Hi David,

your patch has push-status.
https://sourceforge.net/p/testlilyissues/issues/5064/
Any changings/additions you want to have included?

Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Thomas Morley]

2017-02-15 0:53 GMT+01:00 Thomas Morley :

>> OK--I've made a patch update based on the review comments so far.
>> (See attachment.)
>
> I'll upload it asap, which will likely be tomorrow evening.

Done.
I extended the commit message with the issue number.

Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Werner LEMBERG]

>> Maybe the solution to the problem is to scrap Win10 altogether.
>> The insidious updates seem to have messed up my permissions, so I
>> can't update VirtualBox -- even running the installer as an
>> administrator.  (Was hoping that a newer version would correct the
>> problem I'm having.)
> 
> Sorry to hear that.  Some time ago I used a dual boot setup. After
> all I hear from Win 10 updates, I'm very happy I dropped windows
> entirely.

Maybe doing the opposite is a possible solution, i.e., running Win 10
within VirtualBox.


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Thomas Morley]

Hi David,

2017-02-15 0:25 GMT+01:00 David Nalesnik :
> Hi Harm,
>
> On Thu, Feb 9, 2017 at 8:10 AM, David Nalesnik  
> wrote:
>> On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley  
>> wrote:
>>> 2017-02-08 14:37 GMT+01:00 David Nalesnik :
>>>
 I notice that the patch has gotten swept up into the review process.
 If you like, I will tell James to remove it, or maybe put it into
 waiting so I can figure out how to fix my machine?  (It's already
 gotten a review!) I don't want to put you or anybody to extra trouble.
>>>
>>
>> Hi Harm,
>>
>>>
>>> Hi David,
>>>
>>> I'd happily shepherd this issue.
>>> It would be a pitty to waste the already started review.
>>>
>>> I doubt I can help figuring out whats wrong with your VB, though, if
>>> you think I can check/test anything from my end, please shout.
>>>
>>
>> Thanks--I appreciate this!  I'll wait to collect a good number of
>> review comments before submitting any updates.
>>
>
> OK--I've made a patch update based on the review comments so far.
> (See attachment.)

I'll upload it asap, which will likely be tomorrow evening.

> Maybe the solution to the problem is to scrap Win10 altogether.  The
> insidious updates seem to have messed up my permissions, so I can't
> update VirtualBox -- even running the installer as an administrator.
> (Was hoping that a newer version would correct the problem I'm
> having.)

Sorry to hear that.
Some time ago I used a dual boot setup. After all I hear from Win 10
updates, I'm very happy I dropped windows entirely.

Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Thu, Feb 9, 2017 at 8:10 AM, David Nalesnik  wrote:
> On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley  
> wrote:
>> 2017-02-08 14:37 GMT+01:00 David Nalesnik :
>>
>>> I notice that the patch has gotten swept up into the review process.
>>> If you like, I will tell James to remove it, or maybe put it into
>>> waiting so I can figure out how to fix my machine?  (It's already
>>> gotten a review!) I don't want to put you or anybody to extra trouble.
>>
>
> Hi Harm,
>
>>
>> Hi David,
>>
>> I'd happily shepherd this issue.
>> It would be a pitty to waste the already started review.
>>
>> I doubt I can help figuring out whats wrong with your VB, though, if
>> you think I can check/test anything from my end, please shout.
>>
>
> Thanks--I appreciate this!  I'll wait to collect a good number of
> review comments before submitting any updates.
>

OK--I've made a patch update based on the review comments so far.
(See attachment.)

Maybe the solution to the problem is to scrap Win10 altogether.  The
insidious updates seem to have messed up my permissions, so I can't
update VirtualBox -- even running the installer as an administrator.
(Was hoping that a newer version would correct the problem I'm
having.)

Anyway, thanks!

David
From 0fd5890a32e9cb298853b6b8187a51d6ef7bfbc4 Mon Sep 17 00:00:00 2001
From: David Nalesnik 
Date: Sat, 4 Feb 2017 19:13:31 -0600
Subject: [PATCH] Let analysis brackets support text

Ability to add labels to brackets is essential for musical analysis.

This patch introduces a new grob, "HorizontalBracketText," a spanner
created along with "HorizontalBracket" by Horizontal_bracket_engraver.

Repeated text of broken brackets is parenthesized.
---
 Documentation/changes.tely | 18 ++
 Documentation/notation/editorial.itely | 13 ++--
 .../snippets/new/analysis-brackets-with-labels.ly  | 38 ++
 .../regression/horizontal-bracket-broken-texted.ly | 25 ++
 input/regression/horizontal-bracket-texted.ly  | 36 
 lily/horizontal-bracket-engraver.cc| 31 +++---
 lily/horizontal-bracket.cc |  6 +---
 scm/define-grob-interfaces.scm |  5 +++
 scm/define-grob-properties.scm |  1 +
 scm/define-grobs.scm   | 18 ++
 scm/output-lib.scm | 27 +++
 11 files changed, 206 insertions(+), 12 deletions(-)
 create mode 100644 Documentation/snippets/new/analysis-brackets-with-labels.ly
 create mode 100644 input/regression/horizontal-bracket-broken-texted.ly
 create mode 100644 input/regression/horizontal-bracket-texted.ly

diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index 2a64778..f205d00 100644
--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -62,6 +62,24 @@ which scares away people.
 @end ignore
 
 @item
+It is now possible to add text to analysis brackets through the
+@code{HorizontalBracketText} object.
+@lilypond[quote,verbatim]
+\layout {
+  \context {
+\Voice
+\consists "Horizontal_bracket_engraver"
+  }
+}
+
+{
+  \once \override HorizontalBracketText.text = "a"
+  c''\startGroup d''\stopGroup
+  e''-\tweak text "a'" \startGroup d''\stopGroup
+}
+@end lilypond
+
+@item
 The ends of hairpins may now be fine-tuned using the @code{shorten-pair}
 grob property, which previously only affected text-spanners like
 @code{TupletBracket} and @code{OttavaBracket}.  Positive values offset
diff --git a/Documentation/notation/editorial.itely b/Documentation/notation/editorial.itely
index 458fce1..8dc3ac9 100644
--- a/Documentation/notation/editorial.itely
+++ b/Documentation/notation/editorial.itely
@@ -879,12 +879,19 @@ Analysis brackets may be nested.
 }
 @end lilypond
 
-@seealso
-Snippets:
-@rlsr{Editorial annotations}.
+@snippets
 
+@lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
+{analysis-brackets-above-the-staff.ly}
+
+@lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
+{analysis-brackets-with-labels.ly}
+
+@seealso
 Internals Reference:
 @rinternals{Horizontal_bracket_engraver},
 @rinternals{HorizontalBracket},
 @rinternals{horizontal-bracket-interface},
+@rinternals{HorizontalBracketText},
+@rinternals{horizontal-bracket-text-interface},
 @rinternals{Staff}.
diff --git a/Documentation/snippets/new/analysis-brackets-with-labels.ly b/Documentation/snippets/new/analysis-brackets-with-labels.ly
new file mode 100644
index 000..30ae349
--- /dev/null
+++ b/Documentation/snippets/new/analysis-brackets-with-labels.ly
@@ -0,0 +1,38 @@
+\version "2.19.55"
+
+\header {
+  lsrtags = "editorial-annotations, tweaks-and-overrides"
+
+  texidoc = "
+Text may be added to analysis brackets through the @code{text} property
+of the @code{HorizontalBracketText} grob.  Adding 

Re: trouble uploading a patch

[David Nalesnik]

On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley  wrote:
> 2017-02-08 14:37 GMT+01:00 David Nalesnik :
>
>> I notice that the patch has gotten swept up into the review process.
>> If you like, I will tell James to remove it, or maybe put it into
>> waiting so I can figure out how to fix my machine?  (It's already
>> gotten a review!) I don't want to put you or anybody to extra trouble.
>

Hi Harm,

>
> Hi David,
>
> I'd happily shepherd this issue.
> It would be a pitty to waste the already started review.
>
> I doubt I can help figuring out whats wrong with your VB, though, if
> you think I can check/test anything from my end, please shout.
>

Thanks--I appreciate this!  I'll wait to collect a good number of
review comments before submitting any updates.

I'll do some more digging into the VM setup.  Hopefully, I'll be able
to fix this.

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Thomas Morley]

2017-02-08 14:37 GMT+01:00 David Nalesnik :

> I notice that the patch has gotten swept up into the review process.
> If you like, I will tell James to remove it, or maybe put it into
> waiting so I can figure out how to fix my machine?  (It's already
> gotten a review!) I don't want to put you or anybody to extra trouble.


Hi David,

I'd happily shepherd this issue.
It would be a pitty to waste the already started review.

I doubt I can help figuring out whats wrong with your VB, though, if
you think I can check/test anything from my end, please shout.

Best,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Tue, Feb 7, 2017 at 7:46 PM, Thomas Morley  wrote:
> 2017-02-08 0:08 GMT+00:00 David Nalesnik :
>> Harm,
>>
>> On Tue, Feb 7, 2017 at 5:57 PM, Thomas Morley  
>> wrote:
>>> 2017-02-08 0:26 GMT+01:00 David Nalesnik :
>>>

 I don't want to put anyone to the trouble of shepherding this for me,
 since I can't predict how drawn out the review process will be.
>>>
>>>
>>> Nevertheless, how about sending me a git-formated patch?
>>> I could try to to upload. At least we could check whether it's a
>>> general git-cl problem or whether it's related to your setup.
>>> Though, I'll not able to do anything before tomorrow evening.
>>>
>>
>> OK, that would be much appreciated.  Patch attached.
>>
>> Thanks,
>> David
>
> Hi David,
>
> I found some time and had no problems uploading it.
>
> Although, I needed to do
> sudo /sbin/vboxconfig
> on my VirtualBox, which is $ uname -a
> Linux my-host 3.16.0-4-686-pae #1 SMP Debian 3.16.7-ckt11-1+deb8u3
> (2015-08-04) i686 GNU/Linux
>
> Here the terminal output for the upload
>
>
> [lilypond-git (dev/david-patch-test)]$ git cl upload origin/master
>  Documentation/changes.tely  | 18
> ++
>  Documentation/notation/editorial.itely  | 13 
> ++---
>  Documentation/snippets/new/analysis-brackets-with-labels.ly | 38
> ++
>  input/regression/horizontal-bracket-broken-texted.ly| 25
> +
>  input/regression/horizontal-bracket-texted.ly   | 33
> +
>  lily/horizontal-bracket-engraver.cc | 31
> +++
>  lily/horizontal-bracket.cc  |  6 +-
>  scm/define-grob-interfaces.scm  |  5 +
>  scm/define-grob-properties.scm  |  1 +
>  scm/define-grobs.scm| 18
> ++
>  scm/output-lib.scm  | 27
> +++
>  11 files changed, 203 insertions(+), 12 deletions(-)
> Upload server: codereview.appspot.com (change with -s/--server)
> Your browser has been opened to visit:
>
> https://codereview.appspot.com/get-access-token?port=8001
>
> If your browser is on a different machine then exit and re-run
> upload.py with the command-line parameter
>
>   --no_oauth2_webbrowser
>
> Issue created. URL: http://codereview.appspot.com/315570043
> Uploading base file for Documentation/changes.tely
> Uploading base file for scm/define-grob-properties.scm
> Uploading base file for scm/define-grobs.scm
> Uploading base file for
> Documentation/snippets/new/analysis-brackets-with-labels.ly
> Uploading base file for input/regression/horizontal-bracket-broken-texted.ly
> Uploading base file for lily/horizontal-bracket.cc
> Uploading base file for input/regression/horizontal-bracket-texted.ly
> Uploading base file for scm/define-grob-interfaces.scm
> Uploading base file for Documentation/notation/editorial.itely
> Uploading base file for lily/horizontal-bracket-engraver.cc
> Uploading base file for scm/output-lib.scm
> We were not able to associate this patch with a tracker issue.
> Please enter a valid tracker issue number
> (or enter nothing to create a new issue):
> Ticket created at: https://sourceforge.net/p/testlilyissues/issues/5064/
> Tracker issue done: 5064
>

Thanks for testing this!  It confirms what I was thinking--that this
is a problem on my end.

Though I do have an internet connection in my VirtualBox VM (on a
Win10 system), I seem not to be able to maintain a connection to
https://codereview.appspot.com for long enough for the uploads of all
the base files to happen.  Maybe something to do with a VirtualBox
configuration, maybe I have to figure out a way to request another
connection authomatically when one fails, I'm afraid I'm way out of my
depth here.

I notice that the patch has gotten swept up into the review process.
If you like, I will tell James to remove it, or maybe put it into
waiting so I can figure out how to fix my machine?  (It's already
gotten a review!) I don't want to put you or anybody to extra trouble.

Thanks again--
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[Thomas Morley]

2017-02-08 0:08 GMT+00:00 David Nalesnik :
> Harm,
>
> On Tue, Feb 7, 2017 at 5:57 PM, Thomas Morley  
> wrote:
>> 2017-02-08 0:26 GMT+01:00 David Nalesnik :
>>
>>>
>>> I don't want to put anyone to the trouble of shepherding this for me,
>>> since I can't predict how drawn out the review process will be.
>>
>>
>> Nevertheless, how about sending me a git-formated patch?
>> I could try to to upload. At least we could check whether it's a
>> general git-cl problem or whether it's related to your setup.
>> Though, I'll not able to do anything before tomorrow evening.
>>
>
> OK, that would be much appreciated.  Patch attached.
>
> Thanks,
> David

Hi David,

I found some time and had no problems uploading it.

Although, I needed to do
sudo /sbin/vboxconfig
on my VirtualBox, which is $ uname -a
Linux my-host 3.16.0-4-686-pae #1 SMP Debian 3.16.7-ckt11-1+deb8u3
(2015-08-04) i686 GNU/Linux

Here the terminal output for the upload


[lilypond-git (dev/david-patch-test)]$ git cl upload origin/master
 Documentation/changes.tely  | 18
++
 Documentation/notation/editorial.itely  | 13 ++---
 Documentation/snippets/new/analysis-brackets-with-labels.ly | 38
++
 input/regression/horizontal-bracket-broken-texted.ly| 25
+
 input/regression/horizontal-bracket-texted.ly   | 33
+
 lily/horizontal-bracket-engraver.cc | 31
+++
 lily/horizontal-bracket.cc  |  6 +-
 scm/define-grob-interfaces.scm  |  5 +
 scm/define-grob-properties.scm  |  1 +
 scm/define-grobs.scm| 18
++
 scm/output-lib.scm  | 27
+++
 11 files changed, 203 insertions(+), 12 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser

Issue created. URL: http://codereview.appspot.com/315570043
Uploading base file for Documentation/changes.tely
Uploading base file for scm/define-grob-properties.scm
Uploading base file for scm/define-grobs.scm
Uploading base file for
Documentation/snippets/new/analysis-brackets-with-labels.ly
Uploading base file for input/regression/horizontal-bracket-broken-texted.ly
Uploading base file for lily/horizontal-bracket.cc
Uploading base file for input/regression/horizontal-bracket-texted.ly
Uploading base file for scm/define-grob-interfaces.scm
Uploading base file for Documentation/notation/editorial.itely
Uploading base file for lily/horizontal-bracket-engraver.cc
Uploading base file for scm/output-lib.scm
We were not able to associate this patch with a tracker issue.
Please enter a valid tracker issue number
(or enter nothing to create a new issue):
Ticket created at: https://sourceforge.net/p/testlilyissues/issues/5064/
Tracker issue done: 5064


Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Kastrup]

David Nalesnik  writes:

> On Sat, Feb 4, 2017 at 7:02 PM, David Nalesnik  
> wrote:
>> Yes, I've run it a number of times.
>>
>> All I can think is that somewhere during the upload process I lose my
>> authenticated connection with www.google.com.
>>
>> Hmmm.  I've rebased everything to a single commit, and that's what
>> I'm uploading.

Don't do that.  Always keep your work in recognizable pieces (sometimes
it takes a bit of work to turn "historic" pieces into "logic" pieces,
but git rebase -i helps with that, as do git checkout -p and similar).

>> Maybe I should break it down into several commits?

I don't think git-cl works with more than the diffs anyway.  We really
need some actually git-aware tool at one point of time.

> Nope.  Broke it up into 4 commits.  Same result.
>
> Always the same two files lead to "error: old chunk mismatch"--so the
> base files aren't getting uploaded.

Really have no idea about that.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Sat, Feb 4, 2017 at 7:02 PM, David Nalesnik  wrote:
> On Sat, Feb 4, 2017 at 6:45 PM, David Kastrup  wrote:
>> David Nalesnik  writes:
>>
>>> On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup  wrote:
 David Nalesnik  writes:

> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik
>  wrote:
>> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
>>  wrote:
>>> Hi,
>>>
>>> I'm trying to upload a patch for review, and I'm running into 
>>> difficulties.
>>>
>>> Using git-cl, I get this output:
>>>
>>> Issue created. URL: http://codereview.appspot.com/320140043
>>> Uploading base file for Documentation/changes.tely
>>> Uploading base file for scm/define-grob-properties.scm
>>> Uploading base file for scm/define-grobs.scm
>>> Uploading base file for
>>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>>> Traceback (most recent call last):
>>>   File "/home/david/git-cl/git-cl", line 628, in 
>>> sys.exit(main(sys.argv))
>>>   File "/home/david/git-cl/git-cl", line 622, in main
>>> return func(argv[2:])
>>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
>>> files)
>>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>>> print t.get(timeout=60)
>>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>>> raise self._value
>>> urllib2.URLError: 
>>>
>>> The patch is visible here: https://codereview.appspot.com/320140043/
>>> but no issue has been created.
>>
>> Except that two files show "Error: old chunk mismatch":
>> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>
> I've tried uploading this a number of times, always the same results.
> The base files aren't uploaded for these two files.  (Current attempt:
> https://codereview.appspot.com/316280043/)
>
> Is the patch simply too large, and I'm losing the connection before
> all of the base files have been uploaded?
>
> If this is so, is there any way to get all of this uploaded and
> associated with a single issue?

 What command line have you been using for the upload attempt?

>>>
>>> git-cl upload origin/master
>>>
>>> Has worked with all recent patches I've done.  They've all been
>>> noticeably smaller, though.
>>
>> Have you tried
>>
>> git rebase origin/master
>>
>> before calling git-cl?  I could imagine problems due to master not being
>> in your ancestry.
>
> Yes, I've run it a number of times.
>
> All I can think is that somewhere during the upload process I lose my
> authenticated connection with www.google.com.
>
> Hmmm.  I've rebased everything to a single commit, and that's what I'm
> uploading.  Maybe I should break it down into several commits?

Nope.  Broke it up into 4 commits.  Same result.

Always the same two files lead to "error: old chunk mismatch"--so the
base files aren't getting uploaded.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Kastrup]

David Nalesnik  writes:

> On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup  wrote:
>> David Nalesnik  writes:
>>
>>> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik
>>>  wrote:
 On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
  wrote:
> Hi,
>
> I'm trying to upload a patch for review, and I'm running into 
> difficulties.
>
> Using git-cl, I get this output:
>
> Issue created. URL: http://codereview.appspot.com/320140043
> Uploading base file for Documentation/changes.tely
> Uploading base file for scm/define-grob-properties.scm
> Uploading base file for scm/define-grobs.scm
> Uploading base file for
> Documentation/snippets/new/analysis-brackets-with-labels.ly
> Traceback (most recent call last):
>   File "/home/david/git-cl/git-cl", line 628, in 
> sys.exit(main(sys.argv))
>   File "/home/david/git-cl/git-cl", line 622, in main
> return func(argv[2:])
>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
> files)
>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
> print t.get(timeout=60)
>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
> raise self._value
> urllib2.URLError: 
>
> The patch is visible here: https://codereview.appspot.com/320140043/
> but no issue has been created.

 Except that two files show "Error: old chunk mismatch":
 scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>>>
>>> I've tried uploading this a number of times, always the same results.
>>> The base files aren't uploaded for these two files.  (Current attempt:
>>> https://codereview.appspot.com/316280043/)
>>>
>>> Is the patch simply too large, and I'm losing the connection before
>>> all of the base files have been uploaded?
>>>
>>> If this is so, is there any way to get all of this uploaded and
>>> associated with a single issue?
>>
>> What command line have you been using for the upload attempt?
>>
>
> git-cl upload origin/master
>
> Has worked with all recent patches I've done.  They've all been
> noticeably smaller, though.

Have you tried

git rebase origin/master

before calling git-cl?  I could imagine problems due to master not being
in your ancestry.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup  wrote:
> David Nalesnik  writes:
>
>> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik  
>> wrote:
>>> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
>>>  wrote:
 Hi,

 I'm trying to upload a patch for review, and I'm running into difficulties.

 Using git-cl, I get this output:

 Issue created. URL: http://codereview.appspot.com/320140043
 Uploading base file for Documentation/changes.tely
 Uploading base file for scm/define-grob-properties.scm
 Uploading base file for scm/define-grobs.scm
 Uploading base file for
 Documentation/snippets/new/analysis-brackets-with-labels.ly
 Traceback (most recent call last):
   File "/home/david/git-cl/git-cl", line 628, in 
 sys.exit(main(sys.argv))
   File "/home/david/git-cl/git-cl", line 622, in main
 return func(argv[2:])
   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
 issue, patchset = upload.RealMain(['upload'] + upload_args + args)
   File "/home/david/git-cl/upload.py", line 2693, in RealMain
 vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
 files)
   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
 print t.get(timeout=60)
   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
 raise self._value
 urllib2.URLError: 

 The patch is visible here: https://codereview.appspot.com/320140043/
 but no issue has been created.
>>>
>>> Except that two files show "Error: old chunk mismatch":
>>> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>>
>> I've tried uploading this a number of times, always the same results.
>> The base files aren't uploaded for these two files.  (Current attempt:
>> https://codereview.appspot.com/316280043/)
>>
>> Is the patch simply too large, and I'm losing the connection before
>> all of the base files have been uploaded?
>>
>> If this is so, is there any way to get all of this uploaded and
>> associated with a single issue?
>
> What command line have you been using for the upload attempt?
>

git-cl upload origin/master

Has worked with all recent patches I've done.  They've all been
noticeably smaller, though.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Kastrup]

David Nalesnik  writes:

> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik  
> wrote:
>> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
>>  wrote:
>>> Hi,
>>>
>>> I'm trying to upload a patch for review, and I'm running into difficulties.
>>>
>>> Using git-cl, I get this output:
>>>
>>> Issue created. URL: http://codereview.appspot.com/320140043
>>> Uploading base file for Documentation/changes.tely
>>> Uploading base file for scm/define-grob-properties.scm
>>> Uploading base file for scm/define-grobs.scm
>>> Uploading base file for
>>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>>> Traceback (most recent call last):
>>>   File "/home/david/git-cl/git-cl", line 628, in 
>>> sys.exit(main(sys.argv))
>>>   File "/home/david/git-cl/git-cl", line 622, in main
>>> return func(argv[2:])
>>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
>>> files)
>>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>>> print t.get(timeout=60)
>>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>>> raise self._value
>>> urllib2.URLError: 
>>>
>>> The patch is visible here: https://codereview.appspot.com/320140043/
>>> but no issue has been created.
>>
>> Except that two files show "Error: old chunk mismatch":
>> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>
> I've tried uploading this a number of times, always the same results.
> The base files aren't uploaded for these two files.  (Current attempt:
> https://codereview.appspot.com/316280043/)
>
> Is the patch simply too large, and I'm losing the connection before
> all of the base files have been uploaded?
>
> If this is so, is there any way to get all of this uploaded and
> associated with a single issue?

What command line have you been using for the upload attempt?

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik  wrote:
> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik  
> wrote:
>> Hi,
>>
>> I'm trying to upload a patch for review, and I'm running into difficulties.
>>
>> Using git-cl, I get this output:
>>
>> Issue created. URL: http://codereview.appspot.com/320140043
>> Uploading base file for Documentation/changes.tely
>> Uploading base file for scm/define-grob-properties.scm
>> Uploading base file for scm/define-grobs.scm
>> Uploading base file for
>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>> Traceback (most recent call last):
>>   File "/home/david/git-cl/git-cl", line 628, in 
>> sys.exit(main(sys.argv))
>>   File "/home/david/git-cl/git-cl", line 622, in main
>> return func(argv[2:])
>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>> print t.get(timeout=60)
>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>> raise self._value
>> urllib2.URLError: 
>>
>> The patch is visible here: https://codereview.appspot.com/320140043/
>> but no issue has been created.
>
> Except that two files show "Error: old chunk mismatch":
> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc

I've tried uploading this a number of times, always the same results.
The base files aren't uploaded for these two files.  (Current attempt:
https://codereview.appspot.com/316280043/)

Is the patch simply too large, and I'm losing the connection before
all of the base files have been uploaded?

If this is so, is there any way to get all of this uploaded and
associated with a single issue?

Thanks,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik  wrote:
> Hi,
>
> I'm trying to upload a patch for review, and I'm running into difficulties.
>
> Using git-cl, I get this output:
>
> Issue created. URL: http://codereview.appspot.com/320140043
> Uploading base file for Documentation/changes.tely
> Uploading base file for scm/define-grob-properties.scm
> Uploading base file for scm/define-grobs.scm
> Uploading base file for
> Documentation/snippets/new/analysis-brackets-with-labels.ly
> Traceback (most recent call last):
>   File "/home/david/git-cl/git-cl", line 628, in 
> sys.exit(main(sys.argv))
>   File "/home/david/git-cl/git-cl", line 622, in main
> return func(argv[2:])
>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
> print t.get(timeout=60)
>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
> raise self._value
> urllib2.URLError: 
>
> The patch is visible here: https://codereview.appspot.com/320140043/
> but no issue has been created.

Except that two files show "Error: old chunk mismatch":
scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

trouble uploading a patch

[David Nalesnik]

Hi,

I'm trying to upload a patch for review, and I'm running into difficulties.

Using git-cl, I get this output:

Issue created. URL: http://codereview.appspot.com/320140043
Uploading base file for Documentation/changes.tely
Uploading base file for scm/define-grob-properties.scm
Uploading base file for scm/define-grobs.scm
Uploading base file for
Documentation/snippets/new/analysis-brackets-with-labels.ly
Traceback (most recent call last):
  File "/home/david/git-cl/git-cl", line 628, in 
sys.exit(main(sys.argv))
  File "/home/david/git-cl/git-cl", line 622, in main
return func(argv[2:])
  File "/home/david/git-cl/git-cl", line 335, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/david/git-cl/upload.py", line 2693, in RealMain
vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
raise self._value
urllib2.URLError: 

The patch is visible here: https://codereview.appspot.com/320140043/
but no issue has been created.

Any help would be appreciated!

Thanks,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel