Re: [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies
On Tue, Jul 25, 2006 at 05:13:31PM -0700, Randy.Dunlap wrote: On Tue, 25 Jul 2006, Keshavamurthy Anil S wrote: On Tue, Jul 25, 2006 at 04:18:54PM -0700, Kristen Carlson Accardi wrote: drivers/pci/hotplug/Kconfig | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) Can;t this be done with just one line change? The first attempted patch was something like: depends on HOTPLUG_PCI ACPI_DOCK!=n but that is not legal kconfig language. Did you have something else in mind? Yup, already mentioned in my first email. Please see below which is just one line change and acheives the same as your 17 line change patch. - depends on ACPI_DOCK HOTPLUG_PCI depends on (!ACPI_DOCK ACPI HOTPLUG_PCI) || (ACPI_DOCK HOTPLUG_PCI) -Anil - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies
--- I confirmed that Anil's patch will work, here is a proper patch with Anil's changes. Change the build options for acpiphp so that it may build without being dependent on the ACPI_DOCK option, but yet does not allow the option of acpiphp being built-in when dock is built as a module. Signed-off-by: Anil S Keshavamurthy [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/pci/hotplug/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 2.6-git.orig/drivers/pci/hotplug/Kconfig +++ 2.6-git/drivers/pci/hotplug/Kconfig @@ -76,7 +76,7 @@ config HOTPLUG_PCI_IBM config HOTPLUG_PCI_ACPI tristate ACPI PCI Hotplug driver - depends on ACPI_DOCK HOTPLUG_PCI + depends on (!ACPI_DOCK ACPI HOTPLUG_PCI) || (ACPI_DOCK HOTPLUG_PCI) help Say Y here if you have a system that supports PCI Hotplug using ACPI. - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [patch] add Dock Station driver to MAINTAINERS
Applied. thanks, -Len -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kristen Carlson Accardi Sent: Wednesday, July 26, 2006 1:59 PM To: Brown, Len Cc: linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org Subject: [patch] add Dock Station driver to MAINTAINERS Add the Dock driver to the MAINTAINERS file Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) --- 2.6-git.orig/MAINTAINERS +++ 2.6-git/MAINTAINERS @@ -882,6 +882,12 @@ M:[EMAIL PROTECTED] T:git http://tali.admingilde.org/git/linux-docbook.git S:Maintained +DOCKING STATION DRIVER +P:Kristen Carlson Accardi +M:[EMAIL PROTECTED] +L:linux-acpi@vger.kernel.org +S:Maintained + DOUBLETALK DRIVER P:James R. Van Zandt M:[EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [gpm] Untangling the sleep hotkey mess
But input layer will be a hub of sorts and I am arguing for ACPI to be converted to use input layer directly. What does lkml think of ACPI using the input layer directly? I think it is a good idea. The only question I have is how to transition. If I replace the acpi_bus_generate_event() calls for power/sleep/lid/hotkeys and replace them with input_report_key(), will there be something up there listening for these events when acpid does not get them? thanks, -Len ps. the long term goal is to delete /proc/acpi, including /proc/acpi/event. Getting rid of the events that are like keys is a step in that direction, but there are a bunch of other steps for non key-like events too. - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [gpm] Untangling the sleep hotkey mess
On Wednesday 26 July 2006 19:41, Brown, Len wrote:
But input layer will be a hub of sorts and I am arguing for ACPI
to be converted to use input layer directly.
What does lkml think of ACPI using the input layer directly?
I think it is a good idea.
The only question I have is how to transition.
If I replace the acpi_bus_generate_event() calls for
power/sleep/lid/hotkeys
and replace them with input_report_key(), will there be something up
there
listening for these events when acpid does not get them?
Let's start with adding reporting through input layer while still
reporintg through /proc/acpi/event, this will allow gradual transition.
What do you think about the patch below (should be applied on top of
cleanup patch which is attached)? I will need to adjust it to
!CONFIG_INPUT, but it can be done later if we agree on principle.
--
Dmitry
Subject: ACPI: button - register with input layer
ACPI: button - register with input layer
In addition to signalling button/lid events through /proc/acpi/event
create separate input devices and report KEY_POWER, KEY_SLEEP and
SW_LID through input layer.
My sleep button autorepeat but userspace will have to filter duplicate
sleep requests anyway (and discard unprocessed events right after
wakeup).
Unlike /proc/acpi/event interface input device corresponding to LID
switch reports true lid state instead of just a counter. SW_LID is
active when lid is closed.
Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED]
---
drivers/acpi/button.c | 172 --
1 files changed, 125 insertions(+), 47 deletions(-)
Index: work/drivers/acpi/button.c
===
--- work.orig/drivers/acpi/button.c
+++ work/drivers/acpi/button.c
@@ -29,6 +29,7 @@
#include linux/types.h
#include linux/proc_fs.h
#include linux/seq_file.h
+#include linux/input.h
#include acpi/acpi_bus.h
#include acpi/acpi_drivers.h
@@ -83,7 +84,9 @@ static struct acpi_driver acpi_button_dr
struct acpi_button {
struct acpi_device *device; /* Fixed button kludge */
- u8 type;
+ unsigned int type;
+ struct input_dev *input;
+ char phys[32]; /* for input device */
unsigned long pushed;
};
@@ -245,12 +248,35 @@ static int acpi_button_remove_fs(struct
static void acpi_button_notify(acpi_handle handle, u32 event, void *data)
{
struct acpi_button *button = data;
+ struct input_dev *input;
if (!button || !button-device)
return;
switch (event) {
case ACPI_BUTTON_NOTIFY_STATUS:
+ input = button-input;
+
+ if (button-type == ACPI_BUTTON_TYPE_LID) {
+ struct acpi_handle *handle = button-device-handle;
+ unsigned long state;
+
+ if (ACPI_FAILURE(acpi_evaluate_integer(handle, _LID,
+ NULL, state)))
+ state = 1; /* assume open */
+
+ input_report_switch(input, SW_LID, !state);
+
+ } else {
+ int keycode = test_bit(KEY_SLEEP, input-keybit) ?
+ KEY_SLEEP : KEY_POWER;
+
+ input_report_key(input, keycode, 1);
+ input_sync(input);
+ input_report_key(input, keycode, 0);
+ }
+ input_sync(input);
+
acpi_bus_generate_event(button-device, event,
++button-pushed);
break;
@@ -275,11 +301,58 @@ static acpi_status acpi_button_notify_fi
return AE_OK;
}
-static int acpi_button_add(struct acpi_device *device)
+static int acpi_button_install_notify_handlers(struct acpi_button *button)
{
- int result;
acpi_status status;
+
+ switch (button-type) {
+ case ACPI_BUTTON_TYPE_POWERF:
+ status =
+ acpi_install_fixed_event_handler(ACPI_EVENT_POWER_BUTTON,
+acpi_button_notify_fixed,
+button);
+ break;
+ case ACPI_BUTTON_TYPE_SLEEPF:
+ status =
+ acpi_install_fixed_event_handler(ACPI_EVENT_SLEEP_BUTTON,
+acpi_button_notify_fixed,
+button);
+ break;
+ default:
+ status = acpi_install_notify_handler(button-device-handle,
+ACPI_DEVICE_NOTIFY,
+acpi_button_notify,
+button);
+ break;
+ }
+
+ return ACPI_FAILURE(status) ?
Re: msi s271 (1058)
On Mon, 2006-07-17 at 12:22 +0200, andreas guetl wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 hello! i recently bought a msi s271 barebone and stuffed it with an amd turion x1 tl-56, 2gb ram and a harddisk. but linux won't start on it when acpi is enabled. i tried tons of kernel-configuration (both 64 and 32bit), boot-parameters and bios-versions. no success. only if acpi=off is appended. so i can't even dump its dsdt table. does anyone know a method to get the dsdt table on windows? (windows x64 that is). i searched a lot but found nothing so far. Just for other msi s271 users: nohpet boot param makes it boot... Thomas - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
