Re: [PATCH] crypto: s390 - fix concurrency issue in aes-ctr mode

[Harald Freudenberger]

On Thu, 2014-01-16 at 16:01 +0100, Harald Freudenberger wrote:

 The aes-ctr mode uses one preallocated page without any concurrency
 protection. When multiple threads run aes-ctr encryption or decryption
 this can lead to data corruption.
 
 The patch introduces locking for the page and a fallback solution with
 slower en/decryption performance in concurrency situations.
 
 Signed-off-by: Harald Freudenberger fre...@linux.vnet.ibm.com
 ---
  arch/s390/crypto/aes_s390.c |   65 
 ++-
  1 file changed, 46 insertions(+), 19 deletions(-)

Herbert, could you please add Cc: sta...@vger.kernel.org to this?

Thanks


--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 62/73] drivers/crypto: delete non-required instances of include linux/init.h

[Paul Gortmaker]

None of these files are actually using any __init type directives
and hence don't need to include linux/init.h.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: David S. Miller da...@davemloft.net
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com
---
 drivers/crypto/atmel-aes.c| 1 -
 drivers/crypto/atmel-sha.c| 1 -
 drivers/crypto/atmel-tdes.c   | 1 -
 drivers/crypto/nx/nx_debugfs.c| 1 -
 drivers/crypto/omap-aes.c | 1 -
 drivers/crypto/omap-sham.c| 1 -
 drivers/crypto/picoxcell_crypto.c | 1 -
 drivers/crypto/s5p-sss.c  | 1 -
 drivers/crypto/tegra-aes.c| 1 -
 9 files changed, 9 deletions(-)

diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index d7c9e31..70fb6fb 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 0618be0..637141b 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 6cde5b5..604a67f 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -24,7 +24,6 @@
 #include linux/platform_device.h
 
 #include linux/device.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/irq.h
diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c
index 7ab2e8d..899d857 100644
--- a/drivers/crypto/nx/nx_debugfs.c
+++ b/drivers/crypto/nx/nx_debugfs.c
@@ -24,7 +24,6 @@
 #include linux/string.h
 #include linux/debugfs.h
 #include linux/module.h
-#include linux/init.h
 #include linux/crypto.h
 #include crypto/hash.h
 #include asm/vio.h
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index dde41f1d..6d34dac 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -19,7 +19,6 @@
 
 #include linux/err.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/platform_device.h
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index a727a6a..5d303eb 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -19,7 +19,6 @@
 #include linux/err.h
 #include linux/device.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/interrupt.h
 #include linux/kernel.h
diff --git a/drivers/crypto/picoxcell_crypto.c 
b/drivers/crypto/picoxcell_crypto.c
index a6175ba..e50a1b9 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -29,7 +29,6 @@
 #include linux/dma-mapping.h
 #include linux/dmapool.h
 #include linux/err.h
-#include linux/init.h
 #include linux/interrupt.h
 #include linux/io.h
 #include linux/list.h
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index cf149b1..78b7eed 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -14,7 +14,6 @@
 #include linux/delay.h
 #include linux/err.h
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/clk.h
diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c
index 060eecc..4c0548f 100644
--- a/drivers/crypto/tegra-aes.c
+++ b/drivers/crypto/tegra-aes.c
@@ -30,7 +30,6 @@
 #define pr_fmt(fmt) KBUILD_MODNAME :  fmt
 
 #include linux/module.h
-#include linux/init.h
 #include linux/errno.h
 #include linux/kernel.h
 #include linux/clk.h
-- 
1.8.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html