Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes

2017-03-06 Thread Guenter Roeck 

On 03/06/2017 03:20 PM, James Hogan wrote:

Hi Guenter,

On Mon, Mar 06, 2017 at 11:13:55AM -0800, Guenter Roeck wrote:

Since commit f3ac60671954 ("sched/headers: Move task-stack related
APIs from  to ") and commit
f780d89a0e82 ("sched/headers: Remove  from
"), various mips builds fail as follows.

arch/mips/kernel/smp-mt.c: In function ‘vsmp_boot_secondary’:
arch/mips/include/asm/processor.h:384:41: error:
implicit declaration of function ‘task_stack_page’

In file included from
/opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c:
arch/mips/include/asm/fpu.h: In function '__own_fpu':
arch/mips/include/asm/processor.h:385:31: error:
invalid application of 'sizeof' to incomplete type 'struct pt_regs'


This one is in an inline function, so I think it'd affect multiple
includes of  even if __own_fpu isn't used, so I think the
following patch which adds the include ptrace.h in fpu.h is more robust
than adding to the individual c files affected:
https://patchwork.linux-mips.org/patch/15386/


Agreed.


Admitedly it could probably have a more specific subject line since
there are more similar errors.


Does that fix all compile problems ? Seems to me that we'll still need

-#include 
+#include 

or did you prepare a patch for this as well ?

Thanks,
Guenter



Cheers
James



arch/mips/netlogic/common/smp.c: In function 'nlm_boot_secondary':
arch/mips/netlogic/common/smp.c:157:2: error:
implicit declaration of function 'task_stack_page'

and more similar errors.

Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs ...")
Fixes: f780d89a0e82 ("sched/headers: Remove  from ...")
Cc: Ingo Molnar <mi...@kernel.org>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
---
v3: Catch more build errors

 arch/mips/cavium-octeon/cpu.c  | 3 ++-
 arch/mips/cavium-octeon/crypto/octeon-crypto.c | 1 +
 arch/mips/cavium-octeon/smp.c  | 2 +-
 arch/mips/kernel/pm.c  | 1 +
 arch/mips/kernel/smp-mt.c  | 2 +-
 arch/mips/netlogic/common/smp.c| 1 +
 arch/mips/netlogic/xlp/cop2-ex.c   | 3 ++-
 arch/mips/power/cpu.c  | 1 +
 8 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/cpu.c b/arch/mips/cavium-octeon/cpu.c
index a5b427909b5c..b826b7a87c57 100644
--- a/arch/mips/cavium-octeon/cpu.c
+++ b/arch/mips/cavium-octeon/cpu.c
@@ -10,7 +10,8 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 

 #include 
 #include 
diff --git a/arch/mips/cavium-octeon/crypto/octeon-crypto.c 
b/arch/mips/cavium-octeon/crypto/octeon-crypto.c
index 4d22365844af..cfb4a146cf17 100644
--- a/arch/mips/cavium-octeon/crypto/octeon-crypto.c
+++ b/arch/mips/cavium-octeon/crypto/octeon-crypto.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 

 #include "octeon-crypto.h"

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 4b94b7fbafa3..d475c0146347 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -10,8 +10,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 #include 
 #include 

diff --git a/arch/mips/kernel/pm.c b/arch/mips/kernel/pm.c
index dc814892133c..fab05022ab39 100644
--- a/arch/mips/kernel/pm.c
+++ b/arch/mips/kernel/pm.c
@@ -11,6 +11,7 @@

 #include 
 #include 
+#include 

 #include 
 #include 
diff --git a/arch/mips/kernel/smp-mt.c b/arch/mips/kernel/smp-mt.c
index e077ea3e11fb..effc1ed18954 100644
--- a/arch/mips/kernel/smp-mt.c
+++ b/arch/mips/kernel/smp-mt.c
@@ -18,7 +18,7 @@
  * Copyright (C) 2006 Ralf Baechle (r...@linux-mips.org)
  */
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/arch/mips/netlogic/common/smp.c b/arch/mips/netlogic/common/smp.c
index 10d86d54880a..9035558920c1 100644
--- a/arch/mips/netlogic/common/smp.c
+++ b/arch/mips/netlogic/common/smp.c
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 

diff --git a/arch/mips/netlogic/xlp/cop2-ex.c b/arch/mips/netlogic/xlp/cop2-ex.c
index 52bc5de42005..d990b7fc84aa 100644
--- a/arch/mips/netlogic/xlp/cop2-ex.c
+++ b/arch/mips/netlogic/xlp/cop2-ex.c
@@ -13,7 +13,8 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 

 #include 
 #include 
diff --git a/arch/mips/power/cpu.c b/arch/mips/power/cpu.c
index 2129e67723ff..6e26bf7f 100644
--- a/arch/mips/power/cpu.c
+++ b/arch/mips/power/cpu.c
@@ -7,6 +7,7 @@
  * Author: Hu Hongbing <h...@lemote.com>
  *Wu Zhangjin <wuzhang...@gmail.com>
  */
+#include 
 #include 
 #include 
 #include 
--
2.7.4

[PATCH v3] MIPS: Fix build breakage caused by header file changes

2017-03-06 Thread Guenter Roeck 
Since commit f3ac60671954 ("sched/headers: Move task-stack related
APIs from  to ") and commit
f780d89a0e82 ("sched/headers: Remove  from
"), various mips builds fail as follows.

arch/mips/kernel/smp-mt.c: In function ‘vsmp_boot_secondary’:
arch/mips/include/asm/processor.h:384:41: error:
implicit declaration of function ‘task_stack_page’

In file included from
/opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c:
arch/mips/include/asm/fpu.h: In function '__own_fpu':
arch/mips/include/asm/processor.h:385:31: error:
invalid application of 'sizeof' to incomplete type 'struct pt_regs'

arch/mips/netlogic/common/smp.c: In function 'nlm_boot_secondary':
arch/mips/netlogic/common/smp.c:157:2: error:
implicit declaration of function 'task_stack_page'

and more similar errors.

Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs ...")
Fixes: f780d89a0e82 ("sched/headers: Remove  from ...")
Cc: Ingo Molnar <mi...@kernel.org>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
---
v3: Catch more build errors

 arch/mips/cavium-octeon/cpu.c  | 3 ++-
 arch/mips/cavium-octeon/crypto/octeon-crypto.c | 1 +
 arch/mips/cavium-octeon/smp.c  | 2 +-
 arch/mips/kernel/pm.c  | 1 +
 arch/mips/kernel/smp-mt.c  | 2 +-
 arch/mips/netlogic/common/smp.c| 1 +
 arch/mips/netlogic/xlp/cop2-ex.c   | 3 ++-
 arch/mips/power/cpu.c  | 1 +
 8 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/cpu.c b/arch/mips/cavium-octeon/cpu.c
index a5b427909b5c..b826b7a87c57 100644
--- a/arch/mips/cavium-octeon/cpu.c
+++ b/arch/mips/cavium-octeon/cpu.c
@@ -10,7 +10,8 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 
 
 #include 
 #include 
diff --git a/arch/mips/cavium-octeon/crypto/octeon-crypto.c 
b/arch/mips/cavium-octeon/crypto/octeon-crypto.c
index 4d22365844af..cfb4a146cf17 100644
--- a/arch/mips/cavium-octeon/crypto/octeon-crypto.c
+++ b/arch/mips/cavium-octeon/crypto/octeon-crypto.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "octeon-crypto.h"
 
diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 4b94b7fbafa3..d475c0146347 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -10,8 +10,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/arch/mips/kernel/pm.c b/arch/mips/kernel/pm.c
index dc814892133c..fab05022ab39 100644
--- a/arch/mips/kernel/pm.c
+++ b/arch/mips/kernel/pm.c
@@ -11,6 +11,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/arch/mips/kernel/smp-mt.c b/arch/mips/kernel/smp-mt.c
index e077ea3e11fb..effc1ed18954 100644
--- a/arch/mips/kernel/smp-mt.c
+++ b/arch/mips/kernel/smp-mt.c
@@ -18,7 +18,7 @@
  * Copyright (C) 2006 Ralf Baechle (r...@linux-mips.org)
  */
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/arch/mips/netlogic/common/smp.c b/arch/mips/netlogic/common/smp.c
index 10d86d54880a..9035558920c1 100644
--- a/arch/mips/netlogic/common/smp.c
+++ b/arch/mips/netlogic/common/smp.c
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
diff --git a/arch/mips/netlogic/xlp/cop2-ex.c b/arch/mips/netlogic/xlp/cop2-ex.c
index 52bc5de42005..d990b7fc84aa 100644
--- a/arch/mips/netlogic/xlp/cop2-ex.c
+++ b/arch/mips/netlogic/xlp/cop2-ex.c
@@ -13,7 +13,8 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 
 
 #include 
 #include 
diff --git a/arch/mips/power/cpu.c b/arch/mips/power/cpu.c
index 2129e67723ff..6e26bf7f 100644
--- a/arch/mips/power/cpu.c
+++ b/arch/mips/power/cpu.c
@@ -7,6 +7,7 @@
  * Author: Hu Hongbing <h...@lemote.com>
  *Wu Zhangjin <wuzhang...@gmail.com>
  */
+#include 
 #include 
 #include 
 #include 
-- 
2.7.4

[PATCH] keys: Use non-conflicting variable name

2015-06-24 Thread Guenter Roeck 
arm64:allmodconfig fails to build as follows.

In file included from include/acpi/platform/aclinux.h:74:0,
 from include/acpi/platform/acenv.h:173,
 from include/acpi/acpi.h:56,
 from include/linux/acpi.h:37,
 from ./arch/arm64/include/asm/dma-mapping.h:21,
 from include/linux/dma-mapping.h:86,
 from include/linux/skbuff.h:34,
 from include/crypto/algapi.h:18,
 from crypto/asymmetric_keys/rsa.c:16:
include/linux/ctype.h:15:12: error: expected ‘;’, ‘,’ or ‘)’
before numeric constant
 #define _X 0x40 /* hex digit */
^
crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ‘_X’
 static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
   ^
crypto/asymmetric_keys/rsa.c: In function ‘RSA_verify_signature’:
crypto/asymmetric_keys/rsa.c:256:2: error:
implicit declaration of function ‘RSA_I2OSP’

The problem is caused by an unrelated include file change, resulting in
the inclusion of ctype.h on arm64. This in turn causes the local variable
_X to conflict with macro _X used in ctype.h.

Fixes: b6197b93fa4b (arm64 : Introduce support for ACPI _CCA object)
Cc: Suthikulpanit, Suravee suravee.suthikulpa...@amd.com
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
 crypto/asymmetric_keys/rsa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/asymmetric_keys/rsa.c b/crypto/asymmetric_keys/rsa.c
index 459cf97a75e2..508b57b77474 100644
--- a/crypto/asymmetric_keys/rsa.c
+++ b/crypto/asymmetric_keys/rsa.c
@@ -120,7 +120,7 @@ static int RSAVP1(const struct public_key *key, MPI s, MPI 
*_m)
 /*
  * Integer to Octet String conversion [RFC3447 sec 4.1]
  */
-static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
+static int RSA_I2OSP(MPI x, size_t xLen, u8 **pX)
 {
unsigned X_size, x_size;
int X_sign;
@@ -147,7 +147,7 @@ static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
return -EBADMSG;
}
 
-   *_X = X;
+   *pX = X;
return 0;
 }
 
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck 
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote:
 Hi Geert, Guenter,
 
 may I ask that you check that the following patch compiles without errors or 
 warnings on your systems?
 
Stephan,

I applied your patch on top of the current mainline (which includes
the crypto updates for 4.2) and pushed it into my 'testing' branch.
You should be able to see the results in a couple of hours at
http://server.roeck-us.net:8010/builders, in the 'testing' column.

The build system doesn't log warnings, but this should give us an idea
if the build passes for all architectures.

I'll have a look myself later and let you know as well.

Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck 
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote:
 Hi Geert, Guenter,
 
 may I ask that you check that the following patch compiles without errors or 
 warnings on your systems?
 
No build failures for all architectures.

Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

2015-06-23 Thread Guenter Roeck 

On 06/23/2015 10:55 AM, Stephan Mueller wrote:

Am Dienstag, 23. Juni 2015, 10:41:03 schrieb Guenter Roeck:

Hi Guenter, Geert,


On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote:

Hi Geert, Guenter,

may I ask that you check that the following patch compiles without errors
or warnings on your systems?

No build failures for all architectures.


Thank you very much for your help.

Now, if Geert would be so kind and have a check on his OpenRISC to ensure that
there are no compiler warnings, I would be happy.

Though, does anybody have any idea what the AVR32 compiler warning about
crypto/builtin.o not being relaxable mean and whether that is an issue? Note,
when I was compiling AVR32, I saw some of these warnings for other builtin.o
too.



At least it compiles ;-). I don't think there is anything else we can do.

Guenter

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck 
On Mon, Jun 08, 2015 at 03:21:09PM +0300, Andy Shevchenko wrote:
 On Fri, May 29, 2015 at 10:14 PM, Jim Davis jim.ep...@gmail.com wrote:
  Building with the attached random configuration file,
 
 Hit the very same error against next-20150605.
 

There are also several failing default configurations.

Guenter

---

um:defconfig:

include/asm-generic/fixmap.h: In function 'fix_to_virt':
include/asm-generic/fixmap.h:31:2: error: size of unnamed array is negative
---

x86_64:defconfig:
i386:defconfig:

./arch/x86/include/asm/qspinlock.h: In function 'native_queued_spin_unlock':
./arch/x86/include/asm/qspinlock.h:17:2: error:
call to '__compiletime_assert_17' declared with attribute error:
Need native word sized stores/loads for atomicity.

---

openrisc:defconfig:

In file included from ./arch/openrisc/include/asm/timex.h:23:0,
...
from crypto/jitterentropy.c:52:
./arch/openrisc/include/asm/spr.h: In function 'jent_loop_shuffle':
./arch/openrisc/include/asm/spr.h:30:2: warning: asm operand 1 probably doesn't
match constraints
./arch/openrisc/include/asm/spr.h:30:2: error: impossible constraint in 'asm'

---

nios2:3c120_defconfig:

ERROR: get_cycles [crypto/jitterentropy.ko] undefined!
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck 

On 06/08/2015 03:36 PM, Stephan Mueller wrote:

Am Monday 08 June 2015, 12:54:12 schrieb Guenter Roeck:

Hi Guenter,

Thanks for the note.

...


---

openrisc:defconfig:

In file included from ./arch/openrisc/include/asm/timex.h:23:0,
...
from crypto/jitterentropy.c:52:
./arch/openrisc/include/asm/spr.h: In function 'jent_loop_shuffle':
./arch/openrisc/include/asm/spr.h:30:2: warning: asm operand 1 probably
doesn't match constraints
./arch/openrisc/include/asm/spr.h:30:2: error: impossible constraint in 'asm'


I received this one also before. But that seems to be an error on the OpenRISC
platform as the random_get_entropy() function or the get_cycles function is
not implemented as defined.

The crypto code uses the following which triggers the issue:

 __u64 tmp = 0;

 tmp = random_get_entropy();

That one seems to be an appropriate use of random_get_entropy() which on
almost all arches is an alias for get_cycles().


Yes and no. I suspect it may have something to do with the compiler options.
The code compiles with the following patch applied.

---
diff --git a/arch/openrisc/include/asm/spr.h b/arch/openrisc/include/asm/spr.h
index 1cccb42dd477..373532cc41f4 100644
--- a/arch/openrisc/include/asm/spr.h
+++ b/arch/openrisc/include/asm/spr.h
@@ -24,7 +24,7 @@
l.mtspr %0,%1,%2  \
: : r (_off), r (_val), K (_spr))

-static inline unsigned long mfspr(unsigned long add)
+static inline unsigned long mfspr(const unsigned long add)
 {
unsigned long ret;
__asm__ __volatile__ (l.mfspr %0,r0,%1 : =r (ret) : K (add));

---

get_cycles is implemented as static inline which executes mfspr(SPR_TTCR).
SPR_TTCR is a constant. Normally that information seems to be passed on,
but not when get_cycles() is compiled through jitterentropy.

Any idea what might cause this ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20150529, in crypto/jitterentropy.c

2015-06-08 Thread Guenter Roeck 

On 06/08/2015 04:33 PM, Stephan Mueller wrote:

Am Monday 08 June 2015, 16:30:09 schrieb Guenter Roeck:

Hi Guenter,



get_cycles is implemented as static inline which executes mfspr(SPR_TTCR).
SPR_TTCR is a constant. Normally that information seems to be passed on,
but not when get_cycles() is compiled through jitterentropy.

Any idea what might cause this ?


Then it may be the optimization issue as well that Peter indicated. May I ask
you for testing purposes (I do not have an OpenRISC) to remove the following
line from crypto/Makefile:

CFLAGS_jitterentropy.o = -O0



Yes, that fixes the problem (after I also removed the associated #error from
jitterentropy.c).

Guenter

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] crypto: api: Do not access module name directly from module structure

2015-04-25 Thread Guenter Roeck 
On Sat, Apr 25, 2015 at 06:38:03AM +0800, Herbert Xu wrote:
 On Fri, Apr 24, 2015 at 08:58:03AM -0700, Guenter Roeck wrote:
  'struct module' is only fully declared if CONFIG_MODULES is configured.
  If not, the build fails with
  
  crypto/algapi.c: In function 'crypto_check_module_sig':
  crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type
  
  Fixes: 59afdc7b3214 (crypto: api - Move module sig ifdef into accessor
  function)
  Cc: Herbert Xu herb...@gondor.apana.org.au
  Cc: Rusty Russell ru...@rustcorp.com.au
  Signed-off-by: Guenter Roeck li...@roeck-us.net
  ---
  Seen in next-20150424.
 
 Thanks but a similar patch has already been queued.

Excellent.

Thanks,
Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] crypto: api: Do not access module name directly from module structure

2015-04-25 Thread Guenter Roeck 
'struct module' is only fully declared if CONFIG_MODULES is configured.
If not, the build fails with

crypto/algapi.c: In function 'crypto_check_module_sig':
crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type

Fixes: 59afdc7b3214 (crypto: api - Move module sig ifdef into accessor
function)
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: Rusty Russell ru...@rustcorp.com.au
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
Seen in next-20150424.

 crypto/algapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/algapi.c b/crypto/algapi.c
index c63836f4ff64..3103e6a1282e 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -46,7 +46,7 @@ static inline void crypto_check_module_sig(struct module *mod)
 {
if (fips_enabled  mod  !module_sig_ok(mod))
panic(Module %s signature verification failed in FIPS mode\n,
- mod-name);
+ module_name(mod));
 }
 
 static int crypto_check_alg(struct crypto_alg *alg)
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Mar 11 (powerpc build failure due to vmx crypto code)

2015-03-11 Thread Guenter Roeck 

On 03/11/2015 06:23 PM, Herbert Xu wrote:

On Wed, Mar 11, 2015 at 08:47:17AM -0700, Guenter Roeck wrote:


Building powerpc:allmodconfig:

ERROR: .aes_p8_cbc_encrypt [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .aes_p8_set_encrypt_key [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .aes_p8_set_decrypt_key [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .gcm_init_p8 [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .aes_p8_decrypt [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .aes_p8_encrypt [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .gcm_ghash_p8 [drivers/crypto/vmx/vmx-crypto.ko] undefined!
ERROR: .aes_p8_ctr32_encrypt_blocks [drivers/crypto/vmx/vmx-crypto.ko] 
undefined!

Those functions are called but don't seem to be defined anywhere.


They are meant to be generated by the perl scripts in that directory.
Can you take a look at why those perl scripts didn't run or didn't
function correctly?



It looks like the perl scripts do run - I see the .S files, and I do see .o 
files created.
But I still get the error.

Looking into the object files, I see

$ nm vmx-crypto.o | grep aes_p8_cbc_encrypt
0680 t .aes_p8_cbc_encrypt
 U .aes_p8_cbc_encrypt
00a8 D aes_p8_cbc_encrypt

$ nm aesp8-ppc.o | grep aes_p8_cbc_encrypt
0680 t .aes_p8_cbc_encrypt
0060 D aes_p8_cbc_encrypt

In the assembler source, I see

.globl  aes_p8_cbc_encrypt

but no .globl for .aes_p8_cbc_encrypt.

Does that tell you anything ?

I also notice is that the .S files are not removed with make mrproper
but left behind. Seems to me that those files should be removed.

Guenter

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html