from:"Stephen Brennan"

[PATCH v2] staging: ccree: Fix indentation in ssi_buffer_mgr.c

2017-10-27 Thread Stephen Brennan

In particular, fixes some over-indented if statement bodies as well as a
couple lines indented with spaces. checkpatch.pl now reports no warnings
on this file other than 80 character warnings.

Signed-off-by: Stephen Brennan <step...@brennan.io>
---
V2 also fixes an overlooked indentation error that checkpatch didn't catch.

 drivers/staging/ccree/ssi_buffer_mgr.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c 
b/drivers/staging/ccree/ssi_buffer_mgr.c
index dca3ce84d043..1f8a225530a8 100644
--- a/drivers/staging/ccree/ssi_buffer_mgr.c
+++ b/drivers/staging/ccree/ssi_buffer_mgr.c
@@ -406,8 +406,8 @@ ssi_aead_handle_config_buf(struct device *dev,
sg_init_one(_ctx->ccm_adata_sg, config_data, AES_BLOCK_SIZE + 
areq_ctx->ccm_hdr_size);
if (unlikely(dma_map_sg(dev, _ctx->ccm_adata_sg, 1,
DMA_TO_DEVICE) != 1)) {
-   dev_err(dev, "dma_map_sg() config buffer failed\n");
-   return -ENOMEM;
+   dev_err(dev, "dma_map_sg() config buffer failed\n");
+   return -ENOMEM;
}
dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK 
offset=%u length=%u\n",
_dma_address(_ctx->ccm_adata_sg),
@@ -435,8 +435,8 @@ static inline int ssi_ahash_handle_curr_buf(struct device 
*dev,
sg_init_one(areq_ctx->buff_sg, curr_buff, curr_buff_cnt);
if (unlikely(dma_map_sg(dev, areq_ctx->buff_sg, 1,
DMA_TO_DEVICE) != 1)) {
-   dev_err(dev, "dma_map_sg() src buffer failed\n");
-   return -ENOMEM;
+   dev_err(dev, "dma_map_sg() src buffer failed\n");
+   return -ENOMEM;
}
dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK 
offset=%u length=%u\n",
_dma_address(areq_ctx->buff_sg), sg_page(areq_ctx->buff_sg),
@@ -1029,12 +1029,12 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
 * verification is made by CPU compare in order to 
simplify
 * MAC verification upon request completion
 */
- u32 size_to_skip = req->assoclen;
+   u32 size_to_skip = req->assoclen;
 
- if (areq_ctx->is_gcm4543)
- size_to_skip += crypto_aead_ivsize(tfm);
+   if (areq_ctx->is_gcm4543)
+   size_to_skip += crypto_aead_ivsize(tfm);
 
- ssi_buffer_mgr_copy_scatterlist_portion(
+   ssi_buffer_mgr_copy_scatterlist_portion(
dev, areq_ctx->backup_mac, req->src,
size_to_skip + req->cryptlen - 
areq_ctx->req_authsize,
size_to_skip + req->cryptlen, SSI_SG_TO_BUF);
-- 
2.14.2

Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

2017-10-27 Thread Stephen Brennan

On Fri, Oct 27, 2017 at 07:23:58AM -0700, Joe Perches wrote:
> On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> > But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
> > correctly.

Yeah, I don't know how I missed it. I'll send a new version of the patch
out momentarily.

> The latest version of checkpatch should bleat something on the
>   ...scatterlist_portion(
> line

Strangely, my checkpatch doesn't complain about it, but I guess you can't
always rely on tools for this stuff. For reference, I'm currently on the
10/18 linux-next branch.

[PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

2017-10-26 Thread Stephen Brennan

In particular, fixes some over-indented if statement bodies as well as a
couple lines indented with spaces. checkpatch.pl now reports no warnings
on this file other than 80 character warnings.

Signed-off-by: Stephen Brennan <step...@brennan.io>
---
Hello again, hoping these indentation issues are a bit more actionable than the
line length errors I was trying to fix in my previous patch. Again, thanks in
advance for taking the time to look!

 drivers/staging/ccree/ssi_buffer_mgr.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c 
b/drivers/staging/ccree/ssi_buffer_mgr.c
index dca3ce84d043..7c62255128d5 100644
--- a/drivers/staging/ccree/ssi_buffer_mgr.c
+++ b/drivers/staging/ccree/ssi_buffer_mgr.c
@@ -406,8 +406,8 @@ ssi_aead_handle_config_buf(struct device *dev,
sg_init_one(_ctx->ccm_adata_sg, config_data, AES_BLOCK_SIZE + 
areq_ctx->ccm_hdr_size);
if (unlikely(dma_map_sg(dev, _ctx->ccm_adata_sg, 1,
DMA_TO_DEVICE) != 1)) {
-   dev_err(dev, "dma_map_sg() config buffer failed\n");
-   return -ENOMEM;
+   dev_err(dev, "dma_map_sg() config buffer failed\n");
+   return -ENOMEM;
}
dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK 
offset=%u length=%u\n",
_dma_address(_ctx->ccm_adata_sg),
@@ -435,8 +435,8 @@ static inline int ssi_ahash_handle_curr_buf(struct device 
*dev,
sg_init_one(areq_ctx->buff_sg, curr_buff, curr_buff_cnt);
if (unlikely(dma_map_sg(dev, areq_ctx->buff_sg, 1,
DMA_TO_DEVICE) != 1)) {
-   dev_err(dev, "dma_map_sg() src buffer failed\n");
-   return -ENOMEM;
+   dev_err(dev, "dma_map_sg() src buffer failed\n");
+   return -ENOMEM;
}
dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK 
offset=%u length=%u\n",
_dma_address(areq_ctx->buff_sg), sg_page(areq_ctx->buff_sg),
@@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
 * verification is made by CPU compare in order to 
simplify
 * MAC verification upon request completion
 */
- u32 size_to_skip = req->assoclen;
+   u32 size_to_skip = req->assoclen;
 
- if (areq_ctx->is_gcm4543)
- size_to_skip += crypto_aead_ivsize(tfm);
+   if (areq_ctx->is_gcm4543)
+   size_to_skip += crypto_aead_ivsize(tfm);
 
  ssi_buffer_mgr_copy_scatterlist_portion(
dev, areq_ctx->backup_mac, req->src,
-- 
2.14.2

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-26 Thread Stephen Brennan

Apologies for the noise, this was the wrong patch. Please ignore this.

[PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-26 Thread Stephen Brennan

Simply break down some long lines and tab-indent them.

Signed-off-by: Stephen Brennan <step...@brennan.io>
---
I'm learning the patch submission process, and this is my first patch. I know
it's trivial but I'm just trying to get my feet wet. Thanks in advance for
taking the time to review this!

 drivers/staging/ccree/ssi_pm.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c
index 11bbdbeec22e..98ba9e918d2a 100644
--- a/drivers/staging/ccree/ssi_pm.c
+++ b/drivers/staging/ccree/ssi_pm.c
@@ -41,7 +41,9 @@ int ssi_power_mgr_runtime_suspend(struct device *dev)
int rc;
 
dev_dbg(dev, "set HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_ENABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_ENABLE);
rc = ssi_request_mgr_runtime_suspend_queue(drvdata);
if (rc != 0) {
dev_err(dev, "ssi_request_mgr_runtime_suspend_queue (%x)\n",
@@ -60,7 +62,9 @@ int ssi_power_mgr_runtime_resume(struct device *dev)
(struct ssi_drvdata *)dev_get_drvdata(dev);
 
dev_dbg(dev, "unset HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_DISABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_DISABLE);
 
rc = cc_clk_on(drvdata);
if (rc) {
-- 
2.14.2

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-23 Thread Stephen Brennan

Hi Gilad,

Thanks for the quick reply, I really appreciate your taking time to help a
newbie get started. I've made the appropriate changes and re-submitted.

> TIP: if you run the scripts/get_maintainers.pl script on your patch it
> will tell you exactly which
> list and which people your patch needs to be addressed, so you don't
> have to guess.

When I ran this tool, it listed out quite a few mailing lists, including
linux-ker...@vger.kernel.org. Is it correct to simply address your patch to
the whole list output by the script? I omitted linux-kernel on my
resubmission, simply to avoid contributing to the heavy volume of that
list, given how trivial this patch is.

Thanks again!
Stephen

[PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-23 Thread Stephen Brennan

Simply break down some long lines and tab-indent them.

Signed-off-by: Stephen Brennan <step...@brennan.io>
---
I'm learning the patch submission process, and this is my first patch. I know
it's trivial but I'm just trying to get my feet wet. Thanks in advance for
taking the time to review this!

 drivers/staging/ccree/ssi_pm.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c
index 11bbdbeec22e..98ba9e918d2a 100644
--- a/drivers/staging/ccree/ssi_pm.c
+++ b/drivers/staging/ccree/ssi_pm.c
@@ -41,7 +41,9 @@ int ssi_power_mgr_runtime_suspend(struct device *dev)
int rc;
 
dev_dbg(dev, "set HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_ENABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_ENABLE);
rc = ssi_request_mgr_runtime_suspend_queue(drvdata);
if (rc != 0) {
dev_err(dev, "ssi_request_mgr_runtime_suspend_queue (%x)\n",
@@ -60,7 +62,9 @@ int ssi_power_mgr_runtime_resume(struct device *dev)
(struct ssi_drvdata *)dev_get_drvdata(dev);
 
dev_dbg(dev, "unset HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_DISABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_DISABLE);
 
rc = cc_clk_on(drvdata);
if (rc) {
-- 
2.14.2

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-20 Thread Stephen Brennan

Hello,

Just bumping this patch. I know it's only a very trivial change that shuts
up a checkpatch warning. Please let me know if I can do anything to help.

Thanks,
Stephen

[PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-09 Thread Stephen Brennan

---
I'm new to kernel development and hoping to start with some simple changes to
get familiar with the process. Please let me know if there's anything I can do
to improve this very trivial patch!

 drivers/staging/ccree/ssi_pm.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c
index 11bbdbeec22e..98ba9e918d2a 100644
--- a/drivers/staging/ccree/ssi_pm.c
+++ b/drivers/staging/ccree/ssi_pm.c
@@ -41,7 +41,9 @@ int ssi_power_mgr_runtime_suspend(struct device *dev)
int rc;
 
dev_dbg(dev, "set HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_ENABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_ENABLE);
rc = ssi_request_mgr_runtime_suspend_queue(drvdata);
if (rc != 0) {
dev_err(dev, "ssi_request_mgr_runtime_suspend_queue (%x)\n",
@@ -60,7 +62,9 @@ int ssi_power_mgr_runtime_resume(struct device *dev)
(struct ssi_drvdata *)dev_get_drvdata(dev);
 
dev_dbg(dev, "unset HOST_POWER_DOWN_EN\n");
-   WRITE_REGISTER(drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, 
HOST_POWER_DOWN_EN), POWER_DOWN_DISABLE);
+   WRITE_REGISTER(
+   drvdata->cc_base + CC_REG_OFFSET(HOST_RGF, HOST_POWER_DOWN_EN),
+   POWER_DOWN_DISABLE);
 
rc = cc_clk_on(drvdata);
if (rc) {
-- 
2.14.2

[PATCH v2] staging: ccree: Fix indentation in ssi_buffer_mgr.c

Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

[PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

[PATCH] staging: ccree: Fix lines longer than 80 characters

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

[PATCH] staging: ccree: Fix lines longer than 80 characters

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

[PATCH] staging: ccree: Fix lines longer than 80 characters

9 matches

Site Navigation

Mail list logo

Footer information