Re: [PATCH] crypto: brcm: fix spelling mistake: "fallbck" -> "fallback"

[Steve Lin]

On Sun, Jun 4, 2017 at 2:29 PM, Colin King <colin.k...@canonical.com> wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> Trivial fix to spelling mistake in flow_log message
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Good catch, thanks!
Reviewed-by: Steve Lin <steven.l...@broadcom.com>

> ---
>  drivers/crypto/bcm/cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
> index 61393dc70b0b..9cfd36c1bcb6 100644
> --- a/drivers/crypto/bcm/cipher.c
> +++ b/drivers/crypto/bcm/cipher.c
> @@ -2639,7 +2639,7 @@ static int aead_need_fallback(struct aead_request *req)
> (spu->spu_type == SPU_TYPE_SPUM) &&
> (ctx->digestsize != 8) && (ctx->digestsize != 12) &&
> (ctx->digestsize != 16)) {
> -   flow_log("%s() AES CCM needs fallbck for digest size %d\n",
> +   flow_log("%s() AES CCM needs fallback for digest size %d\n",
>  __func__, ctx->digestsize);
> return 1;
> }
> --
> 2.11.0
>

Re: [PATCH] crypto: brcm: fix spelling mistake: "genereate" -> "generate"

[Steve Lin]

Looks good, thanks!

Acked-by: Steve Lin <steven.l...@broadcom.com>

On Wed, Feb 22, 2017 at 6:51 PM, Colin King <colin.k...@canonical.com> wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> trivial fix to spelling mistake in pr_err message
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
>  drivers/crypto/bcm/util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c
> index 0502f46..430c557 100644
> --- a/drivers/crypto/bcm/util.c
> +++ b/drivers/crypto/bcm/util.c
> @@ -312,7 +312,7 @@ int do_shash(unsigned char *name, unsigned char *result,
> }
> rc = crypto_shash_final(>shash, result);
> if (rc)
> -   pr_err("%s: Could not genereate %s hash", __func__, name);
> +   pr_err("%s: Could not generate %s hash", __func__, name);
>
>  do_shash_err:
> crypto_free_shash(hash);
> --
> 2.10.2
>

[PATCH 1/1] ARM: dts: NSP: Add crypto (SPU) to dtsi

[Steve Lin]

Adds crypto hardware (SPU) to Northstar Plus device tree file.

Signed-off-by: Steve Lin <steven.l...@broadcom.com>

---
Code changes for this addition were submitted previously by Rob
Rice: 
https://git.kernel.org/cgit/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=9d12ba86f818aa9cfe9f01b750336aa441f2ffa2
---
 arch/arm/boot/dts/bcm-nsp.dtsi | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index b6142bd..9bac0c8 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -241,6 +241,12 @@
brcm,nand-has-wp;
};
 
+   crypto@2f000 {
+   compatible = "brcm,spum-nsp-crypto";
+   reg = <0x2f000 0x900>;
+   mboxes = < 0>;
+   };
+
gpiob: gpio@3 {
compatible = "brcm,iproc-nsp-gpio", "brcm,iproc-gpio";
reg = <0x3 0x50>;
-- 
2.1.0