Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

[Greg Kroah-Hartman]

On Thu, Jun 29, 2017 at 04:13:38PM +0530, karthik wrote:
> On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:
> > Thank you Karthik,
> > 
> > On Wed, Jun 28, 2017 at 12:37 PM,   wrote:
> > > From: Karthik Tummala 
> > > 
> > > This patch series fixes coding style and removes the following
> > > checkpatch.pl warnings:
> > > 
> > > Prefer using '"%s...", __func__' to using the function's name,
> > > in a string.
> > 
> > This one is good.
> > > 
> > > Braces {} are not necessary for single statement blocks.
> > 
> > I have already sent a patch addressing this and some other things
> > yesterday/
> > 
> > > 
> > > Rebased on top of next-20170627.
> > > Patches were tested and built on next-20170627
> > 
> > Can you please check patch 1 still applies after yesterdays patch series?
> Hi, I have applied your patch series and then tried to apply patch 1 and it
> failed. Should I wait until the patch series gets accepted and then continue
> my work on the new linux-next release ? or is there any other option ?

You need to rebased on top of these changes.  All of them are now in
staging-testing, soon to move to staging-next in a day or so.  Rebase on
there and resend.

thanks,

greg k-h

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

[karthik]

On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:

Thank you Karthik,

On Wed, Jun 28, 2017 at 12:37 PM,   wrote:

From: Karthik Tummala 

This patch series fixes coding style and removes the following
checkpatch.pl warnings:

Prefer using '"%s...", __func__' to using the function's name,
in a string.


This one is good.


Braces {} are not necessary for single statement blocks.


I have already sent a patch addressing this and some other things
yesterday/



Rebased on top of next-20170627.
Patches were tested and built on next-20170627


Can you please check patch 1 still applies after yesterdays patch series?
Hi, I have applied your patch series and then tried to apply patch 1 and 
it failed. Should I wait until the patch series gets accepted and then 
continue my work on the new linux-next release ? or is there any other 
option ?




Karthik Tummala (2):
   staging: ccree: Use __func__ instead of function name
   staging: ccree: Remove braces {} for single statement blocks

  drivers/staging/ccree/ssi_aead.c | 48 
  1 file changed, 19 insertions(+), 29 deletions(-)

--
1.9.1



Thanks,
Gilad


Thanks
karthik

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

[Gilad Ben-Yossef]

Thank you Karthik,

On Wed, Jun 28, 2017 at 12:37 PM,   wrote:
> From: Karthik Tummala 
>
> This patch series fixes coding style and removes the following
> checkpatch.pl warnings:
>
> Prefer using '"%s...", __func__' to using the function's name,
> in a string.

This one is good.
>
> Braces {} are not necessary for single statement blocks.

I have already sent a patch addressing this and some other things
yesterday/

>
> Rebased on top of next-20170627.
> Patches were tested and built on next-20170627

Can you please check patch 1 still applies after yesterdays patch series?

>
> Karthik Tummala (2):
>   staging: ccree: Use __func__ instead of function name
>   staging: ccree: Remove braces {} for single statement blocks
>
>  drivers/staging/ccree/ssi_aead.c | 48 
> 
>  1 file changed, 19 insertions(+), 29 deletions(-)
>
> --
> 1.9.1
>

Thanks,
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

[PATCH 0/2] staging: ccree: Fix coding style and remove warnings

[karthik]

From: Karthik Tummala 

This patch series fixes coding style and removes the following
checkpatch.pl warnings:

Prefer using '"%s...", __func__' to using the function's name,
in a string.

Braces {} are not necessary for single statement blocks.

Rebased on top of next-20170627.
Patches were tested and built on next-20170627

Karthik Tummala (2):
  staging: ccree: Use __func__ instead of function name
  staging: ccree: Remove braces {} for single statement blocks

 drivers/staging/ccree/ssi_aead.c | 48 
 1 file changed, 19 insertions(+), 29 deletions(-)

-- 
1.9.1