Re: [PATCH 0/6] crypto: crc32 cleanups and unkeyed tests

[Herbert Xu]

On Sat, May 19, 2018 at 10:07:36PM -0700, Eric Biggers wrote:
> This series fixes up alignment for crc32-generic and crc32c-generic,
> removes test vectors for bfin_crc that are no longer needed, and adds
> unkeyed test vectors for crc32 and an extra unkeyed test vector for
> crc32c.  Adding the unkeyed test vectors also required a testmgr change
> to allow a single hash algorithm to have both unkeyed and keyed tests,
> without relying on having it work by accident.
> 
> The new test vectors pass with the generic and x86 CRC implementations.
> I haven't tested others yet; if any happen to be broken, they'll need to
> be fixed.
> 
> Eric Biggers (6):
>   crypto: crc32-generic - use unaligned access macros when needed
>   crypto: crc32c-generic - remove cra_alignmask
>   crypto: crc32-generic - remove __crc32_le()
>   crypto: testmgr - remove bfin_crc "hmac(crc32)" test vectors
>   crypto: testmgr - fix testing OPTIONAL_KEY hash algorithms
>   crypto: testmgr - add more unkeyed crc32 and crc32c test vectors
> 
>  crypto/crc32_generic.c  |  15 ++
>  crypto/crc32c_generic.c |   8 ++--
>  crypto/tcrypt.c |   4 --
>  crypto/testmgr.c|  56 +-
>  crypto/testmgr.h| 102 ++--
>  5 files changed, 66 insertions(+), 119 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH 0/6] crypto: crc32 cleanups and unkeyed tests

[Eric Biggers]

This series fixes up alignment for crc32-generic and crc32c-generic,
removes test vectors for bfin_crc that are no longer needed, and adds
unkeyed test vectors for crc32 and an extra unkeyed test vector for
crc32c.  Adding the unkeyed test vectors also required a testmgr change
to allow a single hash algorithm to have both unkeyed and keyed tests,
without relying on having it work by accident.

The new test vectors pass with the generic and x86 CRC implementations.
I haven't tested others yet; if any happen to be broken, they'll need to
be fixed.

Eric Biggers (6):
  crypto: crc32-generic - use unaligned access macros when needed
  crypto: crc32c-generic - remove cra_alignmask
  crypto: crc32-generic - remove __crc32_le()
  crypto: testmgr - remove bfin_crc "hmac(crc32)" test vectors
  crypto: testmgr - fix testing OPTIONAL_KEY hash algorithms
  crypto: testmgr - add more unkeyed crc32 and crc32c test vectors

 crypto/crc32_generic.c  |  15 ++
 crypto/crc32c_generic.c |   8 ++--
 crypto/tcrypt.c |   4 --
 crypto/testmgr.c|  56 +-
 crypto/testmgr.h| 102 ++--
 5 files changed, 66 insertions(+), 119 deletions(-)

-- 
2.17.0