Re: [linux-dvb] A link DTU advice needed
Citerar Antti Palosaari [EMAIL PROTECTED]: moi attached patch should fix it. I have been too busy to find proper solution for ZL10353, though I now know how it should be done. Thank you very much. On question though: To what incarnation of the driver tree should I use tha patch? My patch program also complained about a corrupted part of the patch, but that part can be fixed with some manual work... Thanks again Dag This message was sent using IMP, the Internet Messaging Program. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] libdvben50221 docs and debuging
On Fri, November 16, 2007 06:52, Ben Bucksch wrote: I am trying to use libdvben50221 from linuxtv-dvb-apps (version 20070114 from Gentoo) to drive the CI/CA/CAM for some encrypted channels. I get some printouts on the console, but it doesn't work, the channel is not decrypted. I don't know if you've done this, but it would perhaps be a good idea to try the gnutv application first (it uses libdvben50221 and is in the same repo) to make sure that everything works as expected. If gnutv works, then it might be time to start comparing your programs use of libdvben50221 to that of gnutv... -- David Härdeman ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] libdvben50221 docs and debuging
David Härdeman schrieb: I don't know if you've done this, but it would perhaps be a good idea to try the gnutv application first (it uses libdvben50221 and is in the same repo) to make sure that everything works as expected. If gnutv works, then it might be time to start comparing your programs use of libdvben50221 to that of gnutv... I had tried the zap application and it worked. I have compared my code with the zap code, in fact use the exact same zap_ca.* files, just rewrote zap_dvb.*, but cannot see what's different. Ben ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] libdvben50221 docs and debuging
I'm not sure if it is related, but you registered a TDT filter with CRC. As far as I know, there's no CRC in the TDT. Only the TOT. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] DVB-C, distortion on some channels.
Hello, I have a Technotrend C-1500 card, I am experiencing some interference/distortion in image and sound on many of the channels, . when I experience this the mythfrontend dumps lots of errors see below. The strange thing is that some channels it occurs all the time, while some channels it occur less often and some channels are entirely fine. It think the problem is with the channels that are on the same multiplex, but I am not sure. I'm using kernel 2.6.23 that I built myself and with the latest v4l-dvb from CVS. Through I have the same problem with the previous kernel. The Signal Strength shows around 55%. I am using MythTV but I have the same problem with Kaffeine. To make sure it wasn't a poor signal that was causing it I tested with the decoder provider by the cable company and it was fine using that decoder. Could my card be defective even though some channels fine? [mpeg2video @ 0xb7241588]skipped MB in I frame at 13 27 [mpeg2video @ 0xb7241588]00 motion_type at 35 26 [mpeg2video @ 0xb7241588]00 motion_type at 35 8 [mpeg2video @ 0xb7241588]invalid cbp at 22 18 [mpeg2video @ 0xb7241588]00 motion_type at 5 15 [mpeg2video @ 0xb7241588]ac-tex damaged at 20 30 [mpeg2video @ 0xb7241588]00 motion_type at 39 8 [mpeg2video @ 0xb7241588]skipped MB in I frame at 35 30 [mpeg2video @ 0xb7241588]skipped MB in I frame at 33 20 [mpeg2video @ 0xb7241588]00 motion_type at 32 6 [mpeg2video @ 0xb7241588]ac-tex damaged at 37 3 [mpeg2video @ 0xb7241588]mb incr damaged [mpeg2video @ 0xb7241588]ac-tex damaged at 22 19 [mpeg2video @ 0xb7241588]ac-tex damaged at 27 0 [mpeg2video @ 0xb7241588]ac-tex damaged at 24 32 [mpeg2video @ 0xb7241588]00 motion_type at 1 1 [mpeg2video @ 0xb7241588]ac-tex damaged at 1 2 [mpeg2video @ 0xb7241588]ac-tex damaged at 6 3 [mpeg2video @ 0xb7241588]00 motion_type at 4 4 [mpeg2video @ 0xb7241588]00 motion_type at 11 5 [mpeg2video @ 0xb7241588]00 motion_type at 7 6 [mpeg2video @ 0xb7241588]00 motion_type at 30 7 [mpeg2video @ 0xb7241588]00 motion_type at 8 8 [mpeg2video @ 0xb7241588]00 motion_type at 23 9 [mpeg2video @ 0xb7241588]ac-tex damaged at 5 10 [mpeg2video @ 0xb7241588]00 motion_type at 8 11 [mpeg2video @ 0xb7241588]mb incr damaged [mpeg2video @ 0xb7241588]ac-tex damaged at 12 13 [mpeg2video @ 0xb7241588]ac-tex damaged at 8 14 [mpeg2video @ 0xb7241588]ac-tex damaged at 43 15 [mpeg2video @ 0xb7241588]ac-tex damaged at 12 16 [mpeg2video @ 0xb7241588]00 motion_type at 24 17 [mpeg2video @ 0xb7241588]00 motion_type at 1 18 [mpeg2video @ 0xb7241588]ac-tex damaged at 42 19 [mpeg2video @ 0xb7241588]00 motion_type at 27 20 [mpeg2video @ 0xb7241588]00 motion_type at 6 21 [mpeg2video @ 0xb7241588]00 motion_type at 15 22 [mpeg2video @ 0xb7241588]ac-tex damaged at 5 23 [mpeg2video @ 0xb7241588]00 motion_type at 5 24 [mpeg2video @ 0xb7241588]ac-tex damaged at 2 25 [mpeg2video @ 0xb7241588]ac-tex damaged at 9 26 [mpeg2video @ 0xb7241588]00 motion_type at 5 27 [mpeg2video @ 0xb7241588]ac-tex damaged at 6 28 [mpeg2video @ 0xb7241588]00 motion_type at 25 30 [mpeg2video @ 0xb7241588]00 motion_type at 12 30 [mpeg2video @ 0xb7241588]00 motion_type at 7 31 [mpeg2video @ 0xb7241588]invalid mb type in P Frame at 2 32 [mpeg2video @ 0xb7241588]mb incr damaged [mpeg2video @ 0xb7241588]00 motion_type at 12 34 [mpeg2video @ 0xb7241588]ac-tex damaged at 9 35 [mpeg2video @ 0xb7241588]00 motion_type at 24 24 [mpeg2video @ 0xb7241588]invalid mb type in P Frame at 28 3 [mpeg2video @ 0xb7241588]00 motion_type at 27 21 [mpeg2video @ 0xb7241588]00 motion_type at 43 4 [mpeg2video @ 0xb7241588]skipped MB in I frame at 41 30 [mpeg2video @ 0xb7241588]00 motion_type at 16 20 [mpeg2video @ 0xb7241588]ac-tex damaged at 30 5 [mpeg2video @ 0xb7241588]ac-tex damaged at 7 5 [mpeg2video @ 0xb7241588]00 motion_type at 27 22 ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] A link DTU advice needed
Dag Nygren wrote: Citerar Antti Palosaari [EMAIL PROTECTED]: moi attached patch should fix it. I have been too busy to find proper solution for ZL10353, though I now know how it should be done. Thank you very much. it worked? On question though: To what incarnation of the driver tree should I use tha patch? Current master. I take patch out from master level tree of 15.11.2007... My patch program also complained about a corrupted part of the patch, but that part can be fixed with some manual work... Didn't know how you have tried it. Just tested it and it goes through without errors. [EMAIL PROTECTED] 11]$ hg clone http://linuxtv.org/hg/v4l-dvb/ destination directory: v4l-dvb requesting all changes adding changesets adding manifests adding file changes added 6613 changesets with 17743 changes to 1265 files 935 files updated, 0 files merged, 0 files removed, 0 files unresolved [EMAIL PROTECTED] 11]$ cd v4l-dvb/ [EMAIL PROTECTED] v4l-dvb]$ patch -p1 ../../10/gl861_zl10353_qt1010.patch patching file linux/drivers/media/dvb/dvb-usb/au6610.c patching file linux/drivers/media/dvb/dvb-usb/gl861.c patching file linux/drivers/media/dvb/frontends/qt1010.c patching file linux/drivers/media/dvb/frontends/qt1010.h patching file linux/drivers/media/dvb/frontends/qt1010_priv.h patching file linux/drivers/media/dvb/frontends/zl10353.c patching file linux/drivers/media/dvb/frontends/zl10353.h patching file linux/drivers/media/dvb/frontends/zl10353_priv.h [EMAIL PROTECTED] v4l-dvb]$ date Fri Nov 16 19:23:42 EET 2007 regards Antti Palosaari ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] Nexus-S not starting after current checkoutel
Hello, I just build 2.6.23.3 today and grabbed a fresh checkout of v4l-dvb. Now, VDR will not start with my Nexus-S. I have rolled back the drivers a few weeks and it works again. Anyone else having such issues? Best Regards. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Lifeview PCI TRIO DVB-S problems: can not tune half transponders, low SS and SNR
Hello Hermann, Thank you very much for you valuable help. Your suggestions helped a lot. Regards Vagelis hermann pitton wrote: Hi Vangelis! Am Donnerstag, den 15.11.2007, 21:00 + schrieb Vangelis Nonas: Hello Hermann, Your suggestion helped a lot indeed. I can now get about 2000 services on Hotbird using scan from dvb-apps. Moreover the reception is better, SNR is about 90%, SS is around 50% or more and I dont often get high error rates. I also tested viewing channels and I can now see channels that didn't exist before. One minor negative side effect is that channelscan on vdr crashes. However, I still can not tume to 12 transponders on hotbird (out of 94 in total). These are the failing transponders: tune to: 11334:h:S0.0W:27500: (tuning failed) tune to: 11373:h:S0.0W:27500: (tuning failed) tune to: 11432:v:S0.0W:27500: (tuning failed) tune to: 12264:v:S13.0E:27500: (tuning failed) tune to: 11954:h:S19.2E:27500: (tuning failed) tune to: 11597:v:S19.2E:22000: (tuning failed) tune to: 12480:v:S19.2E:27500: (tuning failed) tune to: 12500:v:S13.0E:27500: (tuning failed) tune to: 11533:v:S13.0E:27500: (tuning failed) tune to: 11996:v:S13.0E:27500: (tuning failed) tune to: 12722:h:S68.5E:26657: (tuning failed) tune to: 11344:h:S8.0W:27500: (tuning failed) Although the DVB-S part of the card is now much more usable. I feel there is still room for improvement of the Linux driver. Any suggestions on how to improve the reception further? I have to mention here that I have a single LNB on my installation, no disecq, however the patch helped a lot. Thank you Vagelis I'm a bloody beginner on DVB-S and have a simple dish just since a few days. The reason for that is, that we have the code from Andrew since long for the newer silicon stuff, also saa7134 triple devices, which should support DVB-S as well since for over two years, but we don't make much progress, since only the Trio seems to be supported and on others not even testing happens. For sure I can see, that whole fleets of such triple stuff are coming in from all seas. For now, I'm only on a device, hard enough to barely hold it in a not triple capable PCI slot, and likely not fully initialized for the ISL stuff. I'm looking forward to get something normal next and then maybe I can contribute to your questions in the future. For now, try to exchange with people on the same hardware than you and hope for hints of the DVB guys. BTW, that outstanding patch is committed since 7 days to v4l-dvb master. For what I can see the patchlet from me, attaching the ISL6421 for the ISL6405 on the Medion Quad should not do any harm, quite the same for the first LNB. If somebody recognizes any possible risks to the hardware, please say so. I don't. Cheers, Hermann hermann pitton wrote: Hi, Am Mittwoch, den 14.11.2007, 21:36 + schrieb Vangelis Nonas: Hello, I have been trying to use the DVB-S frontend of lifeview pci trio to scan and watch channels from Hotbird. I have the following two problems: please try again with that patch applied and report again. http://linuxtv.org/pipermail/linux-dvb/2007-June/018741.html I don't get a Medion Quad, not in the original triple bus master PCI slot, to behave well on supplying voltage and tone on a ISL6405ER, but with the RF loop through from an external receiver providing the missing I have more than thousand broadcasts available from Hotbird-13.OE. Cheers, Hermann A) When I scan (using the scan utility from the hg tree, or the scan utility of my distribution) almost half of the transponders can not be tuned. I get the error tuning failed and of course almost half of Hotbitd's channels are not found. My transponders file is correct because it comes from my set top box which also runs linux :) or from hg dvb-apps or from other dvb software (e.g. prog dvb). I have also tried scanning with channelscan plugin of vdr with the same results. When I use kaffeine to scan for channels I get an Oops. I am attaching the output of my scan command using the scan util from dvb-apps fresh hg pull. (scan.log.gz) B) When I use ready made channel lists downloaded from the internet I get low SNR and SS on almost half of the transponders and in some cases high error rate. When I use szap on those transponders I can not get a lock. My kernel is: Linux vagoshome 2.6.22-gentoo-r9 #1 SMP Tue Oct 30 16:02:08 UTC 2007 i686 AMD Athlon(tm) 64 X2 Dual Core Processor 4600+ AuthenticAMD GNU/Linux with a fresh hg mercurial pull and installation. I attach also my dmesg as dmesg.log.gz I also attach my lsmod as lsmod.log.gz In case you need more info about the Oops I get when I scan from Kaffeine, I can reproduce it and send you the output. The card works correctly under windows on the same machine, sat cable, dish. Thank you
Re: [linux-dvb] libdvben50221 docs and debuging
Hi, first of all I'd try to enter the CAM's MMI dialog with the gnutv application - to check whether the CAM may be accessed My 2c, Akiva От: [EMAIL PROTECTED] от имени [EMAIL PROTECTED] Отправлено: Пт, 16.11.2007 13:00 Кому: linux-dvb@linuxtv.org Тема: linux-dvb Digest, Vol 34, Issue 51 Send linux-dvb mailing list submissions to linux-dvb@linuxtv.org To subscribe or unsubscribe via the World Wide Web, visit http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb or, via email, send a message with subject or body 'help' to [EMAIL PROTECTED] You can reach the person managing the list at [EMAIL PROTECTED] When replying, please edit your Subject line so it is more specific than Re: Contents of linux-dvb digest... Today's Topics: 1. Re: libdvben50221 docs and debuging (David H?rdeman) 2. Re: A link DTU advice needed (Dag Nygren) 3. Re: libdvben50221 docs and debuging (Ben Bucksch) -- Message: 1 Date: Fri, 16 Nov 2007 09:46:44 +0100 (CET) From: David H?rdeman [EMAIL PROTECTED] Subject: Re: [linux-dvb] libdvben50221 docs and debuging To: Ben Bucksch [EMAIL PROTECTED] Cc: Linux DVB mailing list linux-dvb@linuxtv.org Message-ID: [EMAIL PROTECTED] Content-Type: text/plain;charset=iso-8859-1 On Fri, November 16, 2007 06:52, Ben Bucksch wrote: I am trying to use libdvben50221 from linuxtv-dvb-apps (version 20070114 from Gentoo) to drive the CI/CA/CAM for some encrypted channels. I get some printouts on the console, but it doesn't work, the channel is not decrypted. I don't know if you've done this, but it would perhaps be a good idea to try the gnutv application first (it uses libdvben50221 and is in the same repo) to make sure that everything works as expected. If gnutv works, then it might be time to start comparing your programs use of libdvben50221 to that of gnutv... -- David H?rdeman -- Message: 2 Date: Fri, 16 Nov 2007 11:06:26 +0200 From: Dag Nygren [EMAIL PROTECTED] Subject: Re: [linux-dvb] A link DTU advice needed To: Antti Palosaari [EMAIL PROTECTED] Cc: linux-dvb@linuxtv.org Message-ID: [EMAIL PROTECTED] Content-Type: text/plain; charset=UTF-8; DelSp=Yes;format=flowed Citerar Antti Palosaari [EMAIL PROTECTED]: moi attached patch should fix it. I have been too busy to find proper solution for ZL10353, though I now know how it should be done. Thank you very much. On question though: To what incarnation of the driver tree should I use tha patch? My patch program also complained about a corrupted part of the patch, but that part can be fixed with some manual work... Thanks again Dag This message was sent using IMP, the Internet Messaging Program. -- Message: 3 Date: Fri, 16 Nov 2007 10:25:32 +0100 From: Ben Bucksch [EMAIL PROTECTED] Subject: Re: [linux-dvb] libdvben50221 docs and debuging To: David H?rdeman [EMAIL PROTECTED] Cc: Linux DVB mailing list linux-dvb@linuxtv.org Message-ID: [EMAIL PROTECTED] Content-Type: text/plain; charset=iso-8859-1 David H?rdeman schrieb: I don't know if you've done this, but it would perhaps be a good idea to try the gnutv application first (it uses libdvben50221 and is in the same repo) to make sure that everything works as expected. If gnutv works, then it might be time to start comparing your programs use of libdvben50221 to that of gnutv... I had tried the zap application and it worked. I have compared my code with the zap code, in fact use the exact same zap_ca.* files, just rewrote zap_dvb.*, but cannot see what's different. Ben -- ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb End of linux-dvb Digest, Vol 34, Issue 51 * winmail.dat___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] never do symbol_put(tunerfoo_attach);
Mauro and Michel, This changeset is wrong: http://linuxtv.org/hg/~mchehab/tm6000/rev/79f9210425e2 You should not symbol_put(xc3028_attach); , because you don't always know that we're dealing with that tuner. Instead, just do dvb_frontend_detach(fe) -- that will detach both tuner and frontend, and also lnb (for satellite devices). Cheers, Mike Krufky ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] Pinnacle PCTV Sat Pro
Hi, I cann't install satellite tuner Pinnacle PCTV Sat Pro in my linux system. lspci -v output Pinnacle systems .unknown device message. I think this device is currently unsupported by linux. Can you help me to install this device? Arvydas___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] small hardware news: recent Medion/Aldi PCs with Creatix CTX_948
Hi, the CTX_948 is a low profile triple PCI card. It is compatible with the saa7134 Medion Quad card=96, but in truth else a very different card. Known pitfall one: analog TV must be used first to get good results on DVB-T. Known pitfall two: the ISL6405EZR doesn't get sharp, needs currently a external receiver with RF/IF loopthrough to get voltage and tone for DVB-S, same like on the Quad ... Someone interested, Hartmut? Might take a while with me... Cheers, Hermann ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] never do symbol_put(tunerfoo_attach);
Michel Ludwig wrote: Hi Mike, On Fri 16 Nov 2007, [EMAIL PROTECTED] wrote: Mauro and Michel, This changeset is wrong: http://linuxtv.org/hg/~mchehab/tm6000/rev/79f9210425e2 You should not symbol_put(xc3028_attach); , because you don't always know that we're dealing with that tuner. We know that because it's the only tuner that I've ever seen on tm6000 devices :-) We like to make linuxtv drivers modular and forward compatible. There _are_ devices out there that use other tuners, and if you hardcode xc3028 into this driver, it prevents future developers from adding support for other devices without having to change existing code. But anyway, how would dvb_frontend_detach(fe) release the xc3028_attach symbol, which is requested by dvb_attach? The answer is self-explanatory. Take a look at the other drivers, and take a look at dvb_frontend_detach. (dvb_frontend.c , lines 1204 thru 1221) Better to use the established methods, and have uniform codingstyle across the tree -- don't reinvent the wheel ;-) -Mike ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] never do symbol_put(tunerfoo_attach);
Mauro Carvalho Chehab wrote: Em Sex, 2007-11-16 às 18:37 -0500, [EMAIL PROTECTED] escreveu: Michel Ludwig wrote: Hi Mike, On Fri 16 Nov 2007, [EMAIL PROTECTED] wrote: Mauro and Michel, This changeset is wrong: http://linuxtv.org/hg/~mchehab/tm6000/rev/79f9210425e2 You should not symbol_put(xc3028_attach); , because you don't always know that we're dealing with that tuner. We know that because it's the only tuner that I've ever seen on tm6000 devices :-) We like to make linuxtv drivers modular and forward compatible. There _are_ devices out there that use other tuners, and if you hardcode xc3028 into this driver, it prevents future developers from adding support for other devices without having to change existing code. But anyway, how would dvb_frontend_detach(fe) release the xc3028_attach symbol, which is requested by dvb_attach? The answer is self-explanatory. Take a look at the other drivers, and take a look at dvb_frontend_detach. (dvb_frontend.c , lines 1204 thru 1221) Better to use the established methods, and have uniform codingstyle across the tree -- don't reinvent the wheel ;-) Mike, there are some that calls symbol_put directly, like dst. -Mike DST is a special case -- it is an ASIC. Certain hacks were done there to make it look like a frontend, but it is not. Manu has explained this repeatedly. -Mike ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] never do symbol_put(tunerfoo_attach);
Michel Ludwig wrote:
On Fri 16 Nov 2007, you wrote:
We like to make linuxtv drivers modular and forward compatible. There
_are_ devices out there that use other tuners, and if you hardcode
xc3028 into this driver, it prevents future developers from adding
support for other devices without having to change existing code.
Sure, but no one said that tm6000-dvb is ready to go into the main tree...
I saw an issue and I felt it was appropriate for me to point it out
immediately.
Better to fix a problem when it is noticed, no?
But anyway, how would dvb_frontend_detach(fe) release the xc3028_attach
symbol, which is requested by dvb_attach?
The answer is self-explanatory. Take a look at the other drivers, and
take a look at dvb_frontend_detach. (dvb_frontend.c , lines 1204 thru
1221)
Of course, I have done that, but it is still not clear to me. Here are the
two
macros:
#define dvb_attach(FUNCTION, ARGS...) ({ \
void *__r = NULL; \
typeof(FUNCTION) __a = symbol_request(FUNCTION); \
if (__a) { \
__r = (void *) __a(ARGS); \
if (__r == NULL) \
symbol_put(FUNCTION); \
} else { \
printk(KERN_ERR DVB: Unable to find symbol
#FUNCTION()\n); \
} \
__r; \
})
void dvb_frontend_detach(struct dvb_frontend* fe)
{
void *ptr;
if (fe-ops.release_sec) {
fe-ops.release_sec(fe);
symbol_put_addr(fe-ops.release_sec);
}
if (fe-ops.tuner_ops.release) {
fe-ops.tuner_ops.release(fe);
symbol_put_addr(fe-ops.tuner_ops.release);
}
ptr = (void*)fe-ops.release;
if (ptr) {
fe-ops.release(fe);
symbol_put_addr(ptr);
}
}
dvb_attach is called with xc2028_attach, hence it will request
xc2028_attach.
But dvb_frontend_detach will release xc2028_dvb_release.
It's the same module.
I can try this out tomorrow, but if I have to reboot my machine after that
to
unload tuner-xc2028, then there is definitely a flaw in this approach...
:-)
This is the accepted and proven method used across the entire dvb tree.
If it doesnt work for you, then something is wrong in your code. I
don't think it will cause any problem.
Hey, I was just trying to point out a flaw in your patch -- Nobody is an
expert, and there is always something to be learned.
-Mike
P.S. Why are you guys dropping cc's? I cc'd linux-dvb mailing list
because this is a development issue. It is important for such
discussions to be documented, because it is the only way for future
developers to learn from our mistakes. To conduct all emails in private
will not lead to any progression. This is a community, and we should
all be willing to give and accept advice from each other.
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] never do symbol_put(tunerfoo_attach);
Am Freitag, den 16.11.2007, 19:10 -0500 schrieb [EMAIL PROTECTED]:
Michel Ludwig wrote:
On Fri 16 Nov 2007, you wrote:
We like to make linuxtv drivers modular and forward compatible. There
_are_ devices out there that use other tuners, and if you hardcode
xc3028 into this driver, it prevents future developers from adding
support for other devices without having to change existing code.
Sure, but no one said that tm6000-dvb is ready to go into the main tree...
I saw an issue and I felt it was appropriate for me to point it out
immediately.
Better to fix a problem when it is noticed, no?
But anyway, how would dvb_frontend_detach(fe) release the xc3028_attach
symbol, which is requested by dvb_attach?
The answer is self-explanatory. Take a look at the other drivers, and
take a look at dvb_frontend_detach. (dvb_frontend.c , lines 1204 thru
1221)
Of course, I have done that, but it is still not clear to me. Here are the
two
macros:
#define dvb_attach(FUNCTION, ARGS...) ({ \
void *__r = NULL; \
typeof(FUNCTION) __a = symbol_request(FUNCTION); \
if (__a) { \
__r = (void *) __a(ARGS); \
if (__r == NULL) \
symbol_put(FUNCTION); \
} else { \
printk(KERN_ERR DVB: Unable to find symbol
#FUNCTION()\n); \
} \
__r; \
})
void dvb_frontend_detach(struct dvb_frontend* fe)
{
void *ptr;
if (fe-ops.release_sec) {
fe-ops.release_sec(fe);
symbol_put_addr(fe-ops.release_sec);
}
if (fe-ops.tuner_ops.release) {
fe-ops.tuner_ops.release(fe);
symbol_put_addr(fe-ops.tuner_ops.release);
}
ptr = (void*)fe-ops.release;
if (ptr) {
fe-ops.release(fe);
symbol_put_addr(ptr);
}
}
dvb_attach is called with xc2028_attach, hence it will request
xc2028_attach.
But dvb_frontend_detach will release xc2028_dvb_release.
It's the same module.
I can try this out tomorrow, but if I have to reboot my machine after that
to
unload tuner-xc2028, then there is definitely a flaw in this approach...
:-)
This is the accepted and proven method used across the entire dvb tree.
If it doesnt work for you, then something is wrong in your code. I
don't think it will cause any problem.
Hey, I was just trying to point out a flaw in your patch -- Nobody is an
expert, and there is always something to be learned.
-Mike
P.S. Why are you guys dropping cc's? I cc'd linux-dvb mailing list
because this is a development issue. It is important for such
discussions to be documented, because it is the only way for future
developers to learn from our mistakes. To conduct all emails in private
will not lead to any progression. This is a community, and we should
all be willing to give and accept advice from each other.
Mike,
I still fully under scribe that.
But we should also not create illusions for those coming later and have
to crawl through.
Sometimes it is a damned ratrace, maybe always!
With that NDA stuff not in some GNU/Linux library as fall back, it can
always start again.
I said it previously and repeat it, it comes from above and gets wild by
will.
We are only the idiots ...
Cheers,
Hermann
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] DVB-C, distortion on some channels.
Jonas Kvinge wrote: I am using MythTV but I have the same problem with Kaffeine. To make sure it wasn't a poor signal that was causing it I tested with the decoder provider by the cable company and it was fine using that decoder. Could my card be defective even though some channels fine? Actually, it seems most set top boxes contain some kind of amplifier (or PCI cards have sensitivity issues), because I had the same issue. I had to add a filter/amplifier to be able to run two cards in a daisy-chain. Before that, the first card would work fine but the second card would only tune some muxes and complain of bad signal. The STB worked fine all along. Try using an amplifier and see if that helps. /fnord ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
