Re: [linux-dvb] Additional USB-id for Nova-T Stick
On Fri, Nov 10, 2006 at 02:16:38PM -0500, Michael Krufky wrote:
This patch is good, but it is missing a Sign-off. Please see
README.patches and README.HG in the top-level directory of the repository.
Patch attached.
--
ciao -
Stefan
# HG changeset patch
# User Stefan Traby [EMAIL PROTECTED]
# Date 1163336068 -3600
# Node ID d80ff5226a01b3ee24e848a81f7f8081c1766d1d
# Parent 2aa8e64c3e3ae3b09120c0e393bce91b23e442f1
Support for new-revision Nova-T Stick
From: Stefan Traby [EMAIL PROTECTED]
Added support for Nova-T Stick with USB-id: 0x7060
Signed-off-by: Stefan Traby [EMAIL PROTECTED]
diff -r 2aa8e64c3e3a -r d80ff5226a01
linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Sun Nov 12 03:07:30
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Sun Nov 12 13:54:28
2006 +0100
@@ -278,6 +278,7 @@ struct usb_device_id dib0700_usb_id_tabl
{ USB_DEVICE(USB_VID_COMPRO,USB_PID_COMPRO_VIDEOMATE_U500)
},
{ USB_DEVICE(USB_VID_UNIWILL, USB_PID_UNIWILL_STK7700P) },
{ USB_DEVICE(USB_VID_LEADTEK,
USB_PID_WINFAST_DTV_DONGLE_STK7700P) },
+ { USB_DEVICE(USB_VID_HAUPPAUGE,
USB_PID_HAUPPAUGE_NOVA_T_STICK_2) },
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -326,7 +327,7 @@ struct dvb_usb_device_properties dib0700
{ NULL },
},
{ Hauppauge Nova-T Stick,
- { dib0700_usb_id_table[4], NULL },
+ { dib0700_usb_id_table[4],
dib0700_usb_id_table[9], NULL },
{ NULL },
},
{ AVerMedia AVerTV DVB-T Volar,
diff -r 2aa8e64c3e3a -r d80ff5226a01
linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Sun Nov 12 03:07:30
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Sun Nov 12 13:54:28
2006 +0100
@@ -101,6 +101,7 @@
#define USB_PID_HAUPPAUGE_NOVA_T_500 0x9941
#define USB_PID_HAUPPAUGE_NOVA_T_500_2 0x9950
#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7050
+#define USB_PID_HAUPPAUGE_NOVA_T_STICK_2 0x7060
#define USB_PID_AVERMEDIA_VOLAR0xa807
#define USB_PID_NEBULA_DIGITV 0x0201
#define USB_PID_DVICO_BLUEBIRD_LGDT0xd820
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Additional USB-id for Nova-T Stick
Stefan Traby wrote: Support for new-revision Nova-T Stick From: Stefan Traby [EMAIL PROTECTED] Added support for Nova-T Stick with USB-id: 0x7060 Signed-off-by: Stefan Traby [EMAIL PROTECTED] I've applied your patch to my repository, located at: http://linuxtv.org/hg/~mkrufky/v4l-dvb ...I will ask Mauro to pull it into the master branch later on. Thank you for the patch. Regards, Mike ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Additional USB-id for Nova-T Stick
Stefan Traby wrote:
On Thu, Nov 09, 2006 at 08:23:17PM -0500, Michael Krufky wrote:
It is obvious to me that you didn't test your patch before sending it in.
Without the
change above, autodetection is guaranteed to fail.
I did a quick test,
make make install then I unplugged the stick, make rmmod
and then I reinserted the stick. Funny.
New patch attached.
This patch is good, but it is missing a Sign-off. Please see
README.patches and README.HG in the top-level directory of the repository.
-Mike
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Thu Nov 09
00:06:26 2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Fri Nov 10
19:52:58 2006 +0100
@@ -278,6 +278,7 @@ struct usb_device_id dib0700_usb_id_tabl
{ USB_DEVICE(USB_VID_COMPRO,USB_PID_COMPRO_VIDEOMATE_U500)
},
{ USB_DEVICE(USB_VID_UNIWILL, USB_PID_UNIWILL_STK7700P) },
{ USB_DEVICE(USB_VID_LEADTEK,
USB_PID_WINFAST_DTV_DONGLE_STK7700P) },
+ { USB_DEVICE(USB_VID_HAUPPAUGE,
USB_PID_HAUPPAUGE_NOVA_T_STICK_2) },
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -326,7 +327,7 @@ struct dvb_usb_device_properties dib0700
{ NULL },
},
{ Hauppauge Nova-T Stick,
- { dib0700_usb_id_table[4], NULL },
+ { dib0700_usb_id_table[4],
dib0700_usb_id_table[9], NULL },
{ NULL },
},
{ AVerMedia AVerTV DVB-T Volar,
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Thu Nov 09 00:06:26
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Fri Nov 10 01:22:44
2006 +0100
@@ -101,6 +101,7 @@
#define USB_PID_HAUPPAUGE_NOVA_T_500 0x9941
#define USB_PID_HAUPPAUGE_NOVA_T_500_2 0x9950
#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7050
+#define USB_PID_HAUPPAUGE_NOVA_T_STICK_2 0x7060
#define USB_PID_AVERMEDIA_VOLAR 0xa807
#define USB_PID_NEBULA_DIGITV0x0201
#define USB_PID_DVICO_BLUEBIRD_LGDT 0xd820
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Additional USB-id for Nova-T Stick
Stefan Traby wrote: Hi! Bus 001 Device 018: ID 2040:7060 Hauppauge I did only -#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7050 +#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7060 and the card worked. (today, v4l-dvb-1743615a44e1) Thanks for the nice driver. In order to add support for your device without removing support for the 7050 device, you should create a new #define got 7060... perhaps like this: #define USB_PID_HAUPPAUGE_NOVA_T_STICK_REV2 0x7060 ... or maybe replace the REV2 with the hauppauge model # found on the device. Once you've done that, add the VID and PID to the usb table of the driver, and then add the reference to that table entry to the dvb_usb_device_properties struct for the Nova-T stick. When you're all done with that, and after successful testing, please generate a diff like this: hg diff nova-t-new-revision.patch Email that patch here to the list, and be sure to include a brief description and sign-off, in the form: Signed-off-by: Your Name [EMAIL PROTECTED] If you have trouble doing this, please let me know, and I'll be happy to generate the appropriate patch for you. Good Luck, Michael Krufky ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Additional USB-id for Nova-T Stick
On Thu, Nov 09, 2006 at 04:57:19PM -0500, Michael Krufky wrote:
In order to add support for your device without removing support
for the 7050 device, you should create a new #define got 7060...
perhaps like this:
#define USB_PID_HAUPPAUGE_NOVA_T_STICK_REV2 0x7060
... or maybe replace the REV2 with the hauppauge model # found on the
device.
I appended _2 because it's used the same way on NOVA_T_500
hg diff nova-t-new-revision.patch
Patch attached (I read somewhere in the archive that you want patches
attached and not inlined).
--
ciao -
Stefan
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Thu Nov 09 00:06:26
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Fri Nov 10 01:23:50
2006 +0100
@@ -274,6 +274,7 @@ struct usb_device_id dib0700_usb_id_tabl
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_500) },
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_500_2)
},
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_STICK)
},
+ { USB_DEVICE(USB_VID_HAUPPAUGE,
USB_PID_HAUPPAUGE_NOVA_T_STICK_2) },
{ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_VOLAR) },
{ USB_DEVICE(USB_VID_COMPRO,USB_PID_COMPRO_VIDEOMATE_U500)
},
{ USB_DEVICE(USB_VID_UNIWILL, USB_PID_UNIWILL_STK7700P) },
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Thu Nov 09 00:06:26
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Fri Nov 10 01:22:44
2006 +0100
@@ -101,6 +101,7 @@
#define USB_PID_HAUPPAUGE_NOVA_T_500 0x9941
#define USB_PID_HAUPPAUGE_NOVA_T_500_2 0x9950
#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7050
+#define USB_PID_HAUPPAUGE_NOVA_T_STICK_2 0x7060
#define USB_PID_AVERMEDIA_VOLAR0xa807
#define USB_PID_NEBULA_DIGITV 0x0201
#define USB_PID_DVICO_BLUEBIRD_LGDT0xd820
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Additional USB-id for Nova-T Stick
Stefan Traby wrote:
On Thu, Nov 09, 2006 at 04:57:19PM -0500, Michael Krufky wrote:
In order to add support for your device without removing support
for the 7050 device, you should create a new #define got 7060...
perhaps like this:
#define USB_PID_HAUPPAUGE_NOVA_T_STICK_REV2 0x7060
... or maybe replace the REV2 with the hauppauge model # found on the
device.
I appended _2 because it's used the same way on NOVA_T_500
I like model number better, but what you did is fine. However, it's a bit
strange that we've skipped both zero and one, jumping straight to two. Oh
well...
hg diff nova-t-new-revision.patch
Patch attached (I read somewhere in the archive that you want patches
attached and not inlined).
Either way is fine with me. Attaching is better if your email client mangles
whitespace or enforces wordrapping.
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Thu Nov 09
00:06:26 2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Fri Nov 10
01:23:50 2006 +0100
@@ -274,6 +274,7 @@ struct usb_device_id dib0700_usb_id_tabl
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_500) },
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_500_2)
},
{ USB_DEVICE(USB_VID_HAUPPAUGE, USB_PID_HAUPPAUGE_NOVA_T_STICK)
},
+ { USB_DEVICE(USB_VID_HAUPPAUGE,
USB_PID_HAUPPAUGE_NOVA_T_STICK_2) },
{ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_VOLAR) },
{ USB_DEVICE(USB_VID_COMPRO,USB_PID_COMPRO_VIDEOMATE_U500)
},
{ USB_DEVICE(USB_VID_UNIWILL, USB_PID_UNIWILL_STK7700P) },
No. Inserting this into the middle of the array will shift the indices of all
of the
other PID/VID combinations by one, breaking ALL of the other devices supported
by this
driver. Instead, you should add this to the end.
Also, you are missing a very important part of the patch. On lines 328-331, you
should see:
{ Hauppauge Nova-T Stick,
{ dib0700_usb_id_table[4], NULL },
{ NULL },
},
After adding your usb id to the end of the usb table, you will be using index 9.
You should change the above lines to read as follows:
{ Hauppauge Nova-T Stick,
{ dib0700_usb_id_table[4],
dib0700_usb_id_table[9], NULL },
{ NULL },
},
It is obvious to me that you didn't test your patch before sending it in.
Without the
change above, autodetection is guaranteed to fail.
diff -r f48b072c5676 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Thu Nov 09 00:06:26
2006 -0200
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Fri Nov 10 01:22:44
2006 +0100
@@ -101,6 +101,7 @@
#define USB_PID_HAUPPAUGE_NOVA_T_500 0x9941
#define USB_PID_HAUPPAUGE_NOVA_T_500_2 0x9950
#define USB_PID_HAUPPAUGE_NOVA_T_STICK 0x7050
+#define USB_PID_HAUPPAUGE_NOVA_T_STICK_2 0x7060
#define USB_PID_AVERMEDIA_VOLAR 0xa807
#define USB_PID_NEBULA_DIGITV0x0201
#define USB_PID_DVICO_BLUEBIRD_LGDT 0xd820
Cheers,
Mike
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
