Re: cleaned up ext4 patch series

2007-03-19 Thread Mingming Cao
On Mon, 2007-03-19 at 10:48 -0500, Dave Kleikamp wrote:
 Ted,
 I have rebased the ext4 patchset on 2.6.21-rc4 and cleaned up some bad
 whitespace and sparse warnings.  The patches are here:
 http://www.kernel.org/pub/linux/kernel/people/shaggy/ext4/ext4-2007-03-19.tar.bz2
 Untarred here:
 http://www.kernel.org/pub/linux/kernel/people/shaggy/ext4/ext4-2007-03-19/
 
 I have commented the series file with the changes I've made.  Some of
 the patches are missing signed-of-by:
 
 # Rebased the patches to 2.6.21-rc4
 
 # New patch to fix whitespace before applying new patches
 whitespace.patch
 
 # Replaced truncated beginning comments
 extent-overlap-bugfix
 

 persistent_allocation_1_ioctl_and_unitialized_extents
 

We could mention here that this patch is going to be replaced by a new
patch to use the fallocate() operations.

 # Fixed an endian error
 persistent_allocation_2_support_for_writing_to_unitialized_extent
 

I think Amit has an updated version of this patch in his place.

 # Note: still lots of outstanding comments from linux-ext4 list, 12/2006
 # Missing signed-off-by:
 booked-page-flag.patch
 
 # Missing signed-off-by:
 ext4-block-reservation.patch
 
 # fixed a bunch of endianness errors reported by sparse
 # Needs a signed-off-by from Alex, then can add shaggy's
 ext4-delayed-allocation.patch
 
 ext4-delalloc-extents-48bit.patch
 
 # updated to latest version
 nanosecond_timestamps.patch
 
This nanosecond patch could be move to upstream earlier than the delayed
allocation patch (Alex is working to rewrite it at VFS level), so shall
we move it before the booked-page-flag.patch?

I wonder if we should create two branches: one branch for patches that
are well discussed and tested, which Andrew could trust and pull to mm
tree; and create another branch to store patches that are still under
discussion and likely to be rewriten based on the review feedback.


Thanks,
Mingming

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: cleaned up ext4 patch series

2007-03-19 Thread Andreas Dilger
On Mar 19, 2007  09:15 -0800, Mingming Cao wrote:
 I wonder if we should create two branches: one branch for patches that
 are well discussed and tested, which Andrew could trust and pull to mm
 tree; and create another branch to store patches that are still under
 discussion and likely to be rewriten based on the review feedback.

Yes, that makes a lot of sense.  It would avoid issues like Andrew finding
problems with the nanosecond patches because they hadn't been widely tested
yet.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html