Re: [Linux-HA] resource-agents build fails with error about cl_log.h

2012-07-31 Thread Lars Ellenberg
On Fri, Jul 27, 2012 at 01:26:08PM -0600, David Corlette wrote:
 Hi folks,
 
 I'm working on a Resource Agent for one of our products, and am thinking 
 about submitting some fixes back to the upstream repository. I'm following 
 the instructions here:
 http://www.linux-ha.org/doc/dev-guides/_submitting_resource_agents.html
 but am running into a problem. Basically, when I try to 'make', I get
 an error about clplumbing/cl_log.h. I've searched for resolutions but
 only found really old stuff from 2008 that said update your repo -
 since I did the git clone about 10m ago, I find it hard to believe
 that will help ;-)

How about installing the necessary libs and headers?
I think it is libglue-devel on sles.

 
 I'm using SLED 11 SP2 x86_64
 
 Any thoughts?
 
 
 Here's a console log showing the problem:
 
 src git clone git://github.com/ClusterLabs/resource-agents
 Initialized empty Git repository in src/resource-agents/.git/
 remote: Counting objects: 51955, done.
 remote: Compressing objects: 100% (17607/17607), done.
 remote: Total 51955 (delta 33814), reused 51773 (delta 33639)
 Receiving objects: 100% (51955/51955), 30.10 MiB | 74 KiB/s, done.
 Resolving deltas: 100% (33814/33814), done.
 
 src cd resource-agents
 
 src/resource-agents ./autogen.sh 
 autoreconf: Entering directory `.'
 autoreconf: configure.ac: not using Gettext
 autoreconf: running: aclocal 
 autoreconf: configure.ac: tracing
 autoreconf: configure.ac: not using Libtool
 autoreconf: running: /usr/bin/autoconf
 autoreconf: running: /usr/bin/autoheader
 autoreconf: running: automake --add-missing --copy --no-force
 configure.ac:82: installing `./compile'
 configure.ac:33: installing `./config.guess'
 configure.ac:33: installing `./config.sub'
 configure.ac:63: installing `./install-sh'
 configure.ac:63: installing `./missing'
 heartbeat/Makefile.am: installing `./depcomp'
 autoreconf: Leaving directory `.'
 Now run ./configure and make
 
 src/resource-agents ./configure
 checking for gcc... gcc
 checking for C compiler default output file name... a.out
 checking whether the C compiler works... yes
 SNIP lots of configure output that looks completely normal 
   CFLAGS   = -g -O2 -ggdb3  -fgnu89-inline 
 -fstack-protector-all -Wall -Wbad-function-cast -Wcast-qual -Wcast-align 
 -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal -Wformat=2 
 -Wformat-security -Wformat-nonliteral -Winline -Wmissing-prototypes 
 -Wmissing-declarations -Wmissing-format-attribute -Wnested-externs 
 -Wno-long-long -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes 
 -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror
   Libraries=  -lglib-2.0  
   Stack Libraries  = 
 
 src/resource-agents make
 echo 3.9.3.25-f2d0  .version-t  mv .version-t .version
 gmake  all-recursive
 gmake[1]: Entering directory 
 `/home/dcorlette/src/siem/content/tools/HA/resource-agents'
  SNIP various subdirectory builds that all appear completely normal 
 Making all in heartbeat
 gmake[2]: Entering directory 
 `/home/dcorlette/src/siem/content/tools/HA/resource-agents/heartbeat'
 gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../include -I../include -I../linux-ha  
 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include-g -O2 -ggdb3  
 -fgnu89-inline -fstack-protector-all -Wall -Wbad-function-cast -Wcast-qual 
 -Wcast-align -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal 
 -Wformat=2 -Wformat-security -Wformat-nonliteral -Winline 
 -Wmissing-prototypes -Wmissing-declarations -Wmissing-format-attribute 
 -Wnested-externs -Wno-long-long -Wno-strict-aliasing -Wpointer-arith 
 -Wstrict-prototypes -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror 
 -MT IPv6addr.o -MD -MP -MF .deps/IPv6addr.Tpo -c -o IPv6addr.o IPv6addr.c
 IPv6addr.c:106:31: error: clplumbing/cl_log.h: No such file or directory
 cc1: warnings being treated as errors
 IPv6addr.c: In function *main*:
 IPv6addr.c:207: error: implicit declaration of function *cl_log_set_entity*
 IPv6addr.c:207: error: nested extern declaration of *cl_log_set_entity*
 IPv6addr.c:208: error: implicit declaration of function *cl_log_set_facility*
 IPv6addr.c:208: error: nested extern declaration of *cl_log_set_facility*
 IPv6addr.c:219: error: implicit declaration of function *cl_log*
 IPv6addr.c:219: error: nested extern declaration of *cl_log*
 IPv6addr.c: In function *scan_if*:
 IPv6addr.c:548: error: *gboolean* undeclared (first use in this function)
 IPv6addr.c:548: error: (Each undeclared identifier is reported only once
 IPv6addr.c:548: error: for each function it appears in.)
 IPv6addr.c:548: error: expected *;* before *same*
 IPv6addr.c:606: error: *same* undeclared (first use in this function)
 IPv6addr.c:606: error: *TRUE* undeclared (first use in this function)
 IPv6addr.c:610: error: *FALSE* undeclared (first use in this function)
 IPv6addr.c: In function *write_pid_file*:
 IPv6addr.c:897: error: *ULONG_MAX* undeclared (first use in this function)
 

Re: [Linux-HA] resource-agents build fails with error about cl_log.h

2012-07-31 Thread David Corlette
That did the trick, thanks!

Two suggestions:
- Shouldn't the configure script check for the presence of libglue (or the 
underlying libraries) and complain if they're not there?
- It would be great if the dependencies were listed on the webpage I pointed to 
below.

I'd make those changes myself, but I'm not really qualified/have permissions.

 On 31.07.2012 at 11:56, in message 20120731155622.GS29767@soda.linbit, 
 Lars
Ellenberg lars.ellenb...@linbit.com wrote: 
 On Fri, Jul 27, 2012 at 01:26:08PM -0600, David Corlette wrote:
 Hi folks,
 
 I'm working on a Resource Agent for one of our products, and am thinking 
 about submitting some fixes back to the upstream repository. I'm following 
 the instructions here:
 http://www.linux-ha.org/doc/dev-guides/_submitting_resource_agents.html
 but am running into a problem. Basically, when I try to 'make', I get
 an error about clplumbing/cl_log.h. I've searched for resolutions but
 only found really old stuff from 2008 that said update your repo -
 since I did the git clone about 10m ago, I find it hard to believe
 that will help ;-)
 
 How about installing the necessary libs and headers?
 I think it is libglue-devel on sles.
 
 
 I'm using SLED 11 SP2 x86_64
 
 Any thoughts?
 
 
 Here's a console log showing the problem:
 
 src git clone git://github.com/ClusterLabs/resource-agents
 Initialized empty Git repository in src/resource-agents/.git/
 remote: Counting objects: 51955, done.
 remote: Compressing objects: 100% (17607/17607), done.
 remote: Total 51955 (delta 33814), reused 51773 (delta 33639)
 Receiving objects: 100% (51955/51955), 30.10 MiB | 74 KiB/s, done.
 Resolving deltas: 100% (33814/33814), done.
 
 src cd resource-agents
 
 src/resource-agents ./autogen.sh 
 autoreconf: Entering directory `.'
 autoreconf: configure.ac: not using Gettext
 autoreconf: running: aclocal 
 autoreconf: configure.ac: tracing
 autoreconf: configure.ac: not using Libtool
 autoreconf: running: /usr/bin/autoconf
 autoreconf: running: /usr/bin/autoheader
 autoreconf: running: automake --add-missing --copy --no-force
 configure.ac:82: installing `./compile'
 configure.ac:33: installing `./config.guess'
 configure.ac:33: installing `./config.sub'
 configure.ac:63: installing `./install-sh'
 configure.ac:63: installing `./missing'
 heartbeat/Makefile.am: installing `./depcomp'
 autoreconf: Leaving directory `.'
 Now run ./configure and make
 
 src/resource-agents ./configure
 checking for gcc... gcc
 checking for C compiler default output file name... a.out
 checking whether the C compiler works... yes
 SNIP lots of configure output that looks completely normal 
   CFLAGS   = -g -O2 -ggdb3  -fgnu89-inline 
 -fstack-protector-all 
 -Wall -Wbad-function-cast -Wcast-qual -Wcast-align 
 -Wdeclaration-after-statement 
 -Wendif-labels -Wfloat-equal -Wformat=2 -Wformat-security -Wformat-nonliteral 
 -Winline -Wmissing-prototypes -Wmissing-declarations 
 -Wmissing-format-attribute 
 -Wnested-externs -Wno-long-long -Wno-strict-aliasing -Wpointer-arith 
 -Wstrict-prototypes -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror
   Libraries=  -lglib-2.0  
   Stack Libraries  = 
 
 src/resource-agents make
 echo 3.9.3.25-f2d0  .version-t  mv .version-t .version
 gmake  all-recursive
 gmake[1]: Entering directory 
 `/home/dcorlette/src/siem/content/tools/HA/resource-agents'
  SNIP various subdirectory builds that all appear completely normal 
 Making all in heartbeat
 gmake[2]: Entering directory 
 `/home/dcorlette/src/siem/content/tools/HA/resource-agents/heartbeat'
 gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../include -I../include -I../linux-ha  
 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include-g -O2 -ggdb3  
 -fgnu89-inline -fstack-protector-all -Wall -Wbad-function-cast -Wcast-qual 
 -Wcast-align -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal 
 -Wformat=2 
 -Wformat-security -Wformat-nonliteral -Winline -Wmissing-prototypes 
 -Wmissing-declarations -Wmissing-format-attribute -Wnested-externs 
 -Wno-long-long 
 -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes -Wwrite-strings 
 -ansi 
 -D_GNU_SOURCE -DANSI_ONLY -Werror -MT IPv6addr.o -MD -MP -MF 
 .deps/IPv6addr.Tpo -c 
 -o IPv6addr.o IPv6addr.c
 IPv6addr.c:106:31: error: clplumbing/cl_log.h: No such file or directory
 cc1: warnings being treated as errors
 IPv6addr.c: In function *main*:
 IPv6addr.c:207: error: implicit declaration of function *cl_log_set_entity*
 IPv6addr.c:207: error: nested extern declaration of *cl_log_set_entity*
 IPv6addr.c:208: error: implicit declaration of function 
 *cl_log_set_facility*
 IPv6addr.c:208: error: nested extern declaration of *cl_log_set_facility*
 IPv6addr.c:219: error: implicit declaration of function *cl_log*
 IPv6addr.c:219: error: nested extern declaration of *cl_log*
 IPv6addr.c: In function *scan_if*:
 IPv6addr.c:548: error: *gboolean* undeclared (first use in this function)
 IPv6addr.c:548: error: (Each 

Re: [Linux-HA] resource-agents build fails with error about cl_log.h

2012-07-31 Thread Lars Ellenberg
On Tue, Jul 31, 2012 at 12:10:19PM -0600, David Corlette wrote:
 That did the trick, thanks!
 
 Two suggestions:
 - Shouldn't the configure script check for the presence of libglue (or the 
 underlying libraries) and complain if they're not there?

Possibly.
Send a patch?

 - It would be great if the dependencies were listed on the webpage I pointed 
 to below.

They are listed in the spec file...
You should have tried to build the package,
rpmbuild would have told you ;-)

BTW,
on debian, it would be a matter of apt-get build-dep $package,
I think the yum equivalent would be yum-builddep $package.
Not sure about rug/zypper/whatnot.

 I'd make those changes myself, but I'm not really qualified/have permissions.
 
  On 31.07.2012 at 11:56, in message 20120731155622.GS29767@soda.linbit, 
  Lars
 Ellenberg lars.ellenb...@linbit.com wrote: 
  On Fri, Jul 27, 2012 at 01:26:08PM -0600, David Corlette wrote:
  Hi folks,
  
  I'm working on a Resource Agent for one of our products, and am thinking 
  about submitting some fixes back to the upstream repository. I'm following 
  the instructions here:
  http://www.linux-ha.org/doc/dev-guides/_submitting_resource_agents.html
  but am running into a problem. Basically, when I try to 'make', I get
  an error about clplumbing/cl_log.h. I've searched for resolutions but
  only found really old stuff from 2008 that said update your repo -
  since I did the git clone about 10m ago, I find it hard to believe
  that will help ;-)
  
  How about installing the necessary libs and headers?
  I think it is libglue-devel on sles.
  
  
  I'm using SLED 11 SP2 x86_64
  
  Any thoughts?
  
  
  Here's a console log showing the problem:
  
  src git clone git://github.com/ClusterLabs/resource-agents
  Initialized empty Git repository in src/resource-agents/.git/
  remote: Counting objects: 51955, done.
  remote: Compressing objects: 100% (17607/17607), done.
  remote: Total 51955 (delta 33814), reused 51773 (delta 33639)
  Receiving objects: 100% (51955/51955), 30.10 MiB | 74 KiB/s, done.
  Resolving deltas: 100% (33814/33814), done.
  
  src cd resource-agents
  
  src/resource-agents ./autogen.sh 
  autoreconf: Entering directory `.'
  autoreconf: configure.ac: not using Gettext
  autoreconf: running: aclocal 
  autoreconf: configure.ac: tracing
  autoreconf: configure.ac: not using Libtool
  autoreconf: running: /usr/bin/autoconf
  autoreconf: running: /usr/bin/autoheader
  autoreconf: running: automake --add-missing --copy --no-force
  configure.ac:82: installing `./compile'
  configure.ac:33: installing `./config.guess'
  configure.ac:33: installing `./config.sub'
  configure.ac:63: installing `./install-sh'
  configure.ac:63: installing `./missing'
  heartbeat/Makefile.am: installing `./depcomp'
  autoreconf: Leaving directory `.'
  Now run ./configure and make
  
  src/resource-agents ./configure
  checking for gcc... gcc
  checking for C compiler default output file name... a.out
  checking whether the C compiler works... yes
  SNIP lots of configure output that looks completely normal 
CFLAGS   = -g -O2 -ggdb3  -fgnu89-inline 
  -fstack-protector-all 
  -Wall -Wbad-function-cast -Wcast-qual -Wcast-align 
  -Wdeclaration-after-statement 
  -Wendif-labels -Wfloat-equal -Wformat=2 -Wformat-security 
  -Wformat-nonliteral 
  -Winline -Wmissing-prototypes -Wmissing-declarations 
  -Wmissing-format-attribute 
  -Wnested-externs -Wno-long-long -Wno-strict-aliasing -Wpointer-arith 
  -Wstrict-prototypes -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror
Libraries=  -lglib-2.0  
Stack Libraries  = 
  
  src/resource-agents make
  echo 3.9.3.25-f2d0  .version-t  mv .version-t .version
  gmake  all-recursive
  gmake[1]: Entering directory 
  `/home/dcorlette/src/siem/content/tools/HA/resource-agents'
   SNIP various subdirectory builds that all appear completely normal 
  
  Making all in heartbeat
  gmake[2]: Entering directory 
  `/home/dcorlette/src/siem/content/tools/HA/resource-agents/heartbeat'
  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../include -I../include -I../linux-ha 
   
  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include-g -O2 -ggdb3  
  -fgnu89-inline -fstack-protector-all -Wall -Wbad-function-cast -Wcast-qual 
  -Wcast-align -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal 
  -Wformat=2 
  -Wformat-security -Wformat-nonliteral -Winline -Wmissing-prototypes 
  -Wmissing-declarations -Wmissing-format-attribute -Wnested-externs 
  -Wno-long-long 
  -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes -Wwrite-strings 
  -ansi 
  -D_GNU_SOURCE -DANSI_ONLY -Werror -MT IPv6addr.o -MD -MP -MF 
  .deps/IPv6addr.Tpo -c 
  -o IPv6addr.o IPv6addr.c
  IPv6addr.c:106:31: error: clplumbing/cl_log.h: No such file or directory
  cc1: warnings being treated as errors
  IPv6addr.c: In function *main*:
  IPv6addr.c:207: error: implicit declaration of function *cl_log_set_entity*
  IPv6addr.c:207: