Re: [PATCH] ide/amd74xx: fix section references
On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote: ide/pci/amd74xx: data structs point to __init text which should be __devinit; unless (a) these are going away real soon, or (b) this just can't happen, isn't a real problem, or (c) other ? This is a problem in most of the IDE PCI drivers. It is a problem if IDE hotplug is to be expected, and shouldn't be causing any immediate harm if IDE controllers can't be hotplugged. AMD74xx certainly can't. However, I believe it's correct to fix that. Some time ago hch made a patch fixing all IDE PCI drivers. It was queued to be merged after hotplug support is added but may be merged earlier if needed (to kill sparse warnings?). - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide/amd74xx: fix section references
Bartlomiej Zolnierkiewicz wrote: On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote: ide/pci/amd74xx: data structs point to __init text which should be __devinit; unless (a) these are going away real soon, or (b) this just can't happen, isn't a real problem, or (c) other ? This is a problem in most of the IDE PCI drivers. It is a problem if IDE hotplug is to be expected, and shouldn't be causing any immediate harm if IDE controllers can't be hotplugged. AMD74xx certainly can't. Yes, I have a list of other offenders, I just wanted to get comments first. However, I believe it's correct to fix that. Some time ago hch made a patch fixing all IDE PCI drivers. It was queued to be merged after hotplug support is added but may be merged earlier if needed (to kill sparse warnings?). So I don't need to fix the remaining offenders, right? -- ~Randy - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide/amd74xx: fix section references
On Fri, 04 Mar 2005 07:33:20 -0800, Randy.Dunlap [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote: ide/pci/amd74xx: data structs point to __init text which should be __devinit; unless (a) these are going away real soon, or (b) this just can't happen, isn't a real problem, or (c) other ? This is a problem in most of the IDE PCI drivers. It is a problem if IDE hotplug is to be expected, and shouldn't be causing any immediate harm if IDE controllers can't be hotplugged. AMD74xx certainly can't. Yes, I have a list of other offenders, I just wanted to get comments first. However, I believe it's correct to fix that. Some time ago hch made a patch fixing all IDE PCI drivers. It was queued to be merged after hotplug support is added but may be merged earlier if needed (to kill sparse warnings?). So I don't need to fix the remaining offenders, right? Yep, I'll apply patch from hch. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ide/amd74xx: fix section references
ide/pci/amd74xx: data structs point to __init text which should be
__devinit;
unless (a) these are going away real soon,
or (b) this just can't happen, isn't a real problem,
or (c) other ?
Error: ./drivers/ide/pci/amd74xx.o .data refers to 04d8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 04e8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0538 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0548 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0598 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 05a8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 05f8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0608 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0658 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0668 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 06b8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 06c8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0718 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0728 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0778 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0788 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 07d8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 07e8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0838 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0848 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0898 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 08a8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 08f8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0908 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0958 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0968 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 09b8 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 09c8 R_X86_64_64
.init.text
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0a18 R_X86_64_64
.init.text+0x0106
Error: ./drivers/ide/pci/amd74xx.o .data refers to 0a28 R_X86_64_64
.init.text
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
diffstat:=
drivers/ide/pci/amd74xx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./drivers/ide/pci/amd74xx.c~ide_amd_sections
./drivers/ide/pci/amd74xx.c
--- ./drivers/ide/pci/amd74xx.c~ide_amd_sections2005-03-01
23:38:33.0 -0800
+++ ./drivers/ide/pci/amd74xx.c 2005-03-03 15:39:21.0 -0800
@@ -308,7 +308,7 @@ static int amd74xx_ide_dma_check(ide_dri
* and initialize its drive independent registers.
*/
-static unsigned int __init init_chipset_amd74xx(struct pci_dev *dev, const
char *name)
+static unsigned int __devinit init_chipset_amd74xx(struct pci_dev *dev, const
char *name)
{
unsigned char t;
unsigned int u;
@@ -412,7 +412,7 @@ static unsigned int __init init_chipset_
return dev-irq;
}
-static void __init init_hwif_amd74xx(ide_hwif_t *hwif)
+static void __devinit init_hwif_amd74xx(ide_hwif_t *hwif)
{
int i;
---
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
