Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-29 Thread Sergei Shtylyov 

Hello, I wrote:


Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]



Acked-by: Sergei Shtylyov [EMAIL PROTECTED]


   Oh, sorry for the dupe ack's... :-
   I'd just noticed that I didn't ack the amd74xx patch, so thought I hadn't 
ack'ed all the series.


MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-29 Thread Sergei Shtylyov 

Bartlomiej Zolnierkiewicz wrote:

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]


Acked-by: Sergei Shtylyov [EMAIL PROTECTED]

MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-28 Thread Bartlomiej Zolnierkiewicz 
On Thursday 26 July 2007, Sergei Shtylyov wrote:
 Bartlomiej Zolnierkiewicz wrote:
 
  Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
 
 Acked-by: Sergei Shtylyov [EMAIL PROTECTED]

added
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-26 Thread Sergei Shtylyov 

Bartlomiej Zolnierkiewicz wrote:


Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]


Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-26 Thread Bartlomiej Zolnierkiewicz 

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
 drivers/ide/pci/pdc202xx_new.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/drivers/ide/pci/pdc202xx_new.c
===
--- a/drivers/ide/pci/pdc202xx_new.c
+++ b/drivers/ide/pci/pdc202xx_new.c
@@ -150,13 +150,13 @@ static int pdcnew_tune_chipset(ide_drive
 {
ide_hwif_t *hwif= HWIF(drive);
u8 adj  = (drive-dn  1) ? 0x08 : 0x00;
-   int err;
 
/*
 * Issue SETFEATURES_XFER to the drive first. PDC202xx hardware will
 * automatically set the timing registers based on 100 MHz PLL output.
 */
-   err = ide_config_drive_speed(drive, speed);
+   if (ide_config_drive_speed(drive, speed))
+   return 1;
 
/*
 * As we set up the PLL to output 133 MHz for UltraDMA/133 capable
@@ -212,7 +212,7 @@ static int pdcnew_tune_chipset(ide_drive
set_indexed_reg(hwif, 0x10 + adj, tmp  0x7f);
}
 
-   return err;
+   return 0;
 }
 
 static void pdcnew_set_pio_mode(ide_drive_t *drive, const u8 pio)
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html