Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
Hello Arnd, On Sun, Nov 25, 2018 at 7:48 PM Arnd Bergmann wrote: > On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador > wrote: > > > > On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann wrote: > > > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador > > > wrote: > > > > > > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > > > > selected by the Kconfig logic. This is done in preparation to making > > > > further changes to this defconfig cleaner. > > > > > > > > > > Does this mean we no longer get the unwinder, or there is some other > > > config (which?) that unconditionally selects it? > > > > It is selected. Before changing the defconfig I did a savedefconfig to > > avoid unrelated changes to be included on the subsequent patches and > > then I found it was now selected. > > Ok, then please mention in the changelog which other option selects it, > as I said. > > Aside from that, your series looks fine to me. Thank you for reviewing it. I sent a v3 mentioning it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
Hello Arnd, On Sun, Nov 25, 2018 at 7:48 PM Arnd Bergmann wrote: > On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador > wrote: > > > > On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann wrote: > > > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador > > > wrote: > > > > > > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > > > > selected by the Kconfig logic. This is done in preparation to making > > > > further changes to this defconfig cleaner. > > > > > > > > > > Does this mean we no longer get the unwinder, or there is some other > > > config (which?) that unconditionally selects it? > > > > It is selected. Before changing the defconfig I did a savedefconfig to > > avoid unrelated changes to be included on the subsequent patches and > > then I found it was now selected. > > Ok, then please mention in the changelog which other option selects it, > as I said. > > Aside from that, your series looks fine to me. Thank you for reviewing it. I sent a v3 mentioning it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
[PATCH v3 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v3: None Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.2
[PATCH v3 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v3: None Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.2
[PATCH v3 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v3: None Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.2
[PATCH v3 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v3: None Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.2
[PATCH v3 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by ARM EABI (AEBI) support. This is done in preparation to making further changes to this defconfig cleaner. Reviewed-by: Fabio Estevam Signed-off-by: Otavio Salvador --- Changes in v3: - mention it is enabled by ARM EABI support (Arnd Bergmann) Changes in v2: - rework commit log (Fabio Estevam) arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.2
[PATCH v3 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by ARM EABI (AEBI) support. This is done in preparation to making further changes to this defconfig cleaner. Reviewed-by: Fabio Estevam Signed-off-by: Otavio Salvador --- Changes in v3: - mention it is enabled by ARM EABI support (Arnd Bergmann) Changes in v2: - rework commit log (Fabio Estevam) arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.2
Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann wrote: > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador > wrote: > > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > > selected by the Kconfig logic. This is done in preparation to making > > further changes to this defconfig cleaner. > > > > Does this mean we no longer get the unwinder, or there is some other > config (which?) that unconditionally selects it? It is selected. Before changing the defconfig I did a savedefconfig to avoid unrelated changes to be included on the subsequent patches and then I found it was now selected. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann wrote: > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador > wrote: > > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > > selected by the Kconfig logic. This is done in preparation to making > > further changes to this defconfig cleaner. > > > > Does this mean we no longer get the unwinder, or there is some other > config (which?) that unconditionally selects it? It is selected. Before changing the defconfig I did a savedefconfig to avoid unrelated changes to be included on the subsequent patches and then I found it was now selected. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
[PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. Reviewed-by: Fabio Estevam Signed-off-by: Otavio Salvador --- Changes in v2: - rework commit log (Fabio Estevam) arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.1
[PATCH v2 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.1
[PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.1
[PATCH v2 1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. Reviewed-by: Fabio Estevam Signed-off-by: Otavio Salvador --- Changes in v2: - rework commit log (Fabio Estevam) arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.1
[PATCH v2 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.1
[PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Reviewed-by: Fabio Estevam Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- Changes in v2: None arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.1
[PATCH 11/13] ARM: dts: rv1108: Add internal timer support
Add support for the internal timer peripheral on RV1108.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 7ef6d965871c..42566adadc83 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -291,6 +291,14 @@
};
};
+ timer: timer@1035 {
+ compatible = "rockchip,rv1108-timer", "rockchip,rk3288-timer";
+ reg = <0x1035 0x20>;
+ interrupts = ;
+ clocks = <>, < PCLK_TIMER>;
+ clock-names = "timer", "pclk";
+ };
+
watchdog: wdt@1036 {
compatible = "snps,dw-wdt";
reg = <0x1036 0x100>;
--
2.19.1
[PATCH 12/13] ARM: dts: rv1108: Pass the 'arm,cpu-registers-not-fw-configured' property
Since firmware does not initialize any of the generic timer CPU
registers pass the 'arm,cpu-registers-not-fw-configured' property as
suggested in Documentation/devicetree/bindings/timer/arm,arch_timer.txt.
This also aligns with other Rockchip SoC dtsi files.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 42566adadc83..d96c58728b28 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -71,6 +71,7 @@
timer {
compatible = "arm,armv7-timer";
+ arm,cpu-registers-not-fw-configured;
interrupts = ,
;
clock-frequency = <2400>;
--
2.19.1
[PATCH 11/13] ARM: dts: rv1108: Add internal timer support
Add support for the internal timer peripheral on RV1108.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 7ef6d965871c..42566adadc83 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -291,6 +291,14 @@
};
};
+ timer: timer@1035 {
+ compatible = "rockchip,rv1108-timer", "rockchip,rk3288-timer";
+ reg = <0x1035 0x20>;
+ interrupts = ;
+ clocks = <>, < PCLK_TIMER>;
+ clock-names = "timer", "pclk";
+ };
+
watchdog: wdt@1036 {
compatible = "snps,dw-wdt";
reg = <0x1036 0x100>;
--
2.19.1
[PATCH 12/13] ARM: dts: rv1108: Pass the 'arm,cpu-registers-not-fw-configured' property
Since firmware does not initialize any of the generic timer CPU
registers pass the 'arm,cpu-registers-not-fw-configured' property as
suggested in Documentation/devicetree/bindings/timer/arm,arch_timer.txt.
This also aligns with other Rockchip SoC dtsi files.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 42566adadc83..d96c58728b28 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -71,6 +71,7 @@
timer {
compatible = "arm,armv7-timer";
+ arm,cpu-registers-not-fw-configured;
interrupts = ,
;
clock-frequency = <2400>;
--
2.19.1
[PATCH 13/13] ARM: dts: rv1108: Pass the 'clock-latency' property
Like it is done on cpu nodes of other Rockchip SoCs, pass the 'clock-latency' property to the CPU node, so that cpufreq driver can take the latency into account when switching frequencies. Signed-off-by: Otavio Salvador --- arch/arm/boot/dts/rv1108.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index d96c58728b28..4e1ca13a1636 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -36,6 +36,7 @@ #cooling-cells = <2>; /* min followed by max */ dynamic-power-coefficient = <75>; operating-points-v2 = <_opp_table>; + clock-latency = <4>; }; }; -- 2.19.1
[PATCH 13/13] ARM: dts: rv1108: Pass the 'clock-latency' property
Like it is done on cpu nodes of other Rockchip SoCs, pass the 'clock-latency' property to the CPU node, so that cpufreq driver can take the latency into account when switching frequencies. Signed-off-by: Otavio Salvador --- arch/arm/boot/dts/rv1108.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index d96c58728b28..4e1ca13a1636 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -36,6 +36,7 @@ #cooling-cells = <2>; /* min followed by max */ dynamic-power-coefficient = <75>; operating-points-v2 = <_opp_table>; + clock-latency = <4>; }; }; -- 2.19.1
[PATCH 09/13] ARM: dts: rv1108: Assign the proper GPIO clocks
It is not correct to assign the 24MHz clock oscillator to the GPIO ports. Fix it by assigning the proper GPIO clocks instead. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- arch/arm/boot/dts/rv1108.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index 442b749eb2e9..ce5509c4657b 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -562,7 +562,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x2003 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO0_PMU>; gpio-controller; #gpio-cells = <2>; @@ -575,7 +575,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1031 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO1>; gpio-controller; #gpio-cells = <2>; @@ -588,7 +588,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1032 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO2>; gpio-controller; #gpio-cells = <2>; @@ -601,7 +601,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1033 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO3>; gpio-controller; #gpio-cells = <2>; -- 2.19.1
[PATCH 10/13] ARM: dts: rv1108: Add UART DMA support
Pass the 'dmas' property to the UART ports so that DMA can be supported. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- arch/arm/boot/dts/rv1108.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index ce5509c4657b..7ef6d965871c 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -114,6 +114,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 6>, < 7>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART2>, < PCLK_UART2>; clock-names = "baudclk", "apb_pclk"; @@ -128,6 +130,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 4>, < 5>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART1>, < PCLK_UART1>; clock-names = "baudclk", "apb_pclk"; @@ -142,6 +146,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 2>, < 3>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART0>, < PCLK_UART0>; clock-names = "baudclk", "apb_pclk"; -- 2.19.1
[PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number
According to the Rockchip vendor tree the PMU interrupt number is
76, so fix it accordingly.
Signed-off-by: Otavio Salvador
Signed-off-by: Fabio Berton
---
arch/arm/boot/dts/rv1108.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 7b331766120d..442b749eb2e9 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -66,7 +66,7 @@
arm-pmu {
compatible = "arm,cortex-a7-pmu";
- interrupts = ;
+ interrupts = ;
};
timer {
--
2.19.1
[PATCH 09/13] ARM: dts: rv1108: Assign the proper GPIO clocks
It is not correct to assign the 24MHz clock oscillator to the GPIO ports. Fix it by assigning the proper GPIO clocks instead. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- arch/arm/boot/dts/rv1108.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index 442b749eb2e9..ce5509c4657b 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -562,7 +562,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x2003 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO0_PMU>; gpio-controller; #gpio-cells = <2>; @@ -575,7 +575,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1031 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO1>; gpio-controller; #gpio-cells = <2>; @@ -588,7 +588,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1032 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO2>; gpio-controller; #gpio-cells = <2>; @@ -601,7 +601,7 @@ compatible = "rockchip,gpio-bank"; reg = <0x1033 0x100>; interrupts = ; - clocks = <>; + clocks = < PCLK_GPIO3>; gpio-controller; #gpio-cells = <2>; -- 2.19.1
[PATCH 10/13] ARM: dts: rv1108: Add UART DMA support
Pass the 'dmas' property to the UART ports so that DMA can be supported. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- arch/arm/boot/dts/rv1108.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi index ce5509c4657b..7ef6d965871c 100644 --- a/arch/arm/boot/dts/rv1108.dtsi +++ b/arch/arm/boot/dts/rv1108.dtsi @@ -114,6 +114,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 6>, < 7>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART2>, < PCLK_UART2>; clock-names = "baudclk", "apb_pclk"; @@ -128,6 +130,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 4>, < 5>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART1>, < PCLK_UART1>; clock-names = "baudclk", "apb_pclk"; @@ -142,6 +146,8 @@ interrupts = ; reg-shift = <2>; reg-io-width = <4>; + dmas = < 2>, < 3>; + #dma-cells = <2>; clock-frequency = <2400>; clocks = < SCLK_UART0>, < PCLK_UART0>; clock-names = "baudclk", "apb_pclk"; -- 2.19.1
[PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number
According to the Rockchip vendor tree the PMU interrupt number is
76, so fix it accordingly.
Signed-off-by: Otavio Salvador
Signed-off-by: Fabio Berton
---
arch/arm/boot/dts/rv1108.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 7b331766120d..442b749eb2e9 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -66,7 +66,7 @@
arm-pmu {
compatible = "arm,cortex-a7-pmu";
- interrupts = ;
+ interrupts = ;
};
timer {
--
2.19.1
[PATCH 07/13] ARM: dts: rv1108: Fix the timer mask
As done in the Rockchip vendor tree and also on other
"arm,armv7-timer" instances, the correct GIC_CPU_MASK_SIMPLE mask
is 4 instead of 1.
Signed-off-by: Otavio Salvador
Signed-off-by: Fabio Berton
---
arch/arm/boot/dts/rv1108.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index c7a26f82655b..7b331766120d 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -71,8 +71,8 @@
timer {
compatible = "arm,armv7-timer";
- interrupts = ,
-;
+ interrupts = ,
+;
clock-frequency = <2400>;
};
--
2.19.1
[PATCH 07/13] ARM: dts: rv1108: Fix the timer mask
As done in the Rockchip vendor tree and also on other
"arm,armv7-timer" instances, the correct GIC_CPU_MASK_SIMPLE mask
is 4 instead of 1.
Signed-off-by: Otavio Salvador
Signed-off-by: Fabio Berton
---
arch/arm/boot/dts/rv1108.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index c7a26f82655b..7b331766120d 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -71,8 +71,8 @@
timer {
compatible = "arm,armv7-timer";
- interrupts = ,
-;
+ interrupts = ,
+;
clock-frequency = <2400>;
};
--
2.19.1
[PATCH 03/13] net: stmmac: dwmac-rk: Allow the driver to probe when phy-supply is not present
The phy-supply is an optional regulator, so we should not treat
as an error when phy-supply is not passed in the device tree.
This allows the dwmac-rk driver to probe when phy-supply is not
present in the dts.
Signed-off-by: Otavio Salvador
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 7b923362ee55..73855622445b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -1205,7 +1205,7 @@ static int phy_power_on(struct rk_priv_data *bsp_priv,
bool enable)
if (!ldo) {
dev_err(dev, "no regulator found\n");
- return -1;
+ return 0;
}
if (enable) {
--
2.19.1
[PATCH 03/13] net: stmmac: dwmac-rk: Allow the driver to probe when phy-supply is not present
The phy-supply is an optional regulator, so we should not treat
as an error when phy-supply is not passed in the device tree.
This allows the dwmac-rk driver to probe when phy-supply is not
present in the dts.
Signed-off-by: Otavio Salvador
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 7b923362ee55..73855622445b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -1205,7 +1205,7 @@ static int phy_power_on(struct rk_priv_data *bsp_priv,
bool enable)
if (!ldo) {
dev_err(dev, "no regulator found\n");
- return -1;
+ return 0;
}
if (enable) {
--
2.19.1
[PATCH 06/13] ARM: dts: rv1108: Add GMAC support
Add GMAC support for RV1108.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 36 +++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 4f4275599f7a..c7a26f82655b 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -516,6 +516,27 @@
status = "disabled";
};
+ gmac: eth@3020 {
+ compatible = "rockchip,rv1108-gmac";
+ reg = <0x3020 0x1>;
+ rockchip,grf = <>;
+ interrupts = ,
+;
+ interrupt-names = "macirq", "eth_wake_irq";
+ clocks = < SCLK_MAC>,
+ < SCLK_MAC_RX>, < SCLK_MAC_RX>,
+ < SCLK_MAC_REF>, < SCLK_MAC_REFOUT>,
+ < ACLK_GMAC>, < PCLK_GMAC>;
+ clock-names = "stmmaceth",
+ "mac_clk_rx", "mac_clk_tx",
+ "clk_mac_ref", "clk_mac_refout",
+ "aclk_mac", "pclk_mac";
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <_pins>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@3201 {
compatible = "arm,gic-400";
interrupt-controller;
@@ -641,6 +662,21 @@
input-enable;
};
+ gmac {
+ rmii_pins: rmii-pins {
+ rockchip,pins = <1 RK_PC5 RK_FUNC_2
_pull_none>,
+ <1 RK_PC3 RK_FUNC_2
_pull_none>,
+ <1 RK_PC4 RK_FUNC_2
_pull_none>,
+ <1 RK_PB2 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB3 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB4 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB5 RK_FUNC_3
_pull_none>,
+ <1 RK_PB6 RK_FUNC_3
_pull_none>,
+ <1 RK_PB7 RK_FUNC_3
_pull_none>,
+ <1 RK_PC2 RK_FUNC_3
_pull_none>;
+ };
+ };
+
i2c0 {
i2c0_xfer: i2c0-xfer {
rockchip,pins = <0 RK_PB1 RK_FUNC_1
_pull_none_smt>,
--
2.19.1
[PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options
From: Fabio Berton Signed-off-by: Fabio Berton Signed-off-by: Otavio Salvador --- arch/arm/configs/multi_v7_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index a8ec309d182a..34c8a745d951 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -2,7 +2,12 @@ CONFIG_SYSVIPC=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_CGROUPS=y +CONFIG_CGROUP_BPF=y +CONFIG_NAMESPACES=y +CONFIG_USER_NS=y +CONFIG_CHECKPOINT_RESTORE=y CONFIG_BLK_DEV_INITRD=y +CONFIG_BPF_SYSCALL=y CONFIG_EMBEDDED=y CONFIG_PERF_EVENTS=y CONFIG_MODULES=y -- 2.19.1
[PATCH 06/13] ARM: dts: rv1108: Add GMAC support
Add GMAC support for RV1108.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108.dtsi | 36 +++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 4f4275599f7a..c7a26f82655b 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -516,6 +516,27 @@
status = "disabled";
};
+ gmac: eth@3020 {
+ compatible = "rockchip,rv1108-gmac";
+ reg = <0x3020 0x1>;
+ rockchip,grf = <>;
+ interrupts = ,
+;
+ interrupt-names = "macirq", "eth_wake_irq";
+ clocks = < SCLK_MAC>,
+ < SCLK_MAC_RX>, < SCLK_MAC_RX>,
+ < SCLK_MAC_REF>, < SCLK_MAC_REFOUT>,
+ < ACLK_GMAC>, < PCLK_GMAC>;
+ clock-names = "stmmaceth",
+ "mac_clk_rx", "mac_clk_tx",
+ "clk_mac_ref", "clk_mac_refout",
+ "aclk_mac", "pclk_mac";
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <_pins>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@3201 {
compatible = "arm,gic-400";
interrupt-controller;
@@ -641,6 +662,21 @@
input-enable;
};
+ gmac {
+ rmii_pins: rmii-pins {
+ rockchip,pins = <1 RK_PC5 RK_FUNC_2
_pull_none>,
+ <1 RK_PC3 RK_FUNC_2
_pull_none>,
+ <1 RK_PC4 RK_FUNC_2
_pull_none>,
+ <1 RK_PB2 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB3 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB4 RK_FUNC_3
_pull_none_drv_12ma>,
+ <1 RK_PB5 RK_FUNC_3
_pull_none>,
+ <1 RK_PB6 RK_FUNC_3
_pull_none>,
+ <1 RK_PB7 RK_FUNC_3
_pull_none>,
+ <1 RK_PC2 RK_FUNC_3
_pull_none>;
+ };
+ };
+
i2c0 {
i2c0_xfer: i2c0-xfer {
rockchip,pins = <0 RK_PB1 RK_FUNC_1
_pull_none_smt>,
--
2.19.1
[PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options
From: Fabio Berton Signed-off-by: Fabio Berton Signed-off-by: Otavio Salvador --- arch/arm/configs/multi_v7_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index a8ec309d182a..34c8a745d951 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -2,7 +2,12 @@ CONFIG_SYSVIPC=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_CGROUPS=y +CONFIG_CGROUP_BPF=y +CONFIG_NAMESPACES=y +CONFIG_USER_NS=y +CONFIG_CHECKPOINT_RESTORE=y CONFIG_BLK_DEV_INITRD=y +CONFIG_BPF_SYSCALL=y CONFIG_EMBEDDED=y CONFIG_PERF_EVENTS=y CONFIG_MODULES=y -- 2.19.1
[PATCH 01/13] ARM: multi_v7_defconfig: Select PHY_ROCKCHIP_INNO_USB2
Select the CONFIG_PHY_ROCKCHIP_INNO_USB2 option by default, so that USB can be functional on RV1108. Signed-off-by: Otavio Salvador --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 63af6234c1b6..a8ec309d182a 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -947,6 +947,7 @@ CONFIG_PHY_CPCAP_USB=m CONFIG_PHY_QCOM_APQ8064_SATA=m CONFIG_PHY_RCAR_GEN2=m CONFIG_PHY_ROCKCHIP_DP=m +CONFIG_PHY_ROCKCHIP_INNO_USB2=y CONFIG_PHY_ROCKCHIP_USB=y CONFIG_PHY_SAMSUNG_USB2=m CONFIG_PHY_MIPHY28LP=y -- 2.19.1
[PATCH 01/13] ARM: multi_v7_defconfig: Select PHY_ROCKCHIP_INNO_USB2
Select the CONFIG_PHY_ROCKCHIP_INNO_USB2 option by default, so that USB can be functional on RV1108. Signed-off-by: Otavio Salvador --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 63af6234c1b6..a8ec309d182a 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -947,6 +947,7 @@ CONFIG_PHY_CPCAP_USB=m CONFIG_PHY_QCOM_APQ8064_SATA=m CONFIG_PHY_RCAR_GEN2=m CONFIG_PHY_ROCKCHIP_DP=m +CONFIG_PHY_ROCKCHIP_INNO_USB2=y CONFIG_PHY_ROCKCHIP_USB=y CONFIG_PHY_SAMSUNG_USB2=m CONFIG_PHY_MIPHY28LP=y -- 2.19.1
[PATCH v2] ARM: dts: rv1108: enable eMMC support
Enable eMMC support for rv1108.dtsi as it can be used across multiple
boards.
Signed-off-by: Otavio Salvador
---
Changes in v2:
- rework evb device tree (Heiko Stuebner)
- avoid adding the evb use as it is not present on evb but
minievb (which I don't have to test) and we are using it on a custom
customer board.
arch/arm/boot/dts/rv1108.dtsi | 21 +
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index ed8f6ca52c5b..4f4275599f7a 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -734,6 +734,27 @@
};
};
+ emmc {
+ emmc_clk: emmc-clk {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_1
_pull_none_drv_8ma>;
+ };
+
+ emmc_cmd: emmc-cmd {
+ rockchip,pins = <2 RK_PB4 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_bus8: emmc-bus8 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA1 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA2 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA3 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA4 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA5 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA6 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA7 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+ };
+
sdmmc {
sdmmc_clk: sdmmc-clk {
rockchip,pins = <3 RK_PC4 RK_FUNC_1
_pull_none_drv_4ma>;
--
2.19.1
[PATCH v2] ARM: dts: rv1108: enable eMMC support
Enable eMMC support for rv1108.dtsi as it can be used across multiple
boards.
Signed-off-by: Otavio Salvador
---
Changes in v2:
- rework evb device tree (Heiko Stuebner)
- avoid adding the evb use as it is not present on evb but
minievb (which I don't have to test) and we are using it on a custom
customer board.
arch/arm/boot/dts/rv1108.dtsi | 21 +
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index ed8f6ca52c5b..4f4275599f7a 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -734,6 +734,27 @@
};
};
+ emmc {
+ emmc_clk: emmc-clk {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_1
_pull_none_drv_8ma>;
+ };
+
+ emmc_cmd: emmc-cmd {
+ rockchip,pins = <2 RK_PB4 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_bus8: emmc-bus8 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA1 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA2 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA3 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA4 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA5 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA6 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA7 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+ };
+
sdmmc {
sdmmc_clk: sdmmc-clk {
rockchip,pins = <3 RK_PC4 RK_FUNC_1
_pull_none_drv_4ma>;
--
2.19.1
Re: [PATCH] ARM: dts: rv1108-evb: enable eMMC support
Hi Heiko,
On Tue, Oct 16, 2018 at 10:09 AM Heiko Stuebner wrote:
> Am Dienstag, 9. Oktober 2018, 23:36:56 CEST schrieb Otavio Salvador:
> > Enable eMMC support for rv1108 evaluation board.
> >
> > Signed-off-by: Otavio Salvador
> > ---
> >
> > arch/arm/boot/dts/rv1108-evb.dts | 8
> > arch/arm/boot/dts/rv1108.dtsi| 29 +
> > 2 files changed, 37 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rv1108-evb.dts
> > b/arch/arm/boot/dts/rv1108-evb.dts
> > index 70f0106d1252..f3c6f52c49e6 100644
> > --- a/arch/arm/boot/dts/rv1108-evb.dts
> > +++ b/arch/arm/boot/dts/rv1108-evb.dts
> > @@ -226,6 +226,14 @@
> > status = "okay";
> > };
> >
> > + {
> > + cap-mmc-highspeed;
> > + supports-emmc;
> > + non-removable;
> > + num-slots = <1>;
>
> num-slots should not be present anymore on new additions
>
> Also missing the pinctrl settings you're defining below?
> Aka pinctrl-0 = <_*>; + pinctrl-names = "default"
Thank you, I am preparing a v2 of this patch together with few more changes.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH] ARM: dts: rv1108-evb: enable eMMC support
Hi Heiko,
On Tue, Oct 16, 2018 at 10:09 AM Heiko Stuebner wrote:
> Am Dienstag, 9. Oktober 2018, 23:36:56 CEST schrieb Otavio Salvador:
> > Enable eMMC support for rv1108 evaluation board.
> >
> > Signed-off-by: Otavio Salvador
> > ---
> >
> > arch/arm/boot/dts/rv1108-evb.dts | 8
> > arch/arm/boot/dts/rv1108.dtsi| 29 +
> > 2 files changed, 37 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rv1108-evb.dts
> > b/arch/arm/boot/dts/rv1108-evb.dts
> > index 70f0106d1252..f3c6f52c49e6 100644
> > --- a/arch/arm/boot/dts/rv1108-evb.dts
> > +++ b/arch/arm/boot/dts/rv1108-evb.dts
> > @@ -226,6 +226,14 @@
> > status = "okay";
> > };
> >
> > + {
> > + cap-mmc-highspeed;
> > + supports-emmc;
> > + non-removable;
> > + num-slots = <1>;
>
> num-slots should not be present anymore on new additions
>
> Also missing the pinctrl settings you're defining below?
> Aka pinctrl-0 = <_*>; + pinctrl-names = "default"
Thank you, I am preparing a v2 of this patch together with few more changes.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
Hello Fabio, On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam wrote: > On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador > wrote: > > > > The setting is removed when running a `savedefconfig` using the > > current setting set. It is being applied in preparation to some > > "setting set" is a bit confusing. > > > patches making changes to this defconfig. > > It would be good to mention that CONFIG_ARM_UNWIND is still selected > automatically. > > Otherwise it may give the impression that such functionality is being removed. > > You could reword the commit log to something like this: > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is > still selected by the Kconfig logic. > This is done in preparation to making further changes to this defconfig > cleaner. In fact, was removed and now selected. I changed the commit log as: ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. Do you agree? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
Hello Fabio, On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam wrote: > On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador > wrote: > > > > The setting is removed when running a `savedefconfig` using the > > current setting set. It is being applied in preparation to some > > "setting set" is a bit confusing. > > > patches making changes to this defconfig. > > It would be good to mention that CONFIG_ARM_UNWIND is still selected > automatically. > > Otherwise it may give the impression that such functionality is being removed. > > You could reword the commit log to something like this: > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is > still selected by the Kconfig logic. > This is done in preparation to making further changes to this defconfig > cleaner. In fact, was removed and now selected. I changed the commit log as: ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. Do you agree? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
[PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.1
[PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
From: Andreas Müller This is very helpful debugging USB issues. Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 22ad2d7a1cf2..d339913845fa 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y CONFIG_SND_SIMPLE_CARD=y CONFIG_HID_MULTITOUCH=y CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y CONFIG_USB_STORAGE=y -- 2.19.1
[PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.1
[PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
From: Andreas Müller This is necessary to support network over bluetooth: | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin Signed-off-by: Andreas Müller Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 0c887a059df3..22ad2d7a1cf2 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -81,6 +81,7 @@ CONFIG_NETFILTER=y CONFIG_CAN=y CONFIG_CAN_FLEXCAN=y CONFIG_BT=y +CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y CONFIG_CFG80211=y -- 2.19.1
[PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
The setting is removed when running a `savedefconfig` using the current setting set. It is being applied in preparation to some patches making changes to this defconfig. Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.1
[PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
The setting is removed when running a `savedefconfig` using the current setting set. It is being applied in preparation to some patches making changes to this defconfig. Signed-off-by: Otavio Salvador --- arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set -- 2.19.1
[PATCH] ARM: dts: rv1108-evb: enable eMMC support
Enable eMMC support for rv1108 evaluation board.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108-evb.dts | 8
arch/arm/boot/dts/rv1108.dtsi| 29 +
2 files changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 70f0106d1252..f3c6f52c49e6 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -226,6 +226,14 @@
status = "okay";
};
+ {
+ cap-mmc-highspeed;
+ supports-emmc;
+ non-removable;
+ num-slots = <1>;
+ status = "okay";
+};
+
{
status = "okay";
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 76ea24636feb..f14a733d85f6 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -772,6 +772,35 @@
};
};
+ emmc {
+ emmc_clk: emmc-clk {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_1
_pull_none_drv_8ma>;
+ };
+
+ emmc_cmd: emmc-cmd {
+ rockchip,pins = <2 RK_PB4 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_pwren: emmc-pwren {
+ rockchip,pins = <2 RK_PC2 RK_FUNC_2
_pull_none>;
+ };
+
+ emmc_bus1: emmc-bus1 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_bus8: emmc-bus8 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA1 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA2 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA3 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA4 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA5 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA6 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA7 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+ };
+
sdmmc {
sdmmc_clk: sdmmc-clk {
rockchip,pins = <3 RK_PC4 RK_FUNC_1
_pull_none_drv_4ma>;
--
2.19.0
[PATCH] ARM: dts: rv1108-evb: enable eMMC support
Enable eMMC support for rv1108 evaluation board.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/rv1108-evb.dts | 8
arch/arm/boot/dts/rv1108.dtsi| 29 +
2 files changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 70f0106d1252..f3c6f52c49e6 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -226,6 +226,14 @@
status = "okay";
};
+ {
+ cap-mmc-highspeed;
+ supports-emmc;
+ non-removable;
+ num-slots = <1>;
+ status = "okay";
+};
+
{
status = "okay";
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 76ea24636feb..f14a733d85f6 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -772,6 +772,35 @@
};
};
+ emmc {
+ emmc_clk: emmc-clk {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_1
_pull_none_drv_8ma>;
+ };
+
+ emmc_cmd: emmc-cmd {
+ rockchip,pins = <2 RK_PB4 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_pwren: emmc-pwren {
+ rockchip,pins = <2 RK_PC2 RK_FUNC_2
_pull_none>;
+ };
+
+ emmc_bus1: emmc-bus1 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+
+ emmc_bus8: emmc-bus8 {
+ rockchip,pins = <2 RK_PA0 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA1 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA2 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA3 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA4 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA5 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA6 RK_FUNC_2
_pull_up_drv_8ma>,
+ <2 RK_PA7 RK_FUNC_2
_pull_up_drv_8ma>;
+ };
+ };
+
sdmmc {
sdmmc_clk: sdmmc-clk {
rockchip,pins = <3 RK_PC4 RK_FUNC_1
_pull_none_drv_4ma>;
--
2.19.0
[PATCH v4] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
---
Changes in v4:
- drop lock flag
Changes in v3:
- use lock instead of read-only (Gary Bisson)
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..919b6b7619a4 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,23 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ };
};
};
--
2.15.0
[PATCH v4] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador
---
Changes in v4:
- drop lock flag
Changes in v3:
- use lock instead of read-only (Gary Bisson)
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..919b6b7619a4 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,23 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ };
};
};
--
2.15.0
Re: [PATCH v3] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
Hello Fabio, On Mon, Nov 27, 2017 at 2:17 PM, Fabio Estevam <feste...@gmail.com> wrote: > On Mon, Nov 27, 2017 at 11:31 AM, Otavio Salvador > <ota...@ossystems.com.br> wrote: >> This adds the partitions definition for the SPI NOR to provide >> backward compatibility with the documented[1] layout used with >> Boundary Devices BSP. >> >> 1. https://boundarydevices.com/boot-flash-access-linux/ >> >> It exports to Linux: >> >> mtd0: bootloader >> mtd1: env >> mtd2: splash >> >> Signed-off-by: Otavio Salvador <ota...@ossystems.com.br> > > Has this been tested? I mean, have you tested the locking mechanism is > really working in this SPI NOR flash? Yes, we tested it here using Linux 4.14 but didn't notice this SPI NOR does not support the lock. > As far as I can see the SPI locking mechanism does not need device > tree properties. Humm it is confusing, at least for me that am not used to the this. In any case, I think for now it is better to include the partitions without read-only and lock as it is convenient to have access to it from Linux so we adhere the same partition layout used in Boundary's Linux fork. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: [PATCH v3] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
Hello Fabio, On Mon, Nov 27, 2017 at 2:17 PM, Fabio Estevam wrote: > On Mon, Nov 27, 2017 at 11:31 AM, Otavio Salvador > wrote: >> This adds the partitions definition for the SPI NOR to provide >> backward compatibility with the documented[1] layout used with >> Boundary Devices BSP. >> >> 1. https://boundarydevices.com/boot-flash-access-linux/ >> >> It exports to Linux: >> >> mtd0: bootloader >> mtd1: env >> mtd2: splash >> >> Signed-off-by: Otavio Salvador > > Has this been tested? I mean, have you tested the locking mechanism is > really working in this SPI NOR flash? Yes, we tested it here using Linux 4.14 but didn't notice this SPI NOR does not support the lock. > As far as I can see the SPI locking mechanism does not need device > tree properties. Humm it is confusing, at least for me that am not used to the this. In any case, I think for now it is better to include the partitions without read-only and lock as it is convenient to have access to it from Linux so we adhere the same partition layout used in Boundary's Linux fork. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
[PATCH v3] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
---
Changes in v3:
- use lock instead of read-only (Gary Bisson)
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..f855d802533e 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,26 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ lock;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ lock;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ lock;
+ };
};
};
--
2.15.0
[PATCH v3] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador
---
Changes in v3:
- use lock instead of read-only (Gary Bisson)
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..f855d802533e 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,26 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ lock;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ lock;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ lock;
+ };
};
};
--
2.15.0
Re: [PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
On Mon, Nov 27, 2017 at 8:17 AM, Gary Bisson <gary.bis...@boundarydevices.com> wrote: > Hi Otavio, > > On Sat, Nov 25, 2017 at 07:55:53AM -0200, Otavio Salvador wrote: >> On Fri, Nov 24, 2017 at 3:00 PM, Otavio Salvador >> <ota...@ossystems.com.br> wrote: >> > This adds the partitions definition for the SPI NOR to provide >> > backward compatibility with the documented[1] layout used with >> > Boundary Devices BSP. >> > >> > 1. https://boundarydevices.com/boot-flash-access-linux/ >> > >> > It exports to Linux: >> > >> > mtd0: bootloader >> > mtd1: env >> > mtd2: splash >> > >> > Signed-off-by: Otavio Salvador <ota...@ossystems.com.br> >> >> After thinking a bit about Fabio's recommendation to use 'read-only' >> to protect the partitions, I think it'd be better to use 'lock' so it >> is still possible to write them on Linux but it requires a unlock >> prior changing it. >> >> In my case, I am interested in being capable of upgrading the >> bootloader from Linux. >> >> What people think? > > Agreed, I would rather have the lock option, especially for the splash > and environment. I will prepare a new patch using the lock option on the three partitions so we allow the user to change them but knowing it may break the system. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: [PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
On Mon, Nov 27, 2017 at 8:17 AM, Gary Bisson wrote: > Hi Otavio, > > On Sat, Nov 25, 2017 at 07:55:53AM -0200, Otavio Salvador wrote: >> On Fri, Nov 24, 2017 at 3:00 PM, Otavio Salvador >> wrote: >> > This adds the partitions definition for the SPI NOR to provide >> > backward compatibility with the documented[1] layout used with >> > Boundary Devices BSP. >> > >> > 1. https://boundarydevices.com/boot-flash-access-linux/ >> > >> > It exports to Linux: >> > >> > mtd0: bootloader >> > mtd1: env >> > mtd2: splash >> > >> > Signed-off-by: Otavio Salvador >> >> After thinking a bit about Fabio's recommendation to use 'read-only' >> to protect the partitions, I think it'd be better to use 'lock' so it >> is still possible to write them on Linux but it requires a unlock >> prior changing it. >> >> In my case, I am interested in being capable of upgrading the >> bootloader from Linux. >> >> What people think? > > Agreed, I would rather have the lock option, especially for the splash > and environment. I will prepare a new patch using the lock option on the three partitions so we allow the user to change them but knowing it may break the system. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: [PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
On Fri, Nov 24, 2017 at 3:00 PM, Otavio Salvador <ota...@ossystems.com.br> wrote: > This adds the partitions definition for the SPI NOR to provide > backward compatibility with the documented[1] layout used with > Boundary Devices BSP. > > 1. https://boundarydevices.com/boot-flash-access-linux/ > > It exports to Linux: > > mtd0: bootloader > mtd1: env > mtd2: splash > > Signed-off-by: Otavio Salvador <ota...@ossystems.com.br> After thinking a bit about Fabio's recommendation to use 'read-only' to protect the partitions, I think it'd be better to use 'lock' so it is still possible to write them on Linux but it requires a unlock prior changing it. In my case, I am interested in being capable of upgrading the bootloader from Linux. What people think? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: [PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
On Fri, Nov 24, 2017 at 3:00 PM, Otavio Salvador wrote: > This adds the partitions definition for the SPI NOR to provide > backward compatibility with the documented[1] layout used with > Boundary Devices BSP. > > 1. https://boundarydevices.com/boot-flash-access-linux/ > > It exports to Linux: > > mtd0: bootloader > mtd1: env > mtd2: splash > > Signed-off-by: Otavio Salvador After thinking a bit about Fabio's recommendation to use 'read-only' to protect the partitions, I think it'd be better to use 'lock' so it is still possible to write them on Linux but it requires a unlock prior changing it. In my case, I am interested in being capable of upgrading the bootloader from Linux. What people think? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
[PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
---
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..28545412577a 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,26 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ read-only;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ read-only;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ read-only;
+ };
};
};
--
2.15.0
[PATCH v2] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: bootloader
mtd1: env
mtd2: splash
Signed-off-by: Otavio Salvador
---
Changes in v2:
- rework labels (Fabio Estevam)
- add read-only flags (Fabio Estevam)
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..28545412577a 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,26 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x0 0xc>;
+ read-only;
+ };
+
+ partition@c {
+ label = "env";
+ reg = <0xc 0x2000>;
+ read-only;
+ };
+
+ partition@c2000 {
+ label = "splash";
+ reg = <0xc2000 0x13e000>;
+ read-only;
+ };
};
};
--
2.15.0
[PATCH] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: U-Boot
mtd1: U-Boot Environment
mtd2: Bootsplash
Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
---
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..f8b267875e1c 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,23 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "U-Boot";
+ reg = <0x0 0xc>;
+ };
+
+ partition@c {
+ label = "U-Boot Environment";
+ reg = <0xc 0x2000>;
+ };
+
+ partition@c2000 {
+ label = "Bootsplash";
+ reg = <0xc2000 0x13e000>;
+ };
};
};
--
2.15.0
[PATCH] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
This adds the partitions definition for the SPI NOR to provide
backward compatibility with the documented[1] layout used with
Boundary Devices BSP.
1. https://boundarydevices.com/boot-flash-access-linux/
It exports to Linux:
mtd0: U-Boot
mtd1: U-Boot Environment
mtd2: Bootsplash
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 4bdf29169d2a..f8b267875e1c 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -276,6 +276,23 @@
compatible = "sst,sst25vf016b", "jedec,spi-nor";
spi-max-frequency = <2000>;
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "U-Boot";
+ reg = <0x0 0xc>;
+ };
+
+ partition@c {
+ label = "U-Boot Environment";
+ reg = <0xc 0x2000>;
+ };
+
+ partition@c2000 {
+ label = "Bootsplash";
+ reg = <0xc2000 0x13e000>;
+ };
};
};
--
2.15.0
Re: The possible regression in kernel 4.8 - clk: imx: correct AV PLL rate formula
On Tue, Oct 11, 2016 at 3:00 PM, Fabio Estevam <feste...@gmail.com> wrote: > Hi Ken, > > On Tue, Oct 11, 2016 at 2:49 PM, Ken.Lin <ken@advantech.com> wrote: > >> With the patches applied, the pixel clock (14850 required for >> 1920x1080@60) is correct as we checked in kernel 4.7 and the actual >> measurement result looked good as we expected. >> I think the patches should fix the issue. > > That's good news. Thanks for testing. > > Emil is working on a v3 version of the patch series. > > Emil, > > Please add Ken Lin on Cc when you submit v3. And what will be done regarding 4.8? Is the faulty change to be reverted or this patches will be backported? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: The possible regression in kernel 4.8 - clk: imx: correct AV PLL rate formula
On Tue, Oct 11, 2016 at 3:00 PM, Fabio Estevam wrote: > Hi Ken, > > On Tue, Oct 11, 2016 at 2:49 PM, Ken.Lin wrote: > >> With the patches applied, the pixel clock (14850 required for >> 1920x1080@60) is correct as we checked in kernel 4.7 and the actual >> measurement result looked good as we expected. >> I think the patches should fix the issue. > > That's good news. Thanks for testing. > > Emil is working on a v3 version of the patch series. > > Emil, > > Please add Ken Lin on Cc when you submit v3. And what will be done regarding 4.8? Is the faulty change to be reverted or this patches will be backported? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
Re: [PATCH] ARM: dts: warp: Add initial WaRP Board support
Hello Shawn, On Tue, Mar 3, 2015 at 12:29 AM, Shawn Guo wrote: > On Wed, Feb 25, 2015 at 02:02:19PM -0300, Otavio Salvador wrote: >> The WaRP Board is a Wearable Reference Plaform. The board features: >> >> - Freescale i.MX6 SoloLite processor with 512MB of RAM >> - Freescale FXOS8700CQ 6-axis Xtrinsic sensor >> - Freescale Kinetis KL16 MCU >> - Freescale Xtrinsic MMA955xL intelligent motion sensing platform >> >> The board implements a hybrid architecture to address the evolving >> needs of the wearables market. The platform consists of a main board >> and an example daughtercard with the ability to add additional >> daughtercards for different usage models. >> >> For more information about the project, visit: >> >> http://www.warpboard.org/ >> >> Signed-off-by: Otavio Salvador > > Pretty neat! Only one comment about dts license below. > >> --- >> arch/arm/boot/dts/Makefile| 3 +- >> arch/arm/boot/dts/imx6sl-warp.dts | 154 >> ++ >> 2 files changed, 156 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index a1c776b..1b49d57 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ >> imx6q-wandboard.dtb \ >> imx6q-wandboard-revb1.dtb >> dtb-$(CONFIG_SOC_IMX6SL) += \ >> - imx6sl-evk.dtb >> + imx6sl-evk.dtb \ >> + imx6sl-warp.dtb >> dtb-$(CONFIG_SOC_IMX6SX) += \ >> imx6sx-sabreauto.dtb \ >> imx6sx-sdb.dtb >> diff --git a/arch/arm/boot/dts/imx6sl-warp.dts >> b/arch/arm/boot/dts/imx6sl-warp.dts >> new file mode 100644 >> index 000..dadb92f >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx6sl-warp.dts >> @@ -0,0 +1,154 @@ >> +/* >> + * Copyright 2014, 2015 O.S. Systems Software LTDA. >> + * >> + * The code contained herein is licensed under the GNU General Public >> + * License. You may obtain a copy of the GNU General Public License >> + * Version 2 or later at the following locations: >> + * >> + * http://www.opensource.org/licenses/gpl-license.html >> + * http://www.gnu.org/copyleft/gpl.html >> + */ > > It's preferred to use GPL/X11 dual license for new dts files. See > arch/arm/boot/dts/imx6q-tbs2910.dts for example. I sent a v2 changing it. Thanks for the remark :) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] ARM: dts: warp: Add initial WaRP Board support
The WaRP Board is a Wearable Reference Plaform. The board features:
- Freescale i.MX6 SoloLite processor with 512MB of RAM
- Freescale FXOS8700CQ 6-axis Xtrinsic sensor
- Freescale Kinetis KL16 MCU
- Freescale Xtrinsic MMA955xL intelligent motion sensing platform
The board implements a hybrid architecture to address the evolving
needs of the wearables market. The platform consists of a main board
and an example daughtercard with the ability to add additional
daughtercards for different usage models.
For more information about the project, visit:
http://www.warpboard.org/
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/Makefile| 3 +-
arch/arm/boot/dts/imx6sl-warp.dts | 190 ++
2 files changed, 192 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b..1b49d57 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-wandboard.dtb \
imx6q-wandboard-revb1.dtb
dtb-$(CONFIG_SOC_IMX6SL) += \
- imx6sl-evk.dtb
+ imx6sl-evk.dtb \
+ imx6sl-warp.dtb
dtb-$(CONFIG_SOC_IMX6SX) += \
imx6sx-sabreauto.dtb \
imx6sx-sdb.dtb
diff --git a/arch/arm/boot/dts/imx6sl-warp.dts
b/arch/arm/boot/dts/imx6sl-warp.dts
new file mode 100644
index 000..904efc4
--- /dev/null
+++ b/arch/arm/boot/dts/imx6sl-warp.dts
@@ -0,0 +1,190 @@
+/*
+ * Copyright 2014, 2015 O.S. Systems Software LTDA.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this file; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include "imx6sl.dtsi"
+
+/ {
+ model = "WaRP Board";
+ compatible = "warp,imx6sl-warp", "fsl,imx6sl";
+
+ memory {
+ reg = <0x8000 0x2000>;
+ };
+
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ reg_usb_otg1_vbus: regulator@0 {
+ compatible = "regulator-fixed";
+ reg = <0>;
+ regulator-name = "usb_otg1_vbus";
+ regulator-min-microvolt = <500>;
+ regulator-max-microvolt = <500>;
+ gpio = < 0 0>;
+ enable-active-high;
+ };
+
+ reg_usb_otg2_vbus: regulator@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "usb_otg2_vbus";
+ regulator-min-microvo
[PATCH v2] ARM: dts: warp: Add initial WaRP Board support
The WaRP Board is a Wearable Reference Plaform. The board features:
- Freescale i.MX6 SoloLite processor with 512MB of RAM
- Freescale FXOS8700CQ 6-axis Xtrinsic sensor
- Freescale Kinetis KL16 MCU
- Freescale Xtrinsic MMA955xL intelligent motion sensing platform
The board implements a hybrid architecture to address the evolving
needs of the wearables market. The platform consists of a main board
and an example daughtercard with the ability to add additional
daughtercards for different usage models.
For more information about the project, visit:
http://www.warpboard.org/
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
arch/arm/boot/dts/Makefile| 3 +-
arch/arm/boot/dts/imx6sl-warp.dts | 190 ++
2 files changed, 192 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b..1b49d57 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-wandboard.dtb \
imx6q-wandboard-revb1.dtb
dtb-$(CONFIG_SOC_IMX6SL) += \
- imx6sl-evk.dtb
+ imx6sl-evk.dtb \
+ imx6sl-warp.dtb
dtb-$(CONFIG_SOC_IMX6SX) += \
imx6sx-sabreauto.dtb \
imx6sx-sdb.dtb
diff --git a/arch/arm/boot/dts/imx6sl-warp.dts
b/arch/arm/boot/dts/imx6sl-warp.dts
new file mode 100644
index 000..904efc4
--- /dev/null
+++ b/arch/arm/boot/dts/imx6sl-warp.dts
@@ -0,0 +1,190 @@
+/*
+ * Copyright 2014, 2015 O.S. Systems Software LTDA.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this file; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the Software), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include imx6sl.dtsi
+
+/ {
+ model = WaRP Board;
+ compatible = warp,imx6sl-warp, fsl,imx6sl;
+
+ memory {
+ reg = 0x8000 0x2000;
+ };
+
+ regulators {
+ compatible = simple-bus;
+ #address-cells = 1;
+ #size-cells = 0;
+
+ reg_usb_otg1_vbus: regulator@0 {
+ compatible = regulator-fixed;
+ reg = 0;
+ regulator-name = usb_otg1_vbus;
+ regulator-min-microvolt = 500;
+ regulator-max-microvolt = 500;
+ gpio = gpio4 0 0;
+ enable-active-high;
+ };
+
+ reg_usb_otg2_vbus: regulator@1 {
+ compatible = regulator-fixed;
+ reg = 1;
+ regulator-name = usb_otg2_vbus;
+ regulator-min-microvolt = 500;
+ regulator-max-microvolt = 500;
+ gpio = gpio4 2 0;
+ enable-active-high;
+ };
+
+ reg_1p8v
Re: [PATCH] ARM: dts: warp: Add initial WaRP Board support
Hello Shawn, On Tue, Mar 3, 2015 at 12:29 AM, Shawn Guo shawn@linaro.org wrote: On Wed, Feb 25, 2015 at 02:02:19PM -0300, Otavio Salvador wrote: The WaRP Board is a Wearable Reference Plaform. The board features: - Freescale i.MX6 SoloLite processor with 512MB of RAM - Freescale FXOS8700CQ 6-axis Xtrinsic sensor - Freescale Kinetis KL16 MCU - Freescale Xtrinsic MMA955xL intelligent motion sensing platform The board implements a hybrid architecture to address the evolving needs of the wearables market. The platform consists of a main board and an example daughtercard with the ability to add additional daughtercards for different usage models. For more information about the project, visit: http://www.warpboard.org/ Signed-off-by: Otavio Salvador ota...@ossystems.com.br Pretty neat! Only one comment about dts license below. --- arch/arm/boot/dts/Makefile| 3 +- arch/arm/boot/dts/imx6sl-warp.dts | 154 ++ 2 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index a1c776b..1b49d57 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-wandboard.dtb \ imx6q-wandboard-revb1.dtb dtb-$(CONFIG_SOC_IMX6SL) += \ - imx6sl-evk.dtb + imx6sl-evk.dtb \ + imx6sl-warp.dtb dtb-$(CONFIG_SOC_IMX6SX) += \ imx6sx-sabreauto.dtb \ imx6sx-sdb.dtb diff --git a/arch/arm/boot/dts/imx6sl-warp.dts b/arch/arm/boot/dts/imx6sl-warp.dts new file mode 100644 index 000..dadb92f --- /dev/null +++ b/arch/arm/boot/dts/imx6sl-warp.dts @@ -0,0 +1,154 @@ +/* + * Copyright 2014, 2015 O.S. Systems Software LTDA. + * + * The code contained herein is licensed under the GNU General Public + * License. You may obtain a copy of the GNU General Public License + * Version 2 or later at the following locations: + * + * http://www.opensource.org/licenses/gpl-license.html + * http://www.gnu.org/copyleft/gpl.html + */ It's preferred to use GPL/X11 dual license for new dts files. See arch/arm/boot/dts/imx6q-tbs2910.dts for example. I sent a v2 changing it. Thanks for the remark :) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ARM: dts: warp: Add initial WaRP Board support
The WaRP Board is a Wearable Reference Plaform. The board features:
- Freescale i.MX6 SoloLite processor with 512MB of RAM
- Freescale FXOS8700CQ 6-axis Xtrinsic sensor
- Freescale Kinetis KL16 MCU
- Freescale Xtrinsic MMA955xL intelligent motion sensing platform
The board implements a hybrid architecture to address the evolving
needs of the wearables market. The platform consists of a main board
and an example daughtercard with the ability to add additional
daughtercards for different usage models.
For more information about the project, visit:
http://www.warpboard.org/
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/Makefile| 3 +-
arch/arm/boot/dts/imx6sl-warp.dts | 154 ++
2 files changed, 156 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b..1b49d57 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-wandboard.dtb \
imx6q-wandboard-revb1.dtb
dtb-$(CONFIG_SOC_IMX6SL) += \
- imx6sl-evk.dtb
+ imx6sl-evk.dtb \
+ imx6sl-warp.dtb
dtb-$(CONFIG_SOC_IMX6SX) += \
imx6sx-sabreauto.dtb \
imx6sx-sdb.dtb
diff --git a/arch/arm/boot/dts/imx6sl-warp.dts
b/arch/arm/boot/dts/imx6sl-warp.dts
new file mode 100644
index 000..dadb92f
--- /dev/null
+++ b/arch/arm/boot/dts/imx6sl-warp.dts
@@ -0,0 +1,154 @@
+/*
+ * Copyright 2014, 2015 O.S. Systems Software LTDA.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+
+#include "imx6sl.dtsi"
+
+/ {
+ model = "WaRP Board";
+ compatible = "warp,imx6sl-warp", "fsl,imx6sl";
+
+ memory {
+ reg = <0x8000 0x2000>;
+ };
+
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ reg_usb_otg1_vbus: regulator@0 {
+ compatible = "regulator-fixed";
+ reg = <0>;
+ regulator-name = "usb_otg1_vbus";
+ regulator-min-microvolt = <500>;
+ regulator-max-microvolt = <500>;
+ gpio = < 0 0>;
+ enable-active-high;
+ };
+
+ reg_usb_otg2_vbus: regulator@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "usb_otg2_vbus";
+ regulator-min-microvolt = <500>;
+ regulator-max-microvolt = <500>;
+ gpio = < 2 0>;
+ enable-active-high;
+ };
+
+ reg_1p8v: regulator@2 {
+ compatible = "regulator-fixed";
+ reg = <2>;
+ regulator-name = "1P8V";
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <180>;
+ };
+ };
+};
+
+ {
+ pinctrl-names = "default";
+ pinctrl-0 = <_uart1>;
+ status = "okay";
+};
+
+ {
+ pinctrl-names = "default";
+ pinctrl-0 = <_uart3>;
+ status = "okay";
+};
+
+ {
+ vbus-supply = <_usb_otg1_vbus>;
+ dr_mode = "host";
+ disable-over-current;
+ status = "okay";
+};
+
+ {
+ vbus-supply = <_usb_otg2_vbus>;
+ disable-over-current;
+ status = "okay";
+};
+
+ {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <_usdhc2>;
+ pinctrl-1 = <_usdhc2_100mhz>;
+ pinctrl-2 = <_usdhc2_200mhz>;
+ non-removable;
+ status = "okay";
+};
+
+ {
+ imx6sl-warp {
+ pinctrl_uart1: uart1grp {
+ fsl,pins = <
+ MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x41b0b1
+ MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x41b0b1
+ >;
+ };
+
+ pinctrl_uart3: uart3grp {
+ fsl,pins = <
+ MX6SL_PAD_AUD_RXC__UART3_RX_DATA0x41b0b1
+ MX6SL_PAD_AUD_RXC__UART3_TX_DATA0x41b0
[PATCH] ARM: dts: warp: Add initial WaRP Board support
The WaRP Board is a Wearable Reference Plaform. The board features:
- Freescale i.MX6 SoloLite processor with 512MB of RAM
- Freescale FXOS8700CQ 6-axis Xtrinsic sensor
- Freescale Kinetis KL16 MCU
- Freescale Xtrinsic MMA955xL intelligent motion sensing platform
The board implements a hybrid architecture to address the evolving
needs of the wearables market. The platform consists of a main board
and an example daughtercard with the ability to add additional
daughtercards for different usage models.
For more information about the project, visit:
http://www.warpboard.org/
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
arch/arm/boot/dts/Makefile| 3 +-
arch/arm/boot/dts/imx6sl-warp.dts | 154 ++
2 files changed, 156 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/imx6sl-warp.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b..1b49d57 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -299,7 +299,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-wandboard.dtb \
imx6q-wandboard-revb1.dtb
dtb-$(CONFIG_SOC_IMX6SL) += \
- imx6sl-evk.dtb
+ imx6sl-evk.dtb \
+ imx6sl-warp.dtb
dtb-$(CONFIG_SOC_IMX6SX) += \
imx6sx-sabreauto.dtb \
imx6sx-sdb.dtb
diff --git a/arch/arm/boot/dts/imx6sl-warp.dts
b/arch/arm/boot/dts/imx6sl-warp.dts
new file mode 100644
index 000..dadb92f
--- /dev/null
+++ b/arch/arm/boot/dts/imx6sl-warp.dts
@@ -0,0 +1,154 @@
+/*
+ * Copyright 2014, 2015 O.S. Systems Software LTDA.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+
+#include imx6sl.dtsi
+
+/ {
+ model = WaRP Board;
+ compatible = warp,imx6sl-warp, fsl,imx6sl;
+
+ memory {
+ reg = 0x8000 0x2000;
+ };
+
+ regulators {
+ compatible = simple-bus;
+ #address-cells = 1;
+ #size-cells = 0;
+
+ reg_usb_otg1_vbus: regulator@0 {
+ compatible = regulator-fixed;
+ reg = 0;
+ regulator-name = usb_otg1_vbus;
+ regulator-min-microvolt = 500;
+ regulator-max-microvolt = 500;
+ gpio = gpio4 0 0;
+ enable-active-high;
+ };
+
+ reg_usb_otg2_vbus: regulator@1 {
+ compatible = regulator-fixed;
+ reg = 1;
+ regulator-name = usb_otg2_vbus;
+ regulator-min-microvolt = 500;
+ regulator-max-microvolt = 500;
+ gpio = gpio4 2 0;
+ enable-active-high;
+ };
+
+ reg_1p8v: regulator@2 {
+ compatible = regulator-fixed;
+ reg = 2;
+ regulator-name = 1P8V;
+ regulator-min-microvolt = 180;
+ regulator-max-microvolt = 180;
+ };
+ };
+};
+
+uart1 {
+ pinctrl-names = default;
+ pinctrl-0 = pinctrl_uart1;
+ status = okay;
+};
+
+uart3 {
+ pinctrl-names = default;
+ pinctrl-0 = pinctrl_uart3;
+ status = okay;
+};
+
+usbotg1 {
+ vbus-supply = reg_usb_otg1_vbus;
+ dr_mode = host;
+ disable-over-current;
+ status = okay;
+};
+
+usbotg2 {
+ vbus-supply = reg_usb_otg2_vbus;
+ disable-over-current;
+ status = okay;
+};
+
+usdhc2 {
+ pinctrl-names = default, state_100mhz, state_200mhz;
+ pinctrl-0 = pinctrl_usdhc2;
+ pinctrl-1 = pinctrl_usdhc2_100mhz;
+ pinctrl-2 = pinctrl_usdhc2_200mhz;
+ non-removable;
+ status = okay;
+};
+
+iomuxc {
+ imx6sl-warp {
+ pinctrl_uart1: uart1grp {
+ fsl,pins =
+ MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x41b0b1
+ MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x41b0b1
+ ;
+ };
+
+ pinctrl_uart3: uart3grp {
+ fsl,pins =
+ MX6SL_PAD_AUD_RXC__UART3_RX_DATA0x41b0b1
+ MX6SL_PAD_AUD_RXC__UART3_TX_DATA0x41b0b1
+ ;
+ };
+
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins =
+ MX6SL_PAD_SD2_CMD__SD2_CMD 0x417059
+ MX6SL_PAD_SD2_CLK__SD2_CLK 0x410059
Re: RCU bug with v3.17-rc3 ?
Hello Russell,
On Sat, Oct 11, 2014 at 11:16 AM, Russell King - ARM Linux
wrote:
> On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote:
>> On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
>> > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
>> > >
>> > > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
>> > > it seems that this has been known about for some time.)
>> >
>> > Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x < 3
>> > are affected, as well as 4.9.0.
>> >
>> > > We can blacklist these GCC versions quite easily. We already have GCC
>> > > 3.3 blacklisted, and it's trivial to add others. I would want to include
>> > > some proper details about the bug, just like the other existing entries
>> > > we already have in asm-offsets.c, where we name the functions that the
>> > > compiler is known to break where appropriate.
>> >
>> > Before blacklisting anything, it's worth considering that simple version
>> > checks would break existing pre-4.8.3 compilers that have been patched
>> > for PR58854. It looks like Yocto and Buildroot issued releases with
>> > patched 4.8.2 compilers well before the (fixed) 4.8.3 release. I think
>> > the most we can reasonably do without breaking some correctly-behaving
>> > toolchains is to emit a warning.
>>
>> Yocto has PR58854 problem patch.
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy
>
> Right, and we can provide links to these in the comments above the #error
> so people have the right places to do a bit of research into whether their
> compiler is safe.
>
> It is unfortunate that they are indistinguishable from the broken versions,
> but that's really a distro problem for causing that issue themselves -
> especially given how serious this bug is.
What about checking if GCC_PR58854_FIXED is not defined for error? So
build systems and people could easily define it if they know their GCC
has the fix applied.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: RCU bug with v3.17-rc3 ?
Hello Russell,
On Sat, Oct 11, 2014 at 11:16 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote:
On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
it seems that this has been known about for some time.)
Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x 3
are affected, as well as 4.9.0.
We can blacklist these GCC versions quite easily. We already have GCC
3.3 blacklisted, and it's trivial to add others. I would want to include
some proper details about the bug, just like the other existing entries
we already have in asm-offsets.c, where we name the functions that the
compiler is known to break where appropriate.
Before blacklisting anything, it's worth considering that simple version
checks would break existing pre-4.8.3 compilers that have been patched
for PR58854. It looks like Yocto and Buildroot issued releases with
patched 4.8.2 compilers well before the (fixed) 4.8.3 release. I think
the most we can reasonably do without breaking some correctly-behaving
toolchains is to emit a warning.
Yocto has PR58854 problem patch.
http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy
Right, and we can provide links to these in the comments above the #error
so people have the right places to do a bit of research into whether their
compiler is safe.
It is unfortunate that they are indistinguishable from the broken versions,
but that's really a distro problem for causing that issue themselves -
especially given how serious this bug is.
What about checking if GCC_PR58854_FIXED is not defined for error? So
build systems and people could easily define it if they know their GCC
has the fix applied.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/4] ARM: dts: imx23-evk: enable USB PHY and controller
On Wed, Jul 17, 2013 at 12:50 AM, Shawn Guo wrote: > On Tue, Jul 16, 2013 at 09:56:12AM -0300, Otavio Salvador wrote: >> The i.MX23EVK board provides a USB port so the USB PHY and controller >> need to be enabled for it to be usable. >> >> Signed-off-by: Otavio Salvador > > There is a typo i.XM23 in commit log of patch #2 and #3. I fixed them > up and applied all 3. Thanks Shawn :) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/4] ARM: dts: imx23-evk: enable USB PHY and controller
On Wed, Jul 17, 2013 at 12:50 AM, Shawn Guo shawn@linaro.org wrote: On Tue, Jul 16, 2013 at 09:56:12AM -0300, Otavio Salvador wrote: The i.MX23EVK board provides a USB port so the USB PHY and controller need to be enabled for it to be usable. Signed-off-by: Otavio Salvador ota...@ossystems.com.br There is a typo i.XM23 in commit log of patch #2 and #3. I fixed them up and applied all 3. Thanks Shawn :) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/4] ARM: dts: imx23-evk: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador
---
Changes in v2: None
arch/arm/boot/dts/imx23-evk.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index dc3ab45..185c7c0 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -90,6 +90,11 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = "okay";
+ fsl,lradc-touchscreen-wires = <4>;
+ };
+
pwm: pwm@80064000 {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/4] ARM: dts: imx23-evk: enable USB PHY and controller
The i.MX23EVK board provides a USB port so the USB PHY and controller
need to be enabled for it to be usable.
Signed-off-by: Otavio Salvador
---
Changes in v2: None
arch/arm/boot/dts/imx23-evk.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index da0588a..dc3ab45 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -107,6 +107,16 @@
pinctrl-0 = <_pins_a>;
status = "okay";
};
+
+ usbphy0: usbphy@8007c000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb@8008 {
+ usb0: usb@8008 {
+ status = "okay";
};
};
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] iio: add configuration option for debug support
Signed-off-by: Otavio Salvador --- Changes in v2: - Rework Kconfig help (Lars-Peter Clausen) drivers/iio/Kconfig | 7 +++ drivers/iio/Makefile | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig index 9af763a..e5d1cfc 100644 --- a/drivers/iio/Kconfig +++ b/drivers/iio/Kconfig @@ -12,6 +12,13 @@ menuconfig IIO if IIO +config IIO_DEBUG + boolean "Debug support for Industrial I/O" + depends on DEBUG_KERNEL + help + Say "yes" to enable debug messaging (like dev_dbg and pr_debug) + support in Industrial I/O subsystem and drivers. + config IIO_BUFFER bool "Enable buffer support within IIO" help diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile index 7a3866c..6e43e5b 100644 --- a/drivers/iio/Makefile +++ b/drivers/iio/Makefile @@ -2,6 +2,8 @@ # Makefile for the industrial I/O core. # +ccflags-$(CONFIG_IIO_DEBUG) := -DDEBUG + obj-$(CONFIG_IIO) += industrialio.o industrialio-y := industrialio-core.o industrialio-event.o inkern.o industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 3/4] ARM: dts: imx23-olinuxino: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador
---
Changes in v2: None
arch/arm/boot/dts/imx23-olinuxino.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts
b/arch/arm/boot/dts/imx23-olinuxino.dts
index d107c4a..fc766ae 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -69,6 +69,10 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = "okay";
+ };
+
duart: serial@8007 {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle
On Mon, Jul 15, 2013 at 8:00 PM, Marek Vasut wrote:
> Dear Otavio Salvador,
>
>> On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut wrote:
>> > Dear Otavio Salvador,
>> >
>> >> As we have a 'ret' variable with the iio_trigger_register return, this
>> >> can be used as result.
>> >>
>> >> Signed-off-by: Otavio Salvador
>> >> ---
>> >>
>> >> drivers/staging/iio/adc/mxs-lradc.c | 6 ++
>> >> 1 file changed, 2 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> >> b/drivers/staging/iio/adc/mxs-lradc.c index d92c97a..6d41846 100644
>> >> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> >> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> >> @@ -671,14 +671,12 @@ static int mxs_lradc_trigger_init(struct iio_dev
>> >> *iio) trig->ops = _lradc_trigger_ops;
>> >>
>> >> ret = iio_trigger_register(trig);
>> >>
>> >> - if (ret) {
>> >> + if (ret)
>> >>
>> >> iio_trigger_free(trig);
>> >>
>> >> - return ret;
>> >> - }
>> >>
>> >> iio->trig = trig;
>> >
>> > You are still setting iio->trig , you dont want to do that in case of
>> > failure
>>
>> In this case it'd end being NULL I think, wouldn't it?
>
> It won't, see the implementation in:
>
> drivers/iio/industrialio-trigger.c
Agreed; will drop this from v2.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
On Mon, Jul 15, 2013 at 10:30 PM, Shawn Guo wrote: > On Mon, Jul 15, 2013 at 01:39:13PM -0300, Otavio Salvador wrote: >> On Mon, Jul 15, 2013 at 12:39 PM, Fabio Estevam wrote: >> > Hi Otavio, >> > >> > On Mon, Jul 15, 2013 at 11:22 AM, Otavio Salvador >> > wrote: >> >> The i.MX23EVK board provides a USB port so the USB PHY and controller >> >> need to be enabled for it to be usable. >> >> >> >> Signed-off-by: Otavio Salvador >> >> --- >> > >> > You should have Cc'd Shawn Guo on this series. >> >> Oh; thanks for fix my mistake. I am new to kernel development :-) > > I'm on copy of patches 1, 3 and 4. 2 and 5 are missing? I will prepare a v2, as per Jonathan feedback and will add you in all them. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
On Tue, Jul 16, 2013 at 12:42 AM, Fabio Estevam wrote: > On Mon, Jul 15, 2013 at 11:22 AM, Otavio Salvador > wrote: >> The i.MX23EVK board provides a USB port so the USB PHY and controller >> need to be enabled for it to be usable. > > Has this been tested? I don't see in this patch any code to enable USB power. It does, I am using it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] iio: add configuration option for debug support
On Tue, Jul 16, 2013 at 7:26 AM, Lars-Peter Clausen wrote: > On 07/16/2013 11:58 AM, Jonathan Cameron wrote: >> On 07/15/2013 03:22 PM, Otavio Salvador wrote: >>> Signed-off-by: Otavio Salvador >> seems a sensible facility to have available. >> >> Applied to the togreg branch of iio.git > > Can you update the Kconfig help text? Sure I can. Jonathan seem to have applied it so should I send a v2 or a new patch? >>> --- >>> drivers/iio/Kconfig | 7 +++ >>> drivers/iio/Makefile | 2 ++ >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig >>> index 9af763a..d1f06f2 100644 >>> --- a/drivers/iio/Kconfig >>> +++ b/drivers/iio/Kconfig >>> @@ -12,6 +12,13 @@ menuconfig IIO >>> >>> if IIO >>> >>> +config IIO_DEBUG >>> +boolean "Debug support for Industrial I/O" >>> +depends on DEBUG_KERNEL >>> +help >>> + Say "yes" to enable debug messaging (like dev_dbg and pr_debug), >>> + sysfs, and debugfs support in Industrial I/O subsystem and drivers. > > This has nothing to do with either sysfs or debugfs support. Say "yes" to enable debug messaging (like dev_dbg and pr_debug) support in Industrial I/O subsystem and drivers. ? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] iio: add configuration option for debug support
On Tue, Jul 16, 2013 at 7:26 AM, Lars-Peter Clausen l...@metafoo.de wrote: On 07/16/2013 11:58 AM, Jonathan Cameron wrote: On 07/15/2013 03:22 PM, Otavio Salvador wrote: Signed-off-by: Otavio Salvador ota...@ossystems.com.br seems a sensible facility to have available. Applied to the togreg branch of iio.git Can you update the Kconfig help text? Sure I can. Jonathan seem to have applied it so should I send a v2 or a new patch? --- drivers/iio/Kconfig | 7 +++ drivers/iio/Makefile | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig index 9af763a..d1f06f2 100644 --- a/drivers/iio/Kconfig +++ b/drivers/iio/Kconfig @@ -12,6 +12,13 @@ menuconfig IIO if IIO +config IIO_DEBUG +boolean Debug support for Industrial I/O +depends on DEBUG_KERNEL +help + Say yes to enable debug messaging (like dev_dbg and pr_debug), + sysfs, and debugfs support in Industrial I/O subsystem and drivers. This has nothing to do with either sysfs or debugfs support. Say yes to enable debug messaging (like dev_dbg and pr_debug) support in Industrial I/O subsystem and drivers. ? -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
On Tue, Jul 16, 2013 at 12:42 AM, Fabio Estevam feste...@gmail.com wrote: On Mon, Jul 15, 2013 at 11:22 AM, Otavio Salvador ota...@ossystems.com.br wrote: The i.MX23EVK board provides a USB port so the USB PHY and controller need to be enabled for it to be usable. Has this been tested? I don't see in this patch any code to enable USB power. It does, I am using it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
On Mon, Jul 15, 2013 at 10:30 PM, Shawn Guo shawn@linaro.org wrote: On Mon, Jul 15, 2013 at 01:39:13PM -0300, Otavio Salvador wrote: On Mon, Jul 15, 2013 at 12:39 PM, Fabio Estevam feste...@gmail.com wrote: Hi Otavio, On Mon, Jul 15, 2013 at 11:22 AM, Otavio Salvador ota...@ossystems.com.br wrote: The i.MX23EVK board provides a USB port so the USB PHY and controller need to be enabled for it to be usable. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- You should have Cc'd Shawn Guo on this series. Oh; thanks for fix my mistake. I am new to kernel development :-) I'm on copy of patches 1, 3 and 4. 2 and 5 are missing? I will prepare a v2, as per Jonathan feedback and will add you in all them. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle
On Mon, Jul 15, 2013 at 8:00 PM, Marek Vasut ma...@denx.de wrote:
Dear Otavio Salvador,
On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut marek.va...@gmail.com wrote:
Dear Otavio Salvador,
As we have a 'ret' variable with the iio_trigger_register return, this
can be used as result.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
drivers/staging/iio/adc/mxs-lradc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
b/drivers/staging/iio/adc/mxs-lradc.c index d92c97a..6d41846 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -671,14 +671,12 @@ static int mxs_lradc_trigger_init(struct iio_dev
*iio) trig-ops = mxs_lradc_trigger_ops;
ret = iio_trigger_register(trig);
- if (ret) {
+ if (ret)
iio_trigger_free(trig);
- return ret;
- }
iio-trig = trig;
You are still setting iio-trig , you dont want to do that in case of
failure
In this case it'd end being NULL I think, wouldn't it?
It won't, see the implementation in:
drivers/iio/industrialio-trigger.c
Agreed; will drop this from v2.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 3/4] ARM: dts: imx23-olinuxino: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v2: None
arch/arm/boot/dts/imx23-olinuxino.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts
b/arch/arm/boot/dts/imx23-olinuxino.dts
index d107c4a..fc766ae 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -69,6 +69,10 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = okay;
+ };
+
duart: serial@8007 {
pinctrl-names = default;
pinctrl-0 = duart_pins_a;
--
1.8.3.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/4] ARM: dts: imx23-evk: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v2: None
arch/arm/boot/dts/imx23-evk.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index dc3ab45..185c7c0 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -90,6 +90,11 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = okay;
+ fsl,lradc-touchscreen-wires = 4;
+ };
+
pwm: pwm@80064000 {
pinctrl-names = default;
pinctrl-0 = pwm2_pins_a;
--
1.8.3.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] iio: add configuration option for debug support
Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- Changes in v2: - Rework Kconfig help (Lars-Peter Clausen) drivers/iio/Kconfig | 7 +++ drivers/iio/Makefile | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig index 9af763a..e5d1cfc 100644 --- a/drivers/iio/Kconfig +++ b/drivers/iio/Kconfig @@ -12,6 +12,13 @@ menuconfig IIO if IIO +config IIO_DEBUG + boolean Debug support for Industrial I/O + depends on DEBUG_KERNEL + help + Say yes to enable debug messaging (like dev_dbg and pr_debug) + support in Industrial I/O subsystem and drivers. + config IIO_BUFFER bool Enable buffer support within IIO help diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile index 7a3866c..6e43e5b 100644 --- a/drivers/iio/Makefile +++ b/drivers/iio/Makefile @@ -2,6 +2,8 @@ # Makefile for the industrial I/O core. # +ccflags-$(CONFIG_IIO_DEBUG) := -DDEBUG + obj-$(CONFIG_IIO) += industrialio.o industrialio-y := industrialio-core.o industrialio-event.o inkern.o industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o -- 1.8.3.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/4] ARM: dts: imx23-evk: enable USB PHY and controller
The i.MX23EVK board provides a USB port so the USB PHY and controller
need to be enabled for it to be usable.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v2: None
arch/arm/boot/dts/imx23-evk.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index da0588a..dc3ab45 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -107,6 +107,16 @@
pinctrl-0 = duart_pins_a;
status = okay;
};
+
+ usbphy0: usbphy@8007c000 {
+ status = okay;
+ };
+ };
+ };
+
+ ahb@8008 {
+ usb0: usb@8008 {
+ status = okay;
};
};
--
1.8.3.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
On Mon, Jul 15, 2013 at 12:39 PM, Fabio Estevam wrote: > Hi Otavio, > > On Mon, Jul 15, 2013 at 11:22 AM, Otavio Salvador > wrote: >> The i.MX23EVK board provides a USB port so the USB PHY and controller >> need to be enabled for it to be usable. >> >> Signed-off-by: Otavio Salvador >> --- > > You should have Cc'd Shawn Guo on this series. Oh; thanks for fix my mistake. I am new to kernel development :-) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle
On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut wrote:
> Dear Otavio Salvador,
>
>> As we have a 'ret' variable with the iio_trigger_register return, this
>> can be used as result.
>>
>> Signed-off-by: Otavio Salvador
>> ---
>> drivers/staging/iio/adc/mxs-lradc.c | 6 ++
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> b/drivers/staging/iio/adc/mxs-lradc.c index d92c97a..6d41846 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -671,14 +671,12 @@ static int mxs_lradc_trigger_init(struct iio_dev
>> *iio) trig->ops = _lradc_trigger_ops;
>>
>> ret = iio_trigger_register(trig);
>> - if (ret) {
>> + if (ret)
>> iio_trigger_free(trig);
>> - return ret;
>> - }
>>
>> iio->trig = trig;
>
>
> You are still setting iio->trig , you dont want to do that in case of failure
In this case it'd end being NULL I think, wouldn't it?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/5] ARM: dts: imx23-evk: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/imx23-evk.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index dc3ab45..185c7c0 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -90,6 +90,11 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = "okay";
+ fsl,lradc-touchscreen-wires = <4>;
+ };
+
pwm: pwm@80064000 {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] ARM: dts: imx23-evk: enable USB PHY and controller
The i.MX23EVK board provides a USB port so the USB PHY and controller
need to be enabled for it to be usable.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/imx23-evk.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index da0588a..dc3ab45 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -107,6 +107,16 @@
pinctrl-0 = <_pins_a>;
status = "okay";
};
+
+ usbphy0: usbphy@8007c000 {
+ status = "okay";
+ };
+ };
+ };
+
+ ahb@8008 {
+ usb0: usb@8008 {
+ status = "okay";
};
};
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 5/5] iio: add configuration option for debug support
Signed-off-by: Otavio Salvador --- drivers/iio/Kconfig | 7 +++ drivers/iio/Makefile | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig index 9af763a..d1f06f2 100644 --- a/drivers/iio/Kconfig +++ b/drivers/iio/Kconfig @@ -12,6 +12,13 @@ menuconfig IIO if IIO +config IIO_DEBUG + boolean "Debug support for Industrial I/O" + depends on DEBUG_KERNEL + help + Say "yes" to enable debug messaging (like dev_dbg and pr_debug), + sysfs, and debugfs support in Industrial I/O subsystem and drivers. + config IIO_BUFFER bool "Enable buffer support within IIO" help diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile index 7a3866c..6e43e5b 100644 --- a/drivers/iio/Makefile +++ b/drivers/iio/Makefile @@ -2,6 +2,8 @@ # Makefile for the industrial I/O core. # +ccflags-$(CONFIG_IIO_DEBUG) := -DDEBUG + obj-$(CONFIG_IIO) += industrialio.o industrialio-y := industrialio-core.o industrialio-event.o inkern.o industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 4/5] ARM: dts: imx23-olinuxino: enable Low Resolution ADC
The i.XM23 has a internal Low Resolution ADC; this enables the support
for this device.
Signed-off-by: Otavio Salvador
---
arch/arm/boot/dts/imx23-olinuxino.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts
b/arch/arm/boot/dts/imx23-olinuxino.dts
index d107c4a..fc766ae 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -69,6 +69,10 @@
};
apbx@8004 {
+ lradc@8005 {
+ status = "okay";
+ };
+
duart: serial@8007 {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
