RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

2019-04-08 Thread RaghuramChary.Jallipalli 
> > Correct, IRQ domain is generally used in chained irq controllers.
> > Yes, We need to check why irq domain is used in the current driver.
> >
> 
> It's introduced in the commit cc89c323a30e
> 
Thanks Jisheng, Will check and get back ASAP.

Thanks

RE: [PATCH] usbnet: smsc95xx: allow to down ethernet link

2019-01-03 Thread RaghuramChary.Jallipalli 
> allow ifconfig ethX to down ethernet link. Ethernet part of chip is switched 
> to
> power down more and on ifconfig up driver does soft reset and restores it's
> state.
> 
Thanks for the patch.
If I understand the issue correctly, the ethernet link is not going down in 
power down mode? Pls clarify.
Does these changes be applied to smsc75xx driver as well??

Thanks,
-Raghu

RE: [PATCH 3/4 next] net: lan78xx: Switch to SPDX identifier

2018-09-03 Thread RaghuramChary.Jallipalli 
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright (C) 2015 Microchip Technology */

Can we merge both in single comment line?

> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (C) 2015 Microchip Technology */

Here too.

Thanks,
-Raghu

RE: [PATCH 3/4 next] net: lan78xx: Switch to SPDX identifier

2018-09-03 Thread RaghuramChary.Jallipalli 
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright (C) 2015 Microchip Technology */

Can we merge both in single comment line?

> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (C) 2015 Microchip Technology */

Here too.

Thanks,
-Raghu

RE: [PATCH 4/4 next] net: lan78xx: Make declaration style consistent

2018-09-03 Thread RaghuramChary.Jallipalli 
> This patch makes some declaration more consistent.
> 
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu

RE: [PATCH 4/4 next] net: lan78xx: Make declaration style consistent

2018-09-03 Thread RaghuramChary.Jallipalli 
> This patch makes some declaration more consistent.
> 
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu

RE: [PATCH 2/4 next] net: lan78xx: Drop unnecessary strcpy in lan78xx_probe

2018-09-03 Thread RaghuramChary.Jallipalli 
> There is no need for this strcpy because alloc_etherdev() already does this
> job.
> 
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu

RE: [PATCH 2/4 next] net: lan78xx: Drop unnecessary strcpy in lan78xx_probe

2018-09-03 Thread RaghuramChary.Jallipalli 
> There is no need for this strcpy because alloc_etherdev() already does this
> job.
> 
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu

RE: [PATCH 1/4 next] net: lan78xx: Bail out if lan78xx_get_endpoints fails

2018-09-03 Thread RaghuramChary.Jallipalli 
> We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is
> overwritten.
> 
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
> Ethernet")
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu

RE: [PATCH 1/4 next] net: lan78xx: Bail out if lan78xx_get_endpoints fails

2018-09-03 Thread RaghuramChary.Jallipalli 
> We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is
> overwritten.
> 
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
> Ethernet")
> Signed-off-by: Stefan Wahren 

Reviewed-by: Raghuram Chary Jallipalli 

Thanks,
-Raghu