Re: linux-next: build failures after merge of the drm tree

[Sachin Kamat]

On Sun, Aug 10, 2014 at 1:28 PM, Dave Airlie  wrote:
>>
>
> Been on holidays, but ack for anything DT related,
>
> Look I wishI knew how DT worked, and what tree is canonical for changes to
> it, I'm not sure its well defined enough or sub maintaniers know enough,
> so I do just trust the exynos guys with this.
>

Inki,

Can you please get your tree included in linux-next so that these kind of issues
could be detected much earlier (even before they hit Dave's tree)?


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failures after merge of the drm tree

[Sachin Kamat]

On Sun, Aug 10, 2014 at 1:28 PM, Dave Airlie airl...@linux.ie wrote:


 Been on holidays, but ack for anything DT related,

 Look I wishI knew how DT worked, and what tree is canonical for changes to
 it, I'm not sure its well defined enough or sub maintaniers know enough,
 so I do just trust the exynos guys with this.


Inki,

Can you please get your tree included in linux-next so that these kind of issues
could be detected much earlier (even before they hit Dave's tree)?


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

[Sachin Kamat]

Hi Vivek,

On Tue, Aug 5, 2014 at 4:09 PM, Vivek Gautam  wrote:
> Since we want to keep support for both older usb-phys as well as the
> newer generic phys, lets first get the generic PHYs and fallback to
> older USB-PHYs only when we fail to get the former.
> This should fix the issue with ehci-exynos and ohci-exynos, wherein
> in the absence of SAMSUNG_USB2PHY config symbol, we end up getting
> the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
> are not configured properly.
>
> Reported-by: Sachin Kamat 
> Signed-off-by: Vivek Gautam 
> Cc: Alan Stern 
> Cc: Jingoo Han 

Tested this patch on Exynos5250 based Arndale and Snow boards.
Fixes the said issue. Thanks.

Tested-by: Sachin Kamat 

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

[Sachin Kamat]

Hi Vivek,

On Tue, Aug 5, 2014 at 4:09 PM, Vivek Gautam gautam.vi...@samsung.com wrote:
 Since we want to keep support for both older usb-phys as well as the
 newer generic phys, lets first get the generic PHYs and fallback to
 older USB-PHYs only when we fail to get the former.
 This should fix the issue with ehci-exynos and ohci-exynos, wherein
 in the absence of SAMSUNG_USB2PHY config symbol, we end up getting
 the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
 are not configured properly.

 Reported-by: Sachin Kamat sachin.ka...@samsung.com
 Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
 Cc: Alan Stern st...@rowland.harvard.edu
 Cc: Jingoo Han jg1@samsung.com

Tested this patch on Exynos5250 based Arndale and Snow boards.
Fixes the said issue. Thanks.

Tested-by: Sachin Kamat sachin.ka...@samsung.com

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

On Fri, Jul 11, 2014 at 3:41 PM, Tomasz Figa  wrote:
> On 11.07.2014 11:57, Sachin Kamat wrote:
>> + Tomasz
>>
>> Sorry for missing the maintainer himself :)
>>
>> On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat  
>> wrote:
>>> Update to reflect the recent file movement to a sub-directory.
>>>
>>> Signed-off-by: Sachin Kamat 
>>> ---
>>>  MAINTAINERS |4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e3a517635eb4..898cf76f8837 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -6943,9 +6943,7 @@ M:Thomas Abraham 
>>>  L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
>>>  L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
>>>  S: Maintained
>>> -F: drivers/pinctrl/pinctrl-exynos.*
>>> -F: drivers/pinctrl/pinctrl-s3c*
>>> -F: drivers/pinctrl/pinctrl-samsung.*
>>> +F: drivers/pinctrl/samsung/
>>>
>>>  PIN CONTROLLER - ST SPEAR
>>>  M: Viresh Kumar 
>>> --
>>> 1.7.9.5
>>>
>>
>
> Acked-by: Tomasz Figa 

Linus,
Gentle ping :)


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

[Sachin Kamat]

Hi Pramod,


On Fri, Jul 25, 2014 at 2:42 PM,   wrote:
> From: Pramod Gurav 
>
> This patch does below:
> - Removes kfree done on data allocated with devm_zalloc in probe
>   path of the driver.
> - Adds a check on return value from devm_kzalloc which was missing
> - Removes the error lables and instead releases resources and returns
>   after failures
>
> CC: Dmitry Torokhov 
> CC: Lejun Zhu 
> CC: Sachin Kamat 
>
> Signed-off-by: Pramod Gurav 
> ---
>
> Changes since v1:
> - Removes de_err logs on OOM cases which is not needed.
>
>  drivers/input/misc/soc_button_array.c |   27 +++
>  1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c 
> b/drivers/input/misc/soc_button_array.c
> index 5a6334b..f421cf4 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -83,6 +83,11 @@ soc_button_device_create(struct pnp_dev *pdev,
>sizeof(*gpio_keys_pdata) +
> sizeof(*gpio_keys) * MAX_NBUTTONS,
>GFP_KERNEL);
> +   if (!gpio_keys_pdata) {
> +   error = -ENOMEM;
> +   return ERR_PTR(error);

You don't need a variable here. You could directly do:
   return ERR_PTR(-ENOMEM);

> +   }
> +
> gpio_keys = (void *)(gpio_keys_pdata + 1);
>
> for (info = button_info; info->name; info++) {
> @@ -104,7 +109,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
> if (n_buttons == 0) {
> error = -ENODEV;
> -   goto err_free_mem;
> +   return ERR_PTR(error);

ditto

> }
>
> gpio_keys_pdata->buttons = gpio_keys;
> @@ -114,25 +119,23 @@ soc_button_device_create(struct pnp_dev *pdev,
> pd = platform_device_alloc("gpio-keys", PLATFORM_DEVID_AUTO);
> if (!pd) {
> error = -ENOMEM;
> -   goto err_free_mem;
> +   return ERR_PTR(error);

ditto

> }
>
> error = platform_device_add_data(pd, gpio_keys_pdata,
>  sizeof(*gpio_keys_pdata));
> -   if (error)
> -   goto err_free_pdev;

This goto could be retained to avoid code duplication.

> +   if (error) {
> +   platform_device_put(pd);
> +   return ERR_PTR(error);
> +   }
>
> error = platform_device_add(pd);
> -   if (error)
> -   goto err_free_pdev;

ditto

> +   if (error) {
> +   platform_device_put(pd);
> +   return ERR_PTR(error);
> +   }
>
> return pd;
> -
> -err_free_pdev:
> -   platform_device_put(pd);
> -err_free_mem:
> -   devm_kfree(>dev, gpio_keys_pdata);
> -   return ERR_PTR(error);
>  }
>
>  static void soc_button_remove(struct pnp_dev *pdev)
> --
> 1.7.9.5
>



-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

[Sachin Kamat]

On Fri, Jul 25, 2014 at 12:39 PM,   wrote:
> From: Pramod Gurav 
>
> This patch does below:
> - Removes kfree done on data allocated with devm_zalloc in probe
>   path of the driver.
> - Adds a check on return value from devm_kzalloc which was missing
>   and renames a lable from err_free_mem to err_mem.
> - Adds couple of dev_err on failure to allocate memory
>
> CC: Dmitry Torokhov 
> CC: Lejun Zhu 
> CC: Sachin Kamat 
>
> Signed-off-by: Pramod Gurav 
> ---
>  drivers/input/misc/soc_button_array.c |   19 ++-
>  1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c 
> b/drivers/input/misc/soc_button_array.c
> index 5a6334b..ac82971 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -83,6 +83,13 @@ soc_button_device_create(struct pnp_dev *pdev,
>sizeof(*gpio_keys_pdata) +
> sizeof(*gpio_keys) * MAX_NBUTTONS,
>GFP_KERNEL);
> +   if (!gpio_keys_pdata) {
> +   dev_err(>dev,
> +   "Can't allocate memory for 
> gpio_keys_platform_data\n");

OOM message is not needed as memory subsystem will take care of it.

> +   error = -ENOMEM;
> +   goto err_mem;

Return directly from here.

> +   }
> +
> gpio_keys = (void *)(gpio_keys_pdata + 1);
>
> for (info = button_info; info->name; info++) {
> @@ -104,7 +111,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
> if (n_buttons == 0) {
> error = -ENODEV;
> -   goto err_free_mem;
> +   goto err_mem;

ditto

> }
>
> gpio_keys_pdata->buttons = gpio_keys;
> @@ -114,7 +121,7 @@ soc_button_device_create(struct pnp_dev *pdev,
> pd = platform_device_alloc("gpio-keys", PLATFORM_DEVID_AUTO);
> if (!pd) {
> error = -ENOMEM;
> -   goto err_free_mem;
> +   goto err_mem;

ditto

> }
>
> error = platform_device_add_data(pd, gpio_keys_pdata,
> @@ -130,8 +137,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
>  err_free_pdev:
> platform_device_put(pd);
> -err_free_mem:
> -   devm_kfree(>dev, gpio_keys_pdata);
> +err_mem:

This label would not be required once returned directly from above.

> return ERR_PTR(error);
>  }
>
> @@ -155,8 +161,11 @@ static int soc_button_pnp_probe(struct pnp_dev *pdev,
> int error;
>
> priv = devm_kzalloc(>dev, sizeof(*priv), GFP_KERNEL);
> -   if (!priv)
> +   if (!priv) {
> +   dev_err(>dev,
> +   "Can't allocate memory for soc_button_data\n");

OOM message is not needed as memory subsystem will take care of it.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

[Sachin Kamat]

On Fri, Jul 25, 2014 at 12:39 PM,  pramod.gurav@gmail.com wrote:
 From: Pramod Gurav pramod.gu...@smartplayin.com

 This patch does below:
 - Removes kfree done on data allocated with devm_zalloc in probe
   path of the driver.
 - Adds a check on return value from devm_kzalloc which was missing
   and renames a lable from err_free_mem to err_mem.
 - Adds couple of dev_err on failure to allocate memory

 CC: Dmitry Torokhov dmitry.torok...@gmail.com
 CC: Lejun Zhu lejun@linux.intel.com
 CC: Sachin Kamat sachin.ka...@linaro.org

 Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com
 ---
  drivers/input/misc/soc_button_array.c |   19 ++-
  1 file changed, 14 insertions(+), 5 deletions(-)

 diff --git a/drivers/input/misc/soc_button_array.c 
 b/drivers/input/misc/soc_button_array.c
 index 5a6334b..ac82971 100644
 --- a/drivers/input/misc/soc_button_array.c
 +++ b/drivers/input/misc/soc_button_array.c
 @@ -83,6 +83,13 @@ soc_button_device_create(struct pnp_dev *pdev,
sizeof(*gpio_keys_pdata) +
 sizeof(*gpio_keys) * MAX_NBUTTONS,
GFP_KERNEL);
 +   if (!gpio_keys_pdata) {
 +   dev_err(pdev-dev,
 +   Can't allocate memory for 
 gpio_keys_platform_data\n);

OOM message is not needed as memory subsystem will take care of it.

 +   error = -ENOMEM;
 +   goto err_mem;

Return directly from here.

 +   }
 +
 gpio_keys = (void *)(gpio_keys_pdata + 1);

 for (info = button_info; info-name; info++) {
 @@ -104,7 +111,7 @@ soc_button_device_create(struct pnp_dev *pdev,

 if (n_buttons == 0) {
 error = -ENODEV;
 -   goto err_free_mem;
 +   goto err_mem;

ditto

 }

 gpio_keys_pdata-buttons = gpio_keys;
 @@ -114,7 +121,7 @@ soc_button_device_create(struct pnp_dev *pdev,
 pd = platform_device_alloc(gpio-keys, PLATFORM_DEVID_AUTO);
 if (!pd) {
 error = -ENOMEM;
 -   goto err_free_mem;
 +   goto err_mem;

ditto

 }

 error = platform_device_add_data(pd, gpio_keys_pdata,
 @@ -130,8 +137,7 @@ soc_button_device_create(struct pnp_dev *pdev,

  err_free_pdev:
 platform_device_put(pd);
 -err_free_mem:
 -   devm_kfree(pdev-dev, gpio_keys_pdata);
 +err_mem:

This label would not be required once returned directly from above.

 return ERR_PTR(error);
  }

 @@ -155,8 +161,11 @@ static int soc_button_pnp_probe(struct pnp_dev *pdev,
 int error;

 priv = devm_kzalloc(pdev-dev, sizeof(*priv), GFP_KERNEL);
 -   if (!priv)
 +   if (!priv) {
 +   dev_err(pdev-dev,
 +   Can't allocate memory for soc_button_data\n);

OOM message is not needed as memory subsystem will take care of it.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

[Sachin Kamat]

Hi Pramod,


On Fri, Jul 25, 2014 at 2:42 PM,  pramod.gurav@gmail.com wrote:
 From: Pramod Gurav pramod.gu...@smartplayin.com

 This patch does below:
 - Removes kfree done on data allocated with devm_zalloc in probe
   path of the driver.
 - Adds a check on return value from devm_kzalloc which was missing
 - Removes the error lables and instead releases resources and returns
   after failures

 CC: Dmitry Torokhov dmitry.torok...@gmail.com
 CC: Lejun Zhu lejun@linux.intel.com
 CC: Sachin Kamat sachin.ka...@linaro.org

 Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com
 ---

 Changes since v1:
 - Removes de_err logs on OOM cases which is not needed.

  drivers/input/misc/soc_button_array.c |   27 +++
  1 file changed, 15 insertions(+), 12 deletions(-)

 diff --git a/drivers/input/misc/soc_button_array.c 
 b/drivers/input/misc/soc_button_array.c
 index 5a6334b..f421cf4 100644
 --- a/drivers/input/misc/soc_button_array.c
 +++ b/drivers/input/misc/soc_button_array.c
 @@ -83,6 +83,11 @@ soc_button_device_create(struct pnp_dev *pdev,
sizeof(*gpio_keys_pdata) +
 sizeof(*gpio_keys) * MAX_NBUTTONS,
GFP_KERNEL);
 +   if (!gpio_keys_pdata) {
 +   error = -ENOMEM;
 +   return ERR_PTR(error);

You don't need a variable here. You could directly do:
   return ERR_PTR(-ENOMEM);

 +   }
 +
 gpio_keys = (void *)(gpio_keys_pdata + 1);

 for (info = button_info; info-name; info++) {
 @@ -104,7 +109,7 @@ soc_button_device_create(struct pnp_dev *pdev,

 if (n_buttons == 0) {
 error = -ENODEV;
 -   goto err_free_mem;
 +   return ERR_PTR(error);

ditto

 }

 gpio_keys_pdata-buttons = gpio_keys;
 @@ -114,25 +119,23 @@ soc_button_device_create(struct pnp_dev *pdev,
 pd = platform_device_alloc(gpio-keys, PLATFORM_DEVID_AUTO);
 if (!pd) {
 error = -ENOMEM;
 -   goto err_free_mem;
 +   return ERR_PTR(error);

ditto

 }

 error = platform_device_add_data(pd, gpio_keys_pdata,
  sizeof(*gpio_keys_pdata));
 -   if (error)
 -   goto err_free_pdev;

This goto could be retained to avoid code duplication.

 +   if (error) {
 +   platform_device_put(pd);
 +   return ERR_PTR(error);
 +   }

 error = platform_device_add(pd);
 -   if (error)
 -   goto err_free_pdev;

ditto

 +   if (error) {
 +   platform_device_put(pd);
 +   return ERR_PTR(error);
 +   }

 return pd;
 -
 -err_free_pdev:
 -   platform_device_put(pd);
 -err_free_mem:
 -   devm_kfree(pdev-dev, gpio_keys_pdata);
 -   return ERR_PTR(error);
  }

  static void soc_button_remove(struct pnp_dev *pdev)
 --
 1.7.9.5




-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

On Fri, Jul 11, 2014 at 3:41 PM, Tomasz Figa t.f...@samsung.com wrote:
 On 11.07.2014 11:57, Sachin Kamat wrote:
 + Tomasz

 Sorry for missing the maintainer himself :)

 On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat sachin.ka...@samsung.com 
 wrote:
 Update to reflect the recent file movement to a sub-directory.

 Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
 ---
  MAINTAINERS |4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

 diff --git a/MAINTAINERS b/MAINTAINERS
 index e3a517635eb4..898cf76f8837 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -6943,9 +6943,7 @@ M:Thomas Abraham thomas.abra...@linaro.org
  L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
  L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
  S: Maintained
 -F: drivers/pinctrl/pinctrl-exynos.*
 -F: drivers/pinctrl/pinctrl-s3c*
 -F: drivers/pinctrl/pinctrl-samsung.*
 +F: drivers/pinctrl/samsung/

  PIN CONTROLLER - ST SPEAR
  M: Viresh Kumar viresh.li...@gmail.com
 --
 1.7.9.5



 Acked-by: Tomasz Figa t.f...@samsung.com

Linus,
Gentle ping :)


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

[Sachin Kamat]

‘rx_buf’ is not used in this function.

Signed-off-by: Sachin Kamat 
---
 drivers/mfd/tps65912-spi.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 69a5178bf152..de60ad98bd9f 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 
addr,
unsigned long spi_data = 1 << 23 | addr << 15 | *data;
struct spi_transfer xfer;
struct spi_message msg;
-   u32 tx_buf, rx_buf;
+   u32 tx_buf;
 
tx_buf = spi_data;
-   rx_buf = 0;
 
xfer.tx_buf = _buf;
xfer.rx_buf = NULL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code

[Sachin Kamat]

Removed code unused in this function.

Signed-off-by: Sachin Kamat 
Cc: Cory Maccarrone 
---
Compile tested.
---
 drivers/mfd/htc-i2cpld.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
 {
struct htcpld_data *htcpld;
-   struct device *dev = >dev;
-   struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
-   struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
 
/* Get the platform and driver data */
-   pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = >chip[chip_index];
-   plat_chip_data = >chip[chip_index];
 
/* Setup irq handlers */
irq_end = chip->irq_start + chip->nirqs;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

[Sachin Kamat]

‘rx_buf’ is not used in this function.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/mfd/tps65912-spi.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 69a5178bf152..de60ad98bd9f 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 
addr,
unsigned long spi_data = 1  23 | addr  15 | *data;
struct spi_transfer xfer;
struct spi_message msg;
-   u32 tx_buf, rx_buf;
+   u32 tx_buf;
 
tx_buf = spi_data;
-   rx_buf = 0;
 
xfer.tx_buf = tx_buf;
xfer.rx_buf = NULL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code

[Sachin Kamat]

Removed code unused in this function.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Cc: Cory Maccarrone darkstar6...@gmail.com
---
Compile tested.
---
 drivers/mfd/htc-i2cpld.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
 {
struct htcpld_data *htcpld;
-   struct device *dev = pdev-dev;
-   struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
-   struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
 
/* Get the platform and driver data */
-   pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = htcpld-chip[chip_index];
-   plat_chip_data = pdata-chip[chip_index];
 
/* Setup irq handlers */
irq_end = chip-irq_start + chip-nirqs;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

[Sachin Kamat]

Hi Naveen,

On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi
 wrote:
> This patch updates the IIO based ADC driver to use syscon and regmap
> APIs to access and use PMU registers instead of remapping the PMU
> registers in the driver.
>
> Signed-off-by: Naveen Krishna Chatradhi 
> To: linux-...@vger.kernel.org

With only this patch applied, I believe the ADC functionality would be broken.
Perhaps the DT changes should be merged along with this patch?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

[Sachin Kamat]

Hi Naveen,

On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
 This patch updates the IIO based ADC driver to use syscon and regmap
 APIs to access and use PMU registers instead of remapping the PMU
 registers in the driver.

 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 To: linux-...@vger.kernel.org

With only this patch applied, I believe the ADC functionality would be broken.
Perhaps the DT changes should be merged along with this patch?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
USB gadget controller supported by the DWC2 gadget driver, make it
depend on them and default to ARCH_EXYNOS as they are meant for
Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat 
Reviewed-by: Jingoo Han 
---
Changes since v3:
* Rebased the series on top of latest PHY tree [1].
[1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 5fceb33..c412ca4 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -132,43 +132,30 @@ config PHY_SUN4I_USB
 config PHY_SAMSUNG_USB2
tristate "Samsung USB 2.0 PHY driver"
depends on HAS_IOMEM
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool "Support for Exynos 4210"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool "Support for Exynos 3250/4x12"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 3250/4x12. This option requires
- that Samsung USB 2.0 PHY driver is enabled and means that support for
- this particular SoC is compiled in the driver. In case of Exynos 4x12
- four phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool "Support for Exynos 5250"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat 
Reviewed-by: Jingoo Han 
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c412ca4..c730e85 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -161,8 +161,10 @@ config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
depends on ARCH_EXYNOS5 && OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jul 14, 2014 at 2:39 PM, Kishon Vijay Abraham I  wrote:
>
>
> On Monday 14 July 2014 02:36 PM, Sachin Kamat wrote:
>> On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I  
>> wrote:
>>>
>>>
>>> On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote:
>>>> Hi,
>>>>
>>>> On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I  
>>>> wrote:
>>>>> Hi,
>>>>>
>>>>> On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
>>>>>> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
>>>>>> USB gadget controller supported by the DWC2 gadget driver, make it
>>>>>> depend on them and default to ARCH_EXYNOS as they are meant for
>>>>>> Exynos platforms. Also, make the sub-drivers silent options enabling
>>>>>> them based on the SoC platforms that they are meant to work with. This
>>>>>> will make life easier for end users who do not have any way knowing the
>>>>>> dependencies.
>>>>>
>>>>> There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch 
>>>>> on
>>>>> top of that?
>>>>
>>>> Sure. But I did not see it in linux-next yet. Is it merged somewhere?
>>>
>>> It's in the list. I can push it to my tree if that helps.
>>
>> That would be great to avoid any other conflicts.
>
> pushed to git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
> next. You can use it to rebase your patch.

Thanks. I will re-spin on top of it.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I  wrote:
>
>
> On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote:
>> Hi,
>>
>> On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I  
>> wrote:
>>> Hi,
>>>
>>> On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
>>>> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
>>>> USB gadget controller supported by the DWC2 gadget driver, make it
>>>> depend on them and default to ARCH_EXYNOS as they are meant for
>>>> Exynos platforms. Also, make the sub-drivers silent options enabling
>>>> them based on the SoC platforms that they are meant to work with. This
>>>> will make life easier for end users who do not have any way knowing the
>>>> dependencies.
>>>
>>> There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on
>>> top of that?
>>
>> Sure. But I did not see it in linux-next yet. Is it merged somewhere?
>
> It's in the list. I can push it to my tree if that helps.

That would be great to avoid any other conflicts.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Hi,

On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I  wrote:
> Hi,
>
> On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
>> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
>> USB gadget controller supported by the DWC2 gadget driver, make it
>> depend on them and default to ARCH_EXYNOS as they are meant for
>> Exynos platforms. Also, make the sub-drivers silent options enabling
>> them based on the SoC platforms that they are meant to work with. This
>> will make life easier for end users who do not have any way knowing the
>> dependencies.
>
> There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on
> top of that?

Sure. But I did not see it in linux-next yet. Is it merged somewhere?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Hi,

On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote:
 Hi,

 On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
 Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
 USB gadget controller supported by the DWC2 gadget driver, make it
 depend on them and default to ARCH_EXYNOS as they are meant for
 Exynos platforms. Also, make the sub-drivers silent options enabling
 them based on the SoC platforms that they are meant to work with. This
 will make life easier for end users who do not have any way knowing the
 dependencies.

 There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on
 top of that?

Sure. But I did not see it in linux-next yet. Is it merged somewhere?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I kis...@ti.com wrote:


 On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote:
 Hi,

 On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com 
 wrote:
 Hi,

 On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
 Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
 USB gadget controller supported by the DWC2 gadget driver, make it
 depend on them and default to ARCH_EXYNOS as they are meant for
 Exynos platforms. Also, make the sub-drivers silent options enabling
 them based on the SoC platforms that they are meant to work with. This
 will make life easier for end users who do not have any way knowing the
 dependencies.

 There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on
 top of that?

 Sure. But I did not see it in linux-next yet. Is it merged somewhere?

 It's in the list. I can push it to my tree if that helps.

That would be great to avoid any other conflicts.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jul 14, 2014 at 2:39 PM, Kishon Vijay Abraham I kis...@ti.com wrote:


 On Monday 14 July 2014 02:36 PM, Sachin Kamat wrote:
 On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I kis...@ti.com 
 wrote:


 On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote:
 Hi,

 On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com 
 wrote:
 Hi,

 On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote:
 Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
 USB gadget controller supported by the DWC2 gadget driver, make it
 depend on them and default to ARCH_EXYNOS as they are meant for
 Exynos platforms. Also, make the sub-drivers silent options enabling
 them based on the SoC platforms that they are meant to work with. This
 will make life easier for end users who do not have any way knowing the
 dependencies.

 There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch 
 on
 top of that?

 Sure. But I did not see it in linux-next yet. Is it merged somewhere?

 It's in the list. I can push it to my tree if that helps.

 That would be great to avoid any other conflicts.

 pushed to git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
 next. You can use it to rebase your patch.

Thanks. I will re-spin on top of it.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c412ca4..c730e85 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -161,8 +161,10 @@ config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
depends on ARCH_EXYNOS5  OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
USB gadget controller supported by the DWC2 gadget driver, make it
depend on them and default to ARCH_EXYNOS as they are meant for
Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
---
Changes since v3:
* Rebased the series on top of latest PHY tree [1].
[1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 5fceb33..c412ca4 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -132,43 +132,30 @@ config PHY_SUN4I_USB
 config PHY_SAMSUNG_USB2
tristate Samsung USB 2.0 PHY driver
depends on HAS_IOMEM
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool Support for Exynos 4210
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool Support for Exynos 3250/4x12
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 3250/4x12. This option requires
- that Samsung USB 2.0 PHY driver is enabled and means that support for
- this particular SoC is compiled in the driver. In case of Exynos 4x12
- four phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool Support for Exynos 5250
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: tps65912-spi: Remove unused variable

[Sachin Kamat]

‘rx_buf’ is not used in this function.

Signed-off-by: Sachin Kamat 
---
 drivers/mfd/tps65912-spi.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 69a5178bf152..de60ad98bd9f 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 
addr,
unsigned long spi_data = 1 << 23 | addr << 15 | *data;
struct spi_transfer xfer;
struct spi_message msg;
-   u32 tx_buf, rx_buf;
+   u32 tx_buf;
 
tx_buf = spi_data;
-   rx_buf = 0;
 
xfer.tx_buf = _buf;
xfer.rx_buf = NULL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: htc-i2cpld: Remove unused code

[Sachin Kamat]

Removed code unused in this function.

Signed-off-by: Sachin Kamat 
---
Compile tested.
---
 drivers/mfd/htc-i2cpld.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
 {
struct htcpld_data *htcpld;
-   struct device *dev = >dev;
-   struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
-   struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
 
/* Get the platform and driver data */
-   pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = >chip[chip_index];
-   plat_chip_data = >chip[chip_index];
 
/* Setup irq handlers */
irq_end = chip->irq_start + chip->nirqs;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

+ Tomasz

Sorry for missing the maintainer himself :)

On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat  wrote:
> Update to reflect the recent file movement to a sub-directory.
>
> Signed-off-by: Sachin Kamat 
> ---
>  MAINTAINERS |4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e3a517635eb4..898cf76f8837 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6943,9 +6943,7 @@ M:Thomas Abraham 
>  L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
>  L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
>  S: Maintained
> -F: drivers/pinctrl/pinctrl-exynos.*
> -F: drivers/pinctrl/pinctrl-s3c*
> -F: drivers/pinctrl/pinctrl-samsung.*
> +F: drivers/pinctrl/samsung/
>
>  PIN CONTROLLER - ST SPEAR
>  M: Viresh Kumar 
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

[Sachin Kamat]

Hi Naveen,

On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi
 wrote:
> The DT bindings in exynos-adc.txt applies to the ADC
> driver (exynos-adc.c) developed based on IIO framework.
>
> The bindings are more appropriate to be under
> Documentation/devicetree/bindings/iio/adc/
>
> Signed-off-by: Naveen Krishna Chatradhi 
> To: devicet...@vger.kernel.org
> ---
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |   82 
> 
>  .../devicetree/bindings/iio/adc/exynos-adc.txt |   82 
> 
>  2 files changed, 82 insertions(+), 82 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/exynos-adc.txt
>

Tip: For only a file move or rename please use "-M" with git
format-patch. That will make the
patch concise.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

Update to reflect the recent file movement to a sub-directory.

Signed-off-by: Sachin Kamat 
---
 MAINTAINERS |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e3a517635eb4..898cf76f8837 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6943,9 +6943,7 @@ M:Thomas Abraham 
 L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
 L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
 S: Maintained
-F: drivers/pinctrl/pinctrl-exynos.*
-F: drivers/pinctrl/pinctrl-s3c*
-F: drivers/pinctrl/pinctrl-samsung.*
+F: drivers/pinctrl/samsung/
 
 PIN CONTROLLER - ST SPEAR
 M: Viresh Kumar 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

[Sachin Kamat]

Hi Wolfram,

On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang  wrote:
> This driver has been flagged to drop class based instantiation. The removal
> improves boot-up time and is unneeded for embedded controllers. Users have 
> been
> warned to switch for some time now, so we can actually do the removal. Keep 
> the
> DEPRECATED flag, so the core can inform users that the behaviour finally
> changed now. After another transition period, this flag can go, too.
> While we are here, remove the indentation for the array setup because
> such things always break after some time.
>
> Signed-off-by: Wolfram Sang 
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c 
> b/drivers/i2c/busses/i2c-s3c2410.c
> index e828a1dba0e5..6252c051525a 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device 
> *pdev)
> s3c24xx_i2c_parse_dt(pdev->dev.of_node, i2c);
>
> strlcpy(i2c->adap.name, "s3c2410-i2c", sizeof(i2c->adap.name));
> -   i2c->adap.owner   = THIS_MODULE;
> -   i2c->adap.algo= _i2c_algorithm;
> +   i2c->adap.owner = THIS_MODULE;
> +   i2c->adap.algo = _i2c_algorithm;
> i2c->adap.retries = 2;
> -   i2c->adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD | 
> I2C_CLASS_DEPRECATED;
> -   i2c->tx_setup = 50;
> +   i2c->adap.class = I2C_CLASS_DEPRECATED;
> +   i2c->tx_setup = 50;
>
> init_waitqueue_head(>wait);
>
> --

Tested on Exynos 5250 boards.
Tested-by: Sachin Kamat 

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

[Sachin Kamat]

Hi Wolfram,

On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang w...@the-dreams.de wrote:
 This driver has been flagged to drop class based instantiation. The removal
 improves boot-up time and is unneeded for embedded controllers. Users have 
 been
 warned to switch for some time now, so we can actually do the removal. Keep 
 the
 DEPRECATED flag, so the core can inform users that the behaviour finally
 changed now. After another transition period, this flag can go, too.
 While we are here, remove the indentation for the array setup because
 such things always break after some time.

 Signed-off-by: Wolfram Sang w...@the-dreams.de
 ---
  drivers/i2c/busses/i2c-s3c2410.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

 diff --git a/drivers/i2c/busses/i2c-s3c2410.c 
 b/drivers/i2c/busses/i2c-s3c2410.c
 index e828a1dba0e5..6252c051525a 100644
 --- a/drivers/i2c/busses/i2c-s3c2410.c
 +++ b/drivers/i2c/busses/i2c-s3c2410.c
 @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device 
 *pdev)
 s3c24xx_i2c_parse_dt(pdev-dev.of_node, i2c);

 strlcpy(i2c-adap.name, s3c2410-i2c, sizeof(i2c-adap.name));
 -   i2c-adap.owner   = THIS_MODULE;
 -   i2c-adap.algo= s3c24xx_i2c_algorithm;
 +   i2c-adap.owner = THIS_MODULE;
 +   i2c-adap.algo = s3c24xx_i2c_algorithm;
 i2c-adap.retries = 2;
 -   i2c-adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD | 
 I2C_CLASS_DEPRECATED;
 -   i2c-tx_setup = 50;
 +   i2c-adap.class = I2C_CLASS_DEPRECATED;
 +   i2c-tx_setup = 50;

 init_waitqueue_head(i2c-wait);

 --

Tested on Exynos 5250 boards.
Tested-by: Sachin Kamat sachin.ka...@samsung.com

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

Update to reflect the recent file movement to a sub-directory.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 MAINTAINERS |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e3a517635eb4..898cf76f8837 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6943,9 +6943,7 @@ M:Thomas Abraham thomas.abra...@linaro.org
 L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
 L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
 S: Maintained
-F: drivers/pinctrl/pinctrl-exynos.*
-F: drivers/pinctrl/pinctrl-s3c*
-F: drivers/pinctrl/pinctrl-samsung.*
+F: drivers/pinctrl/samsung/
 
 PIN CONTROLLER - ST SPEAR
 M: Viresh Kumar viresh.li...@gmail.com
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

[Sachin Kamat]

Hi Naveen,

On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
 The DT bindings in exynos-adc.txt applies to the ADC
 driver (exynos-adc.c) developed based on IIO framework.

 The bindings are more appropriate to be under
 Documentation/devicetree/bindings/iio/adc/

 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 To: devicet...@vger.kernel.org
 ---
  .../devicetree/bindings/arm/samsung/exynos-adc.txt |   82 
 
  .../devicetree/bindings/iio/adc/exynos-adc.txt |   82 
 
  2 files changed, 82 insertions(+), 82 deletions(-)
  delete mode 100644 
 Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
  create mode 100644 Documentation/devicetree/bindings/iio/adc/exynos-adc.txt


Tip: For only a file move or rename please use -M with git
format-patch. That will make the
patch concise.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

[Sachin Kamat]

+ Tomasz

Sorry for missing the maintainer himself :)

On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat sachin.ka...@samsung.com wrote:
 Update to reflect the recent file movement to a sub-directory.

 Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
 ---
  MAINTAINERS |4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

 diff --git a/MAINTAINERS b/MAINTAINERS
 index e3a517635eb4..898cf76f8837 100644
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
 @@ -6943,9 +6943,7 @@ M:Thomas Abraham thomas.abra...@linaro.org
  L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
  L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
  S: Maintained
 -F: drivers/pinctrl/pinctrl-exynos.*
 -F: drivers/pinctrl/pinctrl-s3c*
 -F: drivers/pinctrl/pinctrl-samsung.*
 +F: drivers/pinctrl/samsung/

  PIN CONTROLLER - ST SPEAR
  M: Viresh Kumar viresh.li...@gmail.com
 --
 1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: htc-i2cpld: Remove unused code

[Sachin Kamat]

Removed code unused in this function.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Compile tested.
---
 drivers/mfd/htc-i2cpld.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
 {
struct htcpld_data *htcpld;
-   struct device *dev = pdev-dev;
-   struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
-   struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
 
/* Get the platform and driver data */
-   pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = htcpld-chip[chip_index];
-   plat_chip_data = pdata-chip[chip_index];
 
/* Setup irq handlers */
irq_end = chip-irq_start + chip-nirqs;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: tps65912-spi: Remove unused variable

[Sachin Kamat]

‘rx_buf’ is not used in this function.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/mfd/tps65912-spi.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 69a5178bf152..de60ad98bd9f 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 
addr,
unsigned long spi_data = 1  23 | addr  15 | *data;
struct spi_transfer xfer;
struct spi_message msg;
-   u32 tx_buf, rx_buf;
+   u32 tx_buf;
 
tx_buf = spi_data;
-   rx_buf = 0;
 
xfer.tx_buf = tx_buf;
xfer.rx_buf = NULL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] pinctrl: samsung: Group all drivers in a sub-dir

[Sachin Kamat]

Group all pin control drivers of Samsung platform together in
a sub-directory for easy maintenance.

Signed-off-by: Sachin Kamat 
---
This patch has been inspired by a similar patch [1] from Linus Walleij for
Qualcomm drivers. I have boot tested this patch on Exynos boards and
compile tested for other Samsung platforms.

[1] http://www.spinics.net/lists/arm-kernel/msg345924.html
---
 drivers/pinctrl/Kconfig|   27 +--
 drivers/pinctrl/Makefile   |6 +
 drivers/pinctrl/samsung/Kconfig|   28 
 drivers/pinctrl/samsung/Makefile   |7 +
 drivers/pinctrl/{ => samsung}/pinctrl-exynos.c |0
 drivers/pinctrl/{ => samsung}/pinctrl-exynos.h |0
 drivers/pinctrl/{ => samsung}/pinctrl-exynos5440.c |2 +-
 drivers/pinctrl/{ => samsung}/pinctrl-s3c24xx.c|0
 drivers/pinctrl/{ => samsung}/pinctrl-s3c64xx.c|0
 drivers/pinctrl/{ => samsung}/pinctrl-samsung.c|2 +-
 drivers/pinctrl/{ => samsung}/pinctrl-samsung.h|0
 11 files changed, 39 insertions(+), 33 deletions(-)
 create mode 100644 drivers/pinctrl/samsung/Kconfig
 create mode 100644 drivers/pinctrl/samsung/Makefile
 rename drivers/pinctrl/{ => samsung}/pinctrl-exynos.c (100%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-exynos.h (100%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-exynos5440.c (99%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-s3c24xx.c (100%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-s3c64xx.c (100%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-samsung.c (99%)
 rename drivers/pinctrl/{ => samsung}/pinctrl-samsung.h (100%)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 2744fa2825e0..f8bf9d80fc1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -363,22 +363,6 @@ config PINCTRL_COH901
  COH 901 335 and COH 901 571/3. They contain 3, 5 or 7
  ports of 8 GPIO pins each.
 
-config PINCTRL_SAMSUNG
-   bool
-   select PINMUX
-   select PINCONF
-
-config PINCTRL_EXYNOS
-   bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440"
-   depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)
-   select PINCTRL_SAMSUNG
-
-config PINCTRL_EXYNOS5440
-   bool "Samsung EXYNOS5440 SoC pinctrl driver"
-   depends on SOC_EXYNOS5440
-   select PINMUX
-   select PINCONF
-
 config PINCTRL_PALMAS
bool "Pinctrl driver for the PALMAS Series MFD devices"
depends on OF && MFD_PALMAS
@@ -390,18 +374,9 @@ config PINCTRL_PALMAS
  open drain configuration for the Palmas series devices like
  TPS65913, TPS80036 etc.
 
-config PINCTRL_S3C24XX
-   bool "Samsung S3C24XX SoC pinctrl driver"
-   depends on ARCH_S3C24XX
-   select PINCTRL_SAMSUNG
-
-config PINCTRL_S3C64XX
-   bool "Samsung S3C64XX SoC pinctrl driver"
-   depends on ARCH_S3C64XX
-   select PINCTRL_SAMSUNG
-
 source "drivers/pinctrl/berlin/Kconfig"
 source "drivers/pinctrl/mvebu/Kconfig"
+source "drivers/pinctrl/samsung/Kconfig"
 source "drivers/pinctrl/sh-pfc/Kconfig"
 source "drivers/pinctrl/spear/Kconfig"
 source "drivers/pinctrl/sunxi/Kconfig"
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index c7d8f1b7311f..2ee910dbfe36 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -60,11 +60,6 @@ obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o
 obj-$(CONFIG_PINCTRL_TZ1090_PDC)   += pinctrl-tz1090-pdc.o
 obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o
 obj-$(CONFIG_PINCTRL_COH901)   += pinctrl-coh901.o
-obj-$(CONFIG_PINCTRL_SAMSUNG)  += pinctrl-samsung.o
-obj-$(CONFIG_PINCTRL_EXYNOS)   += pinctrl-exynos.o
-obj-$(CONFIG_PINCTRL_EXYNOS5440)   += pinctrl-exynos5440.o
-obj-$(CONFIG_PINCTRL_S3C24XX)  += pinctrl-s3c24xx.o
-obj-$(CONFIG_PINCTRL_S3C64XX)  += pinctrl-s3c64xx.o
 obj-$(CONFIG_PINCTRL_XWAY) += pinctrl-xway.o
 obj-$(CONFIG_PINCTRL_LANTIQ)   += pinctrl-lantiq.o
 obj-$(CONFIG_PINCTRL_TB10X)+= pinctrl-tb10x.o
@@ -78,3 +73,4 @@ obj-$(CONFIG_SUPERH)  += sh-pfc/
 obj-$(CONFIG_PLAT_SPEAR)   += spear/
 obj-$(CONFIG_ARCH_VT8500)  += vt8500/
 obj-$(CONFIG_ARCH_SUNXI)   += sunxi/
+obj-$(CONFIG_PLAT_SAMSUNG) += samsung/
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
new file mode 100644
index ..d0461cd5d707
--- /dev/null
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -0,0 +1,28 @@
+#
+# Samsung Pin control drivers
+#
+config PINCTRL_SAMSUNG
+   bool
+   select PINMUX
+   select PINCONF
+
+config PINCTRL_EXYNOS
+   bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440"
+   depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)

[PATCH 1/1] pinctrl: samsung: Group all drivers in a sub-dir

[Sachin Kamat]

Group all pin control drivers of Samsung platform together in
a sub-directory for easy maintenance.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
This patch has been inspired by a similar patch [1] from Linus Walleij for
Qualcomm drivers. I have boot tested this patch on Exynos boards and
compile tested for other Samsung platforms.

[1] http://www.spinics.net/lists/arm-kernel/msg345924.html
---
 drivers/pinctrl/Kconfig|   27 +--
 drivers/pinctrl/Makefile   |6 +
 drivers/pinctrl/samsung/Kconfig|   28 
 drivers/pinctrl/samsung/Makefile   |7 +
 drivers/pinctrl/{ = samsung}/pinctrl-exynos.c |0
 drivers/pinctrl/{ = samsung}/pinctrl-exynos.h |0
 drivers/pinctrl/{ = samsung}/pinctrl-exynos5440.c |2 +-
 drivers/pinctrl/{ = samsung}/pinctrl-s3c24xx.c|0
 drivers/pinctrl/{ = samsung}/pinctrl-s3c64xx.c|0
 drivers/pinctrl/{ = samsung}/pinctrl-samsung.c|2 +-
 drivers/pinctrl/{ = samsung}/pinctrl-samsung.h|0
 11 files changed, 39 insertions(+), 33 deletions(-)
 create mode 100644 drivers/pinctrl/samsung/Kconfig
 create mode 100644 drivers/pinctrl/samsung/Makefile
 rename drivers/pinctrl/{ = samsung}/pinctrl-exynos.c (100%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-exynos.h (100%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-exynos5440.c (99%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-s3c24xx.c (100%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-s3c64xx.c (100%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-samsung.c (99%)
 rename drivers/pinctrl/{ = samsung}/pinctrl-samsung.h (100%)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 2744fa2825e0..f8bf9d80fc1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -363,22 +363,6 @@ config PINCTRL_COH901
  COH 901 335 and COH 901 571/3. They contain 3, 5 or 7
  ports of 8 GPIO pins each.
 
-config PINCTRL_SAMSUNG
-   bool
-   select PINMUX
-   select PINCONF
-
-config PINCTRL_EXYNOS
-   bool Pinctrl driver data for Samsung EXYNOS SoCs other than 5440
-   depends on OF  GPIOLIB  (ARCH_EXYNOS || ARCH_S5PV210)
-   select PINCTRL_SAMSUNG
-
-config PINCTRL_EXYNOS5440
-   bool Samsung EXYNOS5440 SoC pinctrl driver
-   depends on SOC_EXYNOS5440
-   select PINMUX
-   select PINCONF
-
 config PINCTRL_PALMAS
bool Pinctrl driver for the PALMAS Series MFD devices
depends on OF  MFD_PALMAS
@@ -390,18 +374,9 @@ config PINCTRL_PALMAS
  open drain configuration for the Palmas series devices like
  TPS65913, TPS80036 etc.
 
-config PINCTRL_S3C24XX
-   bool Samsung S3C24XX SoC pinctrl driver
-   depends on ARCH_S3C24XX
-   select PINCTRL_SAMSUNG
-
-config PINCTRL_S3C64XX
-   bool Samsung S3C64XX SoC pinctrl driver
-   depends on ARCH_S3C64XX
-   select PINCTRL_SAMSUNG
-
 source drivers/pinctrl/berlin/Kconfig
 source drivers/pinctrl/mvebu/Kconfig
+source drivers/pinctrl/samsung/Kconfig
 source drivers/pinctrl/sh-pfc/Kconfig
 source drivers/pinctrl/spear/Kconfig
 source drivers/pinctrl/sunxi/Kconfig
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index c7d8f1b7311f..2ee910dbfe36 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -60,11 +60,6 @@ obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o
 obj-$(CONFIG_PINCTRL_TZ1090_PDC)   += pinctrl-tz1090-pdc.o
 obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o
 obj-$(CONFIG_PINCTRL_COH901)   += pinctrl-coh901.o
-obj-$(CONFIG_PINCTRL_SAMSUNG)  += pinctrl-samsung.o
-obj-$(CONFIG_PINCTRL_EXYNOS)   += pinctrl-exynos.o
-obj-$(CONFIG_PINCTRL_EXYNOS5440)   += pinctrl-exynos5440.o
-obj-$(CONFIG_PINCTRL_S3C24XX)  += pinctrl-s3c24xx.o
-obj-$(CONFIG_PINCTRL_S3C64XX)  += pinctrl-s3c64xx.o
 obj-$(CONFIG_PINCTRL_XWAY) += pinctrl-xway.o
 obj-$(CONFIG_PINCTRL_LANTIQ)   += pinctrl-lantiq.o
 obj-$(CONFIG_PINCTRL_TB10X)+= pinctrl-tb10x.o
@@ -78,3 +73,4 @@ obj-$(CONFIG_SUPERH)  += sh-pfc/
 obj-$(CONFIG_PLAT_SPEAR)   += spear/
 obj-$(CONFIG_ARCH_VT8500)  += vt8500/
 obj-$(CONFIG_ARCH_SUNXI)   += sunxi/
+obj-$(CONFIG_PLAT_SAMSUNG) += samsung/
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
new file mode 100644
index ..d0461cd5d707
--- /dev/null
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -0,0 +1,28 @@
+#
+# Samsung Pin control drivers
+#
+config PINCTRL_SAMSUNG
+   bool
+   select PINMUX
+   select PINCONF
+
+config PINCTRL_EXYNOS
+   bool Pinctrl driver data for Samsung EXYNOS SoCs other than 5440
+   depends on OF  GPIOLIB  (ARCH_EXYNOS || ARCH_S5PV210)
+   select PINCTRL_SAMSUNG
+
+config PINCTRL_EXYNOS5440
+   bool Samsung EXYNOS5440 SoC pinctrl driver
+   depends on SOC_EXYNOS5440
+   select PINMUX
+   select PINCONF
+
+config PINCTRL_S3C24XX
+   bool Samsung

Re: [PATCH 1/3] usb: usb3503: fix build warning

[Sachin Kamat]

Hi Joonyoung,

On Thu, Jul 10, 2014 at 9:53 AM, Joonyoung Shim  wrote:
> This fixes below build warning.
>
> drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
> drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized 
> in this function [-Wmaybe-uninitialized]
> dev_err(dev, "unable to request refclk (%d)\n", err);
>^

This has been fixed and availabe in Greg's usb-next tree.
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next=ec5734c41bee2ee7c938a8f34853d31cada7e67a

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
USB gadget controller supported by the DWC2 gadget driver, make it
depend on them and default to ARCH_EXYNOS as they are meant for
Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat 
---
Changes since v1:
* Added dependency on DWC2 gadget driver as suggested by Tomasz Figa.
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fcdfe7c0e4a7..128f8b92b55c 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -123,43 +123,30 @@ config PHY_SUN4I_USB
 config PHY_SAMSUNG_USB2
tristate "Samsung USB 2.0 PHY driver"
depends on HAS_IOMEM
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool "Support for Exynos 4210"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool "Support for Exynos 4x12"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 4x12. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4x12 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool "Support for Exynos 5250"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat 
---
No changes since v1.
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 128f8b92b55c..ee6c80a5392a 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -152,8 +152,10 @@ config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
depends on ARCH_EXYNOS5 && OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
No changes since v1.
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 128f8b92b55c..ee6c80a5392a 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -152,8 +152,10 @@ config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
depends on ARCH_EXYNOS5  OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and
USB gadget controller supported by the DWC2 gadget driver, make it
depend on them and default to ARCH_EXYNOS as they are meant for
Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Changes since v1:
* Added dependency on DWC2 gadget driver as suggested by Tomasz Figa.
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fcdfe7c0e4a7..128f8b92b55c 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -123,43 +123,30 @@ config PHY_SUN4I_USB
 config PHY_SAMSUNG_USB2
tristate Samsung USB 2.0 PHY driver
depends on HAS_IOMEM
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool Support for Exynos 4210
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool Support for Exynos 4x12
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 4x12. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4x12 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool Support for Exynos 5250
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] usb: usb3503: fix build warning

[Sachin Kamat]

Hi Joonyoung,

On Thu, Jul 10, 2014 at 9:53 AM, Joonyoung Shim jy0922.s...@samsung.com wrote:
 This fixes below build warning.

 drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
 drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized 
 in this function [-Wmaybe-uninitialized]
 dev_err(dev, unable to request refclk (%d)\n, err);
^

This has been fixed and availabe in Greg's usb-next tree.
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-nextid=ec5734c41bee2ee7c938a8f34853d31cada7e67a

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Hi Tomasz,

On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa  wrote:
> On 30.06.2014 10:56, Sachin Kamat wrote:
>> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
>
> That's not true. They are also required for USB gadget controller
> supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the
> change makes sense to me.

Do you propose I amend just the patch description or also add a dependency on
USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based
on your input I will re-spin the patch.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

[Sachin Kamat]

On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo  wrote:
> On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote:
>> Hi Shawn,
>>
>> On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo  wrote:
>> > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
>> >> replace IS_ERR/PTR_ERR
>> >>
>> >> Cc: Shawn Guo 
>> >> Cc: Sascha Hauer 
>> >> Cc: linux-arm-ker...@lists.infradead.org
>> >> Signed-off-by: Fabian Frederick 
>> >
>> > Applied, thanks.
>>
>>
>> I had sent a similar series [1] in May which you rejected. Just
>> curious if something
>> changed between then and now?
>
> The main difference is this is the second attempt from a different
> person to "clean up" the code.  I'm still not fond of the change, but
> I'm getting tied to tell people about that, so just applied the change,
> since after all it at least gives some good diffstat.
>
> I would prefer Fabian's patch over yours because it's really good
> enough to have one patch than 5 patches in a series to do the change for
> IMX platform.

Doesn't really matter whose patches are in. I was just curious to know
the change
in logic at this point of time. Thanks for clarification.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

[Sachin Kamat]

On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo shawn@freescale.com wrote:
 On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote:
 Hi Shawn,

 On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo shawn@freescale.com wrote:
  On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
  replace IS_ERR/PTR_ERR
 
  Cc: Shawn Guo shawn@freescale.com
  Cc: Sascha Hauer ker...@pengutronix.de
  Cc: linux-arm-ker...@lists.infradead.org
  Signed-off-by: Fabian Frederick f...@skynet.be
 
  Applied, thanks.


 I had sent a similar series [1] in May which you rejected. Just
 curious if something
 changed between then and now?

 The main difference is this is the second attempt from a different
 person to clean up the code.  I'm still not fond of the change, but
 I'm getting tied to tell people about that, so just applied the change,
 since after all it at least gives some good diffstat.

 I would prefer Fabian's patch over yours because it's really good
 enough to have one patch than 5 patches in a series to do the change for
 IMX platform.

Doesn't really matter whose patches are in. I was just curious to know
the change
in logic at this point of time. Thanks for clarification.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Hi Tomasz,

On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa t.f...@samsung.com wrote:
 On 30.06.2014 10:56, Sachin Kamat wrote:
 Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,

 That's not true. They are also required for USB gadget controller
 supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the
 change makes sense to me.

Do you propose I amend just the patch description or also add a dependency on
USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based
on your input I will re-spin the patch.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jun 30, 2014 at 2:26 PM, Sachin Kamat  wrote:
> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
> make it depend on them and default to ARCH_EXYNOS as they are meant
> for Exynos platforms. Also, make the sub-drivers silent options enabling
> them based on the SoC platforms that they are meant to work with. This
> will make life easier for end users who do not have any way knowing the
> dependencies.
>
> Signed-off-by: Sachin Kamat 
> ---
>  drivers/phy/Kconfig |   35 +++
>  1 file changed, 11 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 16a2f067c242..9aab5dfb0adf 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -122,43 +122,30 @@ config PHY_SUN4I_USB
>
>  config PHY_SAMSUNG_USB2
> tristate "Samsung USB 2.0 PHY driver"
> +   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS
> select GENERIC_PHY
> select MFD_SYSCON
> +   default ARCH_EXYNOS
> help
>   Enable this to support the Samsung USB 2.0 PHY driver for Samsung
> - SoCs. This driver provides the interface for USB 2.0 PHY. Support 
> for
> - particular SoCs has to be enabled in addition to this driver. Number
> - and type of supported phys depends on the SoC.
> + SoCs. This driver provides the interface for USB 2.0 PHY. Support
> + for particular PHYs will be enabled based on the SoC type in 
> addition
> + to this driver.
>
>  config PHY_EXYNOS4210_USB2
> -   bool "Support for Exynos 4210"
> +   bool
> depends on PHY_SAMSUNG_USB2
> -   depends on CPU_EXYNOS4210
> -   help
> - Enable USB PHY support for Exynos 4210. This option requires that
> - Samsung USB 2.0 PHY driver is enabled and means that support for 
> this
> - particular SoC is compiled in the driver. In case of Exynos 4210 
> four
> - phys are available - device, host, HSIC0 and HSIC1.
> +   default CPU_EXYNOS4210
>
>  config PHY_EXYNOS4X12_USB2
> -   bool "Support for Exynos 4x12"
> +   bool
> depends on PHY_SAMSUNG_USB2
> -   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
> -   help
> - Enable USB PHY support for Exynos 4x12. This option requires that
> - Samsung USB 2.0 PHY driver is enabled and means that support for 
> this
> - particular SoC is compiled in the driver. In case of Exynos 4x12 
> four
> - phys are available - device, host, HSIC0 and HSIC1.
> +   default SOC_EXYNOS4212 || SOC_EXYNOS4412
>
>  config PHY_EXYNOS5250_USB2
> -   bool "Support for Exynos 5250"
> +   bool
> depends on PHY_SAMSUNG_USB2
> -   depends on SOC_EXYNOS5250
> -   help
> - Enable USB PHY support for Exynos 5250. This option requires that
> - Samsung USB 2.0 PHY driver is enabled and means that support for 
> this
> - particular SoC is compiled in the driver. In case of Exynos 5250 
> four
> - phys are available - device, host, HSIC0 and HSIC.
> +   default SOC_EXYNOS5250 || SOC_EXYNOS5420
>
>  config PHY_EXYNOS5_USBDRD
> tristate "Exynos5 SoC series USB DRD PHY driver"
> --
> 1.7.9.5

Kishon,

Any comments on these patches?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

[Sachin Kamat]

Hi Shawn,

On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo  wrote:
> On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
>> replace IS_ERR/PTR_ERR
>>
>> Cc: Shawn Guo 
>> Cc: Sascha Hauer 
>> Cc: linux-arm-ker...@lists.infradead.org
>> Signed-off-by: Fabian Frederick 
>
> Applied, thanks.


I had sent a similar series [1] in May which you rejected. Just
curious if something
changed between then and now?

[1] http://patchwork.ozlabs.org/patch/353653/

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

[Sachin Kamat]

Hi Shawn,

On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo shawn@freescale.com wrote:
 On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
 replace IS_ERR/PTR_ERR

 Cc: Shawn Guo shawn@freescale.com
 Cc: Sascha Hauer ker...@pengutronix.de
 Cc: linux-arm-ker...@lists.infradead.org
 Signed-off-by: Fabian Frederick f...@skynet.be

 Applied, thanks.


I had sent a similar series [1] in May which you rejected. Just
curious if something
changed between then and now?

[1] http://patchwork.ozlabs.org/patch/353653/

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

On Mon, Jun 30, 2014 at 2:26 PM, Sachin Kamat sachin.ka...@samsung.com wrote:
 Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
 make it depend on them and default to ARCH_EXYNOS as they are meant
 for Exynos platforms. Also, make the sub-drivers silent options enabling
 them based on the SoC platforms that they are meant to work with. This
 will make life easier for end users who do not have any way knowing the
 dependencies.

 Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
 ---
  drivers/phy/Kconfig |   35 +++
  1 file changed, 11 insertions(+), 24 deletions(-)

 diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
 index 16a2f067c242..9aab5dfb0adf 100644
 --- a/drivers/phy/Kconfig
 +++ b/drivers/phy/Kconfig
 @@ -122,43 +122,30 @@ config PHY_SUN4I_USB

  config PHY_SAMSUNG_USB2
 tristate Samsung USB 2.0 PHY driver
 +   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS
 select GENERIC_PHY
 select MFD_SYSCON
 +   default ARCH_EXYNOS
 help
   Enable this to support the Samsung USB 2.0 PHY driver for Samsung
 - SoCs. This driver provides the interface for USB 2.0 PHY. Support 
 for
 - particular SoCs has to be enabled in addition to this driver. Number
 - and type of supported phys depends on the SoC.
 + SoCs. This driver provides the interface for USB 2.0 PHY. Support
 + for particular PHYs will be enabled based on the SoC type in 
 addition
 + to this driver.

  config PHY_EXYNOS4210_USB2
 -   bool Support for Exynos 4210
 +   bool
 depends on PHY_SAMSUNG_USB2
 -   depends on CPU_EXYNOS4210
 -   help
 - Enable USB PHY support for Exynos 4210. This option requires that
 - Samsung USB 2.0 PHY driver is enabled and means that support for 
 this
 - particular SoC is compiled in the driver. In case of Exynos 4210 
 four
 - phys are available - device, host, HSIC0 and HSIC1.
 +   default CPU_EXYNOS4210

  config PHY_EXYNOS4X12_USB2
 -   bool Support for Exynos 4x12
 +   bool
 depends on PHY_SAMSUNG_USB2
 -   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
 -   help
 - Enable USB PHY support for Exynos 4x12. This option requires that
 - Samsung USB 2.0 PHY driver is enabled and means that support for 
 this
 - particular SoC is compiled in the driver. In case of Exynos 4x12 
 four
 - phys are available - device, host, HSIC0 and HSIC1.
 +   default SOC_EXYNOS4212 || SOC_EXYNOS4412

  config PHY_EXYNOS5250_USB2
 -   bool Support for Exynos 5250
 +   bool
 depends on PHY_SAMSUNG_USB2
 -   depends on SOC_EXYNOS5250
 -   help
 - Enable USB PHY support for Exynos 5250. This option requires that
 - Samsung USB 2.0 PHY driver is enabled and means that support for 
 this
 - particular SoC is compiled in the driver. In case of Exynos 5250 
 four
 - phys are available - device, host, HSIC0 and HSIC.
 +   default SOC_EXYNOS5250 || SOC_EXYNOS5420

  config PHY_EXYNOS5_USBDRD
 tristate Exynos5 SoC series USB DRD PHY driver
 --
 1.7.9.5

Kishon,

Any comments on these patches?

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

On Sat, Jul 5, 2014 at 6:18 AM, J. Bruce Fields  wrote:
> On Sat, Jul 05, 2014 at 01:10:58AM +1000, Stephen Rothwell wrote:
>> Hi Sachin,
>>
>> On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat  wrote:
>> >
>> > Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
>> > points to a merge
>> > commit:
>> > 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
>> > ("Merge remote-tracking branch 'nfsd/nfsd-next'").
>> >
>> > How do I proceed with this?
>>
>> I guess we get the owner of the tree (possibly) in question involved
>> (cc'd).
>
> Looking at the total diffstat for that branch, it's almost all contained
> in fs/nfsd with a little in include/linux/sunrpc/ and net/sunrpc.  So
> it's extremely unlikely that it would be causing a problem unless you're
> actually testing nfsd.

I found it surprising too as I do not use nfsd. I will try out the things
suggested by Stephen and update.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

On Fri, Jul 4, 2014 at 8:40 PM, Stephen Rothwell  wrote:
> Hi Sachin,
>
> On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat  wrote:
>>
>> Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
>> points to a merge
>> commit:
>> 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
>> ("Merge remote-tracking branch 'nfsd/nfsd-next'").
>>
>> How do I proceed with this?
>
> I guess we get the owner of the tree (possibly) in question involved
> (cc'd).
>
>> Bisect log as follows:
>>
>> git bisect start
>> # good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
>> git bisect good 4c834452aad01531db949414f94f817a86348d59
>> # bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
>> specific files for 20140704
>> git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
>> # bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
>> remote-tracking branch 'md/for-next'
>> git bisect bad de5ea10b7647b299d27a40511772f024629b466d
>> # bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
>> remote-tracking branch 'dmaengine/next'
>> git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
>> # good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
>> remote-tracking branch 'renesas/next'
>> git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
>> # good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
>> remote-tracking branch 'nfs/linux-next'
>> git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
>> # bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
>> remote-tracking branch 'hwmon-staging/hwmon-next'
>> git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
>> # bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
>> remote-tracking branch 'ubifs/linux-next'
>> git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
>> # good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
>> message when compile at i686 arch
>> git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
>> # good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
>> nfsd4_close_open_stateid
>> git bisect good da575690c01993471e38faf3eee1991ee69d7b20
>> # good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
>> session reference without a client reference
>> git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
>> # good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
>> nfsd4_compound_state to cache the nfs4_client
>> git bisect good bdd79ee31bf842051365c798effaffe0e647b501
>> # good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
>> volumes tree sorting criteria
>> git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
>> # bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
>> remote-tracking branch 'nfsd/nfsd-next'
>> git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237
>>
>> Regards,
>> Sachin.
>
> Can you please double check that commit bdd79ee31bf8 is good and commit
> 40556a4c485d is bad.  Also check that commit fdb82f0a3d19 is good.
>
> In that case we have the unlikely event that the (automated) git merge
> is not correct or patches on each side of the merge semantically
> interact badly.
>
> I guess the next thing to try is just Linus' tree (commit 5170a3b24a91)
> merged with the nfsd tree (commit 2fc193cf924e).
>
> You should also post your information about the crash you are
> diagnosing as others may have seen it as well - or know what may cause
> it.

Thanks Stephen. I will give it a try on Monday.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

On Fri, Jul 4, 2014 at 8:40 PM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi Sachin,

 On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat spk.li...@gmail.com wrote:

 Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
 points to a merge
 commit:
 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
 (Merge remote-tracking branch 'nfsd/nfsd-next').

 How do I proceed with this?

 I guess we get the owner of the tree (possibly) in question involved
 (cc'd).

 Bisect log as follows:

 git bisect start
 # good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
 git bisect good 4c834452aad01531db949414f94f817a86348d59
 # bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
 specific files for 20140704
 git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
 # bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
 remote-tracking branch 'md/for-next'
 git bisect bad de5ea10b7647b299d27a40511772f024629b466d
 # bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
 remote-tracking branch 'dmaengine/next'
 git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
 # good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
 remote-tracking branch 'renesas/next'
 git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
 # good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
 remote-tracking branch 'nfs/linux-next'
 git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
 # bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
 remote-tracking branch 'hwmon-staging/hwmon-next'
 git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
 # bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
 remote-tracking branch 'ubifs/linux-next'
 git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
 # good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
 message when compile at i686 arch
 git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
 # good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
 nfsd4_close_open_stateid
 git bisect good da575690c01993471e38faf3eee1991ee69d7b20
 # good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
 session reference without a client reference
 git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
 # good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
 nfsd4_compound_state to cache the nfs4_client
 git bisect good bdd79ee31bf842051365c798effaffe0e647b501
 # good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
 volumes tree sorting criteria
 git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
 # bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
 remote-tracking branch 'nfsd/nfsd-next'
 git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237

 Regards,
 Sachin.

 Can you please double check that commit bdd79ee31bf8 is good and commit
 40556a4c485d is bad.  Also check that commit fdb82f0a3d19 is good.

 In that case we have the unlikely event that the (automated) git merge
 is not correct or patches on each side of the merge semantically
 interact badly.

 I guess the next thing to try is just Linus' tree (commit 5170a3b24a91)
 merged with the nfsd tree (commit 2fc193cf924e).

 You should also post your information about the crash you are
 diagnosing as others may have seen it as well - or know what may cause
 it.

Thanks Stephen. I will give it a try on Monday.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

On Sat, Jul 5, 2014 at 6:18 AM, J. Bruce Fields bfie...@fieldses.org wrote:
 On Sat, Jul 05, 2014 at 01:10:58AM +1000, Stephen Rothwell wrote:
 Hi Sachin,

 On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat spk.li...@gmail.com wrote:
 
  Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
  points to a merge
  commit:
  40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
  (Merge remote-tracking branch 'nfsd/nfsd-next').
 
  How do I proceed with this?

 I guess we get the owner of the tree (possibly) in question involved
 (cc'd).

 Looking at the total diffstat for that branch, it's almost all contained
 in fs/nfsd with a little in include/linux/sunrpc/ and net/sunrpc.  So
 it's extremely unlikely that it would be causing a problem unless you're
 actually testing nfsd.

I found it surprising too as I do not use nfsd. I will try out the things
suggested by Stephen and update.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

[Sachin Kamat]

Hi Tushar,

On Fri, Jul 4, 2014 at 3:01 PM, Tushar Behera  wrote:
> For IOMMU to use on Exynos platforms, we need to enable ARM_DMA_USE_IOMMU. It
> would be better to select it by default when EXYNOS_IOMMU is enabled.
>
> Signed-off-by: Tushar Behera 
> ---
>  drivers/iommu/Kconfig |1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index d260605..54f3ad1a 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -180,6 +180,7 @@ config EXYNOS_IOMMU
> bool "Exynos IOMMU Support"
> depends on ARCH_EXYNOS
> select IOMMU_API
> +   select ARM_DMA_USE_IOMMU
> help
>   Support for the IOMMU (System MMU) of Samsung Exynos application
>   processor family. This enables H/W multimedia accelerators to see
> --

Reviewed-by: Sachin Kamat 

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

Hi Stephen,

Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
points to a merge
commit:
40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
("Merge remote-tracking branch 'nfsd/nfsd-next'").

How do I proceed with this?

Bisect log as follows:

git bisect start
# good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
git bisect good 4c834452aad01531db949414f94f817a86348d59
# bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
specific files for 20140704
git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
# bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
remote-tracking branch 'md/for-next'
git bisect bad de5ea10b7647b299d27a40511772f024629b466d
# bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
remote-tracking branch 'dmaengine/next'
git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
# good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
remote-tracking branch 'renesas/next'
git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
# good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
remote-tracking branch 'nfs/linux-next'
git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
# bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
remote-tracking branch 'hwmon-staging/hwmon-next'
git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
# bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
remote-tracking branch 'ubifs/linux-next'
git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
# good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
message when compile at i686 arch
git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
# good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
nfsd4_close_open_stateid
git bisect good da575690c01993471e38faf3eee1991ee69d7b20
# good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
session reference without a client reference
git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
# good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
nfsd4_compound_state to cache the nfs4_client
git bisect good bdd79ee31bf842051365c798effaffe0e647b501
# good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
volumes tree sorting criteria
git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
# bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
remote-tracking branch 'nfsd/nfsd-next'
git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237

Regards,
Sachin.

On Fri, Jul 4, 2014 at 12:12 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Changes since 20140703:
>
> My fixes tree contains:
> powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
>
> The net tree gained a build failure for which I reverted a commit.
>
> The usb-gadget tree gained a conflict against the usb.current tree.
>
> The staging tree still had its build failure for which I disabled a driver.
>
> The akpm-current tree still had its build failure for which I applied a
> patch.
>
> Non-merge commits (relative to Linus' tree): 3478
>  3383 files changed, 134181 insertions(+), 185822 deletions(-)
>
> 
>
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
> are tracking the linux-next tree using git, you should not use "git pull"
> to do so as that will try to merge the new linux-next release with the
> old one.  You should use "git fetch" and checkout or reset to the new
> master.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: Tree for Jul 4

[Sachin Kamat]

Hi Stephen,

Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
points to a merge
commit:
40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
(Merge remote-tracking branch 'nfsd/nfsd-next').

How do I proceed with this?

Bisect log as follows:

git bisect start
# good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
git bisect good 4c834452aad01531db949414f94f817a86348d59
# bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
specific files for 20140704
git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
# bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
remote-tracking branch 'md/for-next'
git bisect bad de5ea10b7647b299d27a40511772f024629b466d
# bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
remote-tracking branch 'dmaengine/next'
git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
# good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
remote-tracking branch 'renesas/next'
git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
# good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
remote-tracking branch 'nfs/linux-next'
git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
# bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
remote-tracking branch 'hwmon-staging/hwmon-next'
git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
# bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
remote-tracking branch 'ubifs/linux-next'
git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
# good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
message when compile at i686 arch
git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
# good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
nfsd4_close_open_stateid
git bisect good da575690c01993471e38faf3eee1991ee69d7b20
# good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
session reference without a client reference
git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
# good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
nfsd4_compound_state to cache the nfs4_client
git bisect good bdd79ee31bf842051365c798effaffe0e647b501
# good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
volumes tree sorting criteria
git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
# bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
remote-tracking branch 'nfsd/nfsd-next'
git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237

Regards,
Sachin.

On Fri, Jul 4, 2014 at 12:12 PM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi all,

 Changes since 20140703:

 My fixes tree contains:
 powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64

 The net tree gained a build failure for which I reverted a commit.

 The usb-gadget tree gained a conflict against the usb.current tree.

 The staging tree still had its build failure for which I disabled a driver.

 The akpm-current tree still had its build failure for which I applied a
 patch.

 Non-merge commits (relative to Linus' tree): 3478
  3383 files changed, 134181 insertions(+), 185822 deletions(-)

 

 I have created today's linux-next tree at
 git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
 (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
 are tracking the linux-next tree using git, you should not use git pull
 to do so as that will try to merge the new linux-next release with the
 old one.  You should use git fetch and checkout or reset to the new
 master.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

[Sachin Kamat]

Hi Tushar,

On Fri, Jul 4, 2014 at 3:01 PM, Tushar Behera tusha...@samsung.com wrote:
 For IOMMU to use on Exynos platforms, we need to enable ARM_DMA_USE_IOMMU. It
 would be better to select it by default when EXYNOS_IOMMU is enabled.

 Signed-off-by: Tushar Behera tusha...@samsung.com
 ---
  drivers/iommu/Kconfig |1 +
  1 file changed, 1 insertion(+)

 diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
 index d260605..54f3ad1a 100644
 --- a/drivers/iommu/Kconfig
 +++ b/drivers/iommu/Kconfig
 @@ -180,6 +180,7 @@ config EXYNOS_IOMMU
 bool Exynos IOMMU Support
 depends on ARCH_EXYNOS
 select IOMMU_API
 +   select ARM_DMA_USE_IOMMU
 help
   Support for the IOMMU (System MMU) of Samsung Exynos application
   processor family. This enables H/W multimedia accelerators to see
 --

Reviewed-by: Sachin Kamat sachin.ka...@samsung.com

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/6] irq_work: Implement remote queueing

[Sachin Kamat]

On Wed, Jun 25, 2014 at 10:08 PM, Peter Zijlstra  wrote:
> On Wed, Jun 25, 2014 at 10:23:21AM -0600, Stephen Warren wrote:
>> On 06/25/2014 04:19 AM, Peter Zijlstra wrote:
>> > On Wed, Jun 25, 2014 at 03:24:11PM +0530, Srivatsa S. Bhat wrote:
>> >> Wait, that was a stupid idea. hotplug_cfd() already invokes irq_work_run
>> >> indirectly via flush_smp_call_function_queue(). So irq_work_cpu_notify()
>> >> doesn't need to invoke it again, AFAIU. So perhaps we can get rid of
>> >> irq_work_cpu_notify() altogether?
>> >
>> > Just so...
>> >
>> > getting up at 6am and sitting in an airport terminal doesn't seem to
>> > agree with me; any more silly fail here?
>> >
>> > ---
>> > Subject: irq_work: Remove BUG_ON in irq_work_run()
>> > From: Peter Zijlstra 
>> > Date: Wed Jun 25 07:13:07 CEST 2014
>> >
>> > Because of a collision with 8d056c48e486 ("CPU hotplug, smp: flush any
>> > pending IPI callbacks before CPU offline"), which ends up calling
>> > hotplug_cfd()->flush_smp_call_function_queue()->irq_work_run(), which
>> > is not from IRQ context.
>> >
>> > And since that already calls irq_work_run() from the hotplug path,
>> > remove our entire hotplug handling.
>>
>> Tested-by: Stephen Warren 
>>
>> [with the s/static// already mentioned in this thread, obviously:-)]
>
> Right; I pushed out a fixed version right before loosing my tubes at the
> airport :-)
>
> https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/commit/?h=timers/nohz=921d8b81281ecdca686369f52165d04fa3505bd7

This patch fixes boot issue on Exynos5420/5800 based boards with bL
switcher enabled.

FWIW,
Tested-by: Sachin Kamat 

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 09/16] MAINTAINERS: Update Samsunt MFD drivers pattern

[Sachin Kamat]

On Fri, Jul 4, 2014 at 5:23 AM, Sangbeom Kim  wrote:
> On Friday, July 04, 2014 7:08 AM, Joe Perches wrote:
>
>>  F:   drivers/regulator/s2m*.c
>>  F:   drivers/regulator/s5m*.c
>> -F:   drivers/rtc/rtc-sec.c
>>  F:   include/linux/mfd/samsung/
>>
>
> Yes, You are right.
> There is no rtc-sec.c
> Instead, rtc-s5m.c was upstreamed.
> I will post update patch.

Joe,

In any case, if this patch is going to be appled, please fix typo in subject

s/Samsunt/Samsung

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 09/16] MAINTAINERS: Update Samsunt MFD drivers pattern

[Sachin Kamat]

On Fri, Jul 4, 2014 at 5:23 AM, Sangbeom Kim sbki...@samsung.com wrote:
 On Friday, July 04, 2014 7:08 AM, Joe Perches wrote:

  F:   drivers/regulator/s2m*.c
  F:   drivers/regulator/s5m*.c
 -F:   drivers/rtc/rtc-sec.c
  F:   include/linux/mfd/samsung/


 Yes, You are right.
 There is no rtc-sec.c
 Instead, rtc-s5m.c was upstreamed.
 I will post update patch.

Joe,

In any case, if this patch is going to be appled, please fix typo in subject

s/Samsunt/Samsung

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/6] irq_work: Implement remote queueing

[Sachin Kamat]

On Wed, Jun 25, 2014 at 10:08 PM, Peter Zijlstra pet...@infradead.org wrote:
 On Wed, Jun 25, 2014 at 10:23:21AM -0600, Stephen Warren wrote:
 On 06/25/2014 04:19 AM, Peter Zijlstra wrote:
  On Wed, Jun 25, 2014 at 03:24:11PM +0530, Srivatsa S. Bhat wrote:
  Wait, that was a stupid idea. hotplug_cfd() already invokes irq_work_run
  indirectly via flush_smp_call_function_queue(). So irq_work_cpu_notify()
  doesn't need to invoke it again, AFAIU. So perhaps we can get rid of
  irq_work_cpu_notify() altogether?
 
  Just so...
 
  getting up at 6am and sitting in an airport terminal doesn't seem to
  agree with me; any more silly fail here?
 
  ---
  Subject: irq_work: Remove BUG_ON in irq_work_run()
  From: Peter Zijlstra pet...@infradead.org
  Date: Wed Jun 25 07:13:07 CEST 2014
 
  Because of a collision with 8d056c48e486 (CPU hotplug, smp: flush any
  pending IPI callbacks before CPU offline), which ends up calling
  hotplug_cfd()-flush_smp_call_function_queue()-irq_work_run(), which
  is not from IRQ context.
 
  And since that already calls irq_work_run() from the hotplug path,
  remove our entire hotplug handling.

 Tested-by: Stephen Warren swar...@nvidia.com

 [with the s/static// already mentioned in this thread, obviously:-)]

 Right; I pushed out a fixed version right before loosing my tubes at the
 airport :-)

 https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/commit/?h=timers/nohzid=921d8b81281ecdca686369f52165d04fa3505bd7

This patch fixes boot issue on Exynos5420/5800 based boards with bL
switcher enabled.

FWIW,
Tested-by: Sachin Kamat sachin.ka...@samsung.com

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

[Sachin Kamat]

On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I  wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han  wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat 
>>>> Cc: Jingoo Han 
>>>
>>> Acked-by: Jingoo Han 
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>>  drivers/phy/phy-exynos-dp-video.c |5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c 
>>>> b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>>   * published by the Free Software Foundation.
>>>>   */
>>>>
>>>> +#include 
>>>>  #include 
>>>>  #include 
>>>>  #include 
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct 
>>>> platform_device *pdev)
>>>>   phy_set_drvdata(phy, state);
>>>>
>>>>   phy_provider = devm_of_phy_provider_register(dev, 
>>>> of_phy_simple_xlate);
>>>> - if (IS_ERR(phy_provider))
>>>> - return PTR_ERR(phy_provider);
>>>>
>>>> - return 0;
>>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>>>  }
>>>>
>>>>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.

Gentle ping..


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

[Sachin Kamat]

On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote:


 On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
 Hi Kishon,

 On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han jg1@samsung.com wrote:
 On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:

 PTR_ERR_OR_ZERO simplifies the code.

 Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
 Cc: Jingoo Han jg1@samsung.com

 Acked-by: Jingoo Han jg1@samsung.com

 Best regards,
 Jingoo Han

 ---
  drivers/phy/phy-exynos-dp-video.c |5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

 diff --git a/drivers/phy/phy-exynos-dp-video.c 
 b/drivers/phy/phy-exynos-dp-video.c
 index 0786fef842e7..098f822a2fa4 100644
 --- a/drivers/phy/phy-exynos-dp-video.c
 +++ b/drivers/phy/phy-exynos-dp-video.c
 @@ -9,6 +9,7 @@
   * published by the Free Software Foundation.
   */

 +#include linux/err.h
  #include linux/io.h
  #include linux/kernel.h
  #include linux/module.h
 @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct 
 platform_device *pdev)
   phy_set_drvdata(phy, state);

   phy_provider = devm_of_phy_provider_register(dev, 
 of_phy_simple_xlate);
 - if (IS_ERR(phy_provider))
 - return PTR_ERR(phy_provider);

 - return 0;
 + return PTR_ERR_OR_ZERO(phy_provider);
  }

  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
 --
 1.7.9.5



 ping on this series.

 I'll queue to -next once -rc1 is tagged.

Gentle ping..


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi  wrote:
> On 07/01/2014 01:10 PM, Sachin Kamat wrote:
>> Hi Chanwoo,
>>
>> On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi  wrote:
>>> Hi Sachin,
>>>
>>> On 07/01/2014 12:33 PM, Sachin Kamat wrote:
>>>> Hi Chanwoo,
>>>>
>>>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi  wrote:
>>>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high
>>>>> temperature for Exynos3250.
>>>>>
>>>>> Signed-off-by: Chanwoo Choi 
>>>>> Acked-by: Kyungmin Park 
>>>>> ---
>>>>> This patch has a dependency on following patch [1]:
>>>>>  [1] https://lkml.org/lkml/2014/6/30/805
>>>>>
>>>>>  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
>>>>>  1 file changed, 10 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
>>>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> index 3660cab..1e566af 100644
>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> @@ -192,6 +192,16 @@
>>>>> status = "disabled";
>>>>> };
>>>>>
>>>>> +   tmu: tmu@100C {
>>>>> +   compatible = "samsung,exynos3250-tmu";
>>>>> +   interrupt-parent = <>;
>>>>> +   reg = <0x100C 0x100>;
>>>>> +   interrupts = <0 216 0>;
>>>>> +   clocks = < CLK_TMU_APBIF>;
>>>>> +   clock-names = "tmu_apbif";
>>>>> +   status = "disabled";
>>>>
>>>> I don't think there would be any board specific properties needed. Hence
>>>> leave the status as enabled (by deleting the above line).
>>>>
>>>
>>> I think that if specific board need TMU feature, dts file for specific board
>>> should include tmu dt node with 'okay' status. The specific board based on
>>> Exynos3250 might not need TMU feature.
>>
>> The status field in DT node is not meant for stating the build configuration 
>> but
>> represents the readiness of the hardware for usage on the platform. If
>> a particular
>> board does not need this feature it needs to be disabled in the build
>> config and only
>> for any special requirements disable it in board file.
>
> TMU (Thermal Management Unit) needs specific regulator for TMU power as 
> following:
> The regulator for TMU is dependent on board.

In this case it makes sense to leave it disabled in dtsi.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/1] clk: Fix build warnings

[Sachin Kamat]

‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
[-Wunused-variable]

Signed-off-by: Sachin Kamat 
Cc: Peter De Schrijver 
---
Changes since v1:
Moved the definitions under already existing #ifdefs.
---
 drivers/clk/clk.c |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..958967d141ee 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,17 +36,6 @@ static HLIST_HEAD(clk_root_list);
 static HLIST_HEAD(clk_orphan_list);
 static LIST_HEAD(clk_notifier_list);
 
-static struct hlist_head *all_lists[] = {
-   _root_list,
-   _orphan_list,
-   NULL,
-};
-
-static struct hlist_head *orphan_list[] = {
-   _orphan_list,
-   NULL,
-};
-
 /***   locking ***/
 static void clk_prepare_lock(void)
 {
@@ -111,6 +100,17 @@ static void clk_enable_unlock(unsigned long flags)
 static struct dentry *rootdir;
 static int inited = 0;
 
+static struct hlist_head *all_lists[] = {
+   _root_list,
+   _orphan_list,
+   NULL,
+};
+
+static struct hlist_head *orphan_list[] = {
+   _orphan_list,
+   NULL,
+};
+
 static void clk_summary_show_one(struct seq_file *s, struct clk *c, int level)
 {
if (!c)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] clk: Fix build warnings

[Sachin Kamat]

On Mon, Jun 30, 2014 at 7:07 PM, Peter De Schrijver
 wrote:
> On Mon, Jun 30, 2014 at 11:40:54AM +0200, Sachin Kamat wrote:
>> ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
>> Thus, make their compilation conditional to fix the below warnings introduced
>> by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
>> drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
>> [-Wunused-variable]
>> drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
>> [-Wunused-variable]
>>
>
> Maybe just move them inside the existing #ifdef CONFIG_DEBUG_FS / #endif?

That makes sense. Thanks for the hint. Will re-spin.

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] clk: Fix build warnings

[Sachin Kamat]

On Mon, Jun 30, 2014 at 7:07 PM, Peter De Schrijver
pdeschrij...@nvidia.com wrote:
 On Mon, Jun 30, 2014 at 11:40:54AM +0200, Sachin Kamat wrote:
 ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
 Thus, make their compilation conditional to fix the below warnings introduced
 by commit 27b8d5f723 (clk: flatten clk tree in debugfs):
 drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
 [-Wunused-variable]
 drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
 [-Wunused-variable]


 Maybe just move them inside the existing #ifdef CONFIG_DEBUG_FS / #endif?

That makes sense. Thanks for the hint. Will re-spin.

Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/1] clk: Fix build warnings

[Sachin Kamat]

‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 (clk: flatten clk tree in debugfs):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
[-Wunused-variable]

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Cc: Peter De Schrijver pdeschrij...@nvidia.com
---
Changes since v1:
Moved the definitions under already existing #ifdefs.
---
 drivers/clk/clk.c |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..958967d141ee 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,17 +36,6 @@ static HLIST_HEAD(clk_root_list);
 static HLIST_HEAD(clk_orphan_list);
 static LIST_HEAD(clk_notifier_list);
 
-static struct hlist_head *all_lists[] = {
-   clk_root_list,
-   clk_orphan_list,
-   NULL,
-};
-
-static struct hlist_head *orphan_list[] = {
-   clk_orphan_list,
-   NULL,
-};
-
 /***   locking ***/
 static void clk_prepare_lock(void)
 {
@@ -111,6 +100,17 @@ static void clk_enable_unlock(unsigned long flags)
 static struct dentry *rootdir;
 static int inited = 0;
 
+static struct hlist_head *all_lists[] = {
+   clk_root_list,
+   clk_orphan_list,
+   NULL,
+};
+
+static struct hlist_head *orphan_list[] = {
+   clk_orphan_list,
+   NULL,
+};
+
 static void clk_summary_show_one(struct seq_file *s, struct clk *c, int level)
 {
if (!c)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 On 07/01/2014 01:10 PM, Sachin Kamat wrote:
 Hi Chanwoo,

 On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 Hi Sachin,

 On 07/01/2014 12:33 PM, Sachin Kamat wrote:
 Hi Chanwoo,

 On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch add TMU (Thermal Management Unit) dt node to monitor the high
 temperature for Exynos3250.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Acked-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
 This patch has a dependency on following patch [1]:
  [1] https://lkml.org/lkml/2014/6/30/805

  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
 b/arch/arm/boot/dts/exynos3250.dtsi
 index 3660cab..1e566af 100644
 --- a/arch/arm/boot/dts/exynos3250.dtsi
 +++ b/arch/arm/boot/dts/exynos3250.dtsi
 @@ -192,6 +192,16 @@
 status = disabled;
 };

 +   tmu: tmu@100C {
 +   compatible = samsung,exynos3250-tmu;
 +   interrupt-parent = gic;
 +   reg = 0x100C 0x100;
 +   interrupts = 0 216 0;
 +   clocks = cmu CLK_TMU_APBIF;
 +   clock-names = tmu_apbif;
 +   status = disabled;

 I don't think there would be any board specific properties needed. Hence
 leave the status as enabled (by deleting the above line).


 I think that if specific board need TMU feature, dts file for specific board
 should include tmu dt node with 'okay' status. The specific board based on
 Exynos3250 might not need TMU feature.

 The status field in DT node is not meant for stating the build configuration 
 but
 represents the readiness of the hardware for usage on the platform. If
 a particular
 board does not need this feature it needs to be disabled in the build
 config and only
 for any special requirements disable it in board file.

 TMU (Thermal Management Unit) needs specific regulator for TMU power as 
 following:
 The regulator for TMU is dependent on board.

In this case it makes sense to leave it disabled in dtsi.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

Hi Chanwoo,

On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi  wrote:
> Hi Sachin,
>
> On 07/01/2014 12:33 PM, Sachin Kamat wrote:
>> Hi Chanwoo,
>>
>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi  wrote:
>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high
>>> temperature for Exynos3250.
>>>
>>> Signed-off-by: Chanwoo Choi 
>>> Acked-by: Kyungmin Park 
>>> ---
>>> This patch has a dependency on following patch [1]:
>>>  [1] https://lkml.org/lkml/2014/6/30/805
>>>
>>>  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>> index 3660cab..1e566af 100644
>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>> @@ -192,6 +192,16 @@
>>> status = "disabled";
>>> };
>>>
>>> +   tmu: tmu@100C {
>>> +   compatible = "samsung,exynos3250-tmu";
>>> +   interrupt-parent = <>;
>>> +   reg = <0x100C 0x100>;
>>> +   interrupts = <0 216 0>;
>>> +   clocks = < CLK_TMU_APBIF>;
>>> +   clock-names = "tmu_apbif";
>>> +   status = "disabled";
>>
>> I don't think there would be any board specific properties needed. Hence
>> leave the status as enabled (by deleting the above line).
>>
>
> I think that if specific board need TMU feature, dts file for specific board
> should include tmu dt node with 'okay' status. The specific board based on
> Exynos3250 might not need TMU feature.

The status field in DT node is not meant for stating the build configuration but
represents the readiness of the hardware for usage on the platform. If
a particular
board does not need this feature it needs to be disabled in the build
config and only
for any special requirements disable it in board file.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

Hi Chanwoo,

On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi  wrote:
> This patch add TMU (Thermal Management Unit) dt node to monitor the high
> temperature for Exynos3250.
>
> Signed-off-by: Chanwoo Choi 
> Acked-by: Kyungmin Park 
> ---
> This patch has a dependency on following patch [1]:
>  [1] https://lkml.org/lkml/2014/6/30/805
>
>  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 3660cab..1e566af 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -192,6 +192,16 @@
> status = "disabled";
> };
>
> +   tmu: tmu@100C {
> +   compatible = "samsung,exynos3250-tmu";
> +   interrupt-parent = <>;
> +   reg = <0x100C 0x100>;
> +   interrupts = <0 216 0>;
> +   clocks = < CLK_TMU_APBIF>;
> +   clock-names = "tmu_apbif";
> +   status = "disabled";

I don't think there would be any board specific properties needed. Hence
leave the status as enabled (by deleting the above line).

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] clk: Fix build warnings

[Sachin Kamat]

‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
[-Wunused-variable]

Signed-off-by: Sachin Kamat 
Cc: Peter De Schrijver 
---
 drivers/clk/clk.c |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..a95233c14f86 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,6 +36,7 @@ static HLIST_HEAD(clk_root_list);
 static HLIST_HEAD(clk_orphan_list);
 static LIST_HEAD(clk_notifier_list);
 
+#ifdef CONFIG_DEBUG_FS
 static struct hlist_head *all_lists[] = {
_root_list,
_orphan_list,
@@ -46,6 +47,7 @@ static struct hlist_head *orphan_list[] = {
_orphan_list,
NULL,
 };
+#endif
 
 /***   locking ***/
 static void clk_prepare_lock(void)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat 
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 9aab5dfb0adf..6f90ee3c7ed1 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -151,8 +151,10 @@ config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
depends on ARCH_EXYNOS5 && OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
make it depend on them and default to ARCH_EXYNOS as they are meant
for Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat 
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 16a2f067c242..9aab5dfb0adf 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -122,43 +122,30 @@ config PHY_SUN4I_USB
 
 config PHY_SAMSUNG_USB2
tristate "Samsung USB 2.0 PHY driver"
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool "Support for Exynos 4210"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool "Support for Exynos 4x12"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 4x12. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4x12 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool "Support for Exynos 5250"
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate "Exynos5 SoC series USB DRD PHY driver"
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

[Sachin Kamat]

Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
make it depend on them and default to ARCH_EXYNOS as they are meant
for Exynos platforms. Also, make the sub-drivers silent options enabling
them based on the SoC platforms that they are meant to work with. This
will make life easier for end users who do not have any way knowing the
dependencies.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/phy/Kconfig |   35 +++
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 16a2f067c242..9aab5dfb0adf 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -122,43 +122,30 @@ config PHY_SUN4I_USB
 
 config PHY_SAMSUNG_USB2
tristate Samsung USB 2.0 PHY driver
+   depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default ARCH_EXYNOS
help
  Enable this to support the Samsung USB 2.0 PHY driver for Samsung
- SoCs. This driver provides the interface for USB 2.0 PHY. Support for
- particular SoCs has to be enabled in addition to this driver. Number
- and type of supported phys depends on the SoC.
+ SoCs. This driver provides the interface for USB 2.0 PHY. Support
+ for particular PHYs will be enabled based on the SoC type in addition
+ to this driver.
 
 config PHY_EXYNOS4210_USB2
-   bool Support for Exynos 4210
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on CPU_EXYNOS4210
-   help
- Enable USB PHY support for Exynos 4210. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4210 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default CPU_EXYNOS4210
 
 config PHY_EXYNOS4X12_USB2
-   bool Support for Exynos 4x12
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412)
-   help
- Enable USB PHY support for Exynos 4x12. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 4x12 four
- phys are available - device, host, HSIC0 and HSIC1.
+   default SOC_EXYNOS4212 || SOC_EXYNOS4412
 
 config PHY_EXYNOS5250_USB2
-   bool Support for Exynos 5250
+   bool
depends on PHY_SAMSUNG_USB2
-   depends on SOC_EXYNOS5250
-   help
- Enable USB PHY support for Exynos 5250. This option requires that
- Samsung USB 2.0 PHY driver is enabled and means that support for this
- particular SoC is compiled in the driver. In case of Exynos 5250 four
- phys are available - device, host, HSIC0 and HSIC.
+   default SOC_EXYNOS5250 || SOC_EXYNOS5420
 
 config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

[Sachin Kamat]

USB DWC3 driver on Exynos platform does not work without its
corresponding phy driver. Hence make the PHY driver depend on
Exynos DWC3 driver and default it to yes to make things easier
for the end user.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/phy/Kconfig |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 9aab5dfb0adf..6f90ee3c7ed1 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -151,8 +151,10 @@ config PHY_EXYNOS5_USBDRD
tristate Exynos5 SoC series USB DRD PHY driver
depends on ARCH_EXYNOS5  OF
depends on HAS_IOMEM
+   depends on USB_DWC3_EXYNOS
select GENERIC_PHY
select MFD_SYSCON
+   default y
help
  Enable USB DRD PHY support for Exynos 5 SoC series.
  This driver provides PHY interface for USB 3.0 DRD controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] clk: Fix build warnings

[Sachin Kamat]

‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 (clk: flatten clk tree in debugfs):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used 
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used 
[-Wunused-variable]

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Cc: Peter De Schrijver pdeschrij...@nvidia.com
---
 drivers/clk/clk.c |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..a95233c14f86 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,6 +36,7 @@ static HLIST_HEAD(clk_root_list);
 static HLIST_HEAD(clk_orphan_list);
 static LIST_HEAD(clk_notifier_list);
 
+#ifdef CONFIG_DEBUG_FS
 static struct hlist_head *all_lists[] = {
clk_root_list,
clk_orphan_list,
@@ -46,6 +47,7 @@ static struct hlist_head *orphan_list[] = {
clk_orphan_list,
NULL,
 };
+#endif
 
 /***   locking ***/
 static void clk_prepare_lock(void)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

Hi Chanwoo,

On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch add TMU (Thermal Management Unit) dt node to monitor the high
 temperature for Exynos3250.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Acked-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
 This patch has a dependency on following patch [1]:
  [1] https://lkml.org/lkml/2014/6/30/805

  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
 b/arch/arm/boot/dts/exynos3250.dtsi
 index 3660cab..1e566af 100644
 --- a/arch/arm/boot/dts/exynos3250.dtsi
 +++ b/arch/arm/boot/dts/exynos3250.dtsi
 @@ -192,6 +192,16 @@
 status = disabled;
 };

 +   tmu: tmu@100C {
 +   compatible = samsung,exynos3250-tmu;
 +   interrupt-parent = gic;
 +   reg = 0x100C 0x100;
 +   interrupts = 0 216 0;
 +   clocks = cmu CLK_TMU_APBIF;
 +   clock-names = tmu_apbif;
 +   status = disabled;

I don't think there would be any board specific properties needed. Hence
leave the status as enabled (by deleting the above line).

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

[Sachin Kamat]

Hi Chanwoo,

On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 Hi Sachin,

 On 07/01/2014 12:33 PM, Sachin Kamat wrote:
 Hi Chanwoo,

 On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch add TMU (Thermal Management Unit) dt node to monitor the high
 temperature for Exynos3250.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Acked-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
 This patch has a dependency on following patch [1]:
  [1] https://lkml.org/lkml/2014/6/30/805

  arch/arm/boot/dts/exynos3250.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
 b/arch/arm/boot/dts/exynos3250.dtsi
 index 3660cab..1e566af 100644
 --- a/arch/arm/boot/dts/exynos3250.dtsi
 +++ b/arch/arm/boot/dts/exynos3250.dtsi
 @@ -192,6 +192,16 @@
 status = disabled;
 };

 +   tmu: tmu@100C {
 +   compatible = samsung,exynos3250-tmu;
 +   interrupt-parent = gic;
 +   reg = 0x100C 0x100;
 +   interrupts = 0 216 0;
 +   clocks = cmu CLK_TMU_APBIF;
 +   clock-names = tmu_apbif;
 +   status = disabled;

 I don't think there would be any board specific properties needed. Hence
 leave the status as enabled (by deleting the above line).


 I think that if specific board need TMU feature, dts file for specific board
 should include tmu dt node with 'okay' status. The specific board based on
 Exynos3250 might not need TMU feature.

The status field in DT node is not meant for stating the build configuration but
represents the readiness of the hardware for usage on the platform. If
a particular
board does not need this feature it needs to be disabled in the build
config and only
for any special requirements disable it in board file.


-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice

[Sachin Kamat]

Hi Krzysztof,

On Thu, Jun 26, 2014 at 5:16 PM, Krzysztof Kozlowski
 wrote:
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
>
> Signed-off-by: Krzysztof Kozlowski 
> ---

Thanks for the patch.
Reviewed-by: Sachin Kamat 

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice

[Sachin Kamat]

Hi Krzysztof,

On Thu, Jun 26, 2014 at 5:16 PM, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
 Commit b3205dea8fbf (ARM: EXYNOS: Map SYSRAM through generic DT
 bindings) introduced local variable boot_reg where boot address from
 cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
 again.

 Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
 ---

Thanks for the patch.
Reviewed-by: Sachin Kamat sachin.ka...@samsung.com

Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

[Sachin Kamat]

Hi Naveen,

On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi
 wrote:
> This patch removes an extra line and fixes a styling nit
> in exynos5_i2c_message_start()
>
> Signed-off-by: Naveen Krishna Chatradhi 
> ---
>  drivers/i2c/busses/i2c-exynos5.c |3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c 
> b/drivers/i2c/busses/i2c-exynos5.c
> index 0d1a7bc..4c2e6f3 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c 
> *i2c, int stop)
> if (i2c->msg->flags & I2C_M_RD) {
> i2c_ctl |= HSI2C_RXCHON;
>
> -   i2c_auto_conf = HSI2C_READ_WRITE;
> +   i2c_auto_conf |= HSI2C_READ_WRITE;

This change looks more than just a styling nit. Please update the commit message
accordingly.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

[Sachin Kamat]

Hi Naveen,

On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
 This patch removes an extra line and fixes a styling nit
 in exynos5_i2c_message_start()

 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 ---
  drivers/i2c/busses/i2c-exynos5.c |3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

 diff --git a/drivers/i2c/busses/i2c-exynos5.c 
 b/drivers/i2c/busses/i2c-exynos5.c
 index 0d1a7bc..4c2e6f3 100644
 --- a/drivers/i2c/busses/i2c-exynos5.c
 +++ b/drivers/i2c/busses/i2c-exynos5.c
 @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c 
 *i2c, int stop)
 if (i2c-msg-flags  I2C_M_RD) {
 i2c_ctl |= HSI2C_RXCHON;

 -   i2c_auto_conf = HSI2C_READ_WRITE;
 +   i2c_auto_conf |= HSI2C_READ_WRITE;

This change looks more than just a styling nit. Please update the commit message
accordingly.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: pm8921-core: Remove unused variable

[Sachin Kamat]

‘irq_bit’ is unused in the function. Remove it.

Signed-off-by: Sachin Kamat 
---
Compile tested.
---
 drivers/mfd/pm8921-core.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 959513803542..39904f77c049 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
 {
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
-   int irq_bit;
u8  block, config;
 
block = pmirq / 8;
-   irq_bit = pmirq % 8;
 
config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
pm8xxx_config_irq(chip, block, config);
@@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
 {
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
-   int irq_bit;
u8  block, config;
 
block = pmirq / 8;
-   irq_bit = pmirq % 8;
 
config = chip->config[pmirq];
pm8xxx_config_irq(chip, block, config);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] regulator: s5m8767: Remove unused variable

[Sachin Kamat]

'size' is not used in the function. Remove it.

Signed-off-by: Sachin Kamat 
---
 drivers/regulator/s5m8767.c |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index c79af943a5c0..0ab5cbeeb797 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -686,7 +686,7 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
struct sec_platform_data *pdata = iodev->pdata;
struct regulator_config config = { };
struct s5m8767_info *s5m8767;
-   int i, ret, size, buck_init;
+   int i, ret, buck_init;
 
if (!pdata) {
dev_err(pdev->dev.parent, "Platform data not supplied\n");
@@ -725,8 +725,6 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
if (!s5m8767)
return -ENOMEM;
 
-   size = sizeof(struct regulator_dev *) * (S5M8767_REG_MAX - 2);
-
s5m8767->dev = >dev;
s5m8767->iodev = iodev;
s5m8767->num_regulators = pdata->num_regulators;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] regulator: tps65217: Fix build warnings

[Sachin Kamat]

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat 
---
Series compile tested.
---
 drivers/regulator/tps65217-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65217-regulator.c 
b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range 
tps65217_uv2_ranges[] = {
 static int tps65217_pmic_enable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
 static int tps65217_pmic_disable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] regulator: tps65218: Fix build warnings

[Sachin Kamat]

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:
drivers/regulator/tps65218-regulator.c:132:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65218-regulator.c:146:10: warning: comparison of unsigned 
expression < 0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat 
---
 drivers/regulator/tps65218-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65218-regulator.c 
b/drivers/regulator/tps65218-regulator.c
index 69b4b7750410..8b24404be0bd 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -127,7 +127,7 @@ static int tps65218_pmic_set_voltage_sel(struct 
regulator_dev *dev,
 static int tps65218_pmic_enable(struct regulator_dev *dev)
 {
struct tps65218 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
@@ -141,7 +141,7 @@ static int tps65218_pmic_enable(struct regulator_dev *dev)
 static int tps65218_pmic_disable(struct regulator_dev *dev)
 {
struct tps65218 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

[Sachin Kamat]

'name' field was re-initialized and getting overwritten in some
cases possibly due to a typo. Code inspection says the second time
it should be 'sname' instead of 'name'. Replace it.

Signed-off-by: Sachin Kamat 
---
Compile tested only.
---
 drivers/regulator/as3722-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/as3722-regulator.c 
b/drivers/regulator/as3722-regulator.c
index ad9e0c9b7daf..b68f05f38537 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping 
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
-   .name = "vin-ldo3-4",
+   .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping 
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
-   .name = "vin-ldo3-4",
+   .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

[Sachin Kamat]

'name' field was re-initialized and getting overwritten in some
cases possibly due to a typo. Code inspection says the second time
it should be 'sname' instead of 'name'. Replace it.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Compile tested only.
---
 drivers/regulator/as3722-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/as3722-regulator.c 
b/drivers/regulator/as3722-regulator.c
index ad9e0c9b7daf..b68f05f38537 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping 
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = as3722-ldo3,
-   .name = vin-ldo3-4,
+   .sname = vin-ldo3-4,
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping 
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = as3722-ldo4,
-   .name = vin-ldo3-4,
+   .sname = vin-ldo3-4,
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] regulator: tps65218: Fix build warnings

[Sachin Kamat]

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:
drivers/regulator/tps65218-regulator.c:132:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]
drivers/regulator/tps65218-regulator.c:146:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/regulator/tps65218-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65218-regulator.c 
b/drivers/regulator/tps65218-regulator.c
index 69b4b7750410..8b24404be0bd 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -127,7 +127,7 @@ static int tps65218_pmic_set_voltage_sel(struct 
regulator_dev *dev,
 static int tps65218_pmic_enable(struct regulator_dev *dev)
 {
struct tps65218 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65218_DCDC_1 || rid  TPS65218_LDO_1)
return -EINVAL;
@@ -141,7 +141,7 @@ static int tps65218_pmic_enable(struct regulator_dev *dev)
 static int tps65218_pmic_disable(struct regulator_dev *dev)
 {
struct tps65218 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65218_DCDC_1 || rid  TPS65218_LDO_1)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] regulator: tps65217: Fix build warnings

[Sachin Kamat]

rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:

drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned 
expression  0 is always false [-Wtype-limits]

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Series compile tested.
---
 drivers/regulator/tps65217-regulator.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65217-regulator.c 
b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range 
tps65217_uv2_ranges[] = {
 static int tps65217_pmic_enable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65217_DCDC_1 || rid  TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
 static int tps65217_pmic_disable(struct regulator_dev *dev)
 {
struct tps65217 *tps = rdev_get_drvdata(dev);
-   unsigned int rid = rdev_get_id(dev);
+   int rid = rdev_get_id(dev);
 
if (rid  TPS65217_DCDC_1 || rid  TPS65217_LDO_4)
return -EINVAL;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] regulator: s5m8767: Remove unused variable

[Sachin Kamat]

'size' is not used in the function. Remove it.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/regulator/s5m8767.c |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index c79af943a5c0..0ab5cbeeb797 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -686,7 +686,7 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
struct sec_platform_data *pdata = iodev-pdata;
struct regulator_config config = { };
struct s5m8767_info *s5m8767;
-   int i, ret, size, buck_init;
+   int i, ret, buck_init;
 
if (!pdata) {
dev_err(pdev-dev.parent, Platform data not supplied\n);
@@ -725,8 +725,6 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
if (!s5m8767)
return -ENOMEM;
 
-   size = sizeof(struct regulator_dev *) * (S5M8767_REG_MAX - 2);
-
s5m8767-dev = pdev-dev;
s5m8767-iodev = iodev;
s5m8767-num_regulators = pdata-num_regulators;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] mfd: pm8921-core: Remove unused variable

[Sachin Kamat]

‘irq_bit’ is unused in the function. Remove it.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Compile tested.
---
 drivers/mfd/pm8921-core.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 959513803542..39904f77c049 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
 {
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
-   int irq_bit;
u8  block, config;
 
block = pmirq / 8;
-   irq_bit = pmirq % 8;
 
config = chip-config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
pm8xxx_config_irq(chip, block, config);
@@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
 {
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
-   int irq_bit;
u8  block, config;
 
block = pmirq / 8;
-   irq_bit = pmirq % 8;
 
config = chip-config[pmirq];
pm8xxx_config_irq(chip, block, config);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

[Sachin Kamat]

Hi Sherman,

On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin  wrote:
> Hi Sachin,
>
> Looks good, thanks.  How did you come across the need for this change?

Thanks for the review. Sparse threw up a warning while doing a regular build.

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

[Sachin Kamat]

bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat 
---
 drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c 
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
 };
 
-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
 {
struct bcm281xx_pinctrl_data *pdata = _pinctrl;
struct resource *res;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/