Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

[Andi Shyti]

> > > diff --git a/drivers/gpu/drm/i915/i915_active.c 
> > > b/drivers/gpu/drm/i915/i915_active.c
> > > index d960d0be5bd2..cc017e3cc9c5 100644
> > > --- a/drivers/gpu/drm/i915/i915_active.c
> > > +++ b/drivers/gpu/drm/i915/i915_active.c
> > > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct 
> > > i915_active *ref,
> > >   intel_engine_mask_t tmp, mask = engine->mask;
> > >   struct llist_node *first = NULL, *last = NULL;
> > >   struct intel_gt *gt = engine->gt;
> > > - int err;
> > > + int err = 0;
> > 
> > you don't need the initialization here.
> 
> But it's close enough that I can munge the patch inline.
> Reviewed-by: Chris Wilson 

sure... you can also remove it before merging it and it might
also need:

Fixes: d8af05ff38ae7 ("drm/i915: Allow sharing the idle-barrier from other 
kernel requests)

but, yeah...

Reviewed-by: Andi Shyti 

... as well :)

Andi

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

[Chris Wilson]

Quoting Andi Shyti (2020-08-02 12:40:44)
> Hi Tianjia,
> 
> > diff --git a/drivers/gpu/drm/i915/i915_active.c 
> > b/drivers/gpu/drm/i915/i915_active.c
> > index d960d0be5bd2..cc017e3cc9c5 100644
> > --- a/drivers/gpu/drm/i915/i915_active.c
> > +++ b/drivers/gpu/drm/i915/i915_active.c
> > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct 
> > i915_active *ref,
> >   intel_engine_mask_t tmp, mask = engine->mask;
> >   struct llist_node *first = NULL, *last = NULL;
> >   struct intel_gt *gt = engine->gt;
> > - int err;
> > + int err = 0;
> 
> you don't need the initialization here.

But it's close enough that I can munge the patch inline.
Reviewed-by: Chris Wilson 
-Chris