Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Hi! Let me first explain that it was oversight on my side not noticing initials in your SoB tag. But since the issue was raised by Maxime, I didn't follow up. Dne sobota, 13. februar 2021 ob 07:51:32 CET je B.R. Oake napisal(a): > On Wed Feb 10 at 16:01:18 CET 2021, Maxime Ripard wrote: > > Unfortunately we can't take this patch as is, this needs to be your real > > name, see: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#de > > veloper-s-certificate-of-origin-1-1 > Dear Maxime, > > Thank you very much for considering my contribution and for all your > work on supporting sunxi-based hardware; I appreciate it. > > Thank you for referring me to the Developer's Certificate of Origin, but > I had already read it before submitting (I had to do so in order to know > what I was saying by "Signed-off-by:") and I do certify what it says. > > Looking through recent entries in the commit log of the mainline kernel, > I see several patches from authors such as: > > H.J. Lu > B K Karthik > JC Kuo > EJ Hsu > LH Lin > KP Singh > Karthik B S > Shreyas NC > Vandana BN > > so I believe names of this form are in fact acceptable, even if the > style might seem a little old-fashioned to some. Speaking generally, not only for this case, prior art arguments rarely hold, because: - it might be oversight, - it might be a bad practice, which should not be followed in new contributions, - different maintainers have different point of view on same thing, - maintainer wants to adapt new practice or steer subsystem in new direction > > I would like to add that I have met many people with names such as C.J., > A A, TC, MG, etc. That is what everybody calls them and it would be > natural for them to sign themselves that way. Some of them might want to > contribute to Linux some day, and I think it would be a great shame and > a loss to all of us if they were discouraged from doing so by reading > our conversation in the archives and concluding that any contribution > from them, however small, would be summarily refused simply because of > their name. Please could you ensure that does not happen? The link you posted says following: "using your real name (sorry, no pseudonyms or anonymous contributions.)" I believe that real name means no initials, no matter what people are accustomed to. From my point of view, CJ is pseudonym derived from real name. This is not the first time that fix of SoB tag was requested, you can find such requests in ML archives. Best regards, Jernej > > Thank you again for your consideration. > > Yours sincerely, > B.R. Oake.
Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
On Wed Feb 10 at 16:01:18 CET 2021, Maxime Ripard wrote: > Unfortunately we can't take this patch as is, this needs to be your real > name, see: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 Dear Maxime, Thank you very much for considering my contribution and for all your work on supporting sunxi-based hardware; I appreciate it. Thank you for referring me to the Developer's Certificate of Origin, but I had already read it before submitting (I had to do so in order to know what I was saying by "Signed-off-by:") and I do certify what it says. Looking through recent entries in the commit log of the mainline kernel, I see several patches from authors such as: H.J. Lu B K Karthik JC Kuo EJ Hsu LH Lin KP Singh Karthik B S Shreyas NC Vandana BN so I believe names of this form are in fact acceptable, even if the style might seem a little old-fashioned to some. I would like to add that I have met many people with names such as C.J., A A, TC, MG, etc. That is what everybody calls them and it would be natural for them to sign themselves that way. Some of them might want to contribute to Linux some day, and I think it would be a great shame and a loss to all of us if they were discouraged from doing so by reading our conversation in the archives and concluding that any contribution from them, however small, would be summarily refused simply because of their name. Please could you ensure that does not happen? Thank you again for your consideration. Yours sincerely, B.R. Oake.
Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Hi,
On Mon, Feb 08, 2021 at 12:24:57PM +0100, B.R. Oake wrote:
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config"), Ethernet no longer works on the Orange Pi Plus,
> because that commit sets the RX/TX delay according to the phy-mode
> property in the device tree, which is "rgmii", the wrong setting
> for this board.
>
> Following the example of others who fixed the same problem for
> many other boards, this patch changes the phy-mode to "rgmii-id"
> which gets Ethernet working again on this board.
>
> Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
> Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i")
> Signed-off-by: B.R. Oake
Unfortunately we can't take this patch as is, this needs to be your real name,
see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Maxime
signature.asc
Description: PGP signature
[PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
delay config"), Ethernet no longer works on the Orange Pi Plus,
because that commit sets the RX/TX delay according to the phy-mode
property in the device tree, which is "rgmii", the wrong setting
for this board.
Following the example of others who fixed the same problem for
many other boards, this patch changes the phy-mode to "rgmii-id"
which gets Ethernet working again on this board.
Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i")
Signed-off-by: B.R. Oake
---
arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
index 97f497854e..d05fa679dc 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
@@ -85,7 +85,7 @@
pinctrl-0 = <_rgmii_pins>;
phy-supply = <_gmac_3v3>;
phy-handle = <_rgmii_phy>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.20.1
Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Dne ponedeljek, 08. februar 2021 ob 12:24:57 CET je B.R. Oake napisal(a):
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config"), Ethernet no longer works on the Orange Pi Plus,
> because that commit sets the RX/TX delay according to the phy-mode
> property in the device tree, which is "rgmii", the wrong setting
> for this board.
>
> Following the example of others who fixed the same problem for
> many other boards, this patch changes the phy-mode to "rgmii-id"
> which gets Ethernet working again on this board.
>
> Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
> Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i")
> Signed-off-by: B.R. Oake
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Jernej Skrabec
Thanks!
Best regards,
Jernej
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/
dts/sun8i-h3-orangepi-plus.dts
> index 97f497854e..d05fa679dc 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -85,7 +85,7 @@
> pinctrl-0 = <_rgmii_pins>;
> phy-supply = <_gmac_3v3>;
> phy-handle = <_rgmii_phy>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
>
> status = "okay";
> };
> --
> 2.20.1
>
>
