Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Linus Walleij]

On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann  wrote:
> On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
>  wrote:
>> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:
>>
>>> We cannot select the option when SERIAL_8250 is not also set:
>>>
>>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
>>> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>>
>>> This removes the 'select' statement, requiring that users enable the
>>> option manually. Alternatively, we could make it a conditional
>>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>>> of other symbols that it depends on.
>>>
>>> Signed-off-by: Arnd Bergmann 
>>
>> Reviewed-by: Linus Walleij 
>>
>> Will you apply this directly to the interestingly misspelled
>> "gemeni/multiplatform" branch in the ARM SoC tree
>> directly?
>>
>> I will send pull requests on top of that branch later
>> for more features.
>
> If you are going to send more pull requests, just add the fixup there,
> it's not urgent.

OK thanks, I'll queue it.

Yours,
Linus Walleij

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Linus Walleij]

On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann  wrote:
> On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
>  wrote:
>> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:
>>
>>> We cannot select the option when SERIAL_8250 is not also set:
>>>
>>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
>>> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>>
>>> This removes the 'select' statement, requiring that users enable the
>>> option manually. Alternatively, we could make it a conditional
>>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>>> of other symbols that it depends on.
>>>
>>> Signed-off-by: Arnd Bergmann 
>>
>> Reviewed-by: Linus Walleij 
>>
>> Will you apply this directly to the interestingly misspelled
>> "gemeni/multiplatform" branch in the ARM SoC tree
>> directly?
>>
>> I will send pull requests on top of that branch later
>> for more features.
>
> If you are going to send more pull requests, just add the fixup there,
> it's not urgent.

OK thanks, I'll queue it.

Yours,
Linus Walleij

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Arnd Bergmann]

On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
 wrote:
> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:
>
>> We cannot select the option when SERIAL_8250 is not also set:
>>
>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
>> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>
>> This removes the 'select' statement, requiring that users enable the
>> option manually. Alternatively, we could make it a conditional
>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>> of other symbols that it depends on.
>>
>> Signed-off-by: Arnd Bergmann 
>
> Reviewed-by: Linus Walleij 
>
> Will you apply this directly to the interestingly misspelled
> "gemeni/multiplatform" branch in the ARM SoC tree
> directly?
>
> I will send pull requests on top of that branch later
> for more features.

If you are going to send more pull requests, just add the fixup there,
it's not urgent.

  Arnd

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Arnd Bergmann]

On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij
 wrote:
> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:
>
>> We cannot select the option when SERIAL_8250 is not also set:
>>
>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
>> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>>
>> This removes the 'select' statement, requiring that users enable the
>> option manually. Alternatively, we could make it a conditional
>> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
>> of other symbols that it depends on.
>>
>> Signed-off-by: Arnd Bergmann 
>
> Reviewed-by: Linus Walleij 
>
> Will you apply this directly to the interestingly misspelled
> "gemeni/multiplatform" branch in the ARM SoC tree
> directly?
>
> I will send pull requests on top of that branch later
> for more features.

If you are going to send more pull requests, just add the fixup there,
it's not urgent.

  Arnd

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Linus Walleij]

On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:

> We cannot select the option when SERIAL_8250 is not also set:
>
> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>
> This removes the 'select' statement, requiring that users enable the
> option manually. Alternatively, we could make it a conditional
> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
> of other symbols that it depends on.
>
> Signed-off-by: Arnd Bergmann 

Reviewed-by: Linus Walleij 

Will you apply this directly to the interestingly misspelled
"gemeni/multiplatform" branch in the ARM SoC tree
directly?

I will send pull requests on top of that branch later
for more features.

Yours,
Linus Walleij

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Linus Walleij]

On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann  wrote:

> We cannot select the option when SERIAL_8250 is not also set:
>
> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
> dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)
>
> This removes the 'select' statement, requiring that users enable the
> option manually. Alternatively, we could make it a conditional
> 'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
> of other symbols that it depends on.
>
> Signed-off-by: Arnd Bergmann 

Reviewed-by: Linus Walleij 

Will you apply this directly to the interestingly misspelled
"gemeni/multiplatform" branch in the ARM SoC tree
directly?

I will send pull requests on top of that branch later
for more features.

Yours,
Linus Walleij

[PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Arnd Bergmann]

We cannot select the option when SERIAL_8250 is not also set:

warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)

This removes the 'select' statement, requiring that users enable the
option manually. Alternatively, we could make it a conditional
'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
of other symbols that it depends on.

Signed-off-by: Arnd Bergmann 
---
 arch/arm/mach-gemini/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-gemini/Kconfig b/arch/arm/mach-gemini/Kconfig
index a5ee5fbab796..4162396af6de 100644
--- a/arch/arm/mach-gemini/Kconfig
+++ b/arch/arm/mach-gemini/Kconfig
@@ -8,6 +8,5 @@ menuconfig ARCH_GEMINI
select GPIOLIB
select POWER_RESET
select POWER_RESET_SYSCON
-   select SERIAL_OF_PLATFORM
help
  Support for the Cortina Systems Gemini family SoCs
-- 
2.9.0

[PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

[Arnd Bergmann]

We cannot select the option when SERIAL_8250 is not also set:

warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct 
dependencies (TTY && HAS_IOMEM && SERIAL_8250 && OF)

This removes the 'select' statement, requiring that users enable the
option manually. Alternatively, we could make it a conditional
'select SERIAL_OF_PLATFORM if SERIAL_8250' or also select a handful
of other symbols that it depends on.

Signed-off-by: Arnd Bergmann 
---
 arch/arm/mach-gemini/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-gemini/Kconfig b/arch/arm/mach-gemini/Kconfig
index a5ee5fbab796..4162396af6de 100644
--- a/arch/arm/mach-gemini/Kconfig
+++ b/arch/arm/mach-gemini/Kconfig
@@ -8,6 +8,5 @@ menuconfig ARCH_GEMINI
select GPIOLIB
select POWER_RESET
select POWER_RESET_SYSCON
-   select SERIAL_OF_PLATFORM
help
  Support for the Cortina Systems Gemini family SoCs
-- 
2.9.0