Re: [PATCH] BTRFS: fixed coding style issues
On Tue, Nov 05, 2013 at 09:02:01AM +0200, Aldo Iljazi wrote: > Line 4989: Inserted a space after the comma. > Lines 7986 and 8274: Inserted a space before the open parenthesis. Hm, I don't know why my message from yesterday did not make it to the list, but I'm objecting against flow of such changes that are not always actual changes (replacing spaces by tabs). We don't really need them at this point of development phase of btrfs. The style issues should be fixed when a patch is being merged, doing it afterwards increases patch history and makes digging in history unnecessarily tedious. There are lots of opportunities to do actual code cleanup, whitespaces are just noise. david -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] BTRFS: fixed coding style issues
On Tue, Nov 05, 2013 at 09:02:01AM +0200, Aldo Iljazi wrote: Line 4989: Inserted a space after the comma. Lines 7986 and 8274: Inserted a space before the open parenthesis. Hm, I don't know why my message from yesterday did not make it to the list, but I'm objecting against flow of such changes that are not always actual changes (replacing spaces by tabs). We don't really need them at this point of development phase of btrfs. The style issues should be fixed when a patch is being merged, doing it afterwards increases patch history and makes digging in history unnecessarily tedious. There are lots of opportunities to do actual code cleanup, whitespaces are just noise. david -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] BTRFS: fixed coding style issues
Line 4989: Inserted a space after the comma.
Lines 7986 and 8274: Inserted a space before the open parenthesis.
Signed-off-by: Aldo Iljazi
---
fs/btrfs/extent-tree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index d58bef1..3bcd7c0 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4986,7 +4986,7 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode,
u64 num_bytes)
mutex_unlock(_I(inode)->delalloc_mutex);
if (to_reserve)
- trace_btrfs_space_reservation(root->fs_info,"delalloc",
+ trace_btrfs_space_reservation(root->fs_info, "delalloc",
btrfs_ino(inode), to_reserve, 1);
block_rsv_add_bytes(block_rsv, to_reserve, 1);
@@ -7983,7 +7983,7 @@ u64 btrfs_account_ro_block_groups_free_space(struct
btrfs_space_info *sinfo)
spin_lock(>lock);
- for(i = 0; i < BTRFS_NR_RAID_TYPES; i++)
+ for (i = 0; i < BTRFS_NR_RAID_TYPES; i++)
if (!list_empty(>block_groups[i]))
free_bytes += __btrfs_get_ro_block_group_free_space(
>block_groups[i]);
@@ -8271,7 +8271,7 @@ int btrfs_free_block_groups(struct btrfs_fs_info *info)
release_global_block_rsv(info);
- while(!list_empty(>space_info)) {
+ while (!list_empty(>space_info)) {
space_info = list_entry(info->space_info.next,
struct btrfs_space_info,
list);
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] BTRFS: fixed coding style issues
Line 4989: Inserted a space after the comma.
Lines 7986 and 8274: Inserted a space before the open parenthesis.
Signed-off-by: Aldo Iljazi m...@aldo.io
---
fs/btrfs/extent-tree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index d58bef1..3bcd7c0 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4986,7 +4986,7 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode,
u64 num_bytes)
mutex_unlock(BTRFS_I(inode)-delalloc_mutex);
if (to_reserve)
- trace_btrfs_space_reservation(root-fs_info,delalloc,
+ trace_btrfs_space_reservation(root-fs_info, delalloc,
btrfs_ino(inode), to_reserve, 1);
block_rsv_add_bytes(block_rsv, to_reserve, 1);
@@ -7983,7 +7983,7 @@ u64 btrfs_account_ro_block_groups_free_space(struct
btrfs_space_info *sinfo)
spin_lock(sinfo-lock);
- for(i = 0; i BTRFS_NR_RAID_TYPES; i++)
+ for (i = 0; i BTRFS_NR_RAID_TYPES; i++)
if (!list_empty(sinfo-block_groups[i]))
free_bytes += __btrfs_get_ro_block_group_free_space(
sinfo-block_groups[i]);
@@ -8271,7 +8271,7 @@ int btrfs_free_block_groups(struct btrfs_fs_info *info)
release_global_block_rsv(info);
- while(!list_empty(info-space_info)) {
+ while (!list_empty(info-space_info)) {
space_info = list_entry(info-space_info.next,
struct btrfs_space_info,
list);
--
1.8.3.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
