Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings
When you're writing the subject you don't need to add the "Drivers:" bit. That is understood. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings
When you're writing the subject you don't need to add the Drivers: bit. That is understood. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings
On Sun, Oct 14, 2012 at 09:48:29PM +0900, Sangho Yi wrote: > On drivers/staging/csr/csr_time.h, there were a few warnings on > indentation, braces, and typedef struct usage. > All those were changed to the proper way. No, as I explained in the talk, only do one thing at a time here. So, one patch for the indentation, one patch for the braces, and then, one patch for the typedef. And, with the typedef change, did you just break the build? If not, then the whole structure can be removed, right? So, care to redo this? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Drivers: Staging: CSR: Fixed coding style warnings
On drivers/staging/csr/csr_time.h, there were a few warnings on
indentation, braces, and typedef struct usage.
All those were changed to the proper way.
Signed-off-by: Sangho Yi
---
drivers/staging/csr/csr_time.h | 72
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/csr/csr_time.h b/drivers/staging/csr/csr_time.h
index 2a45f3e..66f1c08 100644
--- a/drivers/staging/csr/csr_time.h
+++ b/drivers/staging/csr/csr_time.h
@@ -2,11 +2,11 @@
#define CSR_TIME_H__
/*
-(c) Cambridge Silicon Radio Limited 2010
-All rights reserved and confidential information of CSR
+(c) Cambridge Silicon Radio Limited 2010
+All rights reserved and confidential information of CSR
-Refer to LICENSE.txt included with this source for details
-on the license terms.
+Refer to LICENSE.txt included with this source for details
+on the license terms.
*/
@@ -18,13 +18,13 @@ extern "C" {
/***
-NAME
-CsrTime
+NAME
+ CsrTime
-DESCRIPTION
-Type to hold a value describing the current system time, which is a
-measure of time elapsed since some arbitrarily defined fixed time
-reference, usually associated with system startup.
+DESCRIPTION
+ Type to hold a value describing the current system time, which is a
+ measure of time elapsed since some arbitrarily defined fixed time
+ reference, usually associated with system startup.
***/
typedef u32 CsrTime;
@@ -32,44 +32,44 @@ typedef u32 CsrTime;
/***
-NAME
-CsrTimeUtc
+NAME
+ CsrTimeUtc
-DESCRIPTION
-Type to hold a value describing a UTC wallclock time expressed in
-seconds and milliseconds elapsed since midnight January 1st 1970.
+DESCRIPTION
+ Type to hold a value describing a UTC wallclock time expressed in
+ seconds and milliseconds elapsed since midnight January 1st 1970.
***/
-typedef struct
-{
-u32 sec;
-u16 msec;
-} CsrTimeUtc;
+struct CstTimeUtc {
+ u32 sec;
+ u16 msec;
+};
/***
-NAME
-CsrTimeGet
+NAME
+ CsrTimeGet
-DESCRIPTION
-Returns the current system time in a low and a high part. The low part
-is expressed in microseconds. The high part is incremented when the low
-part wraps to provide an extended range.
+DESCRIPTION
+ Returns the current system time in a low and a high part. The low part
+ is expressed in microseconds. The high part is incremented when the low
+ part wraps to provide an extended range.
-The caller may provide a NULL pointer as the high parameter. In this
case
-the function just returns the low part and ignores the high parameter.
+ The caller may provide a NULL pointer as the high parameter.
+ In this case the function just returns the low part and ignores the
+ high parameter.
-Although the time is expressed in microseconds the actual resolution is
-platform dependent and can be less. It is recommended that the
-resolution is at least 10 milliseconds.
+ Although the time is expressed in microseconds the actual resolution is
+ platform dependent and can be less. It is recommended that the
+ resolution is at least 10 milliseconds.
-PARAMETERS
-high - Pointer to variable that will receive the high part of the
- current system time. Passing NULL is valid.
+PARAMETERS
+ high - Pointer to variable that will receive the high part of the
+ current system time. Passing NULL is valid.
-RETURNS
-Low part of current system time in microseconds.
+RETURNS
+ Low part of current system time in microseconds.
***/
CsrTime CsrTimeGet(CsrTime *high);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Drivers: Staging: CSR: Fixed coding style warnings
On drivers/staging/csr/csr_time.h, there were a few warnings on
indentation, braces, and typedef struct usage.
All those were changed to the proper way.
Signed-off-by: Sangho Yi antir...@gmail.com
---
drivers/staging/csr/csr_time.h | 72
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/csr/csr_time.h b/drivers/staging/csr/csr_time.h
index 2a45f3e..66f1c08 100644
--- a/drivers/staging/csr/csr_time.h
+++ b/drivers/staging/csr/csr_time.h
@@ -2,11 +2,11 @@
#define CSR_TIME_H__
/*
-(c) Cambridge Silicon Radio Limited 2010
-All rights reserved and confidential information of CSR
+(c) Cambridge Silicon Radio Limited 2010
+All rights reserved and confidential information of CSR
-Refer to LICENSE.txt included with this source for details
-on the license terms.
+Refer to LICENSE.txt included with this source for details
+on the license terms.
*/
@@ -18,13 +18,13 @@ extern C {
/***
-NAME
-CsrTime
+NAME
+ CsrTime
-DESCRIPTION
-Type to hold a value describing the current system time, which is a
-measure of time elapsed since some arbitrarily defined fixed time
-reference, usually associated with system startup.
+DESCRIPTION
+ Type to hold a value describing the current system time, which is a
+ measure of time elapsed since some arbitrarily defined fixed time
+ reference, usually associated with system startup.
***/
typedef u32 CsrTime;
@@ -32,44 +32,44 @@ typedef u32 CsrTime;
/***
-NAME
-CsrTimeUtc
+NAME
+ CsrTimeUtc
-DESCRIPTION
-Type to hold a value describing a UTC wallclock time expressed in
-seconds and milliseconds elapsed since midnight January 1st 1970.
+DESCRIPTION
+ Type to hold a value describing a UTC wallclock time expressed in
+ seconds and milliseconds elapsed since midnight January 1st 1970.
***/
-typedef struct
-{
-u32 sec;
-u16 msec;
-} CsrTimeUtc;
+struct CstTimeUtc {
+ u32 sec;
+ u16 msec;
+};
/***
-NAME
-CsrTimeGet
+NAME
+ CsrTimeGet
-DESCRIPTION
-Returns the current system time in a low and a high part. The low part
-is expressed in microseconds. The high part is incremented when the low
-part wraps to provide an extended range.
+DESCRIPTION
+ Returns the current system time in a low and a high part. The low part
+ is expressed in microseconds. The high part is incremented when the low
+ part wraps to provide an extended range.
-The caller may provide a NULL pointer as the high parameter. In this
case
-the function just returns the low part and ignores the high parameter.
+ The caller may provide a NULL pointer as the high parameter.
+ In this case the function just returns the low part and ignores the
+ high parameter.
-Although the time is expressed in microseconds the actual resolution is
-platform dependent and can be less. It is recommended that the
-resolution is at least 10 milliseconds.
+ Although the time is expressed in microseconds the actual resolution is
+ platform dependent and can be less. It is recommended that the
+ resolution is at least 10 milliseconds.
-PARAMETERS
-high - Pointer to variable that will receive the high part of the
- current system time. Passing NULL is valid.
+PARAMETERS
+ high - Pointer to variable that will receive the high part of the
+ current system time. Passing NULL is valid.
-RETURNS
-Low part of current system time in microseconds.
+RETURNS
+ Low part of current system time in microseconds.
***/
CsrTime CsrTimeGet(CsrTime *high);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings
On Sun, Oct 14, 2012 at 09:48:29PM +0900, Sangho Yi wrote: On drivers/staging/csr/csr_time.h, there were a few warnings on indentation, braces, and typedef struct usage. All those were changed to the proper way. No, as I explained in the talk, only do one thing at a time here. So, one patch for the indentation, one patch for the braces, and then, one patch for the typedef. And, with the typedef change, did you just break the build? If not, then the whole structure can be removed, right? So, care to redo this? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
