Re: [PATCH] Drivers: unisys: visorhba - style fix

[Dan Carpenter]

Drivers is never a valid subsystem.  Do a `git log --oneline ` to
look at what other people are doing.  The style varies by subsystem so
you should always run that command.

regards,
dan carpenter

Re: [PATCH] Drivers: unisys: visorhba - style fix

[Dan Carpenter]

Drivers is never a valid subsystem.  Do a `git log --oneline ` to
look at what other people are doing.  The style varies by subsystem so
you should always run that command.

regards,
dan carpenter

RE: [PATCH] Drivers: unisys: visorhba - style fix

[Kershner, David A]

> -Original Message-
> From: Derek Robson [mailto:robso...@gmail.com]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A <david.kersh...@unisys.com>;
> gre...@linuxfoundation.org; Binder, David Anthony
> <david.bin...@unisys.com>; Sell, Timothy C <timothy.s...@unisys.com>;
> Wadgaonkar, Sameer Laxmikant <sameer.wadgaon...@unisys.com>;
> Thompson, Bryan E. <bryan.thomp...@unisys.com>; robso...@gmail.com
> Cc: *S-Par-Maintainer <sparmaintai...@unisys.com>;
> de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robso...@gmail.com>

Acked-by: David Kershner <david.kersh...@unisys.com>

> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>   goto err_scsi_remove_host;
>   }
>   devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
>   devdata->debugfs_dir, devdata,
>   _debugfs_fops);
>   if (!devdata->debugfs_info) {
> --
> 2.13.0

RE: [PATCH] Drivers: unisys: visorhba - style fix

[Kershner, David A]

> -Original Message-
> From: Derek Robson [mailto:robso...@gmail.com]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A ;
> gre...@linuxfoundation.org; Binder, David Anthony
> ; Sell, Timothy C ;
> Wadgaonkar, Sameer Laxmikant ;
> Thompson, Bryan E. ; robso...@gmail.com
> Cc: *S-Par-Maintainer ;
> de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson 

Acked-by: David Kershner 

> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>   goto err_scsi_remove_host;
>   }
>   devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
>   devdata->debugfs_dir, devdata,
>   _debugfs_fops);
>   if (!devdata->debugfs_info) {
> --
> 2.13.0

[PATCH] Drivers: unisys: visorhba - style fix

[Derek Robson]

Fixed style of permissions to octal.
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c 
b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
goto err_scsi_remove_host;
}
devdata->debugfs_info =
-   debugfs_create_file("info", S_IRUSR | S_IRGRP,
+   debugfs_create_file("info", 0440,
devdata->debugfs_dir, devdata,
_debugfs_fops);
if (!devdata->debugfs_info) {
-- 
2.13.0

[PATCH] Drivers: unisys: visorhba - style fix

[Derek Robson]

Fixed style of permissions to octal.
Found using checkpatch

Signed-off-by: Derek Robson 
---
 drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c 
b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
goto err_scsi_remove_host;
}
devdata->debugfs_info =
-   debugfs_create_file("info", S_IRUSR | S_IRGRP,
+   debugfs_create_file("info", 0440,
devdata->debugfs_dir, devdata,
_debugfs_fops);
if (!devdata->debugfs_info) {
-- 
2.13.0