Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

[Dan Carpenter]

On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote:
> From: Dmitrii Wolf 
> 
> Signed-off-by: Dmitrii Wolf 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c 
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index 690b664df8fa..29a6ce20e2bd 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -2048,12 +2048,12 @@ void ieee80211_softmac_xmit(struct ieee80211_txb 
> *txb, struct ieee80211_device *
>   /* if xmit available, just xmit it immediately, else just insert it to 
> the wait queue */
>   for (i = 0; i < txb->nr_frags; i++) {
>  #ifdef USB_TX_DRIVER_AGGREGATION_ENABLE
> - if ((skb_queue_len(>skb_drv_aggQ[queue_index]) != 0) ||
> + if ((skb_queue_len(>skb_drv_aggQ[queue_index]) != 0)
>  #else
> - if ((skb_queue_len(>skb_waitQ[queue_index]) != 0) ||
> + if ((skb_queue_len(>skb_waitQ[queue_index]) != 0)
>  #endif
> - (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) || \
> - (ieee->queue_stop)) {
> +  || (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) \
> +  || (ieee->queue_stop)) {

No.  The || go on the end, the way the original code had it.  I've no
idea what you were trying to fix.  Maybe the \ characters?

regards,
dan carpenter

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

[Greg KH]

On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote:
> From: Dmitrii Wolf 
> 
> Signed-off-by: Dmitrii Wolf 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

[dev . dragon]

From: Dmitrii Wolf 

Signed-off-by: Dmitrii Wolf 
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 690b664df8fa..29a6ce20e2bd 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -2048,12 +2048,12 @@ void ieee80211_softmac_xmit(struct ieee80211_txb *txb, 
struct ieee80211_device *
/* if xmit available, just xmit it immediately, else just insert it to 
the wait queue */
for (i = 0; i < txb->nr_frags; i++) {
 #ifdef USB_TX_DRIVER_AGGREGATION_ENABLE
-   if ((skb_queue_len(>skb_drv_aggQ[queue_index]) != 0) ||
+   if ((skb_queue_len(>skb_drv_aggQ[queue_index]) != 0)
 #else
-   if ((skb_queue_len(>skb_waitQ[queue_index]) != 0) ||
+   if ((skb_queue_len(>skb_waitQ[queue_index]) != 0)
 #endif
-   (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) || \
-   (ieee->queue_stop)) {
+|| (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) \
+|| (ieee->queue_stop)) {
/* insert the skb packet to the wait queue */
/* as for the completion function, it does not need
 * to check it any more.
-- 
2.25.1