Re: [PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices
Hi,
On Tue, Mar 02, 2021 at 12:23:09AM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai
>
> The macros for the clock and reset indices for the RSB hardware block
> were replaced with raw numbers when the RSB controller node was added.
> This was done to avoid cross-tree dependencies.
>
> Now that both the clk and DT changes have been merged, we can switch
> back to using the macros.
>
> Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
> Signed-off-by: Chen-Yu Tsai
> ---
>
> Small patch split out from the H6 RSB clock support patch.
> This should be merged for v5.12.
It's not really a fix but something we can live with, so I've merged it
to sunxi/dt-for-5.13
Thanks!
Maxime
signature.asc
Description: PGP signature
Re: [PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices
Hi Chen-Yu,
Dne ponedeljek, 01. marec 2021 ob 17:23:09 CET je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai
>
> The macros for the clock and reset indices for the RSB hardware block
> were replaced with raw numbers when the RSB controller node was added.
> This was done to avoid cross-tree dependencies.
>
> Now that both the clk and DT changes have been merged, we can switch
> back to using the macros.
>
> Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
> Signed-off-by: Chen-Yu Tsai
Reviewed-by: Jernej Skrabec
Best regards,
Jernej
[PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices
From: Chen-Yu Tsai
The macros for the clock and reset indices for the RSB hardware block
were replaced with raw numbers when the RSB controller node was added.
This was done to avoid cross-tree dependencies.
Now that both the clk and DT changes have been merged, we can switch
back to using the macros.
Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
Signed-off-by: Chen-Yu Tsai
---
Small patch split out from the H6 RSB clock support patch.
This should be merged for v5.12.
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 49e979794094..af8b7d0ef750 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -995,9 +995,9 @@ r_rsb: rsb@7083000 {
compatible = "allwinner,sun8i-a23-rsb";
reg = <0x07083000 0x400>;
interrupts = ;
- clocks = <_ccu 13>;
+ clocks = <_ccu CLK_R_APB2_RSB>;
clock-frequency = <300>;
- resets = <_ccu 7>;
+ resets = <_ccu RST_R_APB2_RSB>;
pinctrl-names = "default";
pinctrl-0 = <_rsb_pins>;
status = "disabled";
--
2.30.1
