Re: [PATCH] drivers/block: Goodbye BLK_DEV_UMEM

[Jens Axboe]

On 3/23/21 1:07 PM, Davidlohr Bueso wrote:
> This removes the driver on the premise that it has been unused for a long
> time. This is a better approach compared to changing untestable code nobody
> cares about in the first place. Similarly, the umem.com website now shows a
> mere Godaddy parking add.

Applied, thanks.

-- 
Jens Axboe

Re: [PATCH] drivers/block: Goodbye BLK_DEV_UMEM

[NeilBrown]

On Tue, Mar 23 2021, Davidlohr Bueso wrote:

> I'm also Ccing Neil, who is one of the authors.

Thanks!
I have no objection to the removal.  The driver served its purpose at
the time, but technology has moved on.
Add
  Acked-by: NeilBrown 
if you like (not necessary).

Thanks,
NeilBrown

>
> On Tue, 23 Mar 2021, Bueso wrote:
>
>>This removes the driver on the premise that it has been unused for a long
>>time. This is a better approach compared to changing untestable code nobody
>>cares about in the first place. Similarly, the umem.com website now shows a
>>mere Godaddy parking add.
>>
>>Suggested-by: Christoph Hellwig 
>>Signed-off-by: Davidlohr Bueso 
>>---
>> arch/mips/configs/malta_defconfig   |1 -
>> arch/mips/configs/malta_kvm_defconfig   |1 -
>> arch/mips/configs/maltaup_xpa_defconfig |1 -
>> drivers/block/Kconfig   |   17 -
>> drivers/block/Makefile  |1 -
>> drivers/block/umem.c| 1130 ---
>> drivers/block/umem.h|  132 ---
>> 7 files changed, 1283 deletions(-)
>> delete mode 100644 drivers/block/umem.c
>> delete mode 100644 drivers/block/umem.h


signature.asc
Description: PGP signature

Re: [PATCH] drivers/block: Goodbye BLK_DEV_UMEM

[Davidlohr Bueso]

I'm also Ccing Neil, who is one of the authors.

On Tue, 23 Mar 2021, Bueso wrote:


This removes the driver on the premise that it has been unused for a long
time. This is a better approach compared to changing untestable code nobody
cares about in the first place. Similarly, the umem.com website now shows a
mere Godaddy parking add.

Suggested-by: Christoph Hellwig 
Signed-off-by: Davidlohr Bueso 
---
arch/mips/configs/malta_defconfig   |1 -
arch/mips/configs/malta_kvm_defconfig   |1 -
arch/mips/configs/maltaup_xpa_defconfig |1 -
drivers/block/Kconfig   |   17 -
drivers/block/Makefile  |1 -
drivers/block/umem.c| 1130 ---
drivers/block/umem.h|  132 ---
7 files changed, 1283 deletions(-)
delete mode 100644 drivers/block/umem.c
delete mode 100644 drivers/block/umem.h

diff --git a/arch/mips/configs/malta_defconfig 
b/arch/mips/configs/malta_defconfig
index 211bd3d6e6cb..9cb2cf2595e0 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -227,7 +227,6 @@ CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_UBI=m
CONFIG_MTD_UBI_GLUEBI=m
CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
CONFIG_BLK_DEV_NBD=m
diff --git a/arch/mips/configs/malta_kvm_defconfig 
b/arch/mips/configs/malta_kvm_defconfig
index 62b1969b4f55..ab8d1df0f255 100644
--- a/arch/mips/configs/malta_kvm_defconfig
+++ b/arch/mips/configs/malta_kvm_defconfig
@@ -232,7 +232,6 @@ CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_UBI=m
CONFIG_MTD_UBI_GLUEBI=m
CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
CONFIG_BLK_DEV_NBD=m
diff --git a/arch/mips/configs/maltaup_xpa_defconfig 
b/arch/mips/configs/maltaup_xpa_defconfig
index 636311d67a53..c93e5a39c215 100644
--- a/arch/mips/configs/maltaup_xpa_defconfig
+++ b/arch/mips/configs/maltaup_xpa_defconfig
@@ -230,7 +230,6 @@ CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_UBI=m
CONFIG_MTD_UBI_GLUEBI=m
CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
CONFIG_BLK_DEV_NBD=m
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index fd236158f32d..56e7b8450120 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -121,23 +121,6 @@ source "drivers/block/mtip32xx/Kconfig"

source "drivers/block/zram/Kconfig"

-config BLK_DEV_UMEM
-   tristate "Micro Memory MM5415 Battery Backed RAM support"
-   depends on PCI
-   help
- Saying Y here will include support for the MM5415 family of
- battery backed (Non-volatile) RAM cards.
- 
-
- The cards appear as block devices that can be partitioned into
- as many as 15 partitions.
-
- To compile this driver as a module, choose M here: the
- module will be called umem.
-
- The umem driver has not yet been allocated a MAJOR number, so
- one is chosen dynamically.
-
config BLK_DEV_UBD
bool "Virtual block device"
depends on UML
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index e3e3f1c79a82..9878eb3dbfd5 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -24,7 +24,6 @@ obj-$(CONFIG_XILINX_SYSACE)   += xsysace.o
obj-$(CONFIG_CDROM_PKTCDVD) += pktcdvd.o
obj-$(CONFIG_SUNVDC)+= sunvdc.o

-obj-$(CONFIG_BLK_DEV_UMEM) += umem.o
obj-$(CONFIG_BLK_DEV_NBD)   += nbd.o
obj-$(CONFIG_BLK_DEV_CRYPTOLOOP) += cryptoloop.o
obj-$(CONFIG_VIRTIO_BLK)+= virtio_blk.o
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
deleted file mode 100644
index 664280f23bee..
--- a/drivers/block/umem.c
+++ /dev/null
@@ -1,1130 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * mm.c - Micro Memory(tm) PCI memory board block device driver - v2.3
- *
- * (C) 2001 San Mehat 
- * (C) 2001 Johannes Erdfelt 
- * (C) 2001 NeilBrown 
- *
- * This driver for the Micro Memory PCI Memory Module with Battery Backup
- * is Copyright Micro Memory Inc 2001-2002.  All rights reserved.
- *
- * This driver provides a standard block device interface for Micro Memory(tm)
- * PCI based RAM boards.
- * 10/05/01: Phap Nguyen - Rebuilt the driver
- * 10/22/01: Phap Nguyen - v2.1 Added disk partitioning
- * 29oct2001:NeilBrown   - Use make_request_fn instead of request_fn
- *   - use stand disk partitioning (so fdisk works).
- * 08nov2001:NeilBrown  - change driver name from "mm" to "umem"
- *  - incorporate into main kernel
- * 08apr2002:NeilBrown   - Move some of interrupt handle to tasklet
- *  - use spin_lock_bh instead of _irq
- *  - Never block on make_request.  queue
- *bh's instead.
- *  - unregister umem from devfs at mod unload
- *  - Change version to 2.3
- * 07Nov2001:Phap Nguyen - Select pci read command: 06, 12, 15 (Decimal)
- * 

[PATCH] drivers/block: Goodbye BLK_DEV_UMEM

[Davidlohr Bueso]

This removes the driver on the premise that it has been unused for a long
time. This is a better approach compared to changing untestable code nobody
cares about in the first place. Similarly, the umem.com website now shows a
mere Godaddy parking add.

Suggested-by: Christoph Hellwig 
Signed-off-by: Davidlohr Bueso 
---
 arch/mips/configs/malta_defconfig   |1 -
 arch/mips/configs/malta_kvm_defconfig   |1 -
 arch/mips/configs/maltaup_xpa_defconfig |1 -
 drivers/block/Kconfig   |   17 -
 drivers/block/Makefile  |1 -
 drivers/block/umem.c| 1130 ---
 drivers/block/umem.h|  132 ---
 7 files changed, 1283 deletions(-)
 delete mode 100644 drivers/block/umem.c
 delete mode 100644 drivers/block/umem.h

diff --git a/arch/mips/configs/malta_defconfig 
b/arch/mips/configs/malta_defconfig
index 211bd3d6e6cb..9cb2cf2595e0 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -227,7 +227,6 @@ CONFIG_MTD_PHYSMAP_OF=y
 CONFIG_MTD_UBI=m
 CONFIG_MTD_UBI_GLUEBI=m
 CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_CRYPTOLOOP=m
 CONFIG_BLK_DEV_NBD=m
diff --git a/arch/mips/configs/malta_kvm_defconfig 
b/arch/mips/configs/malta_kvm_defconfig
index 62b1969b4f55..ab8d1df0f255 100644
--- a/arch/mips/configs/malta_kvm_defconfig
+++ b/arch/mips/configs/malta_kvm_defconfig
@@ -232,7 +232,6 @@ CONFIG_MTD_PHYSMAP_OF=y
 CONFIG_MTD_UBI=m
 CONFIG_MTD_UBI_GLUEBI=m
 CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_CRYPTOLOOP=m
 CONFIG_BLK_DEV_NBD=m
diff --git a/arch/mips/configs/maltaup_xpa_defconfig 
b/arch/mips/configs/maltaup_xpa_defconfig
index 636311d67a53..c93e5a39c215 100644
--- a/arch/mips/configs/maltaup_xpa_defconfig
+++ b/arch/mips/configs/maltaup_xpa_defconfig
@@ -230,7 +230,6 @@ CONFIG_MTD_PHYSMAP_OF=y
 CONFIG_MTD_UBI=m
 CONFIG_MTD_UBI_GLUEBI=m
 CONFIG_BLK_DEV_FD=m
-CONFIG_BLK_DEV_UMEM=m
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_CRYPTOLOOP=m
 CONFIG_BLK_DEV_NBD=m
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index fd236158f32d..56e7b8450120 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -121,23 +121,6 @@ source "drivers/block/mtip32xx/Kconfig"
 
 source "drivers/block/zram/Kconfig"
 
-config BLK_DEV_UMEM
-   tristate "Micro Memory MM5415 Battery Backed RAM support"
-   depends on PCI
-   help
- Saying Y here will include support for the MM5415 family of
- battery backed (Non-volatile) RAM cards.
- 
-
- The cards appear as block devices that can be partitioned into
- as many as 15 partitions.
-
- To compile this driver as a module, choose M here: the
- module will be called umem.
-
- The umem driver has not yet been allocated a MAJOR number, so
- one is chosen dynamically.
-
 config BLK_DEV_UBD
bool "Virtual block device"
depends on UML
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index e3e3f1c79a82..9878eb3dbfd5 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -24,7 +24,6 @@ obj-$(CONFIG_XILINX_SYSACE)   += xsysace.o
 obj-$(CONFIG_CDROM_PKTCDVD)+= pktcdvd.o
 obj-$(CONFIG_SUNVDC)   += sunvdc.o
 
-obj-$(CONFIG_BLK_DEV_UMEM) += umem.o
 obj-$(CONFIG_BLK_DEV_NBD)  += nbd.o
 obj-$(CONFIG_BLK_DEV_CRYPTOLOOP) += cryptoloop.o
 obj-$(CONFIG_VIRTIO_BLK)   += virtio_blk.o
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
deleted file mode 100644
index 664280f23bee..
--- a/drivers/block/umem.c
+++ /dev/null
@@ -1,1130 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * mm.c - Micro Memory(tm) PCI memory board block device driver - v2.3
- *
- * (C) 2001 San Mehat 
- * (C) 2001 Johannes Erdfelt 
- * (C) 2001 NeilBrown 
- *
- * This driver for the Micro Memory PCI Memory Module with Battery Backup
- * is Copyright Micro Memory Inc 2001-2002.  All rights reserved.
- *
- * This driver provides a standard block device interface for Micro Memory(tm)
- * PCI based RAM boards.
- * 10/05/01: Phap Nguyen - Rebuilt the driver
- * 10/22/01: Phap Nguyen - v2.1 Added disk partitioning
- * 29oct2001:NeilBrown   - Use make_request_fn instead of request_fn
- *   - use stand disk partitioning (so fdisk works).
- * 08nov2001:NeilBrown  - change driver name from "mm" to "umem"
- *  - incorporate into main kernel
- * 08apr2002:NeilBrown   - Move some of interrupt handle to tasklet
- *  - use spin_lock_bh instead of _irq
- *  - Never block on make_request.  queue
- *bh's instead.
- *  - unregister umem from devfs at mod unload
- *  - Change version to 2.3
- * 07Nov2001:Phap Nguyen - Select pci read command: 06, 12, 15 (Decimal)
- * 07Jan2002: P. Nguyen  - Used PCI Memory Write &