Re: [PATCH] f2fs: no need to initialize zero value for GFP_F2FS_ZERO

[Chao Yu]

On 2018/3/21 20:25, Yunlong Song wrote:
> Since f2fs_inode_info is allocated with flag GFP_F2FS_ZERO, so we do not
> need to initialize zero value for its member any more.
> 
> Signed-off-by: Yunlong Song 
> ---
>  fs/f2fs/super.c | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0c1fe9b..3a7fa03 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -825,9 +825,7 @@ static struct inode *f2fs_alloc_inode(struct super_block 
> *sb)
>   init_once((void *) fi);
>  
>   /* Initialize f2fs-specific inode info */
> - atomic_set(>dirty_pages, 0);

We'd better to keep atomic_set function as it is since how it initialize
.dirty_pages field is completely depend on locking sub module itself.

Thanks,

>   fi->i_current_depth = 1;
> - fi->i_advise = 0;
>   init_rwsem(>i_sem);
>   INIT_LIST_HEAD(>dirty_list);
>   INIT_LIST_HEAD(>gdirty_list);
> @@ -839,10 +837,6 @@ static struct inode *f2fs_alloc_inode(struct super_block 
> *sb)
>   init_rwsem(>i_mmap_sem);
>   init_rwsem(>i_xattr_sem);
>  
> -#ifdef CONFIG_QUOTA
> - memset(>i_dquot, 0, sizeof(fi->i_dquot));
> - fi->i_reserved_quota = 0;
> -#endif
>   /* Will be used by directory only */
>   fi->i_dir_level = F2FS_SB(sb)->dir_level;
>  
> 

Re: [PATCH] f2fs: no need to initialize zero value for GFP_F2FS_ZERO

[Chao Yu]

On 2018/3/21 20:25, Yunlong Song wrote:
> Since f2fs_inode_info is allocated with flag GFP_F2FS_ZERO, so we do not
> need to initialize zero value for its member any more.
> 
> Signed-off-by: Yunlong Song 
> ---
>  fs/f2fs/super.c | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0c1fe9b..3a7fa03 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -825,9 +825,7 @@ static struct inode *f2fs_alloc_inode(struct super_block 
> *sb)
>   init_once((void *) fi);
>  
>   /* Initialize f2fs-specific inode info */
> - atomic_set(>dirty_pages, 0);

We'd better to keep atomic_set function as it is since how it initialize
.dirty_pages field is completely depend on locking sub module itself.

Thanks,

>   fi->i_current_depth = 1;
> - fi->i_advise = 0;
>   init_rwsem(>i_sem);
>   INIT_LIST_HEAD(>dirty_list);
>   INIT_LIST_HEAD(>gdirty_list);
> @@ -839,10 +837,6 @@ static struct inode *f2fs_alloc_inode(struct super_block 
> *sb)
>   init_rwsem(>i_mmap_sem);
>   init_rwsem(>i_xattr_sem);
>  
> -#ifdef CONFIG_QUOTA
> - memset(>i_dquot, 0, sizeof(fi->i_dquot));
> - fi->i_reserved_quota = 0;
> -#endif
>   /* Will be used by directory only */
>   fi->i_dir_level = F2FS_SB(sb)->dir_level;
>  
> 

[PATCH] f2fs: no need to initialize zero value for GFP_F2FS_ZERO

[Yunlong Song]

Since f2fs_inode_info is allocated with flag GFP_F2FS_ZERO, so we do not
need to initialize zero value for its member any more.

Signed-off-by: Yunlong Song 
---
 fs/f2fs/super.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c1fe9b..3a7fa03 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -825,9 +825,7 @@ static struct inode *f2fs_alloc_inode(struct super_block 
*sb)
init_once((void *) fi);
 
/* Initialize f2fs-specific inode info */
-   atomic_set(>dirty_pages, 0);
fi->i_current_depth = 1;
-   fi->i_advise = 0;
init_rwsem(>i_sem);
INIT_LIST_HEAD(>dirty_list);
INIT_LIST_HEAD(>gdirty_list);
@@ -839,10 +837,6 @@ static struct inode *f2fs_alloc_inode(struct super_block 
*sb)
init_rwsem(>i_mmap_sem);
init_rwsem(>i_xattr_sem);
 
-#ifdef CONFIG_QUOTA
-   memset(>i_dquot, 0, sizeof(fi->i_dquot));
-   fi->i_reserved_quota = 0;
-#endif
/* Will be used by directory only */
fi->i_dir_level = F2FS_SB(sb)->dir_level;
 
-- 
1.8.5.2

[PATCH] f2fs: no need to initialize zero value for GFP_F2FS_ZERO

[Yunlong Song]

Since f2fs_inode_info is allocated with flag GFP_F2FS_ZERO, so we do not
need to initialize zero value for its member any more.

Signed-off-by: Yunlong Song 
---
 fs/f2fs/super.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0c1fe9b..3a7fa03 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -825,9 +825,7 @@ static struct inode *f2fs_alloc_inode(struct super_block 
*sb)
init_once((void *) fi);
 
/* Initialize f2fs-specific inode info */
-   atomic_set(>dirty_pages, 0);
fi->i_current_depth = 1;
-   fi->i_advise = 0;
init_rwsem(>i_sem);
INIT_LIST_HEAD(>dirty_list);
INIT_LIST_HEAD(>gdirty_list);
@@ -839,10 +837,6 @@ static struct inode *f2fs_alloc_inode(struct super_block 
*sb)
init_rwsem(>i_mmap_sem);
init_rwsem(>i_xattr_sem);
 
-#ifdef CONFIG_QUOTA
-   memset(>i_dquot, 0, sizeof(fi->i_dquot));
-   fi->i_reserved_quota = 0;
-#endif
/* Will be used by directory only */
fi->i_dir_level = F2FS_SB(sb)->dir_level;
 
-- 
1.8.5.2