Re: [PATCH] fbdev: remove mbx framebuffer driver
On 8/30/20 1:55 PM, Mike Rapoport wrote:
> From: Mike Rapoport
>
> The only in-tree user for mbx driver for Intel 2700G graphics chip was
> cm-x270 platform. Since this platform was removed by the commit
> 9d3239147d6d ("ARM: pxa: remove Compulab pxa2xx boards") there is no
> point to keep the obsolete framebuffer driver.
>
> Signed-off-by: Mike Rapoport
Applied to drm-misc-next tree, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
> ---
> .../userspace-api/ioctl/ioctl-number.rst |2 -
> drivers/video/fbdev/Kconfig | 19 -
> drivers/video/fbdev/Makefile |1 -
> drivers/video/fbdev/mbx/Makefile |4 -
> drivers/video/fbdev/mbx/mbxdebugfs.c | 232
> drivers/video/fbdev/mbx/mbxfb.c | 1053 -
> drivers/video/fbdev/mbx/reg_bits.h| 614 --
> drivers/video/fbdev/mbx/regs.h| 196 ---
> include/video/mbxfb.h | 99 --
> 9 files changed, 2220 deletions(-)
> delete mode 100644 drivers/video/fbdev/mbx/Makefile
> delete mode 100644 drivers/video/fbdev/mbx/mbxdebugfs.c
> delete mode 100644 drivers/video/fbdev/mbx/mbxfb.c
> delete mode 100644 drivers/video/fbdev/mbx/reg_bits.h
> delete mode 100644 drivers/video/fbdev/mbx/regs.h
> delete mode 100644 include/video/mbxfb.h
>
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst
> b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index 2a198838fca9..a20102f7db69 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -356,8 +356,6 @@ Code Seq#Include File
>Comments
> 0xEC 00-01 drivers/platform/chrome/cros_ec_dev.h
> ChromeOS EC driver
> 0xF3 00-3F drivers/usb/misc/sisusbvga/sisusb.h sisfb
> (in development)
>
>
> -0xF4 00-1F video/mbxfb.h mbxfb
> -
>
> 0xF6 allLTTng
> Linux Trace Toolkit Next Generation
>
>
> 0xFD alllinux/dm-ioctl.h
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index b2c9dd4f0cb5..e36578258b5b 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1775,25 +1775,6 @@ config PXA3XX_GCU
>
> If you compile this as a module, it will be called pxa3xx_gcu.
>
> -config FB_MBX
> - tristate "2700G LCD framebuffer support"
> - depends on FB && ARCH_PXA
> - select FB_CFB_FILLRECT
> - select FB_CFB_COPYAREA
> - select FB_CFB_IMAGEBLIT
> - help
> - Framebuffer driver for the Intel 2700G (Marathon) Graphics
> - Accelerator
> -
> -config FB_MBX_DEBUG
> - bool "Enable debugging info via debugfs"
> - depends on FB_MBX && DEBUG_FS
> - help
> - Enable this if you want debugging information using the debug
> - filesystem (debugfs)
> -
> - If unsure, say N.
> -
> config FB_FSL_DIU
> tristate "Freescale DIU framebuffer support"
> depends on FB && FSL_SOC
> diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
> index cad4fb64442a..2ff8849ffde6 100644
> --- a/drivers/video/fbdev/Makefile
> +++ b/drivers/video/fbdev/Makefile
> @@ -31,7 +31,6 @@ obj-$(CONFIG_FB_VIA) += via/
> obj-$(CONFIG_FB_KYRO) += kyro/
> obj-$(CONFIG_FB_SAVAGE)+= savage/
> obj-$(CONFIG_FB_GEODE) += geode/
> -obj-$(CONFIG_FB_MBX) += mbx/
> obj-$(CONFIG_FB_NEOMAGIC) += neofb.o
> obj-$(CONFIG_FB_3DFX) += tdfxfb.o
> obj-$(CONFIG_FB_CONTROL) += controlfb.o
> diff --git a/drivers/video/fbdev/mbx/Makefile
> b/drivers/video/fbdev/mbx/Makefile
> deleted file mode 100644
> index 3e8e7ff41f18..
> --- a/drivers/video/fbdev/mbx/Makefile
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0-only
> -# Makefile for the 2700G controller driver.
> -
> -obj-y+= mbxfb.o
> diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c
> b/drivers/video/fbdev/mbx/mbxdebugfs.c
> deleted file mode 100644
> index 09af721638fb..
> --- a/drivers/video/fbdev/mbx/mbxdebugfs.c
> +++ /dev/null
> @@ -1,232 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -#include
> -#include
> -
> -#define BIG_BUFFER_SIZE (1024)
> -
> -static char big_buffer[BIG_BUFFER_SIZE];
> -
> -struct mbxfb_debugfs_data {
> - struct dentry *dir;
> - struct dentry *sysconf;
> - struct dentry
[PATCH] fbdev: remove mbx framebuffer driver
From: Mike Rapoport
The only in-tree user for mbx driver for Intel 2700G graphics chip was
cm-x270 platform. Since this platform was removed by the commit
9d3239147d6d ("ARM: pxa: remove Compulab pxa2xx boards") there is no
point to keep the obsolete framebuffer driver.
Signed-off-by: Mike Rapoport
---
.../userspace-api/ioctl/ioctl-number.rst |2 -
drivers/video/fbdev/Kconfig | 19 -
drivers/video/fbdev/Makefile |1 -
drivers/video/fbdev/mbx/Makefile |4 -
drivers/video/fbdev/mbx/mbxdebugfs.c | 232
drivers/video/fbdev/mbx/mbxfb.c | 1053 -
drivers/video/fbdev/mbx/reg_bits.h| 614 --
drivers/video/fbdev/mbx/regs.h| 196 ---
include/video/mbxfb.h | 99 --
9 files changed, 2220 deletions(-)
delete mode 100644 drivers/video/fbdev/mbx/Makefile
delete mode 100644 drivers/video/fbdev/mbx/mbxdebugfs.c
delete mode 100644 drivers/video/fbdev/mbx/mbxfb.c
delete mode 100644 drivers/video/fbdev/mbx/reg_bits.h
delete mode 100644 drivers/video/fbdev/mbx/regs.h
delete mode 100644 include/video/mbxfb.h
diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst
b/Documentation/userspace-api/ioctl/ioctl-number.rst
index 2a198838fca9..a20102f7db69 100644
--- a/Documentation/userspace-api/ioctl/ioctl-number.rst
+++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
@@ -356,8 +356,6 @@ Code Seq#Include File
Comments
0xEC 00-01 drivers/platform/chrome/cros_ec_dev.h ChromeOS
EC driver
0xF3 00-3F drivers/usb/misc/sisusbvga/sisusb.h sisfb (in
development)
-0xF4 00-1F video/mbxfb.h mbxfb
-
0xF6 allLTTng
Linux Trace Toolkit Next Generation
0xFD alllinux/dm-ioctl.h
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index b2c9dd4f0cb5..e36578258b5b 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1775,25 +1775,6 @@ config PXA3XX_GCU
If you compile this as a module, it will be called pxa3xx_gcu.
-config FB_MBX
- tristate "2700G LCD framebuffer support"
- depends on FB && ARCH_PXA
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
- help
- Framebuffer driver for the Intel 2700G (Marathon) Graphics
- Accelerator
-
-config FB_MBX_DEBUG
- bool "Enable debugging info via debugfs"
- depends on FB_MBX && DEBUG_FS
- help
- Enable this if you want debugging information using the debug
- filesystem (debugfs)
-
- If unsure, say N.
-
config FB_FSL_DIU
tristate "Freescale DIU framebuffer support"
depends on FB && FSL_SOC
diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index cad4fb64442a..2ff8849ffde6 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -31,7 +31,6 @@ obj-$(CONFIG_FB_VIA)+= via/
obj-$(CONFIG_FB_KYRO) += kyro/
obj-$(CONFIG_FB_SAVAGE) += savage/
obj-$(CONFIG_FB_GEODE) += geode/
-obj-$(CONFIG_FB_MBX) += mbx/
obj-$(CONFIG_FB_NEOMAGIC) += neofb.o
obj-$(CONFIG_FB_3DFX) += tdfxfb.o
obj-$(CONFIG_FB_CONTROL) += controlfb.o
diff --git a/drivers/video/fbdev/mbx/Makefile b/drivers/video/fbdev/mbx/Makefile
deleted file mode 100644
index 3e8e7ff41f18..
--- a/drivers/video/fbdev/mbx/Makefile
+++ /dev/null
@@ -1,4 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-# Makefile for the 2700G controller driver.
-
-obj-y += mbxfb.o
diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c
b/drivers/video/fbdev/mbx/mbxdebugfs.c
deleted file mode 100644
index 09af721638fb..
--- a/drivers/video/fbdev/mbx/mbxdebugfs.c
+++ /dev/null
@@ -1,232 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include
-#include
-
-#define BIG_BUFFER_SIZE(1024)
-
-static char big_buffer[BIG_BUFFER_SIZE];
-
-struct mbxfb_debugfs_data {
- struct dentry *dir;
- struct dentry *sysconf;
- struct dentry *clock;
- struct dentry *display;
- struct dentry *gsctl;
- struct dentry *sdram;
- struct dentry *misc;
-};
-
-static ssize_t write_file_dummy(struct file *file, const char __user *buf,
- size_t count, loff_t *ppos)
-{
- return count;
-}
-
-static ssize_t sysconf_read_file(struct file *file, char __user *userbuf,
-
