[PATCH] powerpc: Fix build warning on 32-bit PPC - bisected to commit 989cea5c14be
I am getting the following warning when I build kernel 4.9-git on my
PowerBook G4 with a 32-bit PPC processor:
AS arch/powerpc/kernel/misc_32.o
arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
[-Wundef]
This problem is evident after commit 989cea5c14be ("kbuild: prevent
lib-ksyms.o rebuilds"); however, this change in kbuild only exposes an
error that has been in the code since 2005 when this source file was
created. That was with commit 9994a33865f4 ("powerpc: Introduce
entry_{32,64}.S, misc_{32,64}.S, systbl.S"). The offending line is
way does not make a lot of sense. This error does not seem to cause any
errors in the executable, thus I am not recommending that it be applied
to any stable versions.
Thanks to Nicholas Piggin for suggesting this solution.
Fixes: 9994a33865f4 ("powerpc: Introduce entry_{32,64}.S, misc_{32,64}.S,
systbl.S")
Signed-off-by: Larry Finger
Cc: Nicholas Piggin
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Michael Ellerman
Cc: linuxppc-...@lists.ozlabs.org
---
arch/powerpc/kernel/misc_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index 1863324..84db14e 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -296,7 +296,7 @@ _GLOBAL(flush_instruction_cache)
lis r3, KERNELBASE@h
iccci 0,r3
#endif
-#elif CONFIG_FSL_BOOKE
+#elif defined(CONFIG_FSL_BOOKE)
BEGIN_FTR_SECTION
mfspr r3,SPRN_L1CSR0
ori r3,r3,L1CSR0_CFI|L1CSR0_CLFC
--
2.10.2
[PATCH] powerpc: Fix build warning on 32-bit PPC - bisected to commit 989cea5c14be
I am getting the following warning when I build kernel 4.9-git on my
PowerBook G4 with a 32-bit PPC processor:
AS arch/powerpc/kernel/misc_32.o
arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined
[-Wundef]
This problem is evident after commit 989cea5c14be ("kbuild: prevent
lib-ksyms.o rebuilds"); however, this change in kbuild only exposes an
error that has been in the code since 2005 when this source file was
created. That was with commit 9994a33865f4 ("powerpc: Introduce
entry_{32,64}.S, misc_{32,64}.S, systbl.S"). The offending line is
way does not make a lot of sense. This error does not seem to cause any
errors in the executable, thus I am not recommending that it be applied
to any stable versions.
Thanks to Nicholas Piggin for suggesting this solution.
Fixes: 9994a33865f4 ("powerpc: Introduce entry_{32,64}.S, misc_{32,64}.S,
systbl.S")
Signed-off-by: Larry Finger
Cc: Nicholas Piggin
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Michael Ellerman
Cc: linuxppc-...@lists.ozlabs.org
---
arch/powerpc/kernel/misc_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index 1863324..84db14e 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -296,7 +296,7 @@ _GLOBAL(flush_instruction_cache)
lis r3, KERNELBASE@h
iccci 0,r3
#endif
-#elif CONFIG_FSL_BOOKE
+#elif defined(CONFIG_FSL_BOOKE)
BEGIN_FTR_SECTION
mfspr r3,SPRN_L1CSR0
ori r3,r3,L1CSR0_CFI|L1CSR0_CLFC
--
2.10.2
Re: [PATCH] powerpc: Fix build warning
On Tue, Jun 24, 2014 at 8:01 AM, Guenter Roeck wrote:
> Sigh. Much easier to break something than to fix it. That would mean to get
> approval
> from at least three maintainers, and all that to get rid of a warning. I
> don't
> really have time for that. Let's just forget about it and live with the
> warning.
So you send it to akpm. Or perhaps even trivial.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Tue, Jun 24, 2014 at 8:01 AM, Guenter Roeck li...@roeck-us.net wrote:
Sigh. Much easier to break something than to fix it. That would mean to get
approval
from at least three maintainers, and all that to get rid of a warning. I
don't
really have time for that. Let's just forget about it and live with the
warning.
So you send it to akpm. Or perhaps even trivial.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Mon, 2014-06-23 at 23:01 -0700, Guenter Roeck wrote: > I thought that only happens if a const is dropped, but maybe not. > > Sigh. Much easier to break something than to fix it. That would mean > to get approval > from at least three maintainers, and all that to get rid of a warning. > I don't > really have time for that. Let's just forget about it and live with > the warning. Well you have my tentative approval :) And trivial ones like that don't really need the respective maintainers to respond really, I forget regularly and they still go upstream. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/23/2014 10:34 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. This breaks the 64-bit build: arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] It appears that the generic definition in sched.h has this function defined as const int, so that needs to be fixed too along with all instances in all archs. https://lkml.org/lkml/2014/6/12/743 Won't the patch above break powerpc then ? IE. The functions signature won't match anymore ... /me thinks you probably need to fix them all at once. I thought that only happens if a const is dropped, but maybe not. Sigh. Much easier to break something than to fix it. That would mean to get approval from at least three maintainers, and all that to get rid of a warning. I don't really have time for that. Let's just forget about it and live with the warning. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/23/2014 10:34 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. This breaks the 64-bit build: arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] It appears that the generic definition in sched.h has this function defined as const int, so that needs to be fixed too along with all instances in all archs. https://lkml.org/lkml/2014/6/12/743 Won't the patch above break powerpc then ? IE. The functions signature won't match anymore ... /me thinks you probably need to fix them all at once. I thought that only happens if a const is dropped, but maybe not. Sigh. Much easier to break something than to fix it. That would mean to get approval from at least three maintainers, and all that to get rid of a warning. I don't really have time for that. Let's just forget about it and live with the warning. Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Mon, 2014-06-23 at 23:01 -0700, Guenter Roeck wrote: I thought that only happens if a const is dropped, but maybe not. Sigh. Much easier to break something than to fix it. That would mean to get approval from at least three maintainers, and all that to get rid of a warning. I don't really have time for that. Let's just forget about it and live with the warning. Well you have my tentative approval :) And trivial ones like that don't really need the respective maintainers to respond really, I forget regularly and they still go upstream. Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: > On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: > >> If compiled with W=1, the following warning is seen in powerpc builds. > >> > >> arch/powerpc/kernel/smp.c:750:18: warning: > >>type qualifiers ignored on function return type > >> static const int powerpc_smt_flags(void) > >> ^ > >> > >> This is caused by a function returning 'const int', which doesn't > >> make sense to gcc. Drop 'const' to fix the problem. > > > > This breaks the 64-bit build: > > > > arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible > > pointer type [-Werror] > > arch/powerpc/kernel/smp.c:764:2: error: (near initialization for > > 'powerpc_topology[0].sd_flags') [-Werror] > > > > It appears that the generic definition in sched.h has this function > > defined as const int, so that needs to be fixed too along with all > > instances in all archs. > > > > https://lkml.org/lkml/2014/6/12/743 Won't the patch above break powerpc then ? IE. The functions signature won't match anymore ... /me thinks you probably need to fix them all at once. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. This breaks the 64-bit build: arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] It appears that the generic definition in sched.h has this function defined as const int, so that needs to be fixed too along with all instances in all archs. https://lkml.org/lkml/2014/6/12/743 Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote:
> If compiled with W=1, the following warning is seen in powerpc builds.
>
> arch/powerpc/kernel/smp.c:750:18: warning:
> type qualifiers ignored on function return type
> static const int powerpc_smt_flags(void)
> ^
>
> This is caused by a function returning 'const int', which doesn't
> make sense to gcc. Drop 'const' to fix the problem.
This breaks the 64-bit build:
arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible
pointer type [-Werror]
arch/powerpc/kernel/smp.c:764:2: error: (near initialization for
'powerpc_topology[0].sd_flags') [-Werror]
It appears that the generic definition in sched.h has this function
defined as const int, so that needs to be fixed too along with all
instances in all archs.
Cheers,
Ben.
> Reported-by: Vincent Guittot
> Signed-off-by: Guenter Roeck
> ---
> arch/powerpc/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 10e..49d5d4e 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
>
> #ifdef CONFIG_SCHED_SMT
> /* cpumask of CPUs with asymetric SMT dependancy */
> -static const int powerpc_smt_flags(void)
> +static int powerpc_smt_flags(void)
> {
> int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote:
If compiled with W=1, the following warning is seen in powerpc builds.
arch/powerpc/kernel/smp.c:750:18: warning:
type qualifiers ignored on function return type
static const int powerpc_smt_flags(void)
^
This is caused by a function returning 'const int', which doesn't
make sense to gcc. Drop 'const' to fix the problem.
This breaks the 64-bit build:
arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible
pointer type [-Werror]
arch/powerpc/kernel/smp.c:764:2: error: (near initialization for
'powerpc_topology[0].sd_flags') [-Werror]
It appears that the generic definition in sched.h has this function
defined as const int, so that needs to be fixed too along with all
instances in all archs.
Cheers,
Ben.
Reported-by: Vincent Guittot vincent.guit...@linaro.org
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
arch/powerpc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 10e..49d5d4e 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
#ifdef CONFIG_SCHED_SMT
/* cpumask of CPUs with asymetric SMT dependancy */
-static const int powerpc_smt_flags(void)
+static int powerpc_smt_flags(void)
{
int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. This breaks the 64-bit build: arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] It appears that the generic definition in sched.h has this function defined as const int, so that needs to be fixed too along with all instances in all archs. https://lkml.org/lkml/2014/6/12/743 Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. This breaks the 64-bit build: arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] It appears that the generic definition in sched.h has this function defined as const int, so that needs to be fixed too along with all instances in all archs. https://lkml.org/lkml/2014/6/12/743 Won't the patch above break powerpc then ? IE. The functions signature won't match anymore ... /me thinks you probably need to fix them all at once. Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/16/2014 06:25 PM, David Rientjes wrote: On Fri, 13 Jun 2014, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. Reported-by: Vincent Guittot Signed-off-by: Guenter Roeck Acked-by: David Rientjes Although it's strange you report this happening on line 750 in the changelog but the patch shows it differently. In the latest kernel (v3.16-rc1) the function is at line 750. It appears that I ran the build test on a later version than the one I used to write the patch. Hope that is not a problem. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Fri, 13 Jun 2014, Guenter Roeck wrote:
> If compiled with W=1, the following warning is seen in powerpc builds.
>
> arch/powerpc/kernel/smp.c:750:18: warning:
> type qualifiers ignored on function return type
> static const int powerpc_smt_flags(void)
> ^
>
> This is caused by a function returning 'const int', which doesn't
> make sense to gcc. Drop 'const' to fix the problem.
>
> Reported-by: Vincent Guittot
> Signed-off-by: Guenter Roeck
Acked-by: David Rientjes
Although it's strange you report this happening on line 750 in the
changelog but the patch shows it differently.
> ---
> arch/powerpc/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 10e..49d5d4e 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
>
> #ifdef CONFIG_SCHED_SMT
> /* cpumask of CPUs with asymetric SMT dependancy */
> -static const int powerpc_smt_flags(void)
> +static int powerpc_smt_flags(void)
> {
> int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On Fri, 13 Jun 2014, Guenter Roeck wrote:
If compiled with W=1, the following warning is seen in powerpc builds.
arch/powerpc/kernel/smp.c:750:18: warning:
type qualifiers ignored on function return type
static const int powerpc_smt_flags(void)
^
This is caused by a function returning 'const int', which doesn't
make sense to gcc. Drop 'const' to fix the problem.
Reported-by: Vincent Guittot vincent.guit...@linaro.org
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: David Rientjes rient...@google.com
Although it's strange you report this happening on line 750 in the
changelog but the patch shows it differently.
---
arch/powerpc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 10e..49d5d4e 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
#ifdef CONFIG_SCHED_SMT
/* cpumask of CPUs with asymetric SMT dependancy */
-static const int powerpc_smt_flags(void)
+static int powerpc_smt_flags(void)
{
int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] powerpc: Fix build warning
On 06/16/2014 06:25 PM, David Rientjes wrote: On Fri, 13 Jun 2014, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const int powerpc_smt_flags(void) ^ This is caused by a function returning 'const int', which doesn't make sense to gcc. Drop 'const' to fix the problem. Reported-by: Vincent Guittot vincent.guit...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net Acked-by: David Rientjes rient...@google.com Although it's strange you report this happening on line 750 in the changelog but the patch shows it differently. In the latest kernel (v3.16-rc1) the function is at line 750. It appears that I ran the build test on a later version than the one I used to write the patch. Hope that is not a problem. Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] powerpc: Fix build warning
If compiled with W=1, the following warning is seen in powerpc builds.
arch/powerpc/kernel/smp.c:750:18: warning:
type qualifiers ignored on function return type
static const int powerpc_smt_flags(void)
^
This is caused by a function returning 'const int', which doesn't
make sense to gcc. Drop 'const' to fix the problem.
Reported-by: Vincent Guittot
Signed-off-by: Guenter Roeck
---
arch/powerpc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 10e..49d5d4e 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
#ifdef CONFIG_SCHED_SMT
/* cpumask of CPUs with asymetric SMT dependancy */
-static const int powerpc_smt_flags(void)
+static int powerpc_smt_flags(void)
{
int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] powerpc: Fix build warning
If compiled with W=1, the following warning is seen in powerpc builds.
arch/powerpc/kernel/smp.c:750:18: warning:
type qualifiers ignored on function return type
static const int powerpc_smt_flags(void)
^
This is caused by a function returning 'const int', which doesn't
make sense to gcc. Drop 'const' to fix the problem.
Reported-by: Vincent Guittot vincent.guit...@linaro.org
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
arch/powerpc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 10e..49d5d4e 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -768,7 +768,7 @@ int setup_profiling_timer(unsigned int multiplier)
#ifdef CONFIG_SCHED_SMT
/* cpumask of CPUs with asymetric SMT dependancy */
-static const int powerpc_smt_flags(void)
+static int powerpc_smt_flags(void)
{
int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
