Re: [PATCH] scsi: qla1280: fix warning comparing pointer to 0

[Martin K. Petersen]

On Mon, 15 Mar 2021 11:49:19 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
> 
> ./drivers/scsi/qla1280.c:3057:37-38: WARNING comparing pointer to 0.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: qla1280: fix warning comparing pointer to 0
  https://git.kernel.org/mkp/scsi/c/3070c72155c5

-- 
Martin K. Petersen  Oracle Linux Engineering

[PATCH] scsi: qla1280: fix warning comparing pointer to 0

[Jiapeng Chong]

Fix the following coccicheck warning:

./drivers/scsi/qla1280.c:3057:37-38: WARNING comparing pointer to 0.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 drivers/scsi/qla1280.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 46de254..699da47 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -3054,7 +3054,7 @@ static void qla1280_mailbox_timeout(struct timer_list *t)
 
/* Check for empty slot in outstanding command list. */
for (cnt = 0; cnt < MAX_OUTSTANDING_COMMANDS &&
-(ha->outstanding_cmds[cnt] != 0); cnt++) ;
+ha->outstanding_cmds[cnt]; cnt++);
 
if (cnt >= MAX_OUTSTANDING_COMMANDS) {
status = SCSI_MLQUEUE_HOST_BUSY;
-- 
1.8.3.1