Re: [PATCH] ubi: fix correct rb_tree node comparison in add_vol
On Tue, 2014-06-24 at 09:25 +0200, Heiko Schocher wrote:
> Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 ("UBI: fix rb_tree node
> comparison in add_map")
>
> introduced problems with attaching ubi fastmap images,
> created with older kernel.
Changed the commit message to be a bit more reader-friendly and pushed
to linux-ubifs.git, thank you!
--
Best Regards,
Artem Bityutskiy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ubi: fix correct rb_tree node comparison in add_vol
On Tue, 2014-06-24 at 09:25 +0200, Heiko Schocher wrote: Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 (UBI: fix rb_tree node comparison in add_map) introduced problems with attaching ubi fastmap images, created with older kernel. Changed the commit message to be a bit more reader-friendly and pushed to linux-ubifs.git, thank you! -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ubi: fix correct rb_tree node comparison in add_vol
Am 24.06.2014 09:25, schrieb Heiko Schocher:
> Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 ("UBI: fix rb_tree node
> comparison in add_map")
>
> introduced problems with attaching ubi fastmap images,
> created with older kernel.
>
> As in ubi_find_av() from attach.c is
> [...]
> if (vol_id > av->vol_id)
> p = p->rb_left;
> else
> p = p->rb_right;
>
> sync this logic also in add_vol() with this.
>
> With this patch attaching older ubi images works again.
>
> Signed-off-by: Heiko Schocher
Thanks a lot for fixing this!
Acked-by: Richard Weinberger
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ubi: fix correct rb_tree node comparison in add_vol
Am 24.06.2014 09:25, schrieb Heiko Schocher: Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 (UBI: fix rb_tree node comparison in add_map) introduced problems with attaching ubi fastmap images, created with older kernel. As in ubi_find_av() from attach.c is [...] if (vol_id av-vol_id) p = p-rb_left; else p = p-rb_right; sync this logic also in add_vol() with this. With this patch attaching older ubi images works again. Signed-off-by: Heiko Schocher h...@denx.de Thanks a lot for fixing this! Acked-by: Richard Weinberger rich...@nod.at Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ubi: fix correct rb_tree node comparison in add_vol
Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 ("UBI: fix rb_tree node
comparison in add_map")
introduced problems with attaching ubi fastmap images,
created with older kernel.
As in ubi_find_av() from attach.c is
[...]
if (vol_id > av->vol_id)
p = p->rb_left;
else
p = p->rb_right;
sync this logic also in add_vol() with this.
With this patch attaching older ubi images works again.
Signed-off-by: Heiko Schocher
---
Cc: Artem Bityutskiy
Cc: Richard Weinberger
Cc: David Woodhouse
Cc: Brian Norris
Cc: Mike Snitzer
Cc: Wolfgang Denk
Cc: linux-...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index b04e7d0..72f39da 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -125,7 +125,7 @@ static struct ubi_ainf_volume *add_vol(struct
ubi_attach_info *ai, int vol_id,
parent = *p;
av = rb_entry(parent, struct ubi_ainf_volume, rb);
- if (vol_id < av->vol_id)
+ if (vol_id > av->vol_id)
p = &(*p)->rb_left;
else
p = &(*p)->rb_right;
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ubi: fix correct rb_tree node comparison in add_vol
Commit 604b592e6fd3c98f21435e1181ba7723ffc24715 (UBI: fix rb_tree node comparison in add_map) introduced problems with attaching ubi fastmap images, created with older kernel. As in ubi_find_av() from attach.c is [...] if (vol_id av-vol_id) p = p-rb_left; else p = p-rb_right; sync this logic also in add_vol() with this. With this patch attaching older ubi images works again. Signed-off-by: Heiko Schocher h...@denx.de --- Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: Richard Weinberger rich...@nod.at Cc: David Woodhouse dw...@infradead.org Cc: Brian Norris computersforpe...@gmail.com Cc: Mike Snitzer snit...@redhat.com Cc: Wolfgang Denk w...@denx.de Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.kernel.org drivers/mtd/ubi/fastmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index b04e7d0..72f39da 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -125,7 +125,7 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id, parent = *p; av = rb_entry(parent, struct ubi_ainf_volume, rb); - if (vol_id av-vol_id) + if (vol_id av-vol_id) p = (*p)-rb_left; else p = (*p)-rb_right; -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
