Re: [PATCH -next] soc: use devm_platform_ioremap_resource_byname

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 11:15 UTC 2020, Qilong Zhang wrote:

> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Zhang Qilong 

I fixed up the subject line to match the previous commits in this driver
and applied the patch.

Thank you,
Bjorn

> ---
>  drivers/soc/qcom/llcc-qcom.c | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 429b5a60a1ba..70fbe70c6213 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -387,7 +387,6 @@ static int qcom_llcc_remove(struct platform_device *pdev)
>  static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev,
>   const char *name)
>  {
> - struct resource *res;
>   void __iomem *base;
>   struct regmap_config llcc_regmap_config = {
>   .reg_bits = 32,
> @@ -396,11 +395,7 @@ static struct regmap *qcom_llcc_init_mmio(struct 
> platform_device *pdev,
>   .fast_io = true,
>   };
>  
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
> - if (!res)
> - return ERR_PTR(-ENODEV);
> -
> - base = devm_ioremap_resource(>dev, res);
> + base = devm_platform_ioremap_resource_byname(pdev, name);
>   if (IS_ERR(base))
>   return ERR_CAST(base);
>  
> -- 
> 2.17.1
> 


[PATCH -next] soc: use devm_platform_ioremap_resource_byname

2020-09-16 Thread Qilong Zhang
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.

Signed-off-by: Zhang Qilong 
---
 drivers/soc/qcom/llcc-qcom.c | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 429b5a60a1ba..70fbe70c6213 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -387,7 +387,6 @@ static int qcom_llcc_remove(struct platform_device *pdev)
 static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev,
const char *name)
 {
-   struct resource *res;
void __iomem *base;
struct regmap_config llcc_regmap_config = {
.reg_bits = 32,
@@ -396,11 +395,7 @@ static struct regmap *qcom_llcc_init_mmio(struct 
platform_device *pdev,
.fast_io = true,
};
 
-   res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
-   if (!res)
-   return ERR_PTR(-ENODEV);
-
-   base = devm_ioremap_resource(>dev, res);
+   base = devm_platform_ioremap_resource_byname(pdev, name);
if (IS_ERR(base))
return ERR_CAST(base);
 
-- 
2.17.1