Re: [PATCH 0/2] perf stat: fix segfault when closing events
The perf tool segmentation fault which we were observing and this patch series intended to fix it, has been fixed due to change in default behaviour of perf stat[1][2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.12=0d79f8b93187c771b6971acfaba67f4e2f1e0710 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.11.y=0d79f8b93187c771b6971acfaba67f4e2f1e0710 On Fri, Jun 9, 2017 at 10:03 AM, Ganapatrao Kulkarniwrote: > ping? > > On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarni > wrote: >> On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: >>> Hi, >>> >>> Does anyone have any comments on these? >>> >>> I'm happy to rebase/resend if necessary. >>> >>> I'd very much like to see this fixed. >> >> arm64 platforms have dependency on this patch set to use latest perf tool. >> Earliest merge/review is much appreciated!! >> >>> >>> Thanks, >>> Mark. >>> >>> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: Hi, These patches fix a segfault seen in some cases when perf stat is exiting. We don't balance opening/closing of events in all cases, and go out-of-bounds when we close events. Full details in the patch 2 commit message. Thanks, Mark. Mark Rutland (2): perf evsel: add per{cpu,thread} close helpers perf stat: balance opening/closing of events tools/perf/builtin-stat.c | 24 +++- tools/perf/util/evsel.c | 26 -- tools/perf/util/evsel.h | 4 3 files changed, 47 insertions(+), 7 deletions(-) -- 1.9.1 >> >> thanks >> Ganapat thanks Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
The perf tool segmentation fault which we were observing and this patch series intended to fix it, has been fixed due to change in default behaviour of perf stat[1][2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.12=0d79f8b93187c771b6971acfaba67f4e2f1e0710 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.11.y=0d79f8b93187c771b6971acfaba67f4e2f1e0710 On Fri, Jun 9, 2017 at 10:03 AM, Ganapatrao Kulkarni wrote: > ping? > > On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarni > wrote: >> On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: >>> Hi, >>> >>> Does anyone have any comments on these? >>> >>> I'm happy to rebase/resend if necessary. >>> >>> I'd very much like to see this fixed. >> >> arm64 platforms have dependency on this patch set to use latest perf tool. >> Earliest merge/review is much appreciated!! >> >>> >>> Thanks, >>> Mark. >>> >>> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: Hi, These patches fix a segfault seen in some cases when perf stat is exiting. We don't balance opening/closing of events in all cases, and go out-of-bounds when we close events. Full details in the patch 2 commit message. Thanks, Mark. Mark Rutland (2): perf evsel: add per{cpu,thread} close helpers perf stat: balance opening/closing of events tools/perf/builtin-stat.c | 24 +++- tools/perf/util/evsel.c | 26 -- tools/perf/util/evsel.h | 4 3 files changed, 47 insertions(+), 7 deletions(-) -- 1.9.1 >> >> thanks >> Ganapat thanks Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
ping? On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarniwrote: > On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: >> Hi, >> >> Does anyone have any comments on these? >> >> I'm happy to rebase/resend if necessary. >> >> I'd very much like to see this fixed. > > arm64 platforms have dependency on this patch set to use latest perf tool. > Earliest merge/review is much appreciated!! > >> >> Thanks, >> Mark. >> >> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: >>> Hi, >>> >>> These patches fix a segfault seen in some cases when perf stat is exiting. >>> >>> We don't balance opening/closing of events in all cases, and go >>> out-of-bounds >>> when we close events. Full details in the patch 2 commit message. >>> >>> Thanks, >>> Mark. >>> >>> Mark Rutland (2): >>> perf evsel: add per{cpu,thread} close helpers >>> perf stat: balance opening/closing of events >>> >>> tools/perf/builtin-stat.c | 24 +++- >>> tools/perf/util/evsel.c | 26 -- >>> tools/perf/util/evsel.h | 4 >>> 3 files changed, 47 insertions(+), 7 deletions(-) >>> >>> -- >>> 1.9.1 >>> > > thanks > Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
ping? On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarni wrote: > On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: >> Hi, >> >> Does anyone have any comments on these? >> >> I'm happy to rebase/resend if necessary. >> >> I'd very much like to see this fixed. > > arm64 platforms have dependency on this patch set to use latest perf tool. > Earliest merge/review is much appreciated!! > >> >> Thanks, >> Mark. >> >> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: >>> Hi, >>> >>> These patches fix a segfault seen in some cases when perf stat is exiting. >>> >>> We don't balance opening/closing of events in all cases, and go >>> out-of-bounds >>> when we close events. Full details in the patch 2 commit message. >>> >>> Thanks, >>> Mark. >>> >>> Mark Rutland (2): >>> perf evsel: add per{cpu,thread} close helpers >>> perf stat: balance opening/closing of events >>> >>> tools/perf/builtin-stat.c | 24 +++- >>> tools/perf/util/evsel.c | 26 -- >>> tools/perf/util/evsel.h | 4 >>> 3 files changed, 47 insertions(+), 7 deletions(-) >>> >>> -- >>> 1.9.1 >>> > > thanks > Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
On Tue, May 23, 2017 at 3:34 PM, Mark Rutlandwrote: > Hi, > > Does anyone have any comments on these? > > I'm happy to rebase/resend if necessary. > > I'd very much like to see this fixed. arm64 platforms have dependency on this patch set to use latest perf tool. Earliest merge/review is much appreciated!! > > Thanks, > Mark. > > On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: >> Hi, >> >> These patches fix a segfault seen in some cases when perf stat is exiting. >> >> We don't balance opening/closing of events in all cases, and go out-of-bounds >> when we close events. Full details in the patch 2 commit message. >> >> Thanks, >> Mark. >> >> Mark Rutland (2): >> perf evsel: add per{cpu,thread} close helpers >> perf stat: balance opening/closing of events >> >> tools/perf/builtin-stat.c | 24 +++- >> tools/perf/util/evsel.c | 26 -- >> tools/perf/util/evsel.h | 4 >> 3 files changed, 47 insertions(+), 7 deletions(-) >> >> -- >> 1.9.1 >> thanks Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
On Tue, May 23, 2017 at 3:34 PM, Mark Rutland wrote: > Hi, > > Does anyone have any comments on these? > > I'm happy to rebase/resend if necessary. > > I'd very much like to see this fixed. arm64 platforms have dependency on this patch set to use latest perf tool. Earliest merge/review is much appreciated!! > > Thanks, > Mark. > > On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: >> Hi, >> >> These patches fix a segfault seen in some cases when perf stat is exiting. >> >> We don't balance opening/closing of events in all cases, and go out-of-bounds >> when we close events. Full details in the patch 2 commit message. >> >> Thanks, >> Mark. >> >> Mark Rutland (2): >> perf evsel: add per{cpu,thread} close helpers >> perf stat: balance opening/closing of events >> >> tools/perf/builtin-stat.c | 24 +++- >> tools/perf/util/evsel.c | 26 -- >> tools/perf/util/evsel.h | 4 >> 3 files changed, 47 insertions(+), 7 deletions(-) >> >> -- >> 1.9.1 >> thanks Ganapat
Re: [PATCH 0/2] perf stat: fix segfault when closing events
Hi, Does anyone have any comments on these? I'm happy to rebase/resend if necessary. I'd very much like to see this fixed. Thanks, Mark. On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: > Hi, > > These patches fix a segfault seen in some cases when perf stat is exiting. > > We don't balance opening/closing of events in all cases, and go out-of-bounds > when we close events. Full details in the patch 2 commit message. > > Thanks, > Mark. > > Mark Rutland (2): > perf evsel: add per{cpu,thread} close helpers > perf stat: balance opening/closing of events > > tools/perf/builtin-stat.c | 24 +++- > tools/perf/util/evsel.c | 26 -- > tools/perf/util/evsel.h | 4 > 3 files changed, 47 insertions(+), 7 deletions(-) > > -- > 1.9.1 >
Re: [PATCH 0/2] perf stat: fix segfault when closing events
Hi, Does anyone have any comments on these? I'm happy to rebase/resend if necessary. I'd very much like to see this fixed. Thanks, Mark. On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: > Hi, > > These patches fix a segfault seen in some cases when perf stat is exiting. > > We don't balance opening/closing of events in all cases, and go out-of-bounds > when we close events. Full details in the patch 2 commit message. > > Thanks, > Mark. > > Mark Rutland (2): > perf evsel: add per{cpu,thread} close helpers > perf stat: balance opening/closing of events > > tools/perf/builtin-stat.c | 24 +++- > tools/perf/util/evsel.c | 26 -- > tools/perf/util/evsel.h | 4 > 3 files changed, 47 insertions(+), 7 deletions(-) > > -- > 1.9.1 >
[PATCH 0/2] perf stat: fix segfault when closing events
Hi, These patches fix a segfault seen in some cases when perf stat is exiting. We don't balance opening/closing of events in all cases, and go out-of-bounds when we close events. Full details in the patch 2 commit message. Thanks, Mark. Mark Rutland (2): perf evsel: add per{cpu,thread} close helpers perf stat: balance opening/closing of events tools/perf/builtin-stat.c | 24 +++- tools/perf/util/evsel.c | 26 -- tools/perf/util/evsel.h | 4 3 files changed, 47 insertions(+), 7 deletions(-) -- 1.9.1
[PATCH 0/2] perf stat: fix segfault when closing events
Hi, These patches fix a segfault seen in some cases when perf stat is exiting. We don't balance opening/closing of events in all cases, and go out-of-bounds when we close events. Full details in the patch 2 commit message. Thanks, Mark. Mark Rutland (2): perf evsel: add per{cpu,thread} close helpers perf stat: balance opening/closing of events tools/perf/builtin-stat.c | 24 +++- tools/perf/util/evsel.c | 26 -- tools/perf/util/evsel.h | 4 3 files changed, 47 insertions(+), 7 deletions(-) -- 1.9.1