Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Hi Fabian, On 06/23/2014 07:33 PM, Fabian Frederick wrote: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required can you send the same patch to alsa-devel with subject: ASoC: mcbsp: remove unnecessary null test before kfree You can add my: Acked-by: Peter Ujfalusi > > Cc: Peter Ujfalusi > Cc: Jarkko Nikula > Cc: linux-o...@vger.kernel.org > Signed-off-by: Fabian Frederick > --- > sound/soc/omap/mcbsp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c > index 86c7538..68a1252 100644 > --- a/sound/soc/omap/mcbsp.c > +++ b/sound/soc/omap/mcbsp.c > @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp) > mcbsp->reg_cache = NULL; > spin_unlock(>lock); > > - if (reg_cache) > - kfree(reg_cache); > + kfree(reg_cache); > } > > /* > -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Hi Fabian, On 06/23/2014 07:33 PM, Fabian Frederick wrote: Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required can you send the same patch to alsa-devel with subject: ASoC: mcbsp: remove unnecessary null test before kfree You can add my: Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Jarkko Nikula jarkko.nik...@bitmer.com Cc: linux-o...@vger.kernel.org Signed-off-by: Fabian Frederick f...@skynet.be --- sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c index 86c7538..68a1252 100644 --- a/sound/soc/omap/mcbsp.c +++ b/sound/soc/omap/mcbsp.c @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp) mcbsp-reg_cache = NULL; spin_unlock(mcbsp-lock); - if (reg_cache) - kfree(reg_cache); + kfree(reg_cache); } /* -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Peter Ujfalusi Cc: Jarkko Nikula Cc: linux-o...@vger.kernel.org Signed-off-by: Fabian Frederick --- sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c index 86c7538..68a1252 100644 --- a/sound/soc/omap/mcbsp.c +++ b/sound/soc/omap/mcbsp.c @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp) mcbsp->reg_cache = NULL; spin_unlock(>lock); - if (reg_cache) - kfree(reg_cache); + kfree(reg_cache); } /* -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Jarkko Nikula jarkko.nik...@bitmer.com Cc: linux-o...@vger.kernel.org Signed-off-by: Fabian Frederick f...@skynet.be --- sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c index 86c7538..68a1252 100644 --- a/sound/soc/omap/mcbsp.c +++ b/sound/soc/omap/mcbsp.c @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp) mcbsp-reg_cache = NULL; spin_unlock(mcbsp-lock); - if (reg_cache) - kfree(reg_cache); + kfree(reg_cache); } /* -- 1.8.4.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
